Change-Id: If098b44d2627d86795cea4e4211d357d1a562dba
Reviewed-on: https://gerrit.libreoffice.org/41176Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

...after 5aab2900 "tdf#109142: Update to
HarfBuzz 1.4.8".  The parts that were still relevant for 'make check' are:

* 6694ce6b "external/harfbuzz: Work around ASan
  out of bounds warning"

* 99f7aacd "external/harfbuzz:
  -fsanitize=function"

* ca9a08bb "external/harfbuzz: Silence
  -fsanitize=nonnull-attribute" (plus 83a9c8e0
  "build fix")

Change-Id: Ibff2a7c52c5de60ae00744acd2ef481bbb08706c

To test: make CppunitTest_writerfilter_rtftok

These crash triggering instances were hidden by the presense of \super
in topcontext-2.rtf - so I copied it, and only removed \super.

My fix for tdf#109382 triggered a unit test failure for one
missing m_xTextFactory. It seemed safe enough to test for all of them
that aren't in try/catch blocks, not just for the specific
instance I can prove with the test.

Change-Id: I1e317e05f9bcbbb14360941ce07af1bdf0edac6a
Reviewed-on: https://gerrit.libreoffice.org/41060Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

\htmautsp changes the meaning of \sbauto and \saauto, but the auto
keywords may appear early in style definitions before \htmautsp arrives.
This wasn't a problem before commit
1be0a3fa (n#825305: writerfilter RTF
import: override style properties like Word, 2014-06-17), as there the
right auto keyword interpretation was repeated as direct formatting.

So fix the regression by not deduplicating these keywords, which brings
back the correct layout. A larger rework is necessary in the future to
delay the parsing of the stylesheet table, that would be a cleaner
approach.

Change-Id: I783d2175483bc80ead0a511ad15c4b75e4ab663c
Reviewed-on: https://gerrit.libreoffice.org/41187Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

The first field isn’t editable, so show it visually. Make the actual
editable box have the default focus. Drop the unnecessary heading.

Change-Id: Icf0d5fc3ddb9b9af6d04045899d9e8476a217bba

Change-Id: Ie7cc004e02e3bb1ac8d52a9c0b67b9fa9f946c8c
Reviewed-on: https://gerrit.libreoffice.org/41167Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: Ia4cf7a5382a05061ff98f423cf5640a51015236d
Reviewed-on: https://gerrit.libreoffice.org/41182Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

If there are parents, they are necessarily different pointers for
different pools; the only sensible way to compare them is by-value,
which is a bit tricky because the items overwritten in the child
should of course be ignored.

Rather than rewrite the whole function, just ignore the parents for
now, because this comparison is currently used to replace compares
of the serializations of item sets, and SfxItemSet::Store()
completely ignores the m_pParent, so this looks like the best
replacement.

Change-Id: I0a4bf44d4fef49e47a3ec78bc7d977a6fcbd789d
Reviewed-on: https://gerrit.libreoffice.org/41186Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I381626d80470db18044d517c2c8bb76b2bc6a829
Reviewed-on: https://gerrit.libreoffice.org/40879Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>

As seen on exporting rhbz739243-1.odt, the xGraphic is null in that case.

(regression from 4469b29f)

Change-Id: I535d67eeddc1b9bdf2562fc3b54a97e38ab0354c

Change-Id: Ic8fa88f1e471fe3eab965e5f0106de0348e62ec0
Reviewed-on: https://gerrit.libreoffice.org/41161Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>

* libgpg-error has some fixes around autogen & win32 critical sects
* gpgme has a few nice additions around keyinfos
* update lib versions to deliver
* remove external/libgpg-error/fix-autoconf-macros.patch -> this is
  upstream now

Change-Id: I5a58ac15a485621c54ca1c7a768268e8a541256c
Reviewed-on: https://gerrit.libreoffice.org/37926Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I3ec06e9a196897c095f227e9f765243c6c188898
Reviewed-on: https://gerrit.libreoffice.org/41185Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>

they are KDE3 only and we don't support either KDE3 nor TDE anymore
anyways

Change-Id: I80198c2b63298c0bb3220f3641b6e45107797426
Reviewed-on: https://gerrit.libreoffice.org/41159Reviewed-by: Rene Engelhard <rene@debian.org>
Tested-by: Rene Engelhard <rene@debian.org>

I have no idea why the original implementation used ++nLines
when setting aDrop.Lines. Unchanged since mass import from OOo in
2008 commit 614f53dd.

Change-Id: If427dcea815e91d2cccb2c11044cdb393bff09e3
Reviewed-on: https://gerrit.libreoffice.org/41184Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>

Change-Id: I6a8fe2476adc5c4379c76dfaef090d1b5cd81ea0
Reviewed-on: https://gerrit.libreoffice.org/41170Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>

Split output by chapters. The index is still basic, just "Section N"
entries so far.

Change-Id: I4db659ee4110ab30f4b75f44c41f958533ddad7f
Reviewed-on: https://gerrit.libreoffice.org/41177Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Regression from commit 52863266
"convert ErrCode to strong typedef"

Why this is necessary I don't know. Only the change in ehdl.cxx is
necessary to fix the reported bug, bug fixing the other one too because
it operates in the same way.

I know that the other arrays that get passed here look like:

{ NC_("RID_UUI_ERRHDL", "....."),
ErrCode(sal_uInt32(ERRCODE_UUI_IO_ABORT) & ERRCODE_RES_MASK) },

but RID_ERRHDL in svtools/inc/errtxt.hrc does not, it looks like:

{ NC_("RID_ERRHDL", "...."),
ErrCode(ERRCODE_SFX_MACROS_SUPPORT_DISABLED) },

I'm guessing that somehow before my conversion somehow the code was
stripping the top bits off the error codes?

And why we need to strip the top half of the error code off at all is
also a mystery.

Change-Id: Iebca026ddf80e24ed74802410693adf90ea36047
Reviewed-on: https://gerrit.libreoffice.org/41172Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ifa8e01542ed0e7d72bfc9684f36b6dee9e185df4
Reviewed-on: https://gerrit.libreoffice.org/40645Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

<sberg> noelgrandin, 718cdd43 now also
looks through typedef sugar, e.g. complaining about a gdouble -> double
expl. conversion in configmgr/source/dconf.cxx;
I think we want to remain silent about such conversions involving typedefs
<noelgrandin> sberg, ah, good point.

Change-Id: Icbb0d6be273f53e507c91556cf0ccb5a5c03e5a1
Reviewed-on: https://gerrit.libreoffice.org/41175Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ibc93277c71e51709d56345e8934f045c60d322ca
Reviewed-on: https://gerrit.libreoffice.org/40914Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com>

In the enum types that caused the problem look like this when I dump
then:

EnumType 0xdb45770 'enum SvxFrameDirection'
`-Enum 0xdb456d8 'SvxFrameDirection'

SubstTemplateTypeParmType 0xdb61200 'enum SvxFrameDirection' sugar
|-TemplateTypeParmType 0xd7518f0 'EnumT' dependent depth 0 index 0
| `-TemplateTypeParm 0xd7518a8 'EnumT'
`-EnumType 0xdb45770 'enum SvxFrameDirection'
  `-Enum 0xdb456d8 'SvxFrameDirection'

Change-Id: Id8fedabe43b7a27df61a2320a9acbf54d2dc7882
Reviewed-on: https://gerrit.libreoffice.org/41169Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Project: help  319e2f6b226de998f9945a2325deb608ce1b20a0

tdf#111777 correct help page for named ranges

Scrolling suggested named ranges is done with Crtl+Tab keys

Change-Id: If57beb17528a291e7b08f768378d15c67f1149d9
Reviewed-on: https://gerrit.libreoffice.org/41125Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>

Project: help  c9fc9a65717e174477d11ae4b5d13dfae17848a3

tdf#111651 'Styles and Formatting' -> 'Styles'

Change-Id: Ic4db58aa04d21c514987cdbeaed5d11292d79b85
Reviewed-on: https://gerrit.libreoffice.org/41103Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>

Should fix the Tibetan long U issue.

Also reverts this commit as depending on auto-detection for a required
feature is not a very good idea. The underlying issue is fixed upstream:

commit 5985bed1
Author: jan Iversen <jani@libreoffice.org>
Date:   Mon Jun 12 14:51:42 2017 +0200

    iOS, harfbuzz libcoretext not found

    changed --with-libcoretext
    from "yes" to "auto" for IOS and MACOSX

which seems to be a misguided attemp to fix the build breakage
introduced in:

commit b3559e5c
Author: jan Iversen <jani@libreoffice.org>
Date:   Sun Jun 11 19:35:53 2017 +0200

    iOS, patch harfbuzz

    Add support for arm64

Also had to drop ubsan.patch as it no longer applies, hopefully it is no
longer needed, otherwise it is always good idea to submit such patches
upstream.

Change-Id: I91643c542c0a5a00f36d5564052787eedef8c9cf
Reviewed-on: https://gerrit.libreoffice.org/41124Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I8b20ce6b58915c37e6d4caa11d2f4c724864a257

Characters under <text:span> (and not only under <text:p>) are now
handled.

Change-Id: Iac353005423d65f446b9f93519957f4caeaf1c7a
Reviewed-on: https://gerrit.libreoffice.org/41164Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I2b79ae40afad8c392f219f1798ce44b41649e5b9
Reviewed-on: https://gerrit.libreoffice.org/41163Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: If50b022cabb0a94297cdb13c58f80884c33892d3

Change-Id: I669b020f2f251ef14cbfff78f6e186876ea0127c

Change-Id: I902da0f6e00253d5daf4bf65784dade2ae02740c
Reviewed-on: https://gerrit.libreoffice.org/41155Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

and replace remaining C-style casts

Change-Id: Ie83e2706391c05946ab46dfd7d26059101579153
Reviewed-on: https://gerrit.libreoffice.org/41143Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

...with the added benefit of the implementation-provided versions being trivial
and so avoiding GCC 8 -Werror=class-memaccess when these classes are subject of
memcpy/memmove in store/source/stortree.cxx and store/source/storpage.cxx.

Change-Id: I684109d8743eb7f1fa57c6925d738b11d934a7cf
Reviewed-on: https://gerrit.libreoffice.org/40977Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ib4572899caeb7bc2dceb2c188ceb306b8ffc9193
Reviewed-on: https://gerrit.libreoffice.org/40629Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I33e20b23430483ce318c98a43bde07200802a4d6

which appears at the top-right corner of both Impress's
Slide Pane and Draw's Page Pane.

Change-Id: Ida52ccc35e42546cd6260001e22335b04608034d
Reviewed-on: https://gerrit.libreoffice.org/40803Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>

Change-Id: I112650bbb0ed279b386389e7df6b372bde080b62
Reviewed-on: https://gerrit.libreoffice.org/41157Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I7a06f1a5c3f28b47288b0a2b191a34cd81efb439
Reviewed-on: https://gerrit.libreoffice.org/41156Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Remove character highlighting tab from background style
since there is no text content in the background.

Change-Id: I5fcc3c76a3e60a37c3be72a14fa2f6668875bab6
Reviewed-on: https://gerrit.libreoffice.org/41154Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: Ic95ec7c8a36ef5d19eac93b7eed8a7de2ec8904f
Reviewed-on: https://gerrit.libreoffice.org/41153Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>