If a task is still in the scheduler priority queue and its
priority is changed, it won't be moved into the correct queue.
We have to track the priority of the scheduled task, so we can
warn the developer to fix the code and actually handle re-start
correctly.

Since we don't want to traverse the whole Scheduler queues on
priority change (which sometimes get very long) to remove the
wrong data item, we'll just invalidate it, if a priority change
is detected.

This also reverts commit d24b264c ("vcl opengl: avoid task
priority warning on cursor blink"), which tried to avoid the
warning, which was just half right and independent of the broken
priority change handling.

LO doesn't change priorities of scheduled tasks normally, so
that bug didn't turn out to have much impact, I guess.

Change-Id: I6e46b518a7c3532047c619c013bd8597f73ed7a6
Reviewed-on: https://gerrit.libreoffice.org/69249
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: I2d43c1fc65e8cfed1e252e1a16c37b907ec9f319
Reviewed-on: https://gerrit.libreoffice.org/69180
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

.. after ed901c33

Change-Id: Icc38dcfbf59d3af8b1798064f241f9ce59f1732d
Reviewed-on: https://gerrit.libreoffice.org/69256Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

So that it's possible to do ad-hoc dumping from gdb with something like:

print xMetaFile->dumpAsXml(0)

Similar to how that already worked for SwDoc or SwFrame.

Change-Id: I9cb884491f2a49afdb06179d8d54252101f37bb7
Reviewed-on: https://gerrit.libreoffice.org/69253Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

A fairly pure re-factor, although adding disposed window
checking to a number of sites with a warning.

Moves the event emission helpers from VCL into SfxLokHelper: we're
going to need more view / integration here next anyway.

Removes lots of copy/paste horror.

Change-Id: I279c11a1d8093b4feeeb6b7850f500806fff80dd
Reviewed-on: https://gerrit.libreoffice.org/69218
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I5bd2cc790c3bb81a3b5369ae25dc68664c030bf2
Reviewed-on: https://gerrit.libreoffice.org/69250
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I3c72b19f9c5343451164b5bd35dc79a3753e6a37
Reviewed-on: https://gerrit.libreoffice.org/69179
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

which is consistent with the calc format->cells->numbering page
and solves the keyboard traversal problem here

Change-Id: I90c0f4a380693af871bbd20912eafcf5ea259fc7
Reviewed-on: https://gerrit.libreoffice.org/69229Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

All changes are about not assuming logical top is a lower y value than
logical bottom, by going via the SwRectFnSet abstraction, which already
does the right thing.

Change-Id: I94a9881b018ad14b02e97425f60af01aa3fd9269
Reviewed-on: https://gerrit.libreoffice.org/69226
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I82a348c7be067e777dced15dd014b8139cc9b1dc
Reviewed-on: https://gerrit.libreoffice.org/69224
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Ief7cdb14e2c0fe4b0332cd90e063d649065bf3b6
Reviewed-on: https://gerrit.libreoffice.org/69171
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Id6792f0955a25533d33f6da6ed8c3e993f578c3f
Reviewed-on: https://gerrit.libreoffice.org/69170
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

* Update helpcontent2 from branch 'master'
  - i#119731 Fix icon name
    
    Was wrongly named in 496aaf8cbcd030c1ddfbc3776c23edd08307b96e
    
    Change-Id: I42730caa995ed7e04b6a632ee0fa73091beeea84
    Reviewed-on: https://gerrit.libreoffice.org/69080
    Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
    

... otherwise, after first stylesheet with matching name but failing
predicate, next stylesheet that matches predicate is returned, regardless
what is its name.

See commit b37b299d.

Change-Id: I965ddcd0f8f578b60a46b3c7412d33973aa7a2aa
Reviewed-on: https://gerrit.libreoffice.org/69228
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

When the Help URL is blank, the Help
buttons are hidden LOK (but not desktop).

Change-Id: Ibd76452108d1e3a92fb43f2c0af0586b0cbed073
Reviewed-on: https://gerrit.libreoffice.org/69071Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/69142
Tested-by: Jenkins

... when replacing one of their formula cells, with another
formula cell or any other cell, passing through
DetachFormulaCell()

Change-Id: Id527307ef5278d87345c6dbfab9d05cb490dfe6c
Reviewed-on: https://gerrit.libreoffice.org/69221Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

so e.g. math font dialog doesn't react to button clicks.

since...

commit ab8e0f58
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Fri Jan 18 17:08:58 2019 +0000

    Resolves: tdf#122484 replace gtk autocomplete with vcl-alike autoselect

remove the entrycompletions but left the reference to them

Change-Id: Ia02d0e657fc114692f69f88890192c470a1cab22
Reviewed-on: https://gerrit.libreoffice.org/69208
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ib390abaec648a1e06fcc35f83cb170fc654cf021
Reviewed-on: https://gerrit.libreoffice.org/69203
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

It is "ScStyleFamilyObj" element that is inserted in the ScStyleFamilyTestObj::init()
which is intended to be tormented in all thinkable ways in the tests; and its name
must be passed to all the different interface ctors here. Trying to remove "Default"
style is not something really expected to work.

In my testing on Windows, I experienced hung XNameContainer::testRemoveByName with
endless loop in SfxStyleSheetBase::SetParent, where it tried to set parent of Para
style "Status" to "Heading"; while iterating over "Heading" parents to check for
recursive linkages, it searched for its parent "Default", already removed at that
stage; that search gave another "Default" style of Page type; that makes
DoesStyleMatchStyleSheetPredicate from DoesStyleMatchStyleSheetPredicate to fail in
IndexedStyleSheets::FindPositionsByNameAndPredicate, which for some reason returns
the next stylesheet matching the predicate *with any name* - and that happens to be
"Footnote". When returned to SfxStyleSheetBase::SetParent, it then tried to test
its parent, which is "Text"; then tests its parent "Default" => endless loop.

Whether this is a problem in IndexedStyleSheets::FindPositionsByNameAndPredicate
that needs fixing or not, setting the test object name here to the object intended
for that fixes the never-finishing subsequenttests problem.

Change-Id: I9a36f5c8f399d5c9b863bf33426b15a4388747dc
Reviewed-on: https://gerrit.libreoffice.org/69225Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

The problem was that the page style was set on the first paragraph,
which means a page break on the UI. So if you used a multi-paragraph
autotext twice (insert autotext, press enter, insert autotext again)
then you ended up with 2 pages instead of just 1.

Fix the problem by tracking when we are in autotext import mode, and
similar to pasting, don't set the page style in autotext import mode.

Change-Id: I4fc551b3c1b999687eb80242e261f186fd1b6f13
Reviewed-on: https://gerrit.libreoffice.org/69214Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

* Update helpcontent2 from branch 'master'
  - New approach to switch cases
    
    My previous JS patch broke the sys and appl switch behaviour.
    
    This patch removes the inline function calls from
    online_transform.xsl. Instead, help2.js now finds the relevant spans
    and calls the functions for them.
    
    Change-Id: I45d5b75bdb70a7c18eaa0b215beb57e3e1b6719a
    Reviewed-on: https://gerrit.libreoffice.org/69137
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Change-Id: Id31bd7df4dbbb5bde5b37236958e2a64c2fb9b9c
Reviewed-on: https://gerrit.libreoffice.org/69141
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I1b6ffdab5e1ba4a667957d321762bb9250068fe7
Reviewed-on: https://gerrit.libreoffice.org/69178Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

when source links.txt changes

Change-Id: I90e9b64fdd01ff725149cc6d07d3ea6c28b50156
Reviewed-on: https://gerrit.libreoffice.org/69202
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I88e2a7ee44523482cf36099281c0f632fae7eac0
Reviewed-on: https://gerrit.libreoffice.org/69177
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Move deleteLater() call to the different event loop.
This fixes issue with frames not being disposed of
deterministically, and previously opened window
not reactivating.

Also hide modal dialog window before unsetting modal mode.
Unsetting modal mode may require to toggle window visibility.
Window will be hidden soon anyway,
and additional generated events might make finding correct
focused window harder.

Change-Id: Id7839f817075785287b09f6ac79eb3fb211726aa
Reviewed-on: https://gerrit.libreoffice.org/68852
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

... duplicating the type name

Change-Id: I12b2302c4316b3ec1f22df366100c3b2a4d87454
Reviewed-on: https://gerrit.libreoffice.org/69173Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Test for commit 0a5ca576

Change-Id: I53b72c385d9ef4d51cefa687f07a75c9520d3e71
Reviewed-on: https://gerrit.libreoffice.org/69165
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Otherwise the Tools > Word Count dialog doesn't show up in the iOS
app.

Change-Id: Ic425749cc8f3245d7a16d7784d77b02f6d47253f

Change-Id: Id663ba63b361ebf5f853bdf8e9a38a6dc4ab0e36
Reviewed-on: https://gerrit.libreoffice.org/69157
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Id92fcd2fd33500cc9c60645c627c2fedf2378fb9
Reviewed-on: https://gerrit.libreoffice.org/69158
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I7efb107f53a12185f1bd438983e6f446ee8b6a1b
Reviewed-on: https://gerrit.libreoffice.org/69079
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>

Change-Id: I978f088fa700791d48a5a65392f980822ac14bd2
Reviewed-on: https://gerrit.libreoffice.org/69032
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

Change-Id: Ic82c50d07cf4a2208a6e2956c8b9ebc4f8630b31
Reviewed-on: https://gerrit.libreoffice.org/67597
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Just in case there's a typo or something, without this that source
would not be compiled but shared visitor would not include that
functionality either.

Change-Id: I5d9fad129b83f24fed2613bc071cb33e149c1db3
Reviewed-on: https://gerrit.libreoffice.org/69093
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Change-Id: I7c2938cd731ed85dd0f96ac41d0f0a1468ee858c
Reviewed-on: https://gerrit.libreoffice.org/69089
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Change-Id: Ifcc5cfb8d66ae77bdf54b1a5457590c92a3fe093
Reviewed-on: https://gerrit.libreoffice.org/69088
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I739785daef892ac16d2a41a98268f18670daeedb
Reviewed-on: https://gerrit.libreoffice.org/69136
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I88c1129f50d9f9cbef9970f1a9453641fc87e8fd
Reviewed-on: https://gerrit.libreoffice.org/69135
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Iaaac797812b2addd1e5693dbb4338fc1c506a26d
Reviewed-on: https://gerrit.libreoffice.org/69134
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>