• Caolán McNamara's avatar
    crash because iterator position wasn't changed in stl conversion · e4f5f504
    Caolán McNamara yazdı
    regression from e0284f4b
    
    Here's the original code using the pre stl iterators.
    
    if( !pPara && nDepth > 0 &&  rSet.GetItemState( EE_PARA_NUMBULLET ) == SFX_ITEM_ON &&
        pOutliner->GetDepth( (sal_uInt16) pOutliner->GetAbsPos( (Paragraph*) pList->First() ) ) > 0 )
    	pPara = pOutliner->GetParagraph( 0 );  // Put NumBulletItem in outline level 1
    
    Hidden in there is a pList->First() which only gets called if the prior
    conditions are true.  pList->First() resets the index of the internal pList
    iterator position of pList to 0 i.e. the next call to pList->Prev will now return 0.
    
    The equivalent in the post-stl-conversion code is to jump the reverse_iterator
    iter to the last position in the reverse view.
    
    Create a level 10 entry in master view, select level 10, and use the bullets
    and numbering dropdown from the side panel to see this crash
    
    Change-Id: I52c22ea52020feb0fb75924f63ebe225be462071
    e4f5f504
Adı
Son kayıt (commit)
Son güncelleme
..
DocumentRenderer.cxx Loading commit data...
DocumentRenderer.hrc Loading commit data...
DocumentRenderer.src Loading commit data...
FormShellManager.cxx Loading commit data...
GraphicObjectBar.cxx Loading commit data...
GraphicViewShellBase.cxx Loading commit data...
ImpressViewShellBase.cxx Loading commit data...
MediaObjectBar.cxx Loading commit data...
OutlineViewShellBase.cxx Loading commit data...
Outliner.cxx Loading commit data...
OutlinerIterator.cxx Loading commit data...
PresentationViewShellBase.cxx Loading commit data...
SlideSorterViewShellBase.cxx Loading commit data...
ToolBarManager.cxx Loading commit data...
ViewClipboard.cxx Loading commit data...
ViewShellBase.cxx Loading commit data...
ViewShellHint.cxx Loading commit data...
ViewShellImplementation.cxx Loading commit data...
ViewShellManager.cxx Loading commit data...
ViewTabBar.cxx Loading commit data...
WindowUpdater.cxx Loading commit data...
clview.cxx Loading commit data...
drawview.cxx Loading commit data...
drbezob.cxx Loading commit data...
drtxtob.cxx Loading commit data...
drtxtob1.cxx Loading commit data...
drviews1.cxx Loading commit data...
drviews2.cxx Loading commit data...
drviews3.cxx Loading commit data...
drviews4.cxx Loading commit data...
drviews5.cxx Loading commit data...
drviews6.cxx Loading commit data...
drviews7.cxx Loading commit data...
drviews8.cxx Loading commit data...
drviews9.cxx Loading commit data...
drviewsa.cxx Loading commit data...
drviewsb.cxx Loading commit data...
drviewsc.cxx Loading commit data...
drviewsd.cxx Loading commit data...
drviewse.cxx Loading commit data...
drviewsf.cxx Loading commit data...
drviewsg.cxx Loading commit data...
drviewsh.cxx Loading commit data...
drviewsi.cxx Loading commit data...
drviewsj.cxx Loading commit data...
drvwshrg.cxx Loading commit data...
frmview.cxx Loading commit data...
grviewsh.cxx Loading commit data...
outlnvs2.cxx Loading commit data...
outlnvsh.cxx Loading commit data...
outlview.cxx Loading commit data...
presvish.cxx Loading commit data...
sdruler.cxx Loading commit data...
sdview.cxx Loading commit data...
sdview2.cxx Loading commit data...
sdview3.cxx Loading commit data...
sdview4.cxx Loading commit data...
sdview5.cxx Loading commit data...
sdwindow.cxx Loading commit data...
tabcontr.cxx Loading commit data...
unmodpg.cxx Loading commit data...
viewoverlaymanager.cxx Loading commit data...
viewshe2.cxx Loading commit data...
viewshe3.cxx Loading commit data...
viewshel.cxx Loading commit data...
zoomlist.cxx Loading commit data...