• Michael Stahl's avatar
    dbaccess: fix testCloneMovesPlusDeletions test · ae8bd426
    Michael Stahl yazdı
    JunitTest_dbaccess_complex spuriously fails 1% of the time with:
    
    1) testCloneMovesPlusDeletions(complex.dbaccess.RowSet)
    java.lang.AssertionError: moving to the next record after |deleteRow| and clone moves failed
        at complex.dbaccess.RowSet.testCloneMovesPlusDeletions(RowSet.java:756)
    
    The problem is that line RowSet.java:750 deleteRow() manages to delete
    the last row in the set, because the positionRandom() is tricked to
    position itself on the last row (which it tries not to do), becuase the
    RowSet is currently positioned past-the-end on a deleted row and the
    ORowSetBase::impl_getRowCount() is a lying bastard that adds 1 to the
    result in this special case.
    
    Funnily both the ORowSetBase::impl_getRowCount() and the test using
    positionRandom() were added in CWS rowsetdel.  Yay for randomized
    tests!
    
    Change-Id: Ic8c7bfa190f6a5269604cf5b3c338f2d0b64205e
    ae8bd426
Adı
Son kayıt (commit)
Son güncelleme
..
ApplicationController.java Loading commit data...
Beamer.java Loading commit data...
CRMBasedTestCase.java Loading commit data...
CopyTableInterActionHandler.java Loading commit data...
CopyTableWizard.java Loading commit data...
DataSource.java Loading commit data...
DatabaseApplication.java Loading commit data...
DatabaseDocument.java Loading commit data...
FileHelper.java Loading commit data...
Parser.java Loading commit data...
PropertyBag.java Loading commit data...
Query.java Loading commit data...
QueryInQuery.java Loading commit data...
RowSet.java Loading commit data...
RowSetEventListener.java Loading commit data...
SingleSelectQueryComposer.java Loading commit data...
TestCase.java Loading commit data...
UISettings.java Loading commit data...
makefile.mk Loading commit data...