• Stephan Bergmann's avatar
    Enable --help=html for flatpak · 72b936d7
    Stephan Bergmann yazdı
    To not increase the size of the main org.libreoffice.LibreOffice app further,
    the plan was to realize this as an org.libreoffice.LibreOffice.Help extension.
    Ideally, this would be a localized extension, so that, by default, only a
    relevant subset of the extension would be downloaded and installed.  (But see
    below.)
    
    There are multiple technical problems, as discussed at <https://github.com/
    flathub/org.libreoffice.LibreOffice/issues/35#issuecomment-447295308> "Add
    integrated LibreOffice Help offline":
    
    * LO can't pass a file URL with query part to xdg-open, so uses a temporary
      wrapper .html file that redirects to the target URL.  But for the flatpak case
      this wrapper can't be in /tmp (which isn't visible from outside the flatpak
      sandbox), but is instead stored in a new temp dir under $XDG_CACHE_HOME (which
      is always set for flatpaks and /is/ visible form the outside) that is
      removed on LO exit.
    
    * The file URL stored in the temp file must be rewritten from the internal path
      (/app/libreoffice/help/...) to the path as seen outside the flatpak sandbox.
      While the path for the org.libreoffice.LibreOffice /app is stored in
      /.flatpak-info, the external path for the org.libreoffice.LibreOffice.Help
      extension is different and not stored there.  So use a hack trying to
      construct that path from what information is available in /.flatpak-info.
    
    * But the help content consists of locale-specific and shared files, and those
      reference each other with relative links.  But a localized flatpak extension
      cannot contain shared files, it can only contain per-language sub-dirs.  And
      if the shared help files were kept out of the extension, as part of the app
      itself, the relative paths among these files inside the flatpak sandbox would
      differ from those outside of it, so would be broken when viewing the content
      in the external browser.  A solution would either (a) need to somehow rewrite
      the content of all the help files being served from LO to the external
      browser, or (b) replicate the shared help files in all the extension's per-
      language sub-dirs (and if some localization uses en-US content as a fallback
      for only part of its translated content, e.g., in the case of media files,
      would need to also replicate that en-US content), or (c) use a non-localized
      extension that always contains the content for all localizations.
    
    For now, I chose the third approach.  This makes the
    org.libreoffice.LibreOffice.Help extension relatively large (the current
    /app/libreoffice/help tree has a size of ca. 100MB), so that I decided to not
    have it downloaded and installed automatically ("no-autodownload": true in
    solenv/flatpak-manifest.in).  (I checked with Flatpak 1.0.6 that if the
    extension should be changed to a localized one with the same name in the future,
    updating from an older version would work.  If the old extension was not
    installed, just the relevant localizations of the new version will be downloaded
    and installed.  If the old extension was installed, the full set of
    localizations of the new version will be downloaded and installed.)
    
    (As also mentioned at <https://github.com/flathub/org.libreoffice.LibreOffice/
    issues/35#issuecomment-447295308>:  "A second, minor, nuisance is that, for
    security reasons, an `xdg-open file:///...html` call from a flatpak leads to an
    intermediate popup dialog letting the user chose which application to use to
    open the URI, while e.g. an `xdg-open http:///...html` is allowed to go directly
    to the user's preferred browser.  So accessing help content from LO flatpak
    would present that popup dialog first, forcing the user to select a browser to
    proceed.")
    
    Change-Id: I35f5a23947dd551dc1b9bff1dd2abd6710073b5f
    Reviewed-on: https://gerrit.libreoffice.org/65451
    Tested-by: Jenkins
    Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
    72b936d7
Adı
Son kayıt (commit)
Son güncelleme
.git-hooks Loading commit data...
UnoControls Loading commit data...
accessibility Loading commit data...
android Loading commit data...
animations Loading commit data...
apple_remote Loading commit data...
avmedia Loading commit data...
basctl Loading commit data...
basegfx Loading commit data...
basic Loading commit data...
bean Loading commit data...
bin Loading commit data...
binaryurp Loading commit data...
bridges Loading commit data...
canvas Loading commit data...
chart2 Loading commit data...
cli_ure Loading commit data...
codemaker Loading commit data...
comphelper Loading commit data...
compilerplugins Loading commit data...
config_host Loading commit data...
configmgr Loading commit data...
connectivity Loading commit data...
cppcanvas Loading commit data...
cppu Loading commit data...
cppuhelper Loading commit data...
cpputools Loading commit data...
cui Loading commit data...
dbaccess Loading commit data...
desktop Loading commit data...
dictionaries @ 37f53640
distro-configs Loading commit data...
drawinglayer Loading commit data...
dtrans Loading commit data...
editeng Loading commit data...
embeddedobj Loading commit data...
embedserv Loading commit data...
emfio Loading commit data...
eventattacher Loading commit data...
extensions Loading commit data...
external Loading commit data...
extras Loading commit data...
filter Loading commit data...
forms Loading commit data...
formula Loading commit data...
fpicker Loading commit data...
framework Loading commit data...
helpcompiler Loading commit data...
helpcontent2 @ 41e0b82d
hwpfilter Loading commit data...
i18nlangtag Loading commit data...
i18npool Loading commit data...
i18nutil Loading commit data...
icon-themes Loading commit data...
idl Loading commit data...
idlc Loading commit data...
include Loading commit data...
instsetoo_native Loading commit data...
io Loading commit data...
ios Loading commit data...
javaunohelper Loading commit data...
jurt Loading commit data...
jvmaccess Loading commit data...
jvmfwk Loading commit data...
l10ntools Loading commit data...
librelogo Loading commit data...
libreofficekit Loading commit data...
lingucomponent Loading commit data...
linguistic Loading commit data...
lotuswordpro Loading commit data...
m4 Loading commit data...
nlpsolver Loading commit data...
o3tl Loading commit data...
odk Loading commit data...
offapi Loading commit data...
officecfg Loading commit data...
onlineupdate Loading commit data...
oovbaapi Loading commit data...
oox Loading commit data...
opencl Loading commit data...
osx Loading commit data...
package Loading commit data...
postprocess Loading commit data...
pyuno Loading commit data...
qadevOOo Loading commit data...
readlicense_oo Loading commit data...
registry Loading commit data...
remotebridges Loading commit data...
reportbuilder Loading commit data...
reportdesign Loading commit data...
ridljar Loading commit data...
sal Loading commit data...
salhelper Loading commit data...
sax Loading commit data...
sc Loading commit data...
scaddins Loading commit data...
sccomp Loading commit data...
schema Loading commit data...
scp2 Loading commit data...
scripting Loading commit data...
sd Loading commit data...
sdext Loading commit data...
setup_native Loading commit data...
sfx2 Loading commit data...
shell Loading commit data...
slideshow Loading commit data...
smoketest Loading commit data...
solenv Loading commit data...
soltools Loading commit data...
sot Loading commit data...
starmath Loading commit data...
stoc Loading commit data...
store Loading commit data...
svgio Loading commit data...
svl Loading commit data...
svtools Loading commit data...
svx Loading commit data...
sw Loading commit data...
swext Loading commit data...
sysui Loading commit data...
test Loading commit data...
testtools Loading commit data...
toolkit Loading commit data...
tools Loading commit data...
translations @ 46a65ed7
ucb Loading commit data...
ucbhelper Loading commit data...
udkapi Loading commit data...
uitest Loading commit data...
unodevtools Loading commit data...
unoidl Loading commit data...
unoil Loading commit data...
unotest Loading commit data...
unotools Loading commit data...
unoxml Loading commit data...
ure Loading commit data...
uui Loading commit data...
vbahelper Loading commit data...
vcl Loading commit data...
winaccessibility Loading commit data...
wizards Loading commit data...
writerfilter Loading commit data...
writerperfect Loading commit data...
xmerge Loading commit data...
xmlhelp Loading commit data...
xmloff Loading commit data...
xmlreader Loading commit data...
xmlscript Loading commit data...
xmlsecurity Loading commit data...
.buckconfig Loading commit data...
.buckversion Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitmodules Loading commit data...
.gitreview Loading commit data...
BUCK Loading commit data...
COPYING Loading commit data...
COPYING.LGPL Loading commit data...
COPYING.MPL Loading commit data...
Library_merged.mk Loading commit data...
Makefile.fetch Loading commit data...
Makefile.gbuild Loading commit data...
Makefile.in Loading commit data...
README.Solaris Loading commit data...
README.cross Loading commit data...
README.md Loading commit data...
Repository.mk Loading commit data...
RepositoryExternal.mk Loading commit data...
RepositoryFixes.mk Loading commit data...
RepositoryModule_build.mk Loading commit data...
RepositoryModule_host.mk Loading commit data...
TEMPLATE.SOURCECODE.HEADER Loading commit data...
autogen.sh Loading commit data...
config.guess Loading commit data...
config.sub Loading commit data...
config_host.mk.in Loading commit data...
config_host_lang.mk.in Loading commit data...
configure.ac Loading commit data...
download.lst Loading commit data...
g Loading commit data...
install-sh Loading commit data...
leak-suppress.txt Loading commit data...
lo.xcent Loading commit data...
logerrit Loading commit data...
sanitize-ubsan-blacklist Loading commit data...
setup.cfg Loading commit data...