• Markus Mohrhard's avatar
    no range based for loop when container is modified, tdf#100870, tdf#101320 · b0f4291e
    Markus Mohrhard yazdı
    This crash has been responsible for around 20% of the 5.2.0.4 crashes
    with backtraces for the modification of the container similar to:
    
        sxlo.dll!SfxWorkWindow::SetChildWindowVisible_Impl(unsigned long lId, bool bEnabled, unsigned short nMode) Line 1834    C++
         sfxlo.dll!SfxDispatcher::Update_Impl_(bool bUIActive, bool bIsMDIApp, bool bIsIPOwner, SfxWorkWindow * pTaskWin) Line 1452    C++
         sfxlo.dll!SfxDispatcher::Update_Impl(bool bForce) Line 1326    C++
         sfxlo.dll!SfxApplication::SetViewFrame_Impl(SfxViewFrame * pFrame) Line 372    C++
         sfxlo.dll!SfxViewFrame::SetViewFrame(SfxViewFrame * pFrame) Line 3138    C++
         sfxlo.dll!SfxViewFrame::MakeActive_Impl(bool bGrabFocus) Line 1697    C++
         sfxlo.dll!SfxFrameWindow_Impl::Notify(NotifyEvent & rNEvt) Line 111    C++
         vcllo.dll!vcl::Window::CompatNotify(NotifyEvent & rNEvt) Line 3747    C++
         vcllo.dll!vcl::Window::Notify(NotifyEvent & rNEvt) Line 198    C++
         vcllo.dll!DockingWindow::Notify(NotifyEvent & rNEvt) Line 633    C++
         vcllo.dll!vcl::Window::CompatNotify(NotifyEvent & rNEvt) Line 3747    C++
         vcllo.dll!vcl::Window::Notify(NotifyEvent & rNEvt) Line 198    C++
         vcllo.dll!DockingWindow::Notify(NotifyEvent & rNEvt) Line 633    C++
         sfxlo.dll!SfxDockingWindow::Notify(NotifyEvent & rEvt) Line 1655    C++
         vcllo.dll!vcl::Window::CompatNotify(NotifyEvent & rNEvt) Line 3747    C++
         vcllo.dll!vcl::Window::Notify(NotifyEvent & rNEvt) Line 198    C++
         vcllo.dll!vcl::Window::CompatNotify(NotifyEvent & rNEvt) Line 3747    C++
         vcllo.dll!vcl::Window::Notify(NotifyEvent & rNEvt) Line 198    C++
         vcllo.dll!vcl::Window::CompatNotify(NotifyEvent & rNEvt) Line 3747    C++
         vcllo.dll!vcl::Window::Notify(NotifyEvent & rNEvt) Line 198    C++
         vcllo.dll!Control::Notify(NotifyEvent & rNEvt) Line 274    C++
         vcllo.dll!vcl::Window::CompatNotify(NotifyEvent & rNEvt) Line 3747    C++
         vcllo.dll!vcl::Window::GetFocus() Line 1842    C++
         svtlo.dll!SvTreeListBox::GetFocus() Line 2096    C++
         swlo.dll!SwContentTree::GetFocus() Line 2571    C++
         vcllo.dll!vcl::Window::CompatGetFocus() Line 3716    C++
         vcllo.dll!vcl::Window::ImplGrabFocus(GetFocusFlags nFlags) Line 384    C++
         vcllo.dll!vcl::Window::GrabFocus() Line 3004    C++
         swlo.dll!SwNavigationPI::SwNavigationPI(SfxBindings * _pBindings, SfxChildWindowContext * pCw, vcl::Window * pParent) Line 835    C++
         swlo.dll!VclPtr<SwNavigationPI>::Create<SfxBindings * __ptr64 & __ptr64,SwNavigationChild * __ptr64 const,vcl::Window * __ptr64 & __ptr64>(SfxBinsfdings * & <arg_0>, SwNavigationChild * const && <arg_1>, vcl::Window * & <arg_2>) Line 131    C++
         swlo.dll!SwNavigationChild::SwNavigationChild(vcl::Window * pParent, unsigned short nId, SfxBindings * _pBindings, SfxChildWinInfo * __formal) Line 1306    C++
         swlo.dll!SwNavigationChild::CreateImpl(vcl::Window * pParent, SfxBindings * pBindings, SfxChildWinInfo * pInfo) Line 69    C++
         sfxlo.dll!SfxChildWindow::CreateContext(unsigned short nContextId, SfxBindings & rBindings) Line 457    C++
         sfxlo.dll!SfxWorkWindow::CreateChildWin_Impl(SfxChildWin_Impl * pCW, bool bSetFocus) Line 1436    C++
         sfxlo.dll!SfxWorkWindow::UpdateChildWindows_Impl() Line 1328    C++
         sfxlo.dll!SfxWorkWindow::UpdateObjectBars_Impl() Line 1283    C++
         sfxlo.dll!SfxFrameWorkWin_Impl::UpdateObjectBars_Impl() Line 1114    C++
         sfxlo.dll!SfxDispatcher::Update_Impl(bool bForce) Line 1329    C++
         sfxlo.dll!SfxBaseController::ConnectSfxFrame_Impl(const SfxBaseController::ConnectSfxFrame i_eConnect) Line 1326    C++
         sfxlo.dll!SfxBaseController::attachFrame(const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> & xFrame) Line 584    C++
         sfxlo.dll!`anonymous namespace'::SfxFrameLoader_Impl::impl_createDocumentView(const com::sun::star::uno::Reference<com::sun::star::frame::XModel2> & i_rModel, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> & i_rFrame, const comphelper::NamedValueCollection & i_rViewFactoryArgs, const rtl::OUString & i_rViewName) Line 604    C++
         sfxlo.dll!`anonymous namespace'::SfxFrameLoader_Impl::load(const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rArgs, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> & _rTargetFrame) Line 721    C++
         fwklo.dll!framework::LoadEnv::impl_loadContent() Line 1122    C++
         fwklo.dll!framework::LoadEnv::startLoading() Line 379    C++
         fwklo.dll!framework::LoadDispatcher::impl_dispatch(const com::sun::star::util::URL & rURL, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & lArguments, const com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> & xListener) Line 116    C++
         fwklo.dll!framework::LoadDispatcher::dispatch(const com::sun::star::util::URL & aURL, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & lArguments) Line 55    C++
         sfxlo.dll!RecentDocsView::ExecuteHdl_Impl(RecentDocsView * __formal, void * p) Line 335    C++
         sfxlo.dll!RecentDocsView::LinkStubExecuteHdl_Impl(void * instance, void * data) Line 327    C++
         vcllo.dll!Link<void * __ptr64,void>::Call(void * data) Line 84    C++
         vcllo.dll!ImplHandleUserEvent(ImplSVEvent * pSVEvent) Line 1949    C++
         vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalEvent nEvent, const void * pEvent) Line 2497    C++
         vcllo.dll!SalFrame::CallCallback(SalEvent nEvent, const void * pEvent) Line 282    C++
         vcllo.dll!ImplHandleUserEvent(HWND__ * hWnd, __int64 lParam) Line 4110    C++
         vcllo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, int & rDef) Line 5774    C++
         vcllo.dll!SalFrameWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 5907    C++
         [External Code]
         vcllo.dll!ImplSalDispatchMessage(tagMSG * pMsg) Line 572    C++
         vcllo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 591    C++
         vcllo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents, unsigned __int64 nReleased) Line 654    C++
         vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents, const unsigned __int64 nReleased) Line 510    C++
         vcllo.dll!Application::Yield() Line 556    C++
         vcllo.dll!Application::Execute() Line 472    C++
         sofficeapp.dll!desktop::Desktop::DoExecute() Line 1327    C++
         sofficeapp.dll!desktop::Desktop::Main() Line 1646    C++
         vcllo.dll!ImplSVMain() Line 177    C++
         vcllo.dll!SVMain() Line 216    C++
         sofficeapp.dll!soffice_main() Line 165    C++
         soffice.bin!sal_main() Line 48    C
         soffice.bin!main(int argc, char * * argv) Line 47    C
         soffice.bin!WinMain(void * _hinst, void * _dummy, char * _cmdline, int _nshow) Line 47    C
         [External Code]
    
    Change-Id: I4f699952d144a9c276ce53604dc66418abc4baee
    Reviewed-on: https://gerrit.libreoffice.org/27977Tested-by: 's avatarJenkins <ci@libreoffice.org>
    Reviewed-by: 's avatarMarkus Mohrhard <markus.mohrhard@googlemail.com>
    b0f4291e
Adı
Son kayıt (commit)
Son güncelleme
.git-hooks Loading commit data...
UnoControls Loading commit data...
accessibility Loading commit data...
android Loading commit data...
animations Loading commit data...
apple_remote Loading commit data...
avmedia Loading commit data...
basctl Loading commit data...
basegfx Loading commit data...
basic Loading commit data...
bean Loading commit data...
bin Loading commit data...
binaryurp Loading commit data...
bridges Loading commit data...
canvas Loading commit data...
chart2 Loading commit data...
cli_ure Loading commit data...
codemaker Loading commit data...
comphelper Loading commit data...
compilerplugins Loading commit data...
config_host Loading commit data...
configmgr Loading commit data...
connectivity Loading commit data...
cppcanvas Loading commit data...
cppu Loading commit data...
cppuhelper Loading commit data...
cpputools Loading commit data...
cui Loading commit data...
dbaccess Loading commit data...
desktop Loading commit data...
dictionaries @ 3380b51b
distro-configs Loading commit data...
drawinglayer Loading commit data...
dtrans Loading commit data...
editeng Loading commit data...
embeddedobj Loading commit data...
embedserv Loading commit data...
eventattacher Loading commit data...
extensions Loading commit data...
external Loading commit data...
extras Loading commit data...
filter Loading commit data...
forms Loading commit data...
formula Loading commit data...
fpicker Loading commit data...
framework Loading commit data...
helpcompiler Loading commit data...
helpcontent2 @ 63f0834e
hwpfilter Loading commit data...
i18nlangtag Loading commit data...
i18npool Loading commit data...
i18nutil Loading commit data...
icon-themes Loading commit data...
idl Loading commit data...
idlc Loading commit data...
include Loading commit data...
instsetoo_native Loading commit data...
io Loading commit data...
ios Loading commit data...
javaunohelper Loading commit data...
jurt Loading commit data...
jvmaccess Loading commit data...
jvmfwk Loading commit data...
l10ntools Loading commit data...
librelogo Loading commit data...
libreofficekit Loading commit data...
lingucomponent Loading commit data...
linguistic Loading commit data...
lotuswordpro Loading commit data...
m4 Loading commit data...
mysqlc Loading commit data...
nlpsolver Loading commit data...
o3tl Loading commit data...
odk Loading commit data...
offapi Loading commit data...
officecfg Loading commit data...
onlineupdate Loading commit data...
oovbaapi Loading commit data...
oox Loading commit data...
opencl Loading commit data...
osx Loading commit data...
package Loading commit data...
postprocess Loading commit data...
pyuno Loading commit data...
qadevOOo Loading commit data...
readlicense_oo Loading commit data...
registry Loading commit data...
remotebridges Loading commit data...
reportbuilder Loading commit data...
reportdesign Loading commit data...
ridljar Loading commit data...
rsc Loading commit data...
sal Loading commit data...
salhelper Loading commit data...
sax Loading commit data...
sc Loading commit data...
scaddins Loading commit data...
sccomp Loading commit data...
scp2 Loading commit data...
scripting Loading commit data...
sd Loading commit data...
sdext Loading commit data...
setup_native Loading commit data...
sfx2 Loading commit data...
shell Loading commit data...
slideshow Loading commit data...
smoketest Loading commit data...
solenv Loading commit data...
soltools Loading commit data...
sot Loading commit data...
starmath Loading commit data...
stoc Loading commit data...
store Loading commit data...
svgio Loading commit data...
svl Loading commit data...
svtools Loading commit data...
svx Loading commit data...
sw Loading commit data...
swext Loading commit data...
sysui Loading commit data...
test Loading commit data...
testtools Loading commit data...
toolkit Loading commit data...
tools Loading commit data...
translations @ 80052aba
tubes Loading commit data...
ucb Loading commit data...
ucbhelper Loading commit data...
udkapi Loading commit data...
uitest Loading commit data...
unodevtools Loading commit data...
unoidl Loading commit data...
unoil Loading commit data...
unotest Loading commit data...
unotools Loading commit data...
unoxml Loading commit data...
ure Loading commit data...
uui Loading commit data...
vbahelper Loading commit data...
vcl Loading commit data...
winaccessibility Loading commit data...
windows Loading commit data...
wizards Loading commit data...
writerfilter Loading commit data...
writerperfect Loading commit data...
xmerge Loading commit data...
xmlhelp Loading commit data...
xmloff Loading commit data...
xmlreader Loading commit data...
xmlscript Loading commit data...
xmlsecurity Loading commit data...
.buckconfig Loading commit data...
.buckversion Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitmodules Loading commit data...
.gitreview Loading commit data...
BUCK Loading commit data...
COPYING Loading commit data...
COPYING.LGPL Loading commit data...
COPYING.MPL Loading commit data...
Library_merged.mk Loading commit data...
Makefile.fetch Loading commit data...
Makefile.gbuild Loading commit data...
Makefile.in Loading commit data...
README.Solaris Loading commit data...
README.cross Loading commit data...
README.md Loading commit data...
Repository.mk Loading commit data...
RepositoryExternal.mk Loading commit data...
RepositoryFixes.mk Loading commit data...
RepositoryModule_build.mk Loading commit data...
RepositoryModule_host.mk Loading commit data...
TEMPLATE.SOURCECODE.HEADER Loading commit data...
autogen.sh Loading commit data...
config.guess Loading commit data...
config.sub Loading commit data...
config_host.mk.in Loading commit data...
config_host_lang.mk.in Loading commit data...
configure.ac Loading commit data...
download.lst Loading commit data...
g Loading commit data...
install-sh Loading commit data...
leak-suppress.txt Loading commit data...
lo.xcent.in Loading commit data...
logerrit Loading commit data...
sanitize-ubsan-blacklist Loading commit data...
unusedcode.README Loading commit data...
unusedcode.easy Loading commit data...
unusedcode.exclude Loading commit data...