• Stephan Bergmann's avatar
    SAL_DLLPUBLIC_RTTI for proper RTTI visibility for LLVM · b4f6b26b
    Stephan Bergmann yazdı
    The Itanium C++ ABI mandates that for a unique (complete) C++ type a single
    unique symbol for the type's RTTI name is used across a process's dynamic
    objects (so type equivalence can be determined via pointer comparison on the
    RTTI names).
    
    GCC nowadays deviates from that, using strcmp to determine equivalence, so it is
    resilient to RTTI names being bound locally within dynamic objects (which has
    performance benefits, but also makes it impossible to have unrelated types that
    happen to have the same name "encapsulated" in individual dynamic objects---
    whether or not that would violate the ODR would be open to interpretation of how
    dynamic objects fit into the C++ Standard).
    
    LLVM sticks to the Itanium ABI, which becomes notable in at least two places:
    
    For one, libc++abi's __dynamic_cast uses strict checking.  It still has a
    _LIBCXX_DYNAMIC_FALLBACK for now that additionally uses strcmp checking and
    syslogs visibility violations.  Mac OS X uses libc++abi with
    _LIBCXX_DYNAMIC_FALLBACK enabled, and running LO routinely logs dynamic_cast
    errors to the Console there.
    
    For another, RTTI-based UBSan checks unconditionally only use strict checking
    (cf. isDerivedFromAtOffset in lib/ubsan/ubsan_type_hash.cc).  This causes false
    positives from Clang -fsanitize=function and -fsanitize=vptr even on Linux not
    using libc++abi.
    
    Therefore, introduce SAL_DLLPUBLIC_RTTI to mark types for which RTTI needs to
    have default visibility under the Itanium/LLVM semantics.  There is
    unfortunately no way to mark only the (implicitly generated) RTTI symbols for
    default visibility, but at least with the cases where SAL_DLLPUBLIC_RTTI is used
    for now that is no real problem---any class type marked SAL_DLLPUBLIC_RTTI only
    has inline (covered by -fvisibility-inlines-hidden) or undefined pure virtual
    functions.  It appears that even the vtables of those classes remain hidden, at
    least with Mach-O on Mac OS X.  (That also means there is no need for a
    SAL_DLLPRIVATE_RTTI marker analoguous to the---also superfluous in retrospect---
    CPPU_GCC_DLLPRIVATE one.)
    
    Nevertheless, the number of exported symbols of course increases when
    SAL_DLLPUBLIC_RTTI is "active."  For a full-blown --enable-dbgutil build on Mac
    OS X,
    
      find instdir/LibreOffice.app/Contents -name \*.dylib\* -exec nm -gU {} \; \
        wc -l
    
    increased from 125541 to 139239.  For Linux, an option might be to "activate"
    SAL_DLLPUBLIC_RTTI only for __clang__ plus !ENABLE_RUNTIME_OPTIMIZATIONS.
    
    The set of types marked SAL_DLLPUBLIC_RTTI with this patch (wholesale cppumaker-
    generated UNO enum, struct, and interface types; plus some IEmbeddedHelper and
    IUndoManager) is chosen so that a full "make check" on Mac OS X no longer
    syslogs any dynamic_cast errors to the Console.
    
    Change-Id: I42fa6ec01c2503ec24bcd9c0518abb112afa3235
    b4f6b26b
Adı
Son kayıt (commit)
Son güncelleme
.git-hooks Loading commit data...
UnoControls Loading commit data...
accessibility Loading commit data...
android Loading commit data...
animations Loading commit data...
apple_remote Loading commit data...
avmedia Loading commit data...
basctl Loading commit data...
basebmp Loading commit data...
basegfx Loading commit data...
basic Loading commit data...
bean Loading commit data...
bin Loading commit data...
binaryurp Loading commit data...
bridges Loading commit data...
canvas Loading commit data...
chart2 Loading commit data...
clew Loading commit data...
cli_ure Loading commit data...
codemaker Loading commit data...
comphelper Loading commit data...
compilerplugins Loading commit data...
config_host Loading commit data...
configmgr Loading commit data...
connectivity Loading commit data...
cppcanvas Loading commit data...
cppu Loading commit data...
cppuhelper Loading commit data...
cpputools Loading commit data...
cui Loading commit data...
dbaccess Loading commit data...
desktop Loading commit data...
dictionaries @ e68d0668
distro-configs Loading commit data...
drawinglayer Loading commit data...
dtrans Loading commit data...
editeng Loading commit data...
embeddedobj Loading commit data...
embedserv Loading commit data...
eventattacher Loading commit data...
extensions Loading commit data...
external Loading commit data...
extras Loading commit data...
filter Loading commit data...
forms Loading commit data...
formula Loading commit data...
fpicker Loading commit data...
framework Loading commit data...
helpcompiler Loading commit data...
helpcontent2 @ 50920f83
hwpfilter Loading commit data...
i18nlangtag Loading commit data...
i18npool Loading commit data...
i18nutil Loading commit data...
icon-themes Loading commit data...
idl Loading commit data...
idlc Loading commit data...
include Loading commit data...
instsetoo_native Loading commit data...
io Loading commit data...
ios Loading commit data...
javaunohelper Loading commit data...
jurt Loading commit data...
jvmaccess Loading commit data...
jvmfwk Loading commit data...
l10ntools Loading commit data...
librelogo Loading commit data...
libreofficekit Loading commit data...
lingucomponent Loading commit data...
linguistic Loading commit data...
lotuswordpro Loading commit data...
m4 Loading commit data...
mysqlc Loading commit data...
nlpsolver Loading commit data...
o3tl Loading commit data...
odk Loading commit data...
offapi Loading commit data...
officecfg Loading commit data...
oovbaapi Loading commit data...
oox Loading commit data...
opencl Loading commit data...
osx Loading commit data...
package Loading commit data...
postprocess Loading commit data...
pyuno Loading commit data...
qadevOOo Loading commit data...
readlicense_oo Loading commit data...
registry Loading commit data...
remotebridges Loading commit data...
reportbuilder Loading commit data...
reportdesign Loading commit data...
ridljar Loading commit data...
rsc Loading commit data...
sal Loading commit data...
salhelper Loading commit data...
sax Loading commit data...
sc Loading commit data...
scaddins Loading commit data...
sccomp Loading commit data...
scp2 Loading commit data...
scripting Loading commit data...
sd Loading commit data...
sdext Loading commit data...
setup_native Loading commit data...
sfx2 Loading commit data...
shell Loading commit data...
slideshow Loading commit data...
smoketest Loading commit data...
solenv Loading commit data...
soltools Loading commit data...
sot Loading commit data...
starmath Loading commit data...
stoc Loading commit data...
store Loading commit data...
svgio Loading commit data...
svl Loading commit data...
svtools Loading commit data...
svx Loading commit data...
sw Loading commit data...
swext Loading commit data...
sysui Loading commit data...
test Loading commit data...
testtools Loading commit data...
toolkit Loading commit data...
tools Loading commit data...
translations @ 78a223e7
tubes Loading commit data...
ucb Loading commit data...
ucbhelper Loading commit data...
udkapi Loading commit data...
unodevtools Loading commit data...
unoidl Loading commit data...
unoil Loading commit data...
unotest Loading commit data...
unotools Loading commit data...
unoxml Loading commit data...
ure Loading commit data...
uui Loading commit data...
vbahelper Loading commit data...
vcl Loading commit data...
winaccessibility Loading commit data...
wizards Loading commit data...
writerfilter Loading commit data...
writerperfect Loading commit data...
xmerge Loading commit data...
xmlhelp Loading commit data...
xmloff Loading commit data...
xmlreader Loading commit data...
xmlscript Loading commit data...
xmlsecurity Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitmodules Loading commit data...
.gitreview Loading commit data...
COPYING Loading commit data...
COPYING.LGPL Loading commit data...
COPYING.MPL Loading commit data...
Library_merged.mk Loading commit data...
Library_urelibs.mk Loading commit data...
Makefile.fetch Loading commit data...
Makefile.gbuild Loading commit data...
Makefile.in Loading commit data...
README.Android Loading commit data...
README.Code Loading commit data...
README.Solaris Loading commit data...
README.cross Loading commit data...
Repository.mk Loading commit data...
RepositoryExternal.mk Loading commit data...
RepositoryFixes.mk Loading commit data...
RepositoryModule_build.mk Loading commit data...
RepositoryModule_host.mk Loading commit data...
TEMPLATE.SOURCECODE.HEADER Loading commit data...
autogen.sh Loading commit data...
config.guess Loading commit data...
config.sub Loading commit data...
config_host.mk.in Loading commit data...
configure.ac Loading commit data...
download.lst Loading commit data...
g Loading commit data...
install-sh Loading commit data...
leak-suppress.txt Loading commit data...
lo.xcent.in Loading commit data...
logerrit Loading commit data...
unusedcode.README Loading commit data...
unusedcode.easy Loading commit data...
unusedcode.exclude Loading commit data...