• Tor Lillqvist's avatar
    Fix the OpenCL VLOOKUP to work properly and add it to the trusted subset · 4d61abf9
    Tor Lillqvist yazdı
    Treat an array of null string pointers as no strings for OpenCL. For
    some reason, at least in the case of the "Test OpenCL" thing, we got
    an mpStringArray that is non-null but where all the elements
    (rtl_uString pointers) in it are null. Treat that case as if the
    mpStringArray was null.
    
    This makes the tests "Test OpenCL" actually use OpenCL. Maybe it has other
    useful effects, too. (But for normal spreadsheet use, the mpStringArray that
    gets handled here *is* null when all the cells used by a formula group are
    numbers. At least it seemed so in a simple test.)
    
    Add a few more useful (?) SAL_INFO calls.
    
    Some cosmetic changes to make the code look saner.
    
    Return correct value from the OpenCL VLOOKUP implementation. Also,
    when the lookup fails, produce the expected N/A error code instead of
    a bare NaN.
    
    Don't claim we support strings arguments in the OpenCL VLOOKUP.  The
    string support certainly isn't complete or correct anyway. Partially
    revert c3383aaf.
    
    Add VLOOKUP to the set of opcodes that we trust the OpenCL
    implementation for.
    
    (cherry picked from commit 7e91726f)
    (cherry picked from commit d4310b6c)
    (cherry picked from commit 32b35d9d)
    (cherry picked from commit 41a60940)
    (cherry picked from commit 16226445)
    (cherry picked from commit 7bb7539c)
    
    Change-Id: I5402732c9ddcac1efcc25960a5c46175d7a90b4d
    Reviewed-on: https://gerrit.libreoffice.org/18022Reviewed-by: 's avatarMichael Meeks <michael.meeks@collabora.com>
    Reviewed-by: 's avatarEike Rathke <erack@redhat.com>
    Tested-by: 's avatarJan Holesovsky <kendy@collabora.com>
    4d61abf9
Adı
Son kayıt (commit)
Son güncelleme
..
inc Loading commit data...
qa Loading commit data...
sdi Loading commit data...
source Loading commit data...
uiconfig/scalc Loading commit data...
util Loading commit data...
workben Loading commit data...
AllLangResTarget_sc.mk Loading commit data...
CppunitTest_sc_annotationobj.mk Loading commit data...
CppunitTest_sc_annotationshapeobj.mk Loading commit data...
CppunitTest_sc_annotationsobj.mk Loading commit data...
CppunitTest_sc_bugfix_test.mk Loading commit data...
CppunitTest_sc_cellrangeobj.mk Loading commit data...
CppunitTest_sc_chart_regression_test.mk Loading commit data...
CppunitTest_sc_condformats.mk Loading commit data...
CppunitTest_sc_copypaste.mk Loading commit data...
CppunitTest_sc_databaserangeobj.mk Loading commit data...
CppunitTest_sc_datapilotfieldobj.mk Loading commit data...
CppunitTest_sc_datapilottableobj.mk Loading commit data...
CppunitTest_sc_editfieldobj_cell.mk Loading commit data...
CppunitTest_sc_editfieldobj_header.mk Loading commit data...
CppunitTest_sc_filters_test.mk Loading commit data...
CppunitTest_sc_html_export_test.mk Loading commit data...
CppunitTest_sc_macros_test.mk Loading commit data...
CppunitTest_sc_modelobj.mk Loading commit data...
CppunitTest_sc_namedrangeobj.mk Loading commit data...
CppunitTest_sc_namedrangesobj.mk Loading commit data...
CppunitTest_sc_new_cond_format_api.mk Loading commit data...
CppunitTest_sc_opencl_test.mk Loading commit data...
CppunitTest_sc_outlineobj.mk Loading commit data...
CppunitTest_sc_perfobj.mk Loading commit data...
CppunitTest_sc_rangelst_test.mk Loading commit data...
CppunitTest_sc_recordchanges.mk Loading commit data...
CppunitTest_sc_styleloaderobj.mk Loading commit data...
CppunitTest_sc_subsequent_export_test.mk Loading commit data...
CppunitTest_sc_subsequent_filters_test.mk Loading commit data...
CppunitTest_sc_tablesheetobj.mk Loading commit data...
CppunitTest_sc_tablesheetsobj.mk Loading commit data...
CppunitTest_sc_ucalc.mk Loading commit data...
CustomTarget_uiconfig.mk Loading commit data...
JunitTest_sc_complex.mk Loading commit data...
JunitTest_sc_unoapi.mk Loading commit data...
Library_sc.mk Loading commit data...
Library_scd.mk Loading commit data...
Library_scfilt.mk Loading commit data...
Library_scqahelper.mk Loading commit data...
Library_scui.mk Loading commit data...
Library_vbaobj.mk Loading commit data...
Makefile Loading commit data...
Module_sc.mk Loading commit data...
README Loading commit data...
UIConfig_scalc.mk Loading commit data...