• Stephan Bergmann's avatar
    More -Werror,-Wunused-private-field · ad9498f8
    Stephan Bergmann yazdı
    ...detected with a modified trunk Clang with
    
    > Index: lib/Sema/SemaDeclCXX.cpp
    > ===================================================================
    > --- lib/Sema/SemaDeclCXX.cpp	(revision 219190)
    > +++ lib/Sema/SemaDeclCXX.cpp	(working copy)
    > @@ -1917,9 +1917,10 @@
    >    const Type *T = FD.getType()->getBaseElementTypeUnsafe();
    >    // FIXME: Destruction of ObjC lifetime types has side-effects.
    >    if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
    > -    return !RD->isCompleteDefinition() ||
    > -           !RD->hasTrivialDefaultConstructor() ||
    > -           !RD->hasTrivialDestructor();
    > +    return !RD->hasAttr<WarnUnusedAttr>() &&
    > +           (!RD->isCompleteDefinition() ||
    > +            !RD->hasTrivialDefaultConstructor() ||
    > +            !RD->hasTrivialDestructor());
    >    return false;
    >  }
    >
    > @@ -3517,9 +3518,11 @@
    >    bool addFieldInitializer(CXXCtorInitializer *Init) {
    >      AllToInit.push_back(Init);
    >
    > +#if 0
    >      // Check whether this initializer makes the field "used".
    >      if (Init->getInit()->HasSideEffects(S.Context))
    >        S.UnusedPrivateFields.remove(Init->getAnyMember());
    > +#endif
    >
    >      return false;
    >    }
    
    to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
    initializations with side effects (cf.
    <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
    "-Wunused-private-field distracted by side effects").
    
    Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
    ad9498f8
Adı
Son kayıt (commit)
Son güncelleme
..
ColorPropertySet.cxx Loading commit data...
ColorPropertySet.hxx Loading commit data...
MultiPropertySetHandler.hxx Loading commit data...
PropertyMap.hxx Loading commit data...
PropertyMaps.cxx Loading commit data...
SchXMLAutoStylePoolP.cxx Loading commit data...
SchXMLAutoStylePoolP.hxx Loading commit data...
SchXMLAxisContext.cxx Loading commit data...
SchXMLAxisContext.hxx Loading commit data...
SchXMLCalculationSettingsContext.cxx Loading commit data...
SchXMLCalculationSettingsContext.hxx Loading commit data...
SchXMLChartContext.cxx Loading commit data...
SchXMLChartContext.hxx Loading commit data...
SchXMLEnumConverter.cxx Loading commit data...
SchXMLEnumConverter.hxx Loading commit data...
SchXMLExport.cxx Loading commit data...
SchXMLImport.cxx Loading commit data...
SchXMLLegendContext.cxx Loading commit data...
SchXMLLegendContext.hxx Loading commit data...
SchXMLParagraphContext.cxx Loading commit data...
SchXMLParagraphContext.hxx Loading commit data...
SchXMLPlotAreaContext.cxx Loading commit data...
SchXMLPlotAreaContext.hxx Loading commit data...
SchXMLPropertyMappingContext.cxx Loading commit data...
SchXMLPropertyMappingContext.hxx Loading commit data...
SchXMLRegressionCurveObjectContext.cxx Loading commit data...
SchXMLRegressionCurveObjectContext.hxx Loading commit data...
SchXMLSeries2Context.cxx Loading commit data...
SchXMLSeries2Context.hxx Loading commit data...
SchXMLSeriesHelper.cxx Loading commit data...
SchXMLTableContext.cxx Loading commit data...
SchXMLTableContext.hxx Loading commit data...
SchXMLTextListContext.cxx Loading commit data...
SchXMLTextListContext.hxx Loading commit data...
SchXMLTools.cxx Loading commit data...
SchXMLTools.hxx Loading commit data...
XMLAxisPositionPropertyHdl.cxx Loading commit data...
XMLAxisPositionPropertyHdl.hxx Loading commit data...
XMLChartPropertyContext.cxx Loading commit data...
XMLChartPropertyContext.hxx Loading commit data...
XMLChartStyleContext.cxx Loading commit data...
XMLErrorBarStylePropertyHdl.cxx Loading commit data...
XMLErrorBarStylePropertyHdl.hxx Loading commit data...
XMLErrorIndicatorPropertyHdl.cxx Loading commit data...
XMLErrorIndicatorPropertyHdl.hxx Loading commit data...
XMLLabelSeparatorContext.cxx Loading commit data...
XMLLabelSeparatorContext.hxx Loading commit data...
XMLSymbolImageContext.cxx Loading commit data...
XMLSymbolImageContext.hxx Loading commit data...
XMLSymbolTypePropertyHdl.cxx Loading commit data...
XMLSymbolTypePropertyHdl.hxx Loading commit data...
XMLTextOrientationHdl.cxx Loading commit data...
XMLTextOrientationHdl.hxx Loading commit data...
contexts.cxx Loading commit data...
contexts.hxx Loading commit data...
transporttypes.cxx Loading commit data...
transporttypes.hxx Loading commit data...