• Stephan Bergmann's avatar
    [API CHANGE] Synchronize supported Writer document zoom ranges · 6287a4f0
    Stephan Bergmann yazdı
    On the one hand, SvxZoomSliderItem/SvxZoomSliderControl as used by SwView's
    SID_ATTR_ZOOMSLIDER support a range from MINZOOM (20) to MAXZOOM (600) (defined
    in sw/inc/view.hxx).  Setting a zoom value outside that range for one causes the
    DBG_ASSERT "Looks like the zoom slider item is corrupted" in
    SvxZoomSliderControl::StateChanged (svx/source/stbctrls/zoomsliderctrl.cxx) to
    fire, and for another (when setting a too small value) tries to assign a
    negative value (which wraps around, and gets flagged by Clang's
    -fsanitize=implicit-signed-integer-truncation) to sal_uInt16 nCurrentZoom at
    
      nCurrentZoom = nCurrentZoom - mxImpl->mnMinZoom;
    
    in SvxZoomSliderControl::Zoom2Offset (svx/source/stbctrls/zoomsliderctrl.cxx).
    
    On the other hand, SwXViewSettings' support of css.text.ViewSettings' ZoomValue
    property allowed values in the range from 5 to 1000 (cf.
    SwXViewSettings::_setSingleValue in sw/source/uibase/uno/unomod.cxx), and some
    JunitTests actually set such values (10, 15) below the MINZOOM value of 20.
    
    The incompatible 5--1000 range was there ever since
    7b0b5cdf "initial import", but looks rather
    random, so change it to match the 20--600 range instead.  (And lets flag this as
    an [API CHANGE], to be on the safe side.)
    
    One of the JunitTests files that needed to be adapted,
    qadevOOo/tests/java/mod/_sw/SwAccessibleEndnoteView.java, oddly mentioned a
    zoom value of 130% in a comment while using the value 15 in the actual code.
    (And did so ever since the test code's introduction in
    26ebdfc4 "NEW: initial version".)  Changing the
    code to 130 would cause JunitTest_sw_unoapi_1 to fail in strange ways, with
    disposed UNO objects, while changing the code (and comment) to 21 appears to
    work.  Go figure.
    
    Change-Id: Id944ffdce501448312e008436e7038bf2aec63ac
    Reviewed-on: https://gerrit.libreoffice.org/67427
    Tested-by: Jenkins
    Reviewed-by: 's avatarSamuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
    Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
    6287a4f0
Adı
Son kayıt (commit)
Son güncelleme
..
CharacterStyle.java Loading commit data...
ConditionalParagraphStyle.java Loading commit data...
DocumentSettings.java Loading commit data...
PageStyle.java Loading commit data...
ParagraphStyle.java Loading commit data...
SwAccessibleDocumentPageView.java Loading commit data...
SwAccessibleDocumentView.java Loading commit data...
SwAccessibleEndnoteView.java Loading commit data...
SwAccessibleFooterView.java Loading commit data...
SwAccessibleFootnoteView.java Loading commit data...
SwAccessibleHeaderView.java Loading commit data...
SwAccessiblePageView.java Loading commit data...
SwAccessibleParagraphView.java Loading commit data...
SwAccessibleTableCellView.java Loading commit data...
SwAccessibleTableView.java Loading commit data...
SwAccessibleTextEmbeddedObject.java Loading commit data...
SwAccessibleTextFrameView.java Loading commit data...
SwAccessibleTextGraphicObject.java Loading commit data...
SwXAutoTextContainer.java Loading commit data...
SwXAutoTextEntry.java Loading commit data...
SwXAutoTextGroup.java Loading commit data...
SwXBodyText.java Loading commit data...
SwXBookmark.java Loading commit data...
SwXBookmarks.java Loading commit data...
SwXCell.java Loading commit data...
SwXCellRange.java Loading commit data...
SwXChapterNumbering.java Loading commit data...
SwXDocumentIndex.java Loading commit data...
SwXDocumentIndexMark.java Loading commit data...
SwXDocumentIndexes.java Loading commit data...
SwXDrawPage.java Loading commit data...
SwXEndnoteProperties.java Loading commit data...
SwXFieldEnumeration.java Loading commit data...
SwXFieldMaster.java Loading commit data...
SwXFootnote.java Loading commit data...
SwXFootnoteProperties.java Loading commit data...
SwXFootnoteText.java Loading commit data...
SwXFootnotes.java Loading commit data...
SwXFrames.java Loading commit data...
SwXHeadFootText.java Loading commit data...
SwXLineNumberingProperties.java Loading commit data...
SwXMailMerge.java Loading commit data...
SwXModule.java Loading commit data...
SwXNumberingRules.java Loading commit data...
SwXParagraph.java Loading commit data...
SwXParagraphEnumeration.java Loading commit data...
SwXPrintSettings.java Loading commit data...
SwXPropertySet.java Loading commit data...
SwXPropertySetInfo.java Loading commit data...
SwXReferenceMark.java Loading commit data...
SwXReferenceMarks.java Loading commit data...
SwXShape.java Loading commit data...
SwXStyle.java Loading commit data...
SwXStyleFamilies.java Loading commit data...
SwXStyleFamily.java Loading commit data...
SwXTableCellText.java Loading commit data...
SwXTableColumns.java Loading commit data...
SwXTableRows.java Loading commit data...
SwXTextColumns.java Loading commit data...
SwXTextCursor.java Loading commit data...
SwXTextDefaults.java Loading commit data...
SwXTextDocument.java Loading commit data...
SwXTextEmbeddedObject.java Loading commit data...
SwXTextEmbeddedObjects.java Loading commit data...
SwXTextField.java Loading commit data...
SwXTextFieldMasters.java Loading commit data...
SwXTextFieldTypes.java Loading commit data...
SwXTextFrame.java Loading commit data...
SwXTextFrameText.java Loading commit data...
SwXTextGraphicObject.java Loading commit data...
SwXTextGraphicObjects.java Loading commit data...
SwXTextPortion.java Loading commit data...
SwXTextPortionEnumeration.java Loading commit data...
SwXTextRange.java Loading commit data...
SwXTextRanges.java Loading commit data...
SwXTextSearch.java Loading commit data...
SwXTextSection.java Loading commit data...
SwXTextSections.java Loading commit data...
SwXTextTable.java Loading commit data...
SwXTextTableCursor.java Loading commit data...
SwXTextTableRow.java Loading commit data...
SwXTextTables.java Loading commit data...
SwXTextView.java Loading commit data...
SwXTextViewCursor.java Loading commit data...
SwXViewSettings.java Loading commit data...
XMLContentExporter.java Loading commit data...
XMLContentImporter.java Loading commit data...
XMLExporter.java Loading commit data...
XMLImporter.java Loading commit data...
XMLMetaExporter.java Loading commit data...
XMLMetaImporter.java Loading commit data...
XMLSettingsExporter.java Loading commit data...
XMLSettingsImporter.java Loading commit data...
XMLStylesExporter.java Loading commit data...
XMLStylesImporter.java Loading commit data...
package.html Loading commit data...