Kaydet (Commit) b0b8c0c9 authored tarafından Enrico Tröger's avatar Enrico Tröger

Fix quoting the build command string on Windows (closes #2791769). This broke…

Fix quoting the build command string on Windows (closes #2791769). This broke when we made build commands run synchronously on Windows, now we don't need to special quote the commands anymore.

git-svn-id: https://geany.svn.sourceforge.net/svnroot/geany/trunk@3806 ea778897-0a13-0410-b9d1-a72fbfd435f5
üst cf531e43
......@@ -6,6 +6,10 @@
* src/editor.c, src/editor.h:
Make some only locally used functions static.
Fix wrong sanity check.
* src/build.c:
Fix quoting the build command string on Windows (closes #2791769).
This broke when we made build commands run synchronously on Windows,
now we don't need to special quote the commands anymore.
2009-05-19 Nick Treleaven <nick(dot)treleaven(at)btinternet(dot)com>
......
......@@ -507,13 +507,7 @@ static GPid build_spawn_cmd(GeanyDocument *doc, const gchar *cmd, const gchar *d
g_free(executable);
#ifdef G_OS_WIN32
/* due to g_shell_parse_argv() we need to enclose the command(first element) of cmd_string with
* "" if the command contains a full path(i.e. backslashes) otherwise the backslashes will be
* eaten by g_shell_parse_argv(). */
setptr(cmd_string, quote_executable(cmd_string));
if (! g_shell_parse_argv(cmd_string, NULL, &argv, NULL))
/* if automatic parsing failed, fall back to simple, unsafe argv creation */
argv = g_strsplit(cmd_string, " ", 0);
argv = g_strsplit(cmd_string, " ", 0);
#else
argv = g_new0(gchar *, 4);
argv[0] = g_strdup("/bin/sh");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment