- 28 Nis, 2019 27 kayıt (commit)
-
-
Mike Kaganski yazdı
V595 The 'ustrFile' pointer was utilized before it was verified against nullptr. Check lines: 83, 107. Change-Id: I874983508fb805b1f0a55b3a5b6d4d78ae1babdb Reviewed-on: https://gerrit.libreoffice.org/71472 Tested-by: Jenkins Reviewed-by:Mike Kaganski <mike.kaganski@collabora.com>
-
Jan-Marek Glogowski yazdı
It's the same then * (1 != c && 2 != c) || (3 != c) * !(1 == c || 2 == c) || !(3 == c) * !((1 == c || 2 == c) && (3 == c)) which is always true. Change-Id: Ib63127319ff7e9c13877ac54aa92427637061812 Reviewed-on: https://gerrit.libreoffice.org/71477 Tested-by: Jenkins Reviewed-by:
Jan-Marek Glogowski <glogow@fbihome.de>
-
Jan-Marek Glogowski yazdı
This function is just used by ApplyAsianKerning, so move it there. While at it drop the unused constant boolean. Same for the comment referencing ImplCalcKerning, which is long gone since a huge merge in commit 2f382d6c ("MWS_SRX644: migrate branch mws_srx644 -> HEAD"). Also "const int"ify ApplyAsianKerning. No need for long, as the lcl_CalcAsianKerning just returns int in the range [-2,+2]. Change-Id: I9b1b3351ab71219c8e2ee49ce441f5222e5c1c4b Reviewed-on: https://gerrit.libreoffice.org/71476 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
to make it work under gtk3 Change-Id: I4c895181af233a16292ce16b194f0a60994446fb Reviewed-on: https://gerrit.libreoffice.org/71478 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
Mike Kaganski yazdı
See commit 60dca2de, which converted preceeding OSL_ENSURE into asserts - so nullptr is considered impossible here. Change-Id: Ia6d8f226d94c84a66bad67ce1b5f702864d61fdc Reviewed-on: https://gerrit.libreoffice.org/71475 Tested-by: Jenkins Reviewed-by:
-
Mike Kaganski yazdı
V595 The 'pDoc' pointer was utilized before it was verified against nullptr. Check lines: 434, 460. Change-Id: Iec92cbb8c4f5e47f7852015bf466b1f8ed195517 Reviewed-on: https://gerrit.libreoffice.org/71471 Tested-by: Jenkins Reviewed-by: -
Mike Kaganski yazdı
V595 The 'GetMedium()' pointer was utilized before it was verified against nullptr. Check lines: 435, 455. bURLChanged is only meaningful when GetMedium() is not nullptr; otherwise bSaveDS could become true where no medium existed, and dereferencing GetMedium() to find its URL would segfault. Change-Id: I6f533acb3b1ca078803aa23bdece0ba2ee1d87c3 Reviewed-on: https://gerrit.libreoffice.org/71467 Tested-by: Jenkins Reviewed-by: -
Mike Kaganski yazdı
V595 The 'pContact' pointer was utilized before it was verified against nullptr. Check lines: 1254, 1256. Change-Id: I5d3d28b3c8a70924f329fde9f020f42d9eb5e9a1 Reviewed-on: https://gerrit.libreoffice.org/71459 Tested-by: Jenkins Reviewed-by: -
Mike Kaganski yazdı
V595 The 'mpViewShell' pointer was utilized before it was verified against nullptr. Check lines: 96, 125. Change-Id: I824c6cf8a5ed7f0ef20e99df36c83feec7fe54ea Reviewed-on: https://gerrit.libreoffice.org/71468 Tested-by: Jenkins Reviewed-by: -
Mike Kaganski yazdı
V595 The 'mpViewShell' pointer was utilized before it was verified against nullptr. Check lines: 193, 201. Change-Id: I0d3cfee4d6f7bbb536c463b698361a1d299d2863 Reviewed-on: https://gerrit.libreoffice.org/71469 Tested-by: Jenkins Reviewed-by: -
Mike Kaganski yazdı
V595 The 'GetActiveWindow()' pointer was utilized before it was verified against nullptr. Check lines: 544, 567. Change-Id: I1ef45fa72542168ba88f24482973a1c660bcc1a8 Reviewed-on: https://gerrit.libreoffice.org/71470 Tested-by: Jenkins Reviewed-by: -
Caolán McNamara yazdı
Change-Id: I92c83dcb9fd0fa3305aa2f40f6cc0d28fc0ad022 Reviewed-on: https://gerrit.libreoffice.org/71438 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I729d62520e9b59e96984f5d4b1aabd059f60d71d Reviewed-on: https://gerrit.libreoffice.org/71437 Tested-by: Jenkins Reviewed-by:
-
Mike Kaganski yazdı
V595 The 'pEndIdx' pointer was utilized before it was verified against nullptr. Check lines: 1328, 1347. Change-Id: If9aff472e6ec7429ef2055b44dd11e62d4489ba4 Reviewed-on: https://gerrit.libreoffice.org/71458 Tested-by: Jenkins Reviewed-by: -
Mike Kaganski yazdı
pofs is guaranteed to be non-nullptr after getOutputStream, so no need to check that. is_open() only matters to decide if close() is needed. V595 The 'pofs' pointer was utilized before it was verified against nullptr. Check lines: 1033, 1057. Check lines: 1194, 1220. Change-Id: I2dd22d29c465889269f2496f0964bee030cb5964 Reviewed-on: https://gerrit.libreoffice.org/71456 Tested-by: Jenkins Reviewed-by: -
Mike Kaganski yazdı
The result of GetDialogExampleSet is checked below. Change-Id: Ic3f7820d6d6923e0ced518157ce41f6bc0de65a7 Reviewed-on: https://gerrit.libreoffice.org/71457 Tested-by: Jenkins Reviewed-by:
-
Mike Kaganski yazdı
V595 The 'pHdl' pointer was utilized before it was verified against nullptr. Check lines: 192, 197. Change-Id: I52e1d1eadaded8616b8a27e0fcfaf6d1e6baa03e Reviewed-on: https://gerrit.libreoffice.org/71455 Tested-by: Jenkins Reviewed-by: -
Mike Kaganski yazdı
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Change-Id: I99117fa7c04a5de565833be7bdc001d97e635d61 Reviewed-on: https://gerrit.libreoffice.org/71453 Tested-by: Jenkins Reviewed-by: -
Mike Kaganski yazdı
The strange implementation was there ever since commit bd363380. The other possibility is to just remove the block above the last assignment to aRet Change-Id: I5bd3bf1f518ab894e5df4cbc7d86a76d325e4600 Reviewed-on: https://gerrit.libreoffice.org/71447Reviewed-by:
-
Mike Kaganski yazdı
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Change-Id: I11fa13677c7980e6ac17fc4358406472ee784e41 Reviewed-on: https://gerrit.libreoffice.org/71446 Tested-by: Jenkins Reviewed-by: -
Andrea Gelmini yazdı
Change-Id: Ia5809ac7ff74652e5d83ef2dbc176c4f586b7203 Reviewed-on: https://gerrit.libreoffice.org/71449 Tested-by: Jenkins Reviewed-by:
Julien Nabet <serval2412@yahoo.fr>
-
Andrea Gelmini yazdı
Change-Id: Id6985abca7702039168381082da4e47603b9aaf3 Reviewed-on: https://gerrit.libreoffice.org/71451 Tested-by: Jenkins Reviewed-by:
-
Andrea Gelmini yazdı
Change-Id: I8c928576919c9410eda0a7f33b2120d13c3bc6bf Reviewed-on: https://gerrit.libreoffice.org/71450 Tested-by: Jenkins Reviewed-by:
-
Tomaž Vajngerl yazdı
Change-Id: Ic84773399c95d61f843e4388fe01d00cd4facc5a Reviewed-on: https://gerrit.libreoffice.org/71425Reviewed-by:
Tomaž Vajngerl <quikee@gmail.com> Tested-by:
-
Tomaž Vajngerl yazdı
Change-Id: I95fd2d4e164bf04c4457b3e20401270227e21a8f Reviewed-on: https://gerrit.libreoffice.org/71424Reviewed-by:
-
Tomaž Vajngerl yazdı
Change-Id: I982a108b2241c049b595a13d6f39d24ef0266074 Reviewed-on: https://gerrit.libreoffice.org/71423 Tested-by: Jenkins Reviewed-by:
-
Tomaž Vajngerl yazdı
This is the first step of refactoring Animation where it is needed to separate AnimationBitmap(s) from the Animation class, which is also responsible for displaying of animation. General idea is to make Graphic work only with AnimationBitmaps, which can be freely be swapped out and in, make copies - all transparantly from the actually displaying them and possibly it will also remove the need to copy the animation objects. Change-Id: If5d55ac1a5b26c3880d4f7602be57742b086f9da Reviewed-on: https://gerrit.libreoffice.org/71406 Tested-by: Jenkins Reviewed-by:
-
- 27 Nis, 2019 13 kayıt (commit)
-
-
Jan-Marek Glogowski yazdı
These are adjusted via MultiSalLayout::AdjustLayout, as they just know their own text width, but not the full text width of the MultiSalLayout, so the adjustment is too large. The correct adjustment is done by preparing a DXArray for all glyphs, which is then passed to the individual font fallback layouts for general adjustment. Change-Id: I439527d03df4752e74ff94aee7775a95275be5e2 Reviewed-on: https://gerrit.libreoffice.org/71440 Tested-by: Jenkins Reviewed-by:
-
Jan-Marek Glogowski yazdı
Change-Id: I6602c84b9bd7143e5e7b224c17559b083c9b7f9c Reviewed-on: https://gerrit.libreoffice.org/71439 Tested-by: Jenkins Reviewed-by:
-
Mike Kaganski yazdı
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 645, 655 Since commit 37aa7d81 Change-Id: I7b4d2d58e51cf98ac6294d1feacd28c3a8761d81 Reviewed-on: https://gerrit.libreoffice.org/71431 Tested-by: Jenkins Reviewed-by: -
Dennis Francis yazdı
Change-Id: Id3416e5631dcd6e427429ac475ac81b2ab70b9e5 Reviewed-on: https://gerrit.libreoffice.org/71429 Tested-by: Jenkins Reviewed-by:
Dennis Francis <dennis.francis@collabora.com>
-
Dennis Francis yazdı
Change-Id: Icaa547ba5ef210ba721661242b2becd9f559f09a Reviewed-on: https://gerrit.libreoffice.org/71428 Tested-by: Jenkins Reviewed-by:
-
Andrea Gelmini yazdı
Change-Id: Id81e8db5a38b4e4a88cc21c50234c2338e9c41bf Reviewed-on: https://gerrit.libreoffice.org/71421 Tested-by: Jenkins Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I422131ab203eba62ed5cf6fb2e19e23325b43f6e Reviewed-on: https://gerrit.libreoffice.org/71433 Tested-by: Jenkins Reviewed-by:
-
Michael Meeks yazdı
Change-Id: I13a200c9c9d8b0a8fde6dd15a71fe1a665d04e8d Reviewed-on: https://gerrit.libreoffice.org/71432 Tested-by: Jenkins Reviewed-by:
Michael Meeks <michael.meeks@collabora.com>
-
Mike Kaganski yazdı
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Change-Id: I79c655a072faff0bdb2af031ed1328e684b83aac Reviewed-on: https://gerrit.libreoffice.org/71430 Tested-by: Jenkins Reviewed-by: -
Caolán McNamara yazdı
since... commit e54762ba Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Apr 16 17:17:58 2019 +0100 weld ScTPValidationValue and ScValidationDlg the inc/dev modality on show/hide isn't desirable anymore Change-Id: I5bf908871986160de61508c9678495d0d5a8296d Reviewed-on: https://gerrit.libreoffice.org/71426 Tested-by: Jenkins Reviewed-by:
-
Gabor Kelemen yazdı
Seems I forgot about this in commit 7f6a5b43 Change-Id: Ic575292b99836374f179cbc1dbe182858415b63f Reviewed-on: https://gerrit.libreoffice.org/71306 Tested-by: Jenkins Reviewed-by:
-
Gabor Kelemen yazdı
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9770343f31f882427c9ae13e363b59cd1fb47e98 Reviewed-on: https://gerrit.libreoffice.org/71295 Tested-by: Jenkins Reviewed-by:
-
Gabor Kelemen yazdı
Change-Id: Id48dc67443bbd28b0a7e2987b2546808cac8e8e2 Reviewed-on: https://gerrit.libreoffice.org/71334 Tested-by: Jenkins Reviewed-by:
-
