Change-Id: I098c9ee9d22ac0401faf7fc6d65e91bf5b4b2bf8
Reviewed-on: https://gerrit.libreoffice.org/9797Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Iaf4e34007d7822705a278a94138572b0379b2779

It would certainly be immediately obvious to any reader of the RTF spec
that \sN will apply the style with index N to the current paragraph.

But actually, that is not what Word does when it reads \sN...
what it really does is to apply the style with index N, and then for
every attribute in that style, apply the same attribute with a default
value to the paragraph, effectively overriding what's in the style.

If that doesn't make any sense to you, well, have you heard the joke
about how many Microsoft engineers it takes to change a light bulb?

Also, \pard apparently implies \s0.

To implement that, change RTFSprms::deduplicate() to recursively
look for style SPRMs that are missing in the properties, and put
in default ones, currently just for 2 keywords \sa and \sb.

This requires changing deduplicate() to be const and return a new value,
since it is no longer idempotent, as the erased SPRMs would get
defaulted on the next run.

While at it, fix RTFValue::equals() which did not compare m_sValue.

This fixes the testParaBottomMargin test that was broken by the fix
for fdo#70578.

Change-Id: I4ced38628d76f6c41b488d608a804883493ff00b

quoth the spec:

"For <style>, both <styledef> and <stylename> are optional; the default
is paragraph style 0."

Of course in order to do that we need to add support for at least
recognizing the \dsN and \tsN keywords to override the default, so that
table styles don't become paragraph styles.

Change-Id: Ic100768581f9e8c327063ff776fbd61ac4242483

Change-Id: I2b6f33eaf12343c7da1328a932eb703bb4e4ef6f

CppunitTest_sw_ooxmlsdrexport's testAnchorIdForWP14AndW14 would fail
without this, when "shape with text" is imported as "shape with
textbox".

Change-Id: I8705aee16270aa68416f0c830c429880fc76d85d

Change-Id: Ic63372285fecb6f1be22e92c36cdb6f94733f5c1

For large documents we create and destroy a large number of non-poolable
SfxPoolItems, which get inserted into and removed from a vector.
Unfortunately the performance of this (depending on pattern) is O(N) and
this insert/remove/extend pattern can happen per text span we insert.
This patch makes this O(const) via a hash. This gives a 5x speedup for
the above bug; 176s to 34s or so, and moves the remaining performance
issues elsewhere.

Unfortunately, we have to retain the ordered array to keep the binary
file format code (used for editeng cut-and-paste) in place, so have to
keep both a hash, and an array, and a list around for free slots. cf.
fdo#79851 where there is a start at removing that.

This wastes space; but not that much - for a large open document
collection we have O(100's) of SfxItemPools, and O(1000's) of
SfxPoolItemArray_Impls; having fixed fdo#79851 we can consolidate this.

Add skeletal unit test; translate several German comments; remove
un-necessary include.

Change-Id: Ie0de32b1a29217560c5591c71a6cd4e26d39a531

...no reason to not have it enabled for URE C include files and what
little real C code is still left.  (But note that Clang ignores that
warning.)

Change-Id: Ia6940f9f940a0c226e9b724331d65c9862ce32e6

Change-Id: I1bfdd865429cc6fa89ea3b6b4fc132b5d5b57b0d

Change-Id: I80fd6b112134ab2b0e4a592f60a21c7c177b4b01

Change-Id: Id0a13af0c0d1aa0b6a21edde0ec7f97730a1c912

Change-Id: Icb1ba7f7068f60c4bd5eda7002415214b3d885f3

  
Change-Id: I2b932c9f09a010a4f999707fb6299c392a89550a
Reviewed-on: https://gerrit.libreoffice.org/9806Reviewed-by: Muthu Subramanian K <muthusuba@gmail.com>
Tested-by: Muthu Subramanian K <muthusuba@gmail.com>

Change-Id: I2590bd8b0d0c1d853caead60cf3af1b865d7fed7
Reviewed-on: https://gerrit.libreoffice.org/9805Reviewed-by: Muthu Subramanian K <muthusuba@gmail.com>
Tested-by: Muthu Subramanian K <muthusuba@gmail.com>

... which should be freed even if GetError() != 0

Change-Id: Ifbf72aa17f8bcbdcc3b1504a105aa32e94397ee3
Reviewed-on: https://gerrit.libreoffice.org/9807Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

also

coverity#983450

Change-Id: I43f88005ab130f74df2316f51ab898b112002044

also

coverity#736888
coverity#736889
coverity#736890

Change-Id: I3e0d11d12c7da17297ba827f8125b9d99680121b

Change-Id: I8e6a81b6c1605bd1be33f5f8d75d2472a39361d4

Change-Id: I69df0aa6091263cbb6e500a5015915c6678764ec

Change-Id: Idb9c4aa6475fcd9edd0d76c06509df182bd2111c

also

coverity#706048

Change-Id: I93caf413db4582c8b2cdfbcf2358027c03ed113a

also

coverity#706042
coverity#706045
coverity#706046

Change-Id: I173603a638ef3e2d9ca358a4d4ba111910fac05f

Change-Id: I363c90a71225744bacd0bedccf6938da63e0428f

also

coverity#706000
coverity#706001
coverity#706002

Change-Id: Ib970a4956fcf8362b8e3f9ae859c374c5fc8a545

toolbar combination
(cherry picked from commit 0ce4a90e)

Conflicts:
	include/svx/fillctrl.hxx
	svx/source/tbxctrls/fillctrl.cxx

Change-Id: I9a1b2490a7e9285559dddd4df7fb20c2216fd450

Change-Id: Ia13c3d5657c32b89e200ede572d4615b833374de

Change-Id: Idb4807a58b6008afeb3e26d03b699671c0b88f7c

We used to write out a custom dash definition all the time, even in case
it was imported from a dash preset. Recognize at least "dash", and write
that on export if the parameters match.

Change-Id: Ifaaec51be9ecf1e7667a8c8f85fbd4fb9636a325

Change-Id: Ife852a6c7c360c66a7d7d5b144f18898398505dd

If line height is smaller than text height, we still want to see whole first
line, so add the difference where necessary.

This also helps to see paragraphs as separate to each other.

Change-Id: I51a87edf0cc03d5b5e130290c90347099a581d4e

SfxItemSet::MergeValue changes some items from SFX_ITEM_DEFAULT state to
SFX_ITEM_SET which I think is a bug but this patch avoids the problem too.
The issue was: visible changes in some tables, after changing e.g.
borders spacing, because the cells had wrong SfxItemSet after the process.

Change-Id: I676b211e1a4a1d7341c385d63503aa740718ed5d

Change-Id: Ice7a4802605fbe59dfb24a27408106756a3494ba

Change-Id: I3bb5ecb07d859a05337884a5b29d991b46382b48

Change-Id: I3837f316a4b73eb508bfd4fca97fa741080df8c0

Change-Id: I1d06c7a6a61556c2b501a16c224ccc6fe52307d0

Change-Id: I531891fa1cce10a331dd651ee9ce52d1f8d0c169

someone's odd ": ;" habit

Change-Id: I4a3e3b89bb31764056c844286561e31ae4621036

Change-Id: Ifd9a8ea49b48e81cdff859d2659fbd4d828afa90

Change-Id: I790a7bed0a2ac77c452638349008f4a34fd4ad0c