Since ScTokenArray::Add() overallocates memory, make sure we do not
keep such possibly large arrays. Since any copying of ScTokenArray
implicitly finalizes as well, this is not a big problem right now,
but then why needlessly do the copies? (next commit)

Change-Id: I55398bcd8fb31f1be5a4b8e3f5a71b26649a7594
Reviewed-on: https://gerrit.libreoffice.org/60862
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Change-Id: I855af060e1aeb91bccfc923ca567ad34d64be757
Reviewed-on: https://gerrit.libreoffice.org/60861
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I404b1ff3c312e5168a6dfec0133092dda640e155
Reviewed-on: https://gerrit.libreoffice.org/61508
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

(And it actually works now again, as far as I see, after the recent
fix to LibreOfficeKit's iOS code.)

Adapt to earlier changes: The generated files are now in workdir, not
in the ios source directory.

Use org.libreoffice.ios.LibreOfficeLight for the
PRODUCT_BUNDLE_IDENTIFIER instead of janI's own.

(Additionally the DEVELOPMENT_TEAM was reset to the one I use;
apparently there is no way to make sure that developer-specific
setting is in a file not in version control?)

Change-Id: I575561583f584b5ac3c759d115b1c9c6dc97ef94

Patch by: me

(cherry picked from commit ae1f34be)

Change-Id: I0e5277b17243f6b8f5f4303206cf446b10dd0aef
Reviewed-on: https://gerrit.libreoffice.org/61597Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: I142c86e8add935bf8e0cc384921332d4aed3e591
Reviewed-on: https://gerrit.libreoffice.org/61578
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I09ec02e8148479edf45fb10d8b9261a435bedc64
Reviewed-on: https://gerrit.libreoffice.org/61600
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Last usage was removed in commit
45c753af (svx: pdfium's
FPDFImageObj_GetBitmapBgra() is not needed after all, 2018-09-28).

Change-Id: I2412fa24859ad5bcd3ced634d3c4f41d2f35aebe
Reviewed-on: https://gerrit.libreoffice.org/61599
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: Ie6545844546dc78d14e1fabdf28f4e1938cf2dd7
Reviewed-on: https://gerrit.libreoffice.org/61458
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: I1f79038f2a5cc455a50a532870c4042588c3e446
Reviewed-on: https://gerrit.libreoffice.org/61595
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I2cf75773f380c3a53d3e091e7e72beb62a4ff119
Reviewed-on: https://gerrit.libreoffice.org/61593
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I7ffe52cd96f147956da30d551a30b9170c632383
Reviewed-on: https://gerrit.libreoffice.org/61588
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I20c7c1e82b12a2d20baa673e8b7aeb3d0e1fa58c

Change-Id: I9666aa9f323e53ef394121acdef146866d2cc696
Reviewed-on: https://gerrit.libreoffice.org/61529
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>

This disables shading of URL and email address fields when
displaying cell content and still preserves shading in the Input
Line and when editing cell content to indicate that it is actually
a field content value.

Change-Id: I8737045168646b6cd446bd357713ec9ac4631b31
Reviewed-on: https://gerrit.libreoffice.org/61594Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

It was used to initialize a virtual device pixel buffer to an
"interesting" pattern, in case actual rendering to it failed.

Change-Id: Iacdd86382dfa8c9ed1ea9d213fa489515b2b217d

Not really that useful any longer.

Change-Id: Idf29b9c3eeafd1b1cc7a2baa87205f7064681a23

And explicitly fail if --enable-kde5 and --disable-qt5.

Change-Id: Ifa0cef6b065ca0825b1cb42922f6fcf676e457f1
Reviewed-on: https://gerrit.libreoffice.org/61571
Tested-by: Jenkins
Reviewed-by: Rene Engelhard <rene@debian.org>
Tested-by: Rene Engelhard <rene@debian.org>

tradionally we do double/triple decker tab dialogs when there are a lot of tabs,
that option isn't available with native gtk3 notebooks.

Instead follow
https://developer.gnome.org/hig-book/unstable/controls-notebooks.html.en#controls-too-many-tabs
and when there are > 6 tabs position them at-left

Change-Id: I8e6ca78abeec3c1fa9f616c21f21fd7367be2ec9
Reviewed-on: https://gerrit.libreoffice.org/61487Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ia5e24c6eab1f33d8a9ef8232095cd95c68386a43
Reviewed-on: https://gerrit.libreoffice.org/61592Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I14f808864ec99258731e12879acffdd130ab0613
Reviewed-on: https://gerrit.libreoffice.org/61586
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I7163577fb43f28c8c9c138ebf3a9d36586247a32
Reviewed-on: https://gerrit.libreoffice.org/61587
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I14ecd4d4a967a7c49aef77a423ea17b3fc46fe76
Reviewed-on: https://gerrit.libreoffice.org/61583
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

UNO command SID_GETINVOLVED added with access to the website
from all main menus under Help
Dispensable ellipsis removed from other UNO commands around Help

Change-Id: I79536be3de31f55a7b208bcdd5a243e05b3d3668
Reviewed-on: https://gerrit.libreoffice.org/61238
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

Change-Id: I790703790e49bd9e5b4ad0d5f357681f56db5121
Reviewed-on: https://gerrit.libreoffice.org/61582
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ia5a9880c1e6d88141bd654a9cc761b289f27c249
Reviewed-on: https://gerrit.libreoffice.org/61542Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...where "inline" (in its meaning of "this function can be defined in multiple
translation units") thus doesn't make much sense.  (As discussed in
compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions
in include files for now.)

All the rewriting has been done automatically by the plugin, except for one
instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus
some subsequent solenv/clang-format/reformat-formatted-files.

Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224
Reviewed-on: https://gerrit.libreoffice.org/61573
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Icd7a0f9909f36363b307b4fe7ee920183881afbb
Reviewed-on: https://gerrit.libreoffice.org/61576
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

ImpEditView::CutCopy releases the SolarMutex to handle clipboard
access. So lock the SolarMutex when accessing this function
through OutlinerView::Copy().

Now all paths effectively need the SolarMutex, so remove all the
intermediate locking. I guess the explicit release for the
xTransferable.is() test isn't needed.

Change-Id: Ib2a69a520bbf0ef7ba4ccb893c6489b292207f2a
Reviewed-on: https://gerrit.libreoffice.org/61580
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

("fallthrough annotation in unreachable code")

Change-Id: I858937b439333b851942de9ca8f50ec228e77a76

Change-Id: I1efdffb92e09f83be7052b8a28ddbfb22f17defa
Reviewed-on: https://gerrit.libreoffice.org/61581Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I804895a4dd2d98707f0d1bbbc9bb78782b07a397
Reviewed-on: https://gerrit.libreoffice.org/61505
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: Iacce8e12a85f857192dc0520b795e1990a3612db
Reviewed-on: https://gerrit.libreoffice.org/61575
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I11483e3cece12a7373f4276972b4c899edf1ce15
Reviewed-on: https://gerrit.libreoffice.org/61566
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Idf417c452dbbadbede0e3f0860cce7a8a6fd308e
Reviewed-on: https://gerrit.libreoffice.org/61517
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: Ia2aca4e87054d2f5cc0462e07ac0717278d3c98c
Reviewed-on: https://gerrit.libreoffice.org/61577Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

rather than whether listbox first entry is not selected

Change-Id: Ic3dc574f6f1a476929e89e695849756437024cee
Reviewed-on: https://gerrit.libreoffice.org/61559Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I1c68b9f1f51cb15a30f56eef08dc384d10355bf1
Reviewed-on: https://gerrit.libreoffice.org/58805
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I1484d920649817680f70de4ca00a3d46e1faf42a
Reviewed-on: https://gerrit.libreoffice.org/61554
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ief438d98b8117a7759282323e47c8b5283d6762a
Reviewed-on: https://gerrit.libreoffice.org/61552
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>