Regression from commit beb4aa21
(SwViewShell::ImplEndAction: avoid direct paint, 2015-06-29), the
problem was that the lcl_PaintTransparentFormControls() call performs
direct paint, so it should be called only in case we don't do an async
paint via invalidate.

As expected, this call is no longer needed for the original i#107365
bug document in case SwViewShell::Paint() will be called by the main
loop shortly.

Change-Id: Ia27c551ed838d610f972f20abbb4ae9f0e1241b6

Change-Id: I55dd98b1613376c8e1c83af8ffdc66a58e022cb1

So that the sub-toolbar controller will pick the
right image size.

Change-Id: I70b642ac84377b461a001ef11f551a5e1448c0f1

Change-Id: I71d0ded04b35472f14e4764a47212c73ac500814

The doc for XSubToolbarController::updateImage says:

"gets called to notify a controller that it should set an image
which represents the current selected function.

Only the controller instance is able to set the correct image
for the current function. A toolbar implementation will ask
sub-toolbar controllers to update their image whenever it has
to update the images of all its buttons." However, it didn't
work that way until now.

Steps to reproduce:

1. Open one of the custom shapes dropdowns, and choose a shape
   other than the default. Note that the button is now updated
   with the last selection.

2. Change the icon theme. Note that the button shows now the
   default shape, despite the fact that a future activation
   of that button, will still draw the last used shape.

Change-Id: I9345c9faa17dc82a5f590b242b60751ce5d8e648
Reviewed-on: https://gerrit.libreoffice.org/16781Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

Change-Id: Ib7ea6624ac6b112779b0e64b08805538b8d6afff
Reviewed-on: https://gerrit.libreoffice.org/16796Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>

Change-Id: I2846824d402d029cde8d214f8112047243c79c54

Thanks to Stephan Bergmann.

Change-Id: I22aa3bb827db28bce3eabebb9b8c514663fad860

...but C2514 is still there

Change-Id: I818fed066b0ddaf5c30e6057285151d8a575c373

Change-Id: Ic136cce6abef44291b7236a6d709f0eee391f311
Reviewed-on: https://gerrit.libreoffice.org/16784Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ied85d93019d0f6c01c14045758b405f2ac316676
Reviewed-on: https://gerrit.libreoffice.org/16783Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I14e8bb3e4e38ade1044ce1c50c9676a65152724c
Reviewed-on: https://gerrit.libreoffice.org/16733Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ief207205b3f05dd0ed92a2d1d30e265cbdb914e3

... following commit cc96b273

Change-Id: I152875b6f72ff972d004f6df11325ce89f43ad9d

Change-Id: Ieb73b50471263212285b9c3883c082477c1ad656
Reviewed-on: https://gerrit.libreoffice.org/16729Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Regression from commit 1d9e8376 (Use
GetBoundRect() instead of Frm() in layout., 2011-04-29), this causes
problems for double-buffered rendering and also seems to be pointless,
as just above we already added the rectangle to the repaint area.

Change-Id: I3dc67143e8332ab941a683414ee318dbef13de88

One one hand, a problem since commit
330b8602 (fdo#68787 DOCX import: handle
when w:separator is missing for footnotes, 2013-09-04) was that the type
attribute from <w:footnote w:type="separator"> resulted in two
ooxml:CT_FtnEdn_type tokens, ignoring too many paragraph ends for
footnotes, which resulted in missing paragraph style on footnotes.

On the other hand, fixing the first problem showed that it wasn't
correct that commit 9389cf78 (cp#1000018
RTF import: empty para at the end of footnote text got lost, 2013-11-15)
unconditionally removed the RemoveLastParagraph() call in
DomainMapper_Impl::PopFootOrEndnote(). It turns out that RTF and DOCX
have different semantics here, the footnote is always within a <p></p>
pair in DOCX, while in RTF a \par at the end of a
footnote means an empty paragraph. Fix that by conditionally restoring
the removed RemoveLastParagraph() call.

Change-Id: I33020ac761c94addfec8164a17863565e4453b07

is e.g. an SwDrawFrameFormat instead of an SwFlyFrameFormat during
CppunitTest_sw_uiwriter

Change-Id: I97511cf516f76b12e04da61ce6fd51f61ef83241

This reverts commit 7df3879d. It's not
necessary since commit f16d82ea (make it
possible to force enable double buffering for all widgets, 2015-06-03).

Change-Id: I9e89fea4e94a91edbbe355780c2a12d6e6cb6e4a
Reviewed-on: https://gerrit.libreoffice.org/16728Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ic4d922bd27b7f119a7f8b95bbb4d4ed9e89fe51d

It is only called from other member functions.

Also, all the calls are inside conditionals that check mpData &&
mpData->mbCurVisible already, so no need to check anew in the function. Use an
assert() instead.

Change-Id: Ibcde0aa43877b64b9b0ae5117cbda1fb44ee023d

with variadic variants, and drop unused #includes, in accessibility.

Change-Id: Iddbe0f7932108319a5105448a74c570265d601ce
Reviewed-on: https://gerrit.libreoffice.org/16639Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

in animations.

Change-Id: I7d776ddb81e0943bf2ea5895ea26631db76546ac
Reviewed-on: https://gerrit.libreoffice.org/16645Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

to the variadic variants, in avmedia.

Change-Id: I7fe65771ea5e0d30c7906d0d33acdcbe9e8aa3ff
Reviewed-on: https://gerrit.libreoffice.org/16647Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

with the variadic variants, in basctl.

Change-Id: I52da577a6f6298eb89b0cc8c8ff243ecd341e9b3
Reviewed-on: https://gerrit.libreoffice.org/16718Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

with the variadic variants, in basic.

Change-Id: I13c5644bd6b9e964e42a98bee9c3019d959efb36
Reviewed-on: https://gerrit.libreoffice.org/16719Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I72574e354aadf357d6d8181a514efb4783e79e28

Change-Id: I9b9f198aa6da2f6734194207b4c4bdec3ee1d4c0

So generated data don't unnecessarily differ after each build.

Change-Id: I143fa189a653266fadf9dd34ce2ed42b9b9b1548

Change-Id: I1af1d6bc150c16a2c6b0fe788a41c8c18caee6c6

Change-Id: I8f3871fd4e82b6850718b6f2a8757f3043d00017

Change-Id: I1b510a6194282dfa4a9001d473127c5ebc8b44eb
Reviewed-on: https://gerrit.libreoffice.org/16731Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Not very useful these days, since we have the css:: prefix to reduce
verbosity.

Found with a search like:
   git grep -nP 'typedef .*uno::Reference.*<.*>\s+\w+;'
       | grep -v 'std::'

Change-Id: I16f41c53837ec5c613545ae45df38b0daddcbadd
Reviewed-on: https://gerrit.libreoffice.org/16730Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I999923031c573f361bc421eab84e68a4a130d688

Change-Id: I3414afeab2fb95160d206891868596ec2ee637d7

Change-Id: Id69b55b266fe62934b53fc765030cfd044d0c74a

Change-Id: I4c1d4c9228113bf83e8aabb50f153d2658c3cf59

since 853e9c00

Change-Id: I8b1bcaaff72ed73209e55011e006175356865811

Change-Id: I57511b62b578f897c15c6cbb23dedb1200db232f