Change-Id: Id5715f8753d17b3955ac87b9260318ac56e64a08

Previously the title was set during construction as e.g.
"Conditional Format: A2:B245"

However the selected range can be modified while the dialog is open,
hence we update it whenever the selected range is modified.

Change-Id: I63790108553102cedb51ca32d672a62477493660
Reviewed-on: https://gerrit.libreoffice.org/15711Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

The lookup of getNumberFormatKeyByIndex() is sped up by storing the
addresses into the cached data array m_aDataArray.

The existing cache invalidating strategy should hold since the
cache was already storing information about hidden fields and
ranges, which is the information which affects the addresses.

Also: Change data type of m_aDataArray from std::list to std::vector to
allow index-based access.

Also: Change for-loops over m_aDataArray to range-based loops with auto
variables to make them more readable

Change-Id: I9a5038892a384e7d5e72556a52faaf98b475a839
Reviewed-on: https://gerrit.libreoffice.org/16485Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Try to use some sane consistent formatting in this function. No semantic
change.

Change-Id: Ic9e4625c910f826246451e8ff9e18d6131c04a78

For some reason, at least in the case of the "Test OpenCL" thing, we get here
an mpStringArray that is non-null but where all the elements (rtl_uString
pointers) in it are null. Treat that case as if the mpStringArray was null.

This makes the tests "Test OpenCL" actually use OpenCL. Maybe it has other
useful effects, too. (But for normal spreadsheet use, the mpStringArray that
gets handled here *is* null when all the cells used by a formula group are
numbers. At least it seemed so in a simple test.)

Also add more useful (?) SAL_INFO calls in the area.

Change-Id: I1388786a3a0765af6eb01a63da31e5b83c7a616d

Change-Id: I53dc6d358952a046a4c1f03246441742dfa3d685

Change-Id: I555d4b79a61b371a39ad0f0b76c2d34c22414962

Change-Id: Icc3e913d4150e724c87e8293f7b641ee8ca19177

Change-Id: I1bd1040cc80c0450a5e029c37f0737c0692c056a
Reviewed-on: https://gerrit.libreoffice.org/17952Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

Replace bullet char before write out font description
since it may be altered if bullet font has been changed
(i.e. StarSymbol to WingDings ).

Change-Id: I0461cc0a5e4628b36177602bba7ed7f74a0751eb
Reviewed-on: https://gerrit.libreoffice.org/17376Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>

Change-Id: Id670e83db01efe6bcd5fb6bb374ab9cb92898f88
Reviewed-on: https://gerrit.libreoffice.org/17460Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>

1) Indirect property values were ignored, now they are used.
2) Write endParaRPr so that PowerPoint display them.
3) Automatic colors are written as white or black based on
   whether background is dark.

Change-Id: I255c16f35149b738be2daf2800b1c90389f2c7cf
Reviewed-on: https://gerrit.libreoffice.org/17472Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>

Project: help  67285d99b8c9373ba3fa992679353ee1a5bc4da9

typo "Navigator displays" → "The Navigator displays"

via pootle-feedback

Change-Id: I25578b8a780e607ce553e17289d96cdc7185577e

Change-Id: Icb96b45c936b974938c2dfae48960f727a1dc84d

for the duration of inserting attributes, and excess
dos newline chars can be removed safely afterwards

Change-Id: If70e34fec1c0819f827f483d3d7ac4f19b3caef8

Change-Id: Ia22866225b2a726ed69c9f18d02d1ebffdafde8f

Change-Id: Icc5958d77277c6938b8a03ef44dfd71b9350e288
Reviewed-on: https://gerrit.libreoffice.org/17978Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Tested-by: Maxim Monastirsky <momonasmon@gmail.com>

...as found by UBSan in CppunitTest_filter_ppm_test on
filter/qa/cppunit/data/pbm/fail/crash-1.pbm

Change-Id: Ib7c50ef1f07aba6b78f79c608be69c3dac38ddfe

...as found by UBSan in CppunitTest_sw_filters_test (see below), and at the same
time limit reads within the pA array to its bounds.

> Testing file:///.../sw/qa/core/data/ww6/pass/crash-2.doc:
> sw/source/filter/ww8/ww8scan.cxx:6473:32: runtime error: upcast of misaligned address 0x6200000e70e7 for type 'WW8_FFN_Ver6', which requires 2 byte alignment
> 0x6200000e70e7: note: pointer points here
>  00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 0e 00 00 6a 00  00 00 00 0e 00 00 6a 00  00 00 6a
>              ^
>  WW8Fonts::WW8Fonts(SvStream&, WW8Fib&) sw/source/filter/ww8/ww8scan.cxx:6473:32
>  SwWW8ImplReader::CoreLoad(WW8Glossary*, SwPosition const&) sw/source/filter/ww8/ww8par.cxx:4961:20
>  SwWW8ImplReader::LoadThroughDecryption(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:5767:19
>  SwWW8ImplReader::LoadDoc(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:6039:19
>  WW8Reader::Read(SwDoc&, rtl::OUString const&, SwPaM&, rtl::OUString const&) sw/source/filter/ww8/ww8par.cxx:6157:20
>  SwReader::Read(Reader const&) sw/source/filter/basflt/shellio.cxx:175:18
>  SwDocShell::ConvertFrom(SfxMedium&) sw/source/uibase/app/docsh.cxx:258:22
>  SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:790:23
>  SwFiltersTest::filter(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) sw/qa/core/filters-test.cxx:112:20
>  SwFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) sw/qa/core/filters-test.cxx:71:12
>  test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:129:20
>  test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:154:5
>  SwFiltersTest::testCVEs() sw/qa/core/filters-test.cxx:154:5

Change-Id: I31ac8dc11d985745785c9dda1cec8a11a41098bb

Change-Id: I77f7b528ed97964bdc153f820f6f96977ddb9254

Change-Id: I6e43fd4a4b45f0217de8b6d93ef2403e46e39489

Change-Id: Iab26a2b55586fc824c5edbea519c4f68ba4a548f

Can now be turned off with a SAL_DISABLE_GLYPH_CACHING environment variable.

Change-Id: I7ac14d72dc0f85c0682d92492eb96bec1d207609

Change-Id: Ic48e22169dff2ed06b75af519ca39addef7d07de

Change-Id: I09249673d42d36bf72ee1ffbf8f3f37734bd8bae

Change-Id: I597c007e4636f6b05873f24ef3e89c0a7c2c3670

Change-Id: I348e7f984e5e8b4b915d11de8182da07a6356f8d

Change-Id: Ie1c9891e8095172f53efc027eec9a68bde39ed1f

Change-Id: Id253acad170e3d8f7a1278a10c731c6bd1927b92

lets rather use something smaller, so as not too potentially bump
into the RECT_EMPTY checks in the Rectange code

Change-Id: Ief8200763cac29e3099a2717f20c6f10cbc7d579

Change-Id: I81fa9f80593bdea5098215f71c44b35e0087a6fc

Change-Id: I7e1d737fc1e7a431afd3cde74c2c974e0cbef9ef

Change-Id: I23cbaf7fc1320168eb75ca33fd6d704125508785

Change-Id: I939d36dbb0a298f8181367f74001115ef89d5bc2

Change-Id: I585d4e8f0a53f46b6fbcef9e4d26f88b57569684

Change-Id: I68a4c3324736e111a2c88e3edb9df506c33042b7

Change-Id: Iefebe6b254f2c01b46b48ebaf7a6242e1bf80b62

Change-Id: I79366fe5abc98924e174dcbac83bbb8c053d59ce

When a number format for a cell (for example percent) is applied
it is highlighted in the toolbar but not the equal button in the
sidebar. This patch fixes this issue.

Change-Id: I7f33ab1e989f8a8e3c49468aae2042621d088798

Replace ::std::for_each for a more readable range-based for loop in
cases in which the function object to be applied by for_each is more
readable as the body of a for loop.

Change-Id: Ib0b488b36ed58c65c56357e04391b85096d043aa
Reviewed-on: https://gerrit.libreoffice.org/17930Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>