Regression of:

commit 89d39bc1
Author: Oliver Specht <oliver.specht@cib.de>
Date:   Wed Sep 30 16:10:07 2015 +0200

        tdf#94559: 4th step to remove rtti.hxx

Change-Id: I94408dafde0f2dbea6c3a112963468c593adfc2d
Reviewed-on: https://gerrit.libreoffice.org/19276Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

Push/Pop-ing the cursor led to selection loss.
SelectHiddenRange() immediately returns false if the current cursor
hasMark(), so avoid all of the bugs and expensive push/pop routines
when there is a mark already.

Change-Id: I4624a3e0b2267942812d0429d527ad97962ec7fc
Reviewed-on: https://gerrit.libreoffice.org/19108Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I2658b8fc9d36fe92dd91e0f5adc27612ce1dc438
Reviewed-on: https://gerrit.libreoffice.org/19268Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I5ecf90a927b2ec4aeb2c0586a5da2f814c9062dd
Reviewed-on: https://gerrit.libreoffice.org/19275Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ice121a65e38d47b4a26f7ed81fc3037e031ae7c4

Change-Id: I54691786167fd17b115460f3329573f0c2f023ed

Change-Id: I97db1e22a42e25186be0d7304b9f2a5204fc1c83

Change-Id: I9329233a85df26dcfd83002e50604a6ea4fb50f9

Change-Id: Ic3464a466302b87fae70a63f2723d1355eccab6f

Change-Id: I11b99fca91b266bdf6c29dc142511bf01dbd4bed

Change-Id: Ib9eae95b8ace37d31e905bc098c67de97b7816e3

...to silence a clang-analyzer-deadcode.DeadStores on the last update of nLeft
and nRight, each.  Also, adding a gap of 3 to nRight in case no further buttons
will be layed out next to maDockRect resp. maHideRect is irrelevant, as nRight
will not be used for any further layout computations in those cases.

Change-Id: I251d4470099b1f98782ebdfd0c776d881bb7fae5

i.e. to reset to the initial post-startup state

performance still isn't great unfortunately, 0.7
cycles per second before this, 2.6 after this

Change-Id: Ib9d83b70f0cf052af36a49ed5bacef295fe9ed11
Reviewed-on: https://gerrit.libreoffice.org/19269Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I8a6ea395192d31391868f44152ab3b543a07aeaa

Change-Id: I9e2cf9b06fcf0b0a9dfd642fa788f203ade19fe3

...assuming the success of both steps 2 and 3 should be checked (though the of
this code is lost to history past 40d960cb
"divide pdfwriter_impl.cxx")

Change-Id: Icea5de98e5a0559dbc0f837650e842fb49bc41e0

Change-Id: Ie1d3afb0b9ca59232214d9ab6da9fa761a3fd449

...to silence a clang-analyzer-deadcode.DeadStores on the last update of nUsed

Change-Id: Ib470f09155bd181b05bc0342543a36e59b8dd937

nSxe, nSye were unused ever since WMFReader::GetPlaceableBound was introduced
(seemingly, involving some copy/paste) in
fa149f40 "#98505# if there is no WinExt we try
to calculate the extension instead of using (1/1) default which causes a crash
on unix and linux"

Change-Id: Ica6fb9ec1d25bd5314e73610eccef2a4df0c310f

Change-Id: Icef974fccdc487b8abef3b1200b0b34b7be703ec

Change-Id: I4924a3cecb1e12874659eeccde51126fab4d4e45

Change-Id: Ic76cf540896ba217f7df6045be31197b64298bf3

Change-Id: Iabb2d50cced788ab49d21e1aadcf5ab685107511

Change-Id: Ifef668530d660b0b6330f1e60ed558501a74611e

Change-Id: I0febc2b89d95bde59ad9d3a90d404b3932cc3624

Change-Id: I7b640ecf957ec2663c68a9548680a64c85470da5

...in ~ScUndoDeleteContents, otherwise (implicitly) resetting pUndoDoc only at
the end of ~ScUndoDeleteContents could cause a stack of calls into ~ScDocument,
~ScTable, ~ScColumn, ~ScPostIt that operates on stale pointers, as an
SdrCaptionObj is already destroyed while the ScPostIt still points to it.  See
the failing JunitTest_sc_unoapi_2 under ASan+UBSan at the end of
<http://ci.libreoffice.org/job/lo_ubsan/41/console>.

Regression introduced with ee9b3c1f "Return the
std::unique_ptr itself here, not a raw pointer."

Change-Id: I5e1c6c3e46cb46388d186b63ce23b00fd298a32b

Change-Id: Ib58d04f9e046e604b24e0e338796a7a60aa1d6fd
Reviewed-on: https://gerrit.libreoffice.org/19253Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

... and also set the User-Agent header so the servers know who's messing
with them.

Change-Id: I0173db05868c5fcd0f85435adf78884ca562596d

Change-Id: Idbabae3edad5e95a37fa9834d24a72ebd13087ae

... itself, they were apparently just dependencies of
commons-httpclient, so remove them.

Change-Id: I8fd5c85db058c4aa14c4f5fea20fd17ba361b0b2

JRE 6 has sufficient HttpURLConnection etc. stuff to make this work
without bundling external libraries.

Change-Id: I6c71980c718169024006f02a96c442a71d798d55

... if the current document allows macros.

Change-Id: I927981334e27d073696286ba680777a645d53653

after my commit 0e30af6f
"convert SAL_FRAME_STYLE to scoped enum"

Change-Id: Iefa1b9a39a50ea09fb6a2615196a8adcea40df0d

Change-Id: Ie2d1b466f5773799347aac59d7b5dc25f283b920

...from include/lber_types.hin.  So fix dependencies after
cad68c65 "relax deps of link target on external
projects."

Change-Id: I1c002b063c53f82ff18d11577a99f7413f7fb7a5

Change-Id: Iad11e6bcb64976c7eb4181ee327602e6c3a7e26f

...follow-up to 63899beb "WaE: unused variable"
removing the nVerticalSamplingFactor part

Change-Id: I2830dc0647cf651014e1199ef62a7ea50e4a1719

Change-Id: Ic2d49519475db8292fecf18eb5c90a74ace8dfe7

Change-Id: I68ab6da7c90b869499f1b7a4d2433dac77d36889