1. 29 May, 2014 17 kayıt (commit)
  2. 27 May, 2014 3 kayıt (commit)
  3. 29 May, 2014 18 kayıt (commit)
    • Caolán McNamara's avatar
      remove unused virtual method, slim this down initially · fa551c42
      Caolán McNamara yazdı
      Change-Id: Ie4a912cc3c144c47a4bb59551ebb1c68f302569e
      fa551c42
    • Julien Nabet's avatar
      To avoid some confusion for people like me :) · 74393875
      Julien Nabet yazdı
      Thank you Lionel and Tor!
      (see http://nabble.documentfoundation.org/Strange-part-in-connectivity-source-drivers-jdbc-tools-cxx-td4110680.html)
      
      Change-Id: Ibbe68b8b3d12e4dfacf7f66bb3adbc2fd831d1a5
      74393875
    • Caolán McNamara's avatar
      Resolves: fdo#79392 don't access after last row, when last row is max last row · a35d9219
      Caolán McNamara yazdı
      Change-Id: I06749af90bed6a43f3fb6b3b5ceb61d5fbbc7c02
      a35d9219
    • Caolán McNamara's avatar
      Related: fdo#79392 std::out_or_range -> terminate · da6df38b
      Caolán McNamara yazdı
      Change-Id: I0aada90e9ea4e9fc92fd9c365aa9c7171cb10a55
      da6df38b
    • Caolán McNamara's avatar
      the dubious SfxModelSubComponent and friends aren't used outside sfx2 · c24272c7
      Caolán McNamara yazdı
      so move out of the globals headers and drop their public visibility
      markup
      
      Change-Id: Ie0a852c962a9d05488022397e83152d1c73cfa29
      c24272c7
    • Caolán McNamara's avatar
      valgrind: memleak when sidebar open in writer on close · a65b6a46
      Caolán McNamara yazdı
      ==3768== 512 bytes in 1 blocks are possibly lost in loss record 25,532 of 28,010
      ==3768==    at 0x4A06965: operator new(unsigned long) (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
      ==3768==    by 0xB52FA41: __gnu_cxx::new_allocator<bool>::allocate(unsigned long, void const*) (new_allocator.h:104)
      ==3768==    by 0xB52EC00: std::__cxx1998::_Deque_base<bool, std::allocator<bool> >::_M_allocate_node() (stl_deque.h:533)
      ==3768==    by 0xB52DE4E: std::__cxx1998::_Deque_base<bool, std::allocator<bool> >::_M_create_nodes(bool**, bool**) (stl_deque.h:627)
      ==3768==    by 0xB52C624: std::__cxx1998::_Deque_base<bool, std::allocator<bool> >::_M_initialize_map(unsigned long) (stl_deque.h:601)
      ==3768==    by 0xB52ACA0: std::__cxx1998::_Deque_base<bool, std::allocator<bool> >::_Deque_base(std::allocator<bool> const&, unsigned long) (stl_deque.h:461)
      ==3768==    by 0xB5296D3: std::__cxx1998::deque<bool, std::allocator<bool> >::deque(std::allocator<bool> const&) (stl_deque.h:791)
      ==3768==    by 0xB52840E: std::__debug::deque<bool, std::allocator<bool> >::deque(std::allocator<bool> const&) (deque:73)
      ==3768==    by 0xB52786B: framework::UndoManagerHelper_Impl::UndoManagerHelper_Impl(framework::IUndoManagerImplementation&) (undomanagerhelper.cxx:221)
      ==3768==    by 0xB525882: framework::UndoManagerHelper::UndoManagerHelper(framework::IUndoManagerImplementation&) (undomanagerhelper.cxx:879)
      ==3768==    by 0x6872683: sfx2::DocumentUndoManager_Impl::DocumentUndoManager_Impl(sfx2::DocumentUndoManager&) (docundomanager.cxx:88)
      ==3768==    by 0x6870FB6: sfx2::DocumentUndoManager::DocumentUndoManager(SfxBaseModel&) (docundomanager.cxx:227)
      ==3768==    by 0x687A272: SfxBaseModel::getUndoManager() (sfxbasemodel.cxx:1677)
      ==3768==    by 0x260E562A: (anonymous namespace)::getUndoManager(com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) (PagePropertyPanel.cxx:74)
      ==3768==    by 0x260E6C60: sw::sidebar::PagePropertyPanel::PagePropertyPanel(Window*, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, SfxBindings*) (PagePropertyPanel.cxx:189)
      ==3768==    by 0x260E593C: sw::sidebar::PagePropertyPanel::Create(Window*, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, SfxBindings*) (PagePropertyPanel.cxx:101)
      
      The SfxBaseModel creates the DocumentUndoManager on demand at
      sfx2/source/doc/sfxbasemodel.cxx:1685
      
      m_pDocumentUndoManager is a rtl::Reference but debugging into the
      acquire/release I see that the
      DocumentUndoManager::acquire/DocumentUndoManager::release forward to those of
      SfxModelSubComponent which forward them to its rModel without doing anything
      else, so the implementations of
      DocumentUndoManager::acquire/DocumentUndoManager::release don't actually do
      anything directly to the DocumentUndoManager itself so there is nothing that
      will really release it.
      
      Either the rModel needs to explicitly destroy it somehow, given that the
      acquire/release delegate responsibility to it, or the whole thing is addled.
      
      I rather feel it's addled, so implement as a normal WeakImplHelper1, but
      cowardly in addition also keep acquire/release on the rModel.
      
      Change-Id: Ib52544a9276fd8d9d489ad6b6afda12498cc39fa
      a65b6a46
    • Caolán McNamara's avatar
      pTemplateCommon is never set, so always NULL · 947feaa8
      Caolán McNamara yazdı
      Change-Id: I2311b33034c281cba66d7cce80a6556e27b2b322
      947feaa8
    • Thomas Arnhold's avatar
      update_pch: exclude OpenGLContext.hxx for now · fcfdadc2
      Thomas Arnhold yazdı
      Change-Id: I80ce89351e2a8dbb1d9d928b673a8589fd651584
      fcfdadc2
    • László Németh's avatar
      fdo#79372 fix hyphenation (remove fdo#56392 fix, except hard hyphen part) · 259d3421
      László Németh yazdı
      Change-Id: Ia2f482fb7737e61cfc42966dbc7af6e1cdb3b41d
      259d3421
    • Noel Grandin's avatar
      use OUString::startsWith() · 624a116d
      Noel Grandin yazdı
      Change-Id: I0fc77b50792e48be175ab7cc151509e097676849
      624a116d
    • Noel Grandin's avatar
      remove more unnecesary OUString constructor use · ebc0a155
      Noel Grandin yazdı
      when throwing exceptions
      
      Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
      ebc0a155
    • Noel Grandin's avatar
      remove unnecessary NULL parameter passed to UNO Exception · f0ae48b6
      Noel Grandin yazdı
      .. now that we have a default value for that parameter
      
      Change-Id: I54d6b0a0a01ce2f2e5168ada0c427424de0477bc
      f0ae48b6
    • Noel Grandin's avatar
      remove unnecessary linefeeds from the end of exception messages · 7e4c6e1f
      Noel Grandin yazdı
      Change-Id: Id1d7971639b2496dbe0274423ff4150d9295e8d6
      7e4c6e1f
    • alonso's avatar
      enable new handlers · 6cae6d68
      alonso yazdı
      Change-Id: I1c07a44e7d318478bcb2561d29ea53a9475e4b1f
      6cae6d68
    • David Tardon's avatar
      improve WPXSvInputStream test · c14a6e05
      David Tardon yazdı
      Change-Id: I95817ea44b6793d4a80b74b32f3b5477c6169b26
      c14a6e05
    • Zolnai Tamás's avatar
      OGLPlayer: handle json parsing error · 0e54f126
      Zolnai Tamás yazdı
      Change-Id: I86aea12318d4e21ccadd97ad2820e31bd4580c99
      0e54f126
    • Zolnai Tamás's avatar
      OGLPlayer: check before dereference · 228c5099
      Zolnai Tamás yazdı
      Change-Id: I4bbaf97fe8c5def441ca106c26ad312281ed352f
      228c5099
    • Takeshi Abe's avatar
      Avoid possible memory leaks in case of exceptions · a71ae24a
      Takeshi Abe yazdı
      Change-Id: Iac63a5d60478e5cd8e2b77c889c7b312d3d15f67
      a71ae24a
  4. 28 May, 2014 2 kayıt (commit)
    • Michael Stahl's avatar
      fdo#78737: sw: fix setting tab stops via ruler · 7c8b2f10
      Michael Stahl yazdı
      The SvxRuler binds the SID_ATTR_PARA_LRSPACE, and its indents and the
      positions of tab stops depend on the values it gets from there; in LO
      4.0 the value came from the SwView::StateTabWin() but now it comes from
      SwTextShell::GetAttrState(), and the difference is that the former does
      a special request to get the NumRule indents as LR-space.
      
      (regression from d02f75a8)
      
      Change-Id: I548ce188655555f2473cb3973ce7aeb927d1a404
      7c8b2f10
    • Markus Mohrhard's avatar
      Lsan: fix memory leak · b2f412a3
      Markus Mohrhard yazdı
      Change-Id: I223e0587b5a82c1617a0e79a002472070d2d4402
      b2f412a3