Change-Id: I11b99fca91b266bdf6c29dc142511bf01dbd4bed

Change-Id: Ib9eae95b8ace37d31e905bc098c67de97b7816e3

...to silence a clang-analyzer-deadcode.DeadStores on the last update of nLeft
and nRight, each.  Also, adding a gap of 3 to nRight in case no further buttons
will be layed out next to maDockRect resp. maHideRect is irrelevant, as nRight
will not be used for any further layout computations in those cases.

Change-Id: I251d4470099b1f98782ebdfd0c776d881bb7fae5

i.e. to reset to the initial post-startup state

performance still isn't great unfortunately, 0.7
cycles per second before this, 2.6 after this

Change-Id: Ib9d83b70f0cf052af36a49ed5bacef295fe9ed11
Reviewed-on: https://gerrit.libreoffice.org/19269Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I8a6ea395192d31391868f44152ab3b543a07aeaa

Change-Id: I9e2cf9b06fcf0b0a9dfd642fa788f203ade19fe3

...assuming the success of both steps 2 and 3 should be checked (though the of
this code is lost to history past 40d960cb
"divide pdfwriter_impl.cxx")

Change-Id: Icea5de98e5a0559dbc0f837650e842fb49bc41e0

Change-Id: Ie1d3afb0b9ca59232214d9ab6da9fa761a3fd449

...to silence a clang-analyzer-deadcode.DeadStores on the last update of nUsed

Change-Id: Ib470f09155bd181b05bc0342543a36e59b8dd937

nSxe, nSye were unused ever since WMFReader::GetPlaceableBound was introduced
(seemingly, involving some copy/paste) in
fa149f40 "#98505# if there is no WinExt we try
to calculate the extension instead of using (1/1) default which causes a crash
on unix and linux"

Change-Id: Ica6fb9ec1d25bd5314e73610eccef2a4df0c310f

Change-Id: Icef974fccdc487b8abef3b1200b0b34b7be703ec

Change-Id: I4924a3cecb1e12874659eeccde51126fab4d4e45

Change-Id: Ic76cf540896ba217f7df6045be31197b64298bf3

Change-Id: Iabb2d50cced788ab49d21e1aadcf5ab685107511

Change-Id: Ifef668530d660b0b6330f1e60ed558501a74611e

Change-Id: I0febc2b89d95bde59ad9d3a90d404b3932cc3624

Change-Id: I7b640ecf957ec2663c68a9548680a64c85470da5

...in ~ScUndoDeleteContents, otherwise (implicitly) resetting pUndoDoc only at
the end of ~ScUndoDeleteContents could cause a stack of calls into ~ScDocument,
~ScTable, ~ScColumn, ~ScPostIt that operates on stale pointers, as an
SdrCaptionObj is already destroyed while the ScPostIt still points to it.  See
the failing JunitTest_sc_unoapi_2 under ASan+UBSan at the end of
<http://ci.libreoffice.org/job/lo_ubsan/41/console>.

Regression introduced with ee9b3c1f "Return the
std::unique_ptr itself here, not a raw pointer."

Change-Id: I5e1c6c3e46cb46388d186b63ce23b00fd298a32b

Change-Id: Ib58d04f9e046e604b24e0e338796a7a60aa1d6fd
Reviewed-on: https://gerrit.libreoffice.org/19253Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

... and also set the User-Agent header so the servers know who's messing
with them.

Change-Id: I0173db05868c5fcd0f85435adf78884ca562596d

Change-Id: Idbabae3edad5e95a37fa9834d24a72ebd13087ae

... itself, they were apparently just dependencies of
commons-httpclient, so remove them.

Change-Id: I8fd5c85db058c4aa14c4f5fea20fd17ba361b0b2

JRE 6 has sufficient HttpURLConnection etc. stuff to make this work
without bundling external libraries.

Change-Id: I6c71980c718169024006f02a96c442a71d798d55

... if the current document allows macros.

Change-Id: I927981334e27d073696286ba680777a645d53653

after my commit 0e30af6f
"convert SAL_FRAME_STYLE to scoped enum"

Change-Id: Iefa1b9a39a50ea09fb6a2615196a8adcea40df0d

Change-Id: Ie2d1b466f5773799347aac59d7b5dc25f283b920

...from include/lber_types.hin.  So fix dependencies after
cad68c65 "relax deps of link target on external
projects."

Change-Id: I1c002b063c53f82ff18d11577a99f7413f7fb7a5

Change-Id: Iad11e6bcb64976c7eb4181ee327602e6c3a7e26f

...follow-up to 63899beb "WaE: unused variable"
removing the nVerticalSamplingFactor part

Change-Id: I2830dc0647cf651014e1199ef62a7ea50e4a1719

Change-Id: Ic2d49519475db8292fecf18eb5c90a74ace8dfe7

Change-Id: I68ab6da7c90b869499f1b7a4d2433dac77d36889

Change-Id: I499f00e13543d2191008a0d7a4aa0391d6889315

Change-Id: Id2d892742cd69da2deba51775bd04ecbec32f436
Reviewed-on: https://gerrit.libreoffice.org/19170Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I3fa01a2d03e7de6438d0db0685e53e6b7ca6c25a
Reviewed-on: https://gerrit.libreoffice.org/19218Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Use negative Y if there is only 1 positive Y
Skip some 0 or 1 in some corner case.
Add minus sign if intercept is missing
Simplify writing of equation

Change-Id: I4b164568c87c54934a38ff2d0cd72133f7fece26
Reviewed-on: https://gerrit.libreoffice.org/19033Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Replace ::std::for_each for a more readable range-based for loop in
cases in which the function object to be applied by for_each is more
readable as the body of a for loop.

Change-Id: I5798293cdd0d784cc4c95c67e3fc6a0b930db8bb
Reviewed-on: https://gerrit.libreoffice.org/19261Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

1) The size of the searchResultSelection array in
LOK_CALLBACK_SEARCH_RESULT_SELECTION provides the same information.

2) None of the clients except lokdocview used it.

3) Only sw provided this callback, not sc/sd.

Change-Id: I9da639b6693f24634f298f9bc4773f705e944359

Change-Id: I8a1fb10696a73134bf15fb7721cc5f78cc91eb98

Change-Id: Ie4fe557fc006414d119b64bb8d591f312a1f1f3d

Change-Id: I643f0b9c6a0d2e5688f9b644666b405df2832d07