const methods, removed this->..., naming

Change-Id: I0db1cf445936bab04003062bc59ce0a0c2fc8b71

Change-Id: I97252a66da63e25166acf3a7bc5a00ad1f8e94f0

This debug code was behind > 1 before
9ace8beb, so it probably was broken for
ages (or even forever), and all it does now is obscure my terminal with
hundreds of useless messages whenever I open an RTL document since
basically any weak LTR run next to RTL one will have the same script
type, but this code warns about it without explaining what one should
fix here.

I got fed up, whoever knows what to fix here, please do, but for now I’m
just hiding it.

Change-Id: Ifa50e47a080f335ef6fe06bc0f0b5ed5ddbc7338

Change-Id: I7454d90adfd507aae4c7efd1d4075454f03cddd8

For easy visual comparison.

Change-Id: Ib143f4bb7789b54dfbdd8fcf47516008403b47fd

Change-Id: I2ec31816562e55f6f95cac38dab4a17a393c0f9a

Many of the initalizations (in eg. framework) have to be done on an
acquire()'d object, so instead of doing the initialization directly, return
the initialization member function back to the createInstance() /
createInstanceWithContext() / ... and perform the initialization there.

As a sideeffect, I belive the calling initialize() from servicemanager is not
that much a hack any more - whoever converts the implementation to be
constructor-base has the choice to provide the callback, or still initialize
through XInitialization, where the callback is preferred by servicemanager
when it exists.

Change-Id: I8a87b75c54c1441ca0f184967d31ff4902fc4081

(regression from a3f32769)

Change-Id: Ic72b0e874ebf19e25e43af1f8750c63c04ed8a8e

Change-Id: Iaab13bd37b85128c9cf83b114a155f198b628587

Change-Id: I1588e6dcbc095d8c5fcde3601eea9111fbae15fb

Change-Id: I703c854efd0e3456bfdc2e9ec527283a04bd31aa

Change-Id: Id1a0df17a28372f9d7c3a88424cf7656fed46f9a

Change-Id: I471bebacb036e3809cdef2be9e33891da37a3723

Change-Id: I5c72b0bc34d87312437ae32a506567c3fb3bfa19

Change-Id: I9e5e77ad2c29ccdae1a794b7a0223858d8a662a6

Change-Id: Ia6f86e38cb46a5f7ac634ad0afb66701811e6758

Change-Id: Ie9951690fa99705d2083e0d1515261f2f99fd97a

Change-Id: I24fae431d9e2b99cd6ac937956bb401ecfebc943

Change-Id: Id91399027008ffbda26f3212bd3ddbba22044f2b

Change-Id: I64288207adb083e006b4acc5e7f26d647236a443

Change-Id: I85faf4e3fcab6763af11eb6a4082820e88bea1ca

Change-Id: I714caa8dc3d34fd56e6a11f57db6723dcb7e6705

Change-Id: If2dd67ad08d93e020e0e68043f9270d387bd41d3
Reviewed-on: https://gerrit.libreoffice.org/7246Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Valgrind is capable of detecting such bugs. No need for extra macros.

Change-Id: Ida618d6ac383c65f1c09212a7b6aa5ee228677db
Reviewed-on: https://gerrit.libreoffice.org/7534Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Valgrind is capable of detecting such bugs. No need for extra macros.

Change-Id: I9cb8af9dad93a7ee7114489b13e3994515357a10
Reviewed-on: https://gerrit.libreoffice.org/7533Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Valgrind is capable of detecting such bugs. No need for extra macros.

Conflicts:
	dbaccess/source/ui/dlg/tablespage.cxx

Change-Id: I25ea9174a042050efdb371246417ee7f2edae997
Reviewed-on: https://gerrit.libreoffice.org/7532Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Valgrind is capable of detecting such bugs. No need for extra macros.

Change-Id: Id75ca6991af0bf75e979c7bc2da452f323f389ea
Reviewed-on: https://gerrit.libreoffice.org/7531Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Valgrind is capable of detecting such bugs. No need for extra macros.

Change-Id: Ifc04e2ec9d27c706868569a3bcb8fbfae0e84c69
Reviewed-on: https://gerrit.libreoffice.org/7524Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I90be516235228574dc219447a0eef3a34f83bee2
Reviewed-on: https://gerrit.libreoffice.org/7539Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

This minimum size calculated like this:
width: sidebar optimal width + width of text appearing in
the thumbnail view when no recent document is available.
height: menu width + optimal width of GtkBox containing
buttons.

Change-Id: Ic1fd6e33a1ec93e61318af02c09ee88909a76cf4
Reviewed-on: https://gerrit.libreoffice.org/7505Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

It makes no sense to disable something via an Enable function.
I have split the function into Enable and Disable functions, and
update the code accordingly.

Conflicts:
	include/vcl/svapp.hxx

Change-Id: Ic05d69796f43e802a4a2a16aaca44433b6eaa018
Reviewed-on: https://gerrit.libreoffice.org/7525Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I96720843f815bf6d499eb424c3e4ff579c2bbe23

At ThumbnailView::SelectItem the piece of code in charge of the
accessible events related to selection change was mistakenly using
the accessibility helper class ThumbnailViewAcc instead of
ThumbnailViewItemAcc which is the proper one for managing the events
related to ThumbnailViewItem objects.

The methods FireAccessibleEvent and static getImplementation had to
be added to ThumbnailViewItemAcc to provide the full functionality
required.

Change-Id: Ia5ffb24c920f3c48854021700819be683c979411
Reviewed-on: https://gerrit.libreoffice.org/7551Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

(cherry picked from commit 275a1d7a)

Conflicts:
	basctl/source/dlged/dlged.cxx
	dbaccess/source/ui/querydesign/JoinTableView.cxx
	sc/source/filter/xml/XMLChangeTrackingImportHelper.cxx
	svtools/source/edit/syntaxhighlight.cxx
	svx/source/unodraw/unoshape.cxx
	sw/source/ui/app/appopt.cxx
	vcl/osx/salinst.cxx

Change-Id: If4ddf4ab23dbcfc4ba280948c73664b9794aecc7

Change-Id: I64f513969ff8eae48da4b55449439ea61b828645

Change-Id: I7bfb7698e2a5303b492766fba564c7b9033bcc52

Change-Id: Ie79ea86509004dc149cda2316c07cd7db9b339a4

Change-Id: Iae0c70ab713a0d95fa7bc447f8a79e244c5a4258

Change-Id: I95446e7bcdfb19cea9eb8055ac880f7c8a04eb37

Project: help  23bdde918a84d61f7162980ee9356363c3393202