...and SolarMutex, when e.g. during JunitTest_framework_complex the main thread
has the SolarMutex locked and tries to lock

> osl_acquireMutex(oslMutexImpl*)
> osl::Mutex::acquire()
> osl::Guard<osl::Mutex>::Guard(osl::Mutex&)
> sd::ToolBarManager::Implementation::LockUpdate()
> sd::ToolBarManager::LockUpdate()
> sd::ToolBarManager::UpdateLock::UpdateLock(std::shared_ptr<sd::ToolBarManager> const&)
> sd::framework::ToolBarModule::HandleUpdateStart()
> sd::framework::ToolBarModule::notifyConfigurationChange(com::sun::star::drawing::framework::ConfigurationChangeEvent const&)
> sd::framework::ConfigurationControllerBroadcaster::NotifyListeners(std::__debug::vector<sd::framework::ConfigurationControllerBroadcaster::ListenerDescriptor, std::allocator<sd::framework::ConfigurationControllerBroadcaster::ListenerDescriptor> > const&, com::sun::star::drawing::framework::ConfigurationChangeEvent const&)
> sd::framework::ConfigurationControllerBroadcaster::NotifyListeners(com::sun::star::drawing::framework::ConfigurationChangeEvent const&)
> sd::framework::ConfigurationUpdater::UpdateConfiguration()
> sd::framework::ConfigurationUpdater::RequestUpdate(com::sun::star::uno::Reference<com::sun::star::drawing::framework::XConfiguration> const&)
> sd::framework::ChangeRequestQueueProcessor::ProcessOneEvent()
> sd::framework::ChangeRequestQueueProcessor::ProcessEvent(void*)
> sd::framework::ChangeRequestQueueProcessor::LinkStubProcessEvent(void*, void*)
> Link<void*, void>::Call(void*)
> ImplHandleUserEvent(ImplSVEvent*)
> ImplWindowFrameProc(vcl::Window*, unsigned short, void const*)
> SalFrame::CallCallback(unsigned short, void const*)
> SvpSalInstance::DoYield(bool, bool, unsigned long)
> ImplYield(bool, bool, unsigned long)
> Application::Yield()
> Application::Execute()
> desktop::Desktop::DoExecute()
> desktop::Desktop::Main()
> ImplSVMain()
> SVMain()
> soffice_main()
> main()

while some URP worker thread has sd::ToolBarManager::Implementation::maMutex
locked and tries to lock

> osl_acquireMutex(oslMutexImpl*)
> osl::Mutex::acquire()
> SalYieldMutex::acquire()
> SolarMutexGuard::SolarMutexGuard()
> framework::ToolbarLayoutManager::implts_calcWindowPosSizeOnSingleRowColumn(int, int, framework::ToolbarLayoutManager::SingleRowColumnWindowData&, Size const&)
> framework::ToolbarLayoutManager::doLayout(Size const&)
> framework::LayoutManager::implts_doLayout(bool, bool)
> framework::LayoutManager::implts_doLayout_notify(bool)
> framework::LayoutManager::unlock() (this=0x2b0d9ff633e8)
> (anonymous namespace)::LayouterLock::~LayouterLock()
> std::default_delete<(anonymous namespace)::LayouterLock>::operator()((anonymous namespace)::LayouterLock*) const
> std::unique_ptr<(anonymous namespace)::LayouterLock, std::default_delete<(anonymous namespace)::LayouterLock> >::reset((anonymous namespace)::LayouterLock*)
> sd::ToolBarManager::Implementation::Update(std::unique_ptr<(anonymous namespace)::LayouterLock, std::default_delete<(anonymous namespace)::LayouterLock> >)
> sd::ToolBarManager::Implementation::UnlockUpdate()
> sd::ToolBarManager::Implementation::UpdateLockImplementation::~UpdateLockImplementation()
> sd::ToolBarManager::Implementation::SetValid(bool)
> sd::ToolBarManager::Implementation::EventMultiplexerCallback(sd::tools::EventMultiplexerEvent&)
> sd::ToolBarManager::Implementation::LinkStubEventMultiplexerCallback(void*, sd::tools::EventMultiplexerEvent&)
> Link<sd::tools::EventMultiplexerEvent&, void>::Call(sd::tools::EventMultiplexerEvent&) const
> sd::tools::EventMultiplexer::Implementation::CallListeners(sd::tools::EventMultiplexerEvent&)
> sd::tools::EventMultiplexer::Implementation::CallListeners(unsigned int, void*)
> sd::tools::EventMultiplexer::Implementation::frameAction(com::sun::star::frame::FrameActionEvent const&)
> (anonymous namespace)::Frame::implts_sendFrameActionEvent(com::sun::star::frame::FrameAction const&)
> (anonymous namespace)::Frame::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&)
> (anonymous namespace)::Frame::close(unsigned char)
> gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*)
> cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**)
> bridges::cpp_uno::shared::unoInterfaceProxyDispatch(_uno_Interface*, _typelib_TypeDescription const*, void*, void**, _uno_Any**)
> binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const
> binaryurp::IncomingRequest::execute() const
> request(void*)
> cppu_threadpool::JobQueue::enter(long, bool)
> cppu_threadpool::ORequestThread::run()
> threadFunc(void*) (param=0x2b0db00019e0)
> osl_thread_start_Impl(void*)
> start_thread

Change-Id: Ie846bd95944680160eebc93b904875142723ac70

...after 8c125eca "tdf#45904 move java based api
tests to c++"

Change-Id: Ia8469a6bcbb27658f4f26d41ff83389e37888bde

Change-Id: I273d80b4e9fb45955c5496cf5559df5dd4b057b0

Change-Id: I95cce21c6c9beb5637dd4f4a769f455eaacbec2b

Change-Id: I1ba88bca82b5b251ed34330ab5e0cb8bd88a5815

Change-Id: Id3ce7ce651f541106cf60116f717e6ffd805db24

Although LO was exporting whether an image was flipped
horizontally or vertically, it wasn't reading it in during
an import.

Change-Id: Ia85e3459d00f40d852bbcd3fcfe15e7b53d518ba
Reviewed-on: https://gerrit.libreoffice.org/22344Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

These pointers must be non-null, or deferencing null can happen.

Change-Id: I3ced1204abb70cf7c525ea9d50c6a3a295728ab5
Reviewed-on: https://gerrit.libreoffice.org/22365Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Given that all DOCX signing code is in xmlsecurity and it wasn't
DOCX-specific, this works out of the box.

Change-Id: I18429f63c125a43346e9e52021e1b7e33b300af4

Change-Id: I9e20a35dd8e18ba1a9251f4dc3ce903183c250cf
Reviewed-on: https://gerrit.libreoffice.org/22368Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

- MenuBarManager::Activate has a check for duplicate activation,
  which makes the second activation attempt fail. Removing this
  check or deactivating after each activation will likely affect
  performance even more, but on the other hand should solve
  lp#1296715, which was the main reason of the over activation
  in the first place. So let's activate only one menu at a time,
  and do full activation only on the initial update.

- Unfortunately the HUD activation callback doesn't work, so
  we still have to keep active status listener for all menu
  items. (Which is BTW against the recommendation in
  XPopupMenuController::updatePopupMenu IDL doc. Fortunately
  the performance problem hardly noticeable on modern hw.)

Change-Id: I96affa72412f3f38160fdca4b6efd20ca68d059f
Reviewed-on: https://gerrit.libreoffice.org/22369Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

Change-Id: I15f0320b646d20f0093c77286c1ff2715aacb8ce

Change-Id: I48552afc35c1f7cfff3562c36eca3f1cf6174077

...and fix its documentation, and use it throughout the code base.

Change-Id: I349bc2009b1b0aa7115ea90bc6ecd0a812f63698

Change-Id: I268f0de42e0567d74dd9b9b84b19d6afbf4d44df

Change-Id: I4f147c3d55de86eb4bd56bb4c728df19c925b376
Reviewed-on: https://gerrit.libreoffice.org/22366Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>

This wasn't a problem when we signed MSO-produced documents that have
these all the time, but it was a problem for LO-produced documents.

We don't add an explicit content type for _xmlsignatures/origin.sigs, so
need a default for the .sigs extension.

Change-Id: Ic5d0647991c42f9f1ef3519986a4bd1b56de396d

on css.awt.UnoControlFixedTextModel

Patch by: hanya

(cherry picked from commit 92ff48eb)

Change-Id: I44bbf7d49add8e49d3cb8e1a19839626a2f69b63

Change-Id: I92f41cde892d47abcd31e2b85ace7d228cbfd9fe

Change-Id: I6427bc26d77e4ace2a827b9ae81716d62b5050ba

...which is hard-coded to fail with

  echo '--should-not-have-used-/usr/bin/xml2-config'
  exit 1

Change-Id: Ic358e7d494f01f67c1469c4add080d775525ebb6

Previously it got a PROV_RSA_FULL provider, but SHA-256 needs
PROV_RSA_AES.

Change-Id: I6c689a4c5943920ce656c09d9d7d5e194ff47eb6
Reviewed-on: https://gerrit.libreoffice.org/22364Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ibdb99942ee6c022abad74df93ebfb99c4ce6567f

For some reason, maDisplayName is not initialized always. Use
GetDisplayName() that handles such a case gracefully.

Change-Id: Ib62d4f03dcd3b5571749b540e5af7f90299e2067
Reviewed-on: https://gerrit.libreoffice.org/22348Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: I2119713600703e3aa18f673979c7cd84c38177d7
Reviewed-on: https://gerrit.libreoffice.org/22349Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: Ic76cf0130ebec4cf723b83d82f59ae45bfcb3ea1
Reviewed-on: https://gerrit.libreoffice.org/22350Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ida79aa0d5a519a2c124d20a1cd908411d01799de

Change-Id: I1efafbd64539ac6d71de0be41ecaa71533143590
Reviewed-on: https://gerrit.libreoffice.org/22362Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Martin Hosken <martin_hosken@sil.org>

The old code set called the outline visibility code for each row. Now we
are just calling it once at the end of the import.

Change-Id: Ie19f8bd538495cb50a7618156aed8de832885c2a
Reviewed-on: https://gerrit.libreoffice.org/22239Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Ia4eedef6a6cb060d756ee83b3fb82afa68ac2c5a
Reviewed-on: https://gerrit.libreoffice.org/22276Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I700168b0484e86caa8df4a579ef51bcd40b6f66f

and

coverity#1352322 Dereference null return value

Change-Id: I0482ed95e8fbce5d7f9a827588a66ebd0f9d69c7

and

coverity#1352307 Unchecked dynamic_cast

Change-Id: I0b072e432fe5d510a2a55ad33628ec93b706c860

and

coverity#1352452 Uncaught exception
coverity#1352453 Uncaught exception

Change-Id: I100aa7ebf729bfe2e379e28891f5cd217d4187cc

JPEG values are currently hardcoded to 96PPI when we export JPEGs. The
Graphic class doesn't have an easy way to get the PPI, but this can
actually be calculated from the pref size and pref map mode (no idea
why it is called "Pref").

Interestingly, you need to get a multiplier to work this out, relative
to units of 100th mm. The EPS filter code had a function that does
exactly this, but it's entirely based on MapMode units so it was really
implemented in the wrong class IMO. I have thus moved it out of PSWriter
and into MapMode.

This also fixes tdf#65695, which was partially fixed, but had the JPEG
PPI hardcoded to 96dpi.

Also fixes tdf#97481.

Change-Id: Iedb674141dd4e22fcbfb7be357dc777f732aa3aa
Reviewed-on: https://gerrit.libreoffice.org/22339Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: Ia4ca58ca67936a558b3157daae6a663ef81a81bf

Change-Id: I891519d54212ecd99273a54aca2a44e2d54c1933

--enable-icecream option mentions this in its documentation, but
it had been missing till now.

This option is also necessary when operating systems installs 
icecc wrappers in locations other than /usr/lib/icecc, /opt/icecream, 
which is what GCC_HOME gets set to by default with --enable-icecream.

Change-Id: Ib2b6ec010271467949e7ac9f1d01624cb360c5a5
Reviewed-on: https://gerrit.libreoffice.org/21551Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Project: help  f9a4ba48ebcb885f1d025aa72e674a3b69c4e576

tdf#97813 optional/required param in ACCRINT*

Optional Parameter par is not noted as optional

Change-Id: I1424d723334db8cbfa394f5d402e9a84b61e7b00
Reviewed-on: https://gerrit.libreoffice.org/22342Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Thanks Eike for the feedback!

Change-Id: I4840ddf0cb897fd2138fe4607040a3b5a5b60357