- 18 Eyl, 2015 40 kayıt (commit)
-
-
Michael Stahl yazdı
This reverts commit 9099e21b. It causes the problem that frames anchored to the same node where redlines start or end get duplicated during Hide. Jan-Marek said that the original mail-merge related problem this change was fixing is now most likely fixed differently, and the test in testMultiPageAnchoredDraws() still passes. (cherry picked from commit e84f0a9b) sw: add unit test for the redline frame duplication regression (cherry picked from commit d5ffcba0) Change-Id: Ie84fed3f64be7696782bc557004eb18fccc5b64b Reviewed-on: https://gerrit.libreoffice.org/18509Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
Lubosz Sarnecki yazdı
Change-Id: Ib139e81f770531f7d808764dd3a77c7ac8d6fa3c Signed-off-by:Michael Meeks <michael.meeks@collabora.com>
-
Regina Henschel yazdı
Change wrong PROP_FILENAME to correct PROP_DIRECTORY Change-Id: Iab2e16c486f487699e1574ed508539d95884bf9b Reviewed-on: https://gerrit.libreoffice.org/18127Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
-
Eike Rathke yazdı
Drag&Drop Undo is a special case of ownership.. Change-Id: I2fe7769c4d84efe09d432335d5d8e72d506bf7a1 (cherry picked from commit 44f34c11) Reviewed-on: https://gerrit.libreoffice.org/18470Tested-by:
-
Miklos Vajna yazdı
in JunitTest_sc_unoapi_3. Change-Id: Ic7e32979f31a3376b67eb3bef59373632461e39f (cherry picked from commit 0e682d47) Reviewed-on: https://gerrit.libreoffice.org/18490Reviewed-by:
-
Miklos Vajna yazdı
So that large images are written only once to the ZIP container when they are exported using both markups. This affects drawinglayer images, the Writer ones are handled directly in sw and were already deduplicated. (cherry picked from commit b484e981) Conflicts: oox/source/export/drawingml.cxx Change-Id: Iff7c769329b42939833056b727b070f6a60da5e3 Reviewed-on: https://gerrit.libreoffice.org/18491Reviewed-by:
-
Miklos Vajna yazdı
in JunitTest_sc_unoapi_3. Change-Id: Ibe12a31c1158f782bd7df115171b07e1843d025c (cherry picked from commit 57fc41ad) Reviewed-on: https://gerrit.libreoffice.org/18489Tested-by:
Tomaž Vajngerl <quikee@gmail.com>
-
Miklos Vajna yazdı
Change-Id: Ic8065d4f656d42f1e2e7d8b4c602010fa0ae2d34 Reviewed-on: https://gerrit.libreoffice.org/18343Reviewed-by:
-
Miklos Vajna yazdı
There were two problems here: 1) The OpenGLContext ctor registered the instance on the list of contexts, but platform-specific call (e.g. wglMakeCurrent()) was only made later. Add a registerAsCurrent() member function that helps ensuring that the last item in the context list is indeed the current context. 2) OpenGLContext::prepareForYield() is called without the solar mutex being locked, but it still assumes that the last context in the context list is the thread's current context, which may not be true. The result is that during JunitTest_sd_unoapi, we end up in a situation like: debug:4640:5240: OpenGLContext::registerAsCurrent: wglGetCurrentContext() is 00010001, pSVData->maGDIData.mpLastContext is 00FA65F8 debug:4640:7944: OpenGLContext::registerAsCurrent: wglGetCurrentContext() is 000D0003, pSVData->maGDIData.mpLastContext is 00FA6C70 debug:4640:5240: OpenGLContext::prepareForYield: start, wglGetCurrentContext() is 00010001, pSVData->maGDIData.mpLastContext is 00FA6C70 I.e. one thread registers as current, an other registers as current, too (while the other thread has the solar mutex), then once the original thread wants to release the solar mutex, the real current context and the last item in the context list won't match, so the assert at the end of prepareForYield() will fail. Fix this by releasing the GL context in WinSalInstance::DestroyFrame(). With this, JunitTest_sd_unoapi passes on Windows with GL enabled. Change-Id: Icfb9c65c871586b5df69b5a2ab3aa91843dfc799 Reviewed-on: https://gerrit.libreoffice.org/18473Reviewed-by:
-
Julien Nabet yazdı
When Slide Show/Slide Show Settings is selected and Ok button is clicked the slide from "From" list box is stored in maPresPage and the fact that this var is not empty makes slideshow considers it must be used. So 2 things must be done: 1) Check first if "All Slides" has been selected In this case, don't read slide from "From" in next block (ATTR_PRESENT_DIANAME) and so let maPresPage empty 2) Empty maPresPage if "All Slides" has been selected to remove any existing value Change-Id: I6042ae2db6260e1f441a1c9db90f5de6de966f2a Reviewed-on: https://gerrit.libreoffice.org/18253Tested-by:
-
Miklos Vajna yazdı
Commit a6b00d16 (Related bnc#822625: Cache FontEntry with the original FontSelectPattern.) and the follow-up 16a62079 (Oops, this reference can't be const., 2014-05-28) changed the font cache key, so that it's directly what was the argument to ImplFontCache::GetFontEntry(), which leads to missing glyphs in the bugdoc, e.g. the 4 check mark characters are rendered as a check mark only in the DejaVu Sans case on my machine, the other 3 cases result in placeholders. Fix the problem by changing back the key to aFontSelData, which is possibly modified in ImplFontCache::GetFontEntry() before used as a key. Change-Id: I80eb4ba0f986a10100b6ae421d1346f235ce83b7 (cherry picked from commit e047caf4) Reviewed-on: https://gerrit.libreoffice.org/18437Tested-by:
-
Miklos Vajna yazdı
(cherry picked from commit b5df051c) Change-Id: I4a7199633d0d940ae009ac144989da7d6c9262ec Reviewed-on: https://gerrit.libreoffice.org/18399Tested-by:
Andras Timar <andras.timar@collabora.com>
-
Matthias Freund yazdı
-drawchart icons has now three pieces but only one seperated one. -lc version of the formatdialog icons has now a non equal sign. -dark pie same size as the seperated one. Change-Id: If6373232cff67ec18ad8e5f8bb9e65176cce20ad
-
Matthias Freund yazdı
drawchart with 3 pieces and cleanups wich had prevent sharp symbols. Change-Id: I0733f68b59a66dc6476fa183615e9429b2904275 Reviewed-on: https://gerrit.libreoffice.org/16957Tested-by:
Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by:
-
Caolán McNamara yazdı
Change-Id: I525009b9d037387b236cb4605fe0b93c94858d89 (cherry picked from commit b95175cc)
-
Michael Meeks yazdı
Removes a large number of spurious GL errors left & right. Change-Id: I0b5639478812982b39d3b88be2600dad5d3f1fd0 Reviewed-on: https://gerrit.libreoffice.org/18422Tested-by:
Miklos Vajna <vmiklos@collabora.co.uk>
-
Michael Stahl yazdı
Change-Id: Ib8294e66cb9482ae2502f4741c90dccac36a117b
-
Michael Stahl yazdı
Change-Id: I7b6910a131d95a74168ccee9140bc58393ceddb0
-
Michael Stahl yazdı
Ugly hack in ExternalProject_liborcus.mk as apparently it fails with the define on Windows, and without on MacOSX :( Change-Id: If0b52825122edd956044f61d413c57a76f485101
-
Michael Meeks yazdı
Previously we would get an explicit ~OpenGLContext - and potentially leave FMR's around for other OGC users, now we treat the other users properly - we need an explicit dispose() to get Window::dispose ordering right. Reviewed-on: https://gerrit.libreoffice.org/18412Tested-by:
Markus Mohrhard <markus.mohrhard@googlemail.com> Conflicts: vcl/source/window/openglwin.cxx Change-Id: I5edcbd73399b6db3dbcfb391570f364f9ab0c70d Reviewed-on: https://gerrit.libreoffice.org/18414Reviewed-by:
-
Markus Mohrhard yazdı
Change-Id: Iab0a53abd723f0309f40742636315079a4b2c532 (cherry picked from commit c94d60d6) Signed-off-by:
Michael Stahl <mstahl@redhat.com>
-
Michael Meeks yazdı
Squashes two related patches from master: Don't use rtl::Reference for the global / list state, so the ref-count reflects the number of real users. Hold a reference during ~OpenGLContext. Fix mis-use in: gltf rendering, OpenGL canvas, GL transitions & GL capable (charts) Avoid GLX operations on un-initialized contexts. Signed-off-by: -
Michael Meeks yazdı
Change-Id: I4a61595294c24a609a5952ce72f9f88524969784 Reviewed-on: https://gerrit.libreoffice.org/18384Reviewed-by:
-
Michael Stahl yazdı
After the document is created, an event is dispatched on the main loop that calls SfxPickList::Notify(), which modifies document properties. It tries to prevent setting the document to modified by calling SfxObjectShell::EnableSetModified(false), but Writer cunningly outwits it by simply having its own independent(?) modified flag that is set unconditionally in DocumentStatisticsManager::DocInfoChgd(). Let's assume that if the modified flag shouldn't be modified in SfxObjectShell, it shouldn't be modified in DocumentStatisticsManager. Somehow in 4.4 and 4.3 the same thing was going on, but it didn't result in a visibly enabled Save icon in the UI, but with 5.0 it does - cannot easily bisect why that changed due to tdf#91383. Change-Id: Id30fd831eb29910c9fb44ed3031bf8da23586bea (cherry picked from commit 5adc8ee3) Reviewed-on: https://gerrit.libreoffice.org/18388Reviewed-by:
-
Michael Stahl yazdı
... when deleting the temporarily inserted styles in SwDocStyleSheet::FillStyleSheet(). Change-Id: Id4abc067ce10b41486f659350267c7e3933db472 (cherry picked from commit 66133fd8) Reviewed-on: https://gerrit.libreoffice.org/18387Reviewed-by:
-
Michael Stahl yazdı
If the style does not actually have any font items, as is the case for frame, page and number styles in Writer, the maFont will be default-initialized and the maPixelSize incorrect. Avoid using these variables. (cherry picked from commit 07df816d) Change-Id: I084cd8faa90a3d53310ceec55e8dae3af3dd586c Reviewed-on: https://gerrit.libreoffice.org/18383Reviewed-by:
-
Michael Stahl yazdı
The dialog/sidebar should not actually create styles that don't exist yet, because it messes up Undo and the (unused) styles are then unnecessarily exported to documents. Due to Writer's ... unusual SwDocStyleSheet class this is a bit tricky. Add a new function GetItemSetForPreview() and use it from the style preview code. The implementation does not use FillPhysical so will temporarily create and then delete any non-existing styles. Skip page and numbering styles for now since they don't have a useful preview. (regression from ca953076) (cherry picked from commit 93067f37) -Werror,-Wreturn-type (cherry picked from commit 0ed64030) Change-Id: Id6ee30ea467fc24c991547a4c23a9ce14fdd86c7 Reviewed-on: https://gerrit.libreoffice.org/18381Reviewed-by:
-
Michael Stahl yazdı
This causes the temporary creation of frame styles to fail. Change-Id: I5d148ae008660d9c0f457a4c0e9dc256e0dfc49a (cherry picked from commit 110dc43d) Reviewed-on: https://gerrit.libreoffice.org/18380Reviewed-by:
-
Michael Stahl yazdı
SwDocStyleSheet::FillStyleSheet() already takes care to remove all temporarily created styles, so assume that works and suppress the creation of user-visible Undo objects. Change-Id: I748f0e8304c42e767b331ebd22be0290b9c0d89d (cherry picked from commit 779b547c) Reviewed-on: https://gerrit.libreoffice.org/18382Reviewed-by:
-
Michael Stahl yazdı
+ rLineBoxes = pFndBox->GetLines()[nEnd]->GetBoxes(); This actually assigns the boxes vector of the last line to the first line, which the previous code didn't do. Notably after converting the types from boost::ptr_vector to std::vector<std::unique_ptr>, the assignment produces a several page error message from both GCC and clang, and infuriatingly neither compiler was able to tell on which line in tblrwcl.cxx the template was instantiated, so i had to bisect that. (regression from be5e4247) Change-Id: I646e3ca678895480d38ec48f38d720458860a985 (cherry picked from commit 8bf0e60d) Reviewed-on: https://gerrit.libreoffice.org/18379Reviewed-by:
-
Markus Mohrhard yazdı
There are even more and it is causing a number of performance issues. This just fixes the most obvious place. Change-Id: Id85c13b5b7f4bb0bc077e62c39258067e17c0094 Signed-off-by: -
Miklos Vajna yazdı
Cached glyphs used to have a 2px border in all font sizes, that's too small for larger fonts. Make the border size depend on the font size for larger fonts to make sure that the rendered glyphs are indeed independent. The introduced GLYPH_SPACE_RATIO = 8 constant is the smallest value where I don't see overflows anymore for large fonts. With this, not even the bugdoc renders correctly when presenting, but also the text is OK when the font size is set to the max allowed by the UI (96pt). Change-Id: I52aa5c4444583fc0467291463697a63f2b8fc86c (cherry picked from commit 840248a4) Reviewed-on: https://gerrit.libreoffice.org/18369Tested-by:
Jan Holesovsky <kendy@collabora.com>
-
Markus Mohrhard yazdı
Change-Id: Ia829b0f723c8ded1237e52d48f034da3c1ac249e Signed-off-by: -
Maxim Monastirsky yazdı
Regression of eb505c25. Change-Id: I4623c41617d92a808513f18154a7531e6dfd5463 (cherry picked from commit fdbad676) Reviewed-on: https://gerrit.libreoffice.org/18370Tested-by:
-
László Németh yazdı
before drawing the new icon (cherry-picked from commit e74bc6b9) Conflicts: svtools/source/control/ruler.cxx Change-Id: Ibbdbed448f965848429ace28dcfae47efc982164 Reviewed-on: https://gerrit.libreoffice.org/18376Reviewed-by:
-
David Ostrovsky yazdı
9a6cdce3 was trying to fix the problem with exposing deprecated vars and functions in system's error_code.hpp include file by patching bundled boost version. This approach would only make sense, when upstream version is going to be fixed ASAP. Apply another approach, and follow the same pattern as applied in external libraries, by defining -DBOOST_ERROR_CODE_HEADER_ONLY \ -DBOOST_SYSTEM_NO_DEPRECATED instead of patching bundled boost version. This way, the code would work with unpatched system boost 1.59 final as well. Reviewed-on: https://gerrit.libreoffice.org/18201Reviewed-by:
David Ostrovsky <david@ostrovsky.org> Tested-by:
David Tardon <dtardon@redhat.com> Tested-by:
-
Juergen Funk yazdı
Evaluation of the 0 is here http://opengrok.libreoffice.org/xref/core/xmloff/source/text/txtparae.cxx#615 the methode "xNumRule->getCount()" get back the 0. Change-Id: I15424fe7eb9d35a6a6d4f669e695efc904be320f Reviewed-on: https://gerrit.libreoffice.org/18231Tested-by:
Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by:
Katarina Behrens <Katarina.Behrens@cib.de>
-
Miklos Vajna yazdı
Commit ef2668ba (PPTX import: fix missing document metadata, 2014-08-28) implemented metadata import for the PPTX filter, but in case the metadata stream is not an existing one, then OHierarchyHolder_Impl::GetListPathFromString() invoked by OStorage::openStreamElementByHierarchicalName() throws. The bugdoc is generated by a 3rd-party tool that always starts the stream path with a slash, and MSO seems to just ignore that: so let's do the same to be able to open the document. Change-Id: I6c0715adeb19b9055669f6a45055415dd2c44e28 (cherry picked from commit 46cf9bb7) Reviewed-on: https://gerrit.libreoffice.org/18368Reviewed-by:
-
Stephan Bergmann yazdı
Change-Id: If54b3017296f5bcea01b3b0d24d9ac821f6a24e9 (cherry picked from commit c82c94b4)
-
Stephan Bergmann yazdı
Change-Id: I88baef02e5c8c87e7bc408212e16fd7039bfd7a1 (cherry picked from commit ec923b0c)
-
