Change-Id: If25d9307efda5f57b0f80a0cf5c2c5cab6a752d6
Reviewed-on: https://gerrit.libreoffice.org/27981Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Icdf2a908d131ff05a1c00b7305686edba26d4b24

Change-Id: I53ef8c215866fc45ee82b6805c41c93da0e024b7
Reviewed-on: https://gerrit.libreoffice.org/27980Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Needed to manage https certificates and authentication whenever
needed.

Change-Id: If20b85a9b349b203a8c46d453afa823629d114cb
Reviewed-on: https://gerrit.libreoffice.org/27927Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>

Change-Id: I34fc490407f2bdac036dced5360b438ffb1cb4e2

Change-Id: I90d280dd041051d8d8433519a7ad7fc17117fd74

Change-Id: I4590d8448c997665882b0b1e26b1bdfbd4b3539e
Reviewed-on: https://gerrit.libreoffice.org/27758Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: Iac5683afd20d8a2b7bc43474580bd1d05ace562b
Reviewed-on: https://gerrit.libreoffice.org/27934Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Id920a83693969ab2d93047524a9affa267a231dc
Reviewed-on: https://gerrit.libreoffice.org/27931Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

and assert hard as rRectangle size is MAX_PRESOBJS

Change-Id: Ia486d4237e9efdf4f7b89dc3ec5c58916bdfd950
Reviewed-on: https://gerrit.libreoffice.org/27941Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ic20f31f4fb3c2af3a479be238968904d37fcc668
Reviewed-on: https://gerrit.libreoffice.org/27945Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I42fc09957f243c89a0c45309b92a91cf3c2692b1
Reviewed-on: https://gerrit.libreoffice.org/27944Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

This crash has been responsible for around 20% of the 5.2.0.4 crashes
with backtraces for the modification of the container similar to:

    sxlo.dll!SfxWorkWindow::SetChildWindowVisible_Impl(unsigned long lId, bool bEnabled, unsigned short nMode) Line 1834    C++
     sfxlo.dll!SfxDispatcher::Update_Impl_(bool bUIActive, bool bIsMDIApp, bool bIsIPOwner, SfxWorkWindow * pTaskWin) Line 1452    C++
     sfxlo.dll!SfxDispatcher::Update_Impl(bool bForce) Line 1326    C++
     sfxlo.dll!SfxApplication::SetViewFrame_Impl(SfxViewFrame * pFrame) Line 372    C++
     sfxlo.dll!SfxViewFrame::SetViewFrame(SfxViewFrame * pFrame) Line 3138    C++
     sfxlo.dll!SfxViewFrame::MakeActive_Impl(bool bGrabFocus) Line 1697    C++
     sfxlo.dll!SfxFrameWindow_Impl::Notify(NotifyEvent & rNEvt) Line 111    C++
     vcllo.dll!vcl::Window::CompatNotify(NotifyEvent & rNEvt) Line 3747    C++
     vcllo.dll!vcl::Window::Notify(NotifyEvent & rNEvt) Line 198    C++
     vcllo.dll!DockingWindow::Notify(NotifyEvent & rNEvt) Line 633    C++
     vcllo.dll!vcl::Window::CompatNotify(NotifyEvent & rNEvt) Line 3747    C++
     vcllo.dll!vcl::Window::Notify(NotifyEvent & rNEvt) Line 198    C++
     vcllo.dll!DockingWindow::Notify(NotifyEvent & rNEvt) Line 633    C++
     sfxlo.dll!SfxDockingWindow::Notify(NotifyEvent & rEvt) Line 1655    C++
     vcllo.dll!vcl::Window::CompatNotify(NotifyEvent & rNEvt) Line 3747    C++
     vcllo.dll!vcl::Window::Notify(NotifyEvent & rNEvt) Line 198    C++
     vcllo.dll!vcl::Window::CompatNotify(NotifyEvent & rNEvt) Line 3747    C++
     vcllo.dll!vcl::Window::Notify(NotifyEvent & rNEvt) Line 198    C++
     vcllo.dll!vcl::Window::CompatNotify(NotifyEvent & rNEvt) Line 3747    C++
     vcllo.dll!vcl::Window::Notify(NotifyEvent & rNEvt) Line 198    C++
     vcllo.dll!Control::Notify(NotifyEvent & rNEvt) Line 274    C++
     vcllo.dll!vcl::Window::CompatNotify(NotifyEvent & rNEvt) Line 3747    C++
     vcllo.dll!vcl::Window::GetFocus() Line 1842    C++
     svtlo.dll!SvTreeListBox::GetFocus() Line 2096    C++
     swlo.dll!SwContentTree::GetFocus() Line 2571    C++
     vcllo.dll!vcl::Window::CompatGetFocus() Line 3716    C++
     vcllo.dll!vcl::Window::ImplGrabFocus(GetFocusFlags nFlags) Line 384    C++
     vcllo.dll!vcl::Window::GrabFocus() Line 3004    C++
     swlo.dll!SwNavigationPI::SwNavigationPI(SfxBindings * _pBindings, SfxChildWindowContext * pCw, vcl::Window * pParent) Line 835    C++
     swlo.dll!VclPtr<SwNavigationPI>::Create<SfxBindings * __ptr64 & __ptr64,SwNavigationChild * __ptr64 const,vcl::Window * __ptr64 & __ptr64>(SfxBinsfdings * & <arg_0>, SwNavigationChild * const && <arg_1>, vcl::Window * & <arg_2>) Line 131    C++
     swlo.dll!SwNavigationChild::SwNavigationChild(vcl::Window * pParent, unsigned short nId, SfxBindings * _pBindings, SfxChildWinInfo * __formal) Line 1306    C++
     swlo.dll!SwNavigationChild::CreateImpl(vcl::Window * pParent, SfxBindings * pBindings, SfxChildWinInfo * pInfo) Line 69    C++
     sfxlo.dll!SfxChildWindow::CreateContext(unsigned short nContextId, SfxBindings & rBindings) Line 457    C++
     sfxlo.dll!SfxWorkWindow::CreateChildWin_Impl(SfxChildWin_Impl * pCW, bool bSetFocus) Line 1436    C++
     sfxlo.dll!SfxWorkWindow::UpdateChildWindows_Impl() Line 1328    C++
     sfxlo.dll!SfxWorkWindow::UpdateObjectBars_Impl() Line 1283    C++
     sfxlo.dll!SfxFrameWorkWin_Impl::UpdateObjectBars_Impl() Line 1114    C++
     sfxlo.dll!SfxDispatcher::Update_Impl(bool bForce) Line 1329    C++
     sfxlo.dll!SfxBaseController::ConnectSfxFrame_Impl(const SfxBaseController::ConnectSfxFrame i_eConnect) Line 1326    C++
     sfxlo.dll!SfxBaseController::attachFrame(const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> & xFrame) Line 584    C++
     sfxlo.dll!`anonymous namespace'::SfxFrameLoader_Impl::impl_createDocumentView(const com::sun::star::uno::Reference<com::sun::star::frame::XModel2> & i_rModel, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> & i_rFrame, const comphelper::NamedValueCollection & i_rViewFactoryArgs, const rtl::OUString & i_rViewName) Line 604    C++
     sfxlo.dll!`anonymous namespace'::SfxFrameLoader_Impl::load(const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rArgs, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> & _rTargetFrame) Line 721    C++
     fwklo.dll!framework::LoadEnv::impl_loadContent() Line 1122    C++
     fwklo.dll!framework::LoadEnv::startLoading() Line 379    C++
     fwklo.dll!framework::LoadDispatcher::impl_dispatch(const com::sun::star::util::URL & rURL, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & lArguments, const com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> & xListener) Line 116    C++
     fwklo.dll!framework::LoadDispatcher::dispatch(const com::sun::star::util::URL & aURL, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & lArguments) Line 55    C++
     sfxlo.dll!RecentDocsView::ExecuteHdl_Impl(RecentDocsView * __formal, void * p) Line 335    C++
     sfxlo.dll!RecentDocsView::LinkStubExecuteHdl_Impl(void * instance, void * data) Line 327    C++
     vcllo.dll!Link<void * __ptr64,void>::Call(void * data) Line 84    C++
     vcllo.dll!ImplHandleUserEvent(ImplSVEvent * pSVEvent) Line 1949    C++
     vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalEvent nEvent, const void * pEvent) Line 2497    C++
     vcllo.dll!SalFrame::CallCallback(SalEvent nEvent, const void * pEvent) Line 282    C++
     vcllo.dll!ImplHandleUserEvent(HWND__ * hWnd, __int64 lParam) Line 4110    C++
     vcllo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, int & rDef) Line 5774    C++
     vcllo.dll!SalFrameWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 5907    C++
     [External Code]
     vcllo.dll!ImplSalDispatchMessage(tagMSG * pMsg) Line 572    C++
     vcllo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 591    C++
     vcllo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents, unsigned __int64 nReleased) Line 654    C++
     vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents, const unsigned __int64 nReleased) Line 510    C++
     vcllo.dll!Application::Yield() Line 556    C++
     vcllo.dll!Application::Execute() Line 472    C++
     sofficeapp.dll!desktop::Desktop::DoExecute() Line 1327    C++
     sofficeapp.dll!desktop::Desktop::Main() Line 1646    C++
     vcllo.dll!ImplSVMain() Line 177    C++
     vcllo.dll!SVMain() Line 216    C++
     sofficeapp.dll!soffice_main() Line 165    C++
     soffice.bin!sal_main() Line 48    C
     soffice.bin!main(int argc, char * * argv) Line 47    C
     soffice.bin!WinMain(void * _hinst, void * _dummy, char * _cmdline, int _nshow) Line 47    C
     [External Code]

Change-Id: I4f699952d144a9c276ce53604dc66418abc4baee
Reviewed-on: https://gerrit.libreoffice.org/27977Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

As can be seen in the other places we need to check for nullptr.

See
http://crashreport.libreoffice.org/stats/crash_details/553b9ef5-c85f-4cda-b432-472501795634

Change-Id: Ic5cab914f403fcae7f4e1e6f0e66c6295f7f56dd
Reviewed-on: https://gerrit.libreoffice.org/27949Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: If986b156397e15d2f1faa52b7d52b1ce0b37d213
Reviewed-on: https://gerrit.libreoffice.org/27889Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

See e.g.
http://crashreport.libreoffice.org/stats/crash_details/2218a489-b64c-4193-a7d4-cd01c6a607cb

Change-Id: I6c123d3e9e5c6dbcb7756a686503904cbfd944a4
Reviewed-on: https://gerrit.libreoffice.org/27948Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

In MS specification the output value is set with double precision after delimiter, according to formula:
 =Truncate(({width in pixels} - 5)/{Maximum Digit Width} * 100 + 0.5)/100

Explanation of magic numbers:
 - 5 number - are 4 pixels of margin padding (two on each side), plus 1 pixel padding for the gridlines. It is still unknown if it should be applied during LibreOffice export
 - 100 number - used to limit precision to 0.01 with formula =Truncate( {value} * 100 ) / 100
 - 0.5 number (0.005 to output value) - used to increase value before truncating, to avoid situation when 2.997 will be truncated to 2.99 and not to 3

Benefits of limited precision:
- small .xlsx file size
- slightly better performance during .xlsx import
- easier to track column width changes, especially in unit tests
- according to MS Excel specification

Change-Id: I0537df5f9d04f5c715784c2b0c4e0d4472904dcc
Reviewed-on: https://gerrit.libreoffice.org/27932Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

As explained in https://bugs.documentfoundation.org/67302
this is the right thing to do in that directory, but cannot
be comitted in isolation. All callers of that function in
all of LibreOffice need to be adapted to the new syntax
of the returned value (that is that the value is now properly escaped). This needs to be done at the same time in all drivers and all places that call this API (+documented in the release notes).

This reverts commit d43f4390.

Change-Id: I8f33fd68ec09d67dd6d38ae50d8ae156f11c5357
Reviewed-on: https://gerrit.libreoffice.org/26593Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ibb4cadb58aa17eacfc9741f7f13c780be347cd8b

Change-Id: I19ef66c037a69debc90f260f82cbc2bf6355ea8d

in commit 05c89af8

Change-Id: Ice51df4f91c083d0b5bd97e9299caa016bbad7c1
Reviewed-on: https://gerrit.libreoffice.org/27933Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>

Change-Id: Ie0bdc9693d2bade872ee3ac8d4cf6fd5c469493d
Reviewed-on: https://gerrit.libreoffice.org/27891Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ib30a12120fce2e8bb63c0fed3311d3390ad6afb5
Reviewed-on: https://gerrit.libreoffice.org/27925Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>

Change-Id: I0eb4e32901a78c32b2219b24fdf9019ad80a7dbb
Reviewed-on: https://gerrit.libreoffice.org/27926Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>

Fix what has been done in commit 07966a99. Replace string constant
concatenation with a single constructor.

Change-Id: I8a848cd0211a75321263b0b7413c079db9245471
Reviewed-on: https://gerrit.libreoffice.org/27928Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Ifbecef188b314d599d7e97717934143b2aac8c09
Reviewed-on: https://gerrit.libreoffice.org/27912Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>

only users in implementation of ScImportExport and ScImportStringStream
moving them to impex.cxx

Change-Id: Ic7a78f9dd11830ad0ed330c5349beddd724236da
Reviewed-on: https://gerrit.libreoffice.org/27918Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

This fix what has been done in 203e3c0f ,
which set CJK and CTL font in SwWW8ImplReader::Read_Symbol but didn't
close CJK and CTL fonts in SwWW8ImplReader::ReadChars.

Change-Id: I7c1d3b2a284d00a524a61785a5a94ca2d589295e
Reviewed-on: https://gerrit.libreoffice.org/27090Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Hung <marklh9@gmail.com>

Change-Id: Ic33edb9ca34235d2e24e8b0b0d6455efd0f3076c

... as PushDouble() may use it to create a FormulaTypedDoubleToken for type
inheritance.

Change-Id: I9fd668802d2890185fd4e338478c1404586cda04

So with {# ?/?} format 1.96 is displayed as "2" insted of "1 1/1"

Change-Id: I756deeb884d41726c7d476a236d3c68b89fe9cba

So summing [HH]:MM cells or calculating with dates uses the same format
in the result, not just the default format of a type.

This also fixes the apparently broken state stored by 4.4 (and earlier,
later?) where no type information was stored with the formula cell,
which may be just due to the old behavior of not applying the actual
format but determining it on the fly instead.

Change-Id: I14d0a7d07185bf5c77e0d7f6989a4a1d1a468d27

This shows the full undo and redo stack, with all the metadata available
via the LOK API.

Also fix SfxUndoManager::GetRedoActionsInfo(), so it's easy to show the
undo/redo stack in linear time; and fix a use-after-free in lokdocview.

Change-Id: I66625ed453efa61b5738d99d7d1ad8f468908240
Reviewed-on: https://gerrit.libreoffice.org/27913Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I747ddbe448b72bab0d7746d4d0a897f1c307c610
Reviewed-on: https://gerrit.libreoffice.org/27907Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I996f8fbba28222f4669fb89a9e1a6bda5132de5b
Reviewed-on: https://gerrit.libreoffice.org/27798Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I15801021c8c3a30125ded3ea33af40e2284d4bbb
Reviewed-on: https://gerrit.libreoffice.org/27851Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Ibcd9bae59b1722aaf744211a880d118a0162710f
Reviewed-on: https://gerrit.libreoffice.org/27803Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: I3cfcab9eb21107823f256dc2c30afd75c2531ab6
Reviewed-on: https://gerrit.libreoffice.org/27911Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Ia8b5cdc375a770a241c3fb5c4e9522b604bf96af
Reviewed-on: https://gerrit.libreoffice.org/27910Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Change-Id: Id15ec960cd64704faa89498f1935a780bdd714e5
Reviewed-on: https://gerrit.libreoffice.org/27909Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>