Change-Id: I6d44335ab51c92dc605ee341efaaa4bf6f7bd42f
Reviewed-on: https://gerrit.libreoffice.org/72587
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I23a6d485ee1ca0bc3801bcc1a6d748b8ed2b490c
Reviewed-on: https://gerrit.libreoffice.org/72634
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I677c3b184e225c3bac1c56efd5ea46aaa2497d69
Reviewed-on: https://gerrit.libreoffice.org/72810
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Property "PickListEntry" is available since LO 5.1 but not
mentioned in css.document.MediaDescriptor.
original change has been committed with tdf#95095.

Change-Id: I684e4c76f79c9646af3cac9670790d2b2c3eca97
Reviewed-on: https://gerrit.libreoffice.org/72553
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

This is for COLEAT's internal use.

Change-Id: If1ac2a5b251129e4431d3c0bde82529d6bdc7ccc
Reviewed-on: https://gerrit.libreoffice.org/72809
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

The page handling implementation is a little bit tricky, because
the elemnt list is not handled like a grid but a list. Normally
one would keep the horizontal cell and just scroll vertically.
Instead this implements a kind of circle.

Vertical offset is consistet, so you have the same amount of
steps for up and down, but up runs left and down runs right.

Change-Id: I296a46e98f7e00a59fd0a0ba358c981b49ac86cd
Reviewed-on: https://gerrit.libreoffice.org/72793
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

This adds arrows + home + end key navigation.

The grid is handled like a list. For convenience Left + Up
and Right + Down keys work in the same way.

Change-Id: I757184e5161f2c7ac9b241294a5edc304c882497
Reviewed-on: https://gerrit.libreoffice.org/72792
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Just implements Move the same way then Resize. More importantly
the patch correctly resets the Thumb and Page rectangles to
position (0,0) instead of just Empty, which ImplCalc is based on.

Otherwise this results in broken scroll bars, when the StarMath
elements window is docked in in the bottom or top area and
switches the scrolling orientation on undock.

Change-Id: I32b0507cdd6551cc7f42655a730faf8ef25b747b
Reviewed-on: https://gerrit.libreoffice.org/72794
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Switches the ScrollBar to horizontal in vertical mode and
adapts the scrolling.

Change-Id: I35370d74175ccd1f117b17f7d7ffa25119f2e612
Reviewed-on: https://gerrit.libreoffice.org/72791
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Moves duplicate code from ImplInitSettings and ApplySettings into
their own functions.

Change-Id: I65b5a052b171a661ee22762e373745c28779a9e9
Reviewed-on: https://gerrit.libreoffice.org/72790
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Replaces some code with calls to ApplyControlForeground and
ApplyControlFont.

Change-Id: I16837ad7c48ed46fa48b1f2a33a84c7e94f63482
Reviewed-on: https://gerrit.libreoffice.org/72789
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

TextEngine::SetFont copies the font parameter and then modifies
its color, transparency, fill color and alignment, so passing the
same font again will not be detected as the same font.

Therefore this patch stores the original font in addition to the
modified one and also returns that one on the GetFont call.

This allows us to merge the font setup in VclMultiLineEdit's
ImplInitSettings and ApplySettings into a common function.

Change-Id: I618d283ecd0ae14faf9b87a3aceec6ca1c37b526
Reviewed-on: https://gerrit.libreoffice.org/72788
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: I221b7ae202d6dbd08d0496561652b2471b093b46
Reviewed-on: https://gerrit.libreoffice.org/72783Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>

Regression from commit 458a827e (further
refactor Menu to use RenderContext, 2015-05-15), the problem was that
this highlight on the menu bar on mouse move was only part of the
incremental paint, never the full paint.

So when that commit removed incremental paint, we lost highlight on
mouse move (move only, click is there).

Later commit 843b9d5d (VCL add support
for rollover menubars, 2016-09-22) added this code back, conditionally
for the case when there is not enough space for the menu bar
horizontally.

So fix the lack of highlight on plain mouse move by unconditionally
highlighting the rolled over item, even if there is enough horizontal
space.

Change-Id: I357001f2e65f843444ed0ffbe470667dfc5d5aa3
Reviewed-on: https://gerrit.libreoffice.org/72774Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: I2080f3c04a04cea626d4969b59e54612cbefe03b
Reviewed-on: https://gerrit.libreoffice.org/72780Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>

Change-Id: I3ea246c84bb81e4eca9fe569edb957bed3c788ee
Reviewed-on: https://gerrit.libreoffice.org/72674
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

...following up on 1453c2c8 "prefer vector::data
to &vector[0]"

Change-Id: I7c113747d92d144a521d49b89384dd8bf1215c01
Reviewed-on: https://gerrit.libreoffice.org/72765
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...to avoid the upcoming loplugin:data asking to replace just each initial
&aAttrs[0] with aAttrs.begin() and leave the remaining &aAttrs[N] alone, which
would make the results look odd.

Change-Id: I7d5c76e9d4fc6c7fa13cb28fca5ea65ea2d0f77e
Reviewed-on: https://gerrit.libreoffice.org/72764
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...to avoid the upcoming loplugin:data asking to replace just the initial
&aStrs[0] with aStrs.begin() and leave the rest alone, which would make the
result look odd.

Change-Id: I37a86fc494c47afc56de041f3d803356fb97317d
Reviewed-on: https://gerrit.libreoffice.org/72762
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: If7a5e779716e9423e94c22d11fc0f029fb89401f
Reviewed-on: https://gerrit.libreoffice.org/72754
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Regression from
https://cgit.freedesktop.org/libreoffice/core/commit/?id=3208fcb3a36d75d6290d9c548430682f153b09db

Change-Id: I8f85f0a5838df87671ecb9bdb5751b7ec43c09ea
Reviewed-on: https://gerrit.libreoffice.org/72701
Tested-by: Jenkins
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>

Fixes CVE-2019-5435. It looks like this is not a problem on 32-bit
Windows because fortunately we don't use /LARGEADDRESSAWARE flag
to set IMAGE_FILE_LARGE_ADDRESS_AWARE... but on 32-bit Linux
the user-space VM is 3GB so an exploit might be possible.

Apparently there's no code in LO that uses the CURLU_URLENCODE flag.

The other one, CVE-2019-5436, doesn't matter because we disable tftp.

Change-Id: I0d4f087befa5a3c4fb21ec36761dad68932425d9
Reviewed-on: https://gerrit.libreoffice.org/72732
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

...which causes asserts to fire since <https://github.com/llvm/llvm-project/
commit/04323c24a1ac9464471331d9f6499d3cb95d1ccd> "Added an assertion to constant
evaluation enty points that prohibits …"

Change-Id: Iafbf1cea85d15a38a71275d4cea8303bab500f6a
Reviewed-on: https://gerrit.libreoffice.org/72723
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

It doesn't correctly make a dependency on the .gch or anything
the .gch is made from, so there would be stale cache hits even
if anything included from the .gch changed. Disable CCACHE_DEPEND.
https://github.com/ccache/ccache/pull/427

Change-Id: I6929ff6ec1f1e50498033cdf95b56c94522166eb
Reviewed-on: https://gerrit.libreoffice.org/72704
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

With just -include a.hxx ccache checks only for presence of a.hxx.gch
and it doesn't search the path given by -I, so it didn't detect the usage
of the .gch and thus didn't include it in the checksum, possibly leading
to false positives. Icecream similarly doesn't search paths given by -I
and may fail to properly handle the .gch usage.

Change-Id: I40ba2d5089e77cd5e8da670c7e030f9e90ebc8ac
Reviewed-on: https://gerrit.libreoffice.org/72703
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Enable the gtk3_kde5 and kde5 VCL plugins as discussed
in ESC all of 2019-05-02.
Also drop the "--disable-gtk3" switch so gtk3 is built
as well (which is enabled by default).

Change-Id: I65230255f8db6a7de992c6f5e9f9892a72436349
Reviewed-on: https://gerrit.libreoffice.org/71865
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

There's pretty much the same code in CanvasHelper::fillTexturedPolyPolygon()
that has received various fixes over the time, but this code not, so
fix it as well.

Change-Id: I7293d4d67dff2d5276928bb3ab25adfb883ce3ca
Reviewed-on: https://gerrit.libreoffice.org/72700
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Change-Id: If99c008f40c20ba97b0abd1203b7e89378cd7095
Reviewed-on: https://gerrit.libreoffice.org/72731
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

See <https://gerrit.libreoffice.org/#/c/67754/3> for discussion, the
stability of this test has to be improved before it can be enabled
again.

Change-Id: Iae7d16c7a6c3659de132e2d64ca43865081b3c9b
Reviewed-on: https://gerrit.libreoffice.org/72724Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: I8d5bb318674311b1e21c6fdf487d69609af344a5
Reviewed-on: https://gerrit.libreoffice.org/72686
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

The problem here is that we never actually hit the maExportGraphics
cache in SvXMLGraphicHelper, even though we are passing the same image
down repeatedly.

There are two bugs here:

(1) BitmapEx::operator== does not return true if we instantiate 2
Graphic objects from the same XGraphic, so change it to use the more
expensive operator==. To mitigate the cost, move the expensive checks to
the bottom of the method.

(2) in order to use an object in std::unordered_map, the object must
implement an equality function and a hash function. If two objects are
equal THEY MUST have the same hash value. Using the Impl* as the hash
value does not satisfy that condition, so rather use the checksum, which
does.

After these fixes, the save time drops to less than a second.

Also make the checksum method look more like the operator== method,
and add a checksum calculation method for SVG data that more accurately
reflects the underlying SVG data.

Change-Id: I4ca0c7bee60b2efa6fe42301e582c7b278022b46
Reviewed-on: https://gerrit.libreoffice.org/72615
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ib7e1d0f7483aa8b5cab320278714f2d5f36fdbd9
Reviewed-on: https://gerrit.libreoffice.org/72534
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I7e45e30f8e316c49d1fe2311baf82a5729905a3c
Reviewed-on: https://gerrit.libreoffice.org/72702
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

by considering the axis direction.

Note: Legend name order in left/right position was fixed in
commit 40144617

Change-Id: Id5bd585a666c3bcf346af5317e9197e6460f932a
Reviewed-on: https://gerrit.libreoffice.org/72670Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>

and endnotes by creating redline data for their anchors, too.

Now footnote/endnote insertions are visible, and it's possible
to reject them.

Change-Id: I5cd3300c0d423b8c6803b7aeb848dcc103c3b565
Reviewed-on: https://gerrit.libreoffice.org/72680
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Change-Id: I3bb52201d523fd1c97315c99ce58e4473f971a12
Reviewed-on: https://gerrit.libreoffice.org/72699
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I8d0eb79c1848714c637d05064b6aae5140843c20
Reviewed-on: https://gerrit.libreoffice.org/72707
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I88e2a10836ae961764d899b8d74fd707a3e15b2c
Reviewed-on: https://gerrit.libreoffice.org/72708
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I97909d9d6ece176f519318ebb53b4cdfeeba9146
Reviewed-on: https://gerrit.libreoffice.org/72709
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I257313aa1744f8c70ea9888cd19adde149c1ce64
Reviewed-on: https://gerrit.libreoffice.org/72716Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>