a) subStr is not ours to delete, belongs to the OString
b) and anyway subStr points to the buffer of the out-of-scope temporary OString

Change-Id: I1689c6626c52ae9d94e0cfa5de4235be3c1f3262

Change-Id: Ia400ca7fdd2728e4fa12b96ace75ba1d5b7231f2

Change-Id: I1c15003acfb4d1c49c990a247629c70c4dcc3bd3

It was never integrated and used. If we made the effort to integrate it,
Windows installer would be a few megabytes smaller, because indexes of
thesauri would be generated in install time (instead of packaging
pre-generated indexes).

However, the cons are:
* untested
* presumably slows down instal process which is slow already
* adds complexity to installer which is too complex already
* indexes will not be there in case of administrative install (QA)
* bad experiences with CustomActions that manipulate the installed
  application (various, weird permission problems)

Change-Id: I3989b835b1250718bc03107a3807d091e7a9aa0e

This makes it possible to turn the bitmap background of a Writer frame
into a gradient one.

Change-Id: Iae88793d40593a2adbcc7f83e82e28265cdd9be7

This makes it possible to turn off the gradient background of a Writer
frame.

Change-Id: Ic7bdfec252847f463da47c838c7de0fdb7625869

Change-Id: Id40bdd821308b18a49630c15b1e28c004d7311ed

Change-Id: I52cda360116b719bf05776e01bf3d15303eea97d

Change-Id: I5b4b839b930c294bee6727402dbc47efee7fbcd7

This reverts commit fc65a66d.

Throw in crash reporter as a bonus.

Change-Id: Ia1eccd4a3948b3c6d361b341599c7f565cd74cfb

Change-Id: I8c8ed2db29d1175ba2187509482cdaf858ed660c

Change-Id: I47b527ad6e68dba83ebb253bcc55a2717c7dd0ca

Change-Id: I7dc5b189e98a0351bac0eab28c1161b5893f5ef1

Change-Id: Ibb0b1808532622ffb2dfc55d533428f6d72b890c

Change-Id: I6b2c51c57a98046e30b2782dd2565ee02345379d

plus German comments were translated

Change-Id: Id9ff5d4835e4ea224c9e6232a1762822aa833d37

Change-Id: I99a66ac3af8e391b5feaeafbb3abd63dcdd2bb2b

Change-Id: Id47172d0386e7aa28d82178f04b5f626f0c441fe

Project: help  4d7b72491649f33d115f687f5deee58bd9619ca4

git hooks used to be set by virtue of calling ./g clone
but recent changes means that ./g is not always called
these day, so it is possible to end-up with no hooks.

Change-Id: I630066ee0e2961b93ddfbf177eb4e5fc09505911

Change-Id: I48b95c6c0cbfb2f4c4b09cc90b254b96de40b3e9

So yeah, need to keep this feature. Spell Wi-Fi correctly, and mention Wi-Fi
in the menu button.

Change-Id: I4cd6f0689a6ff9647f355d4b1404be84ec0c0138

Why "Choose a Computer" but "Add Server"? Let's always call them "computers"
in the UI.

And in fact I think the feature to add a computer manually is kinda pointless;
is it too much to ask people to have their machines discoverable? I doubt
keeping a computer not discoverable through Bluetooth thwarts a determined
attacker from finding it anyway. (I am not saying that just finding it would
mean compromising it.)

Change-Id: Ib8041a8a793d84bee24587adac582c5fad03d1be

Change-Id: I4e912cab7ab252ef4c118fe63b02931eecd986aa

Cell validation is stored as cell attributes which are stored with
columns not with cells.  When HasSpecialContent() is true, it flags
the *cell* not empty, which in turns causes AddTextAndValueCell to
iterate over every single cell position for all repeated columns
and rows.  That can very very slow when the number of repeated rows
is very high.

Since cell validation is stored with columns, skipping empty cells
even when they have cell validation settings set won't cause any
issues, and all cell validation settings are imported correctly even
after this change.

With the test document I have (confidential), this change alone reduces
the load time from 30 seconds to 0.3 seconds.

Change-Id: I84fa4cec50172ccd02eca1042c8fafb93d1cfc73

This fixes connecting to one computer after connecting to another failed.

Change-Id: I5b13d186d32690a91e4290c81c8d2e12a0a1f2be

The latestInstance lifecycle and mName initialisation was borked.

Change-Id: If7ef8a15fdc297e0fe6e401399a3b94dcd8d08c5

Change-Id: Ife81ec74b36f71782997219e36ac926ea429c297

Change-Id: I3d515fabc272e5c14f2e2779da1c43f92514f290

Change-Id: I05d4b62a32a44a7d174d7fa19f7814d45dab22b2

The existing code in refreshLists() was somewhat hard to understand, and it
actually crashed (if uncommented-out). Now it simply empties the maps and view
lists and then rebuilds them.

The visible end result, at least for me, is that I no longer get duplicate
servers in the list...

Change-Id: I1543292e219e666e7dcbc68473f40a11e2eb3381

These files are Java, not C++. Add empty line before the vim mode line.

Change-Id: Ia94d18e9995ecfbbbfd1c9e6a4d2ce4e8ffb95f3

After 5adefb21 the "computer" names on the
main ("Choose a Computer") dialog (which probably isn't the right term) were
invisible for me on my Android 4.1 device at least. Very light grey on white,
or something like that. Let's try with default colours and then if that
doesn't work *slowly* modify the colours one item by one.

Change-Id: I9ae2ee8232cfa85eee4aba0fbcf69b8c245a1ad6

Change-Id: I314066086827d283938c6f402733da3f801ad55b

Change-Id: I8609949377181f8edb30ac07b2791cfcd079fc7d