- 15 Mar, 2019 12 kayıt (commit)
-
-
Michael Meeks yazdı
Unfortunately we still have large amounts of global state, and key event handling in some corners requires this in addition to the window. Change-Id: Id817030536f9cb45dbc39551dfb5332fc6998c62 Reviewed-on: https://gerrit.libreoffice.org/69266 Tested-by: Jenkins Reviewed-by:
Michael Meeks <michael.meeks@collabora.com>
-
Stephan Bergmann yazdı
...and no longer signed ptrdiff_t (which now caused -Werror,-Wsign-compare here) Change-Id: I48234d9cc4c35583e3268441dcc21a03fab3e856 Reviewed-on: https://gerrit.libreoffice.org/69306 Tested-by: Jenkins Reviewed-by:
Stephan Bergmann <sbergman@redhat.com>
-
Stephan Bergmann yazdı
Change-Id: Id694376160986b74ef2bf6cacdd96c13669d5c32 Reviewed-on: https://gerrit.libreoffice.org/69291 Tested-by: Jenkins Reviewed-by:
Stephan Bergmann <sbergman@redhat.com>
-
Eike Rathke yazdı
Change-Id: I3e5a5334dfe11002b526f942463626b62efbc340 Reviewed-on: https://gerrit.libreoffice.org/69303Reviewed-by:
Eike Rathke <erack@redhat.com> Tested-by: Jenkins
-
Noel Grandin yazdı
/home/noel/libo/desktop/source/lib/init.cxx:3571:22: error: rewrite call of 'rtl::operator==' with empty string constant argument as call of 'rtl::OUString::isEmpty' [loplugin:stringconstant] if (aHeaders == "") Change-Id: If0d8c411c6dd563622a855e209c0a5692c222abe
-
Noel Grandin yazdı
Create a new script to scan our codebase for holes in our structures. Implemented a couple of the things I found ScSortKeyState 12bytes -> 8bytes sc::MultiDataCellState 12bytes -> 8bytes Change-Id: I139dda36aedf02b7f19be121eb312e5552142b87
-
Tor Lillqvist yazdı
If the caller receives a pointer to an empty C string, it will send the message "commandvalues: " to the JavaScript bits. That will cause an exception as it expects JSON after the commandvalues: keyword. Instead return a nullptr. The caller is prepared to handle that. Change-Id: Ia1efa967668ba518993edb7945f064758b660b96
-
Caolán McNamara yazdı
Change-Id: Ibaf0962e3d150c67f951e1b20c0e72aacfc7ea78 Reviewed-on: https://gerrit.libreoffice.org/69284 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: Ic2782ed51cfb7dea25a455843eb749abd70e53a4 Reviewed-on: https://gerrit.libreoffice.org/69283Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: Ifdd794ae97eac3885c828f7610135b60ce7b3b7d Reviewed-on: https://gerrit.libreoffice.org/69282Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
refactor the mega-widget dnd drop target to be reused at mini-widget level and weld SwInsertBookmarkDlg Change-Id: I3f36e1cd902ecf166e369d0a05902d3df2b4f791 Reviewed-on: https://gerrit.libreoffice.org/69274 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com>
-
Rizal Muttaqin yazdı
Change-Id: I5deaa2276127548b6f5f127b65120300d11dbac9 Reviewed-on: https://gerrit.libreoffice.org/69181 Tested-by: Jenkins Reviewed-by:
Rizal Muttaqin <riz_17_oke@yahoo.co.id>
-
- 14 Mar, 2019 28 kayıt (commit)
-
-
Ilmari Lauhakangas yazdı
* Update helpcontent2 from branch 'master' - Header and donation CSS tweaks Change-Id: I20e5610c08db700e12baffa9b62dcf8dfd0c4328 Reviewed-on: https://gerrit.libreoffice.org/69278Reviewed-by:
Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by:
Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
-
Matteo Casalin yazdı
Change-Id: I0ed7bbd66f220ac28ad25ed301a50054c4c47008 Reviewed-on: https://gerrit.libreoffice.org/69247 Tested-by: Jenkins Reviewed-by:
Matteo Casalin <matteo.casalin@yahoo.com>
-
Matteo Casalin yazdı
Change-Id: I155996a0504e39b11afd1b2e0f2472f6c1830a1e Reviewed-on: https://gerrit.libreoffice.org/69245 Tested-by: Jenkins Reviewed-by:
Matteo Casalin <matteo.casalin@yahoo.com>
-
Matteo Casalin yazdı
Change-Id: Ice39b95ed5bb77a4989c838b51992c80ef37756f Reviewed-on: https://gerrit.libreoffice.org/69244 Tested-by: Jenkins Reviewed-by:
Matteo Casalin <matteo.casalin@yahoo.com>
-
Matteo Casalin yazdı
Change-Id: Ib13f279fd764538deb77b3ee871e58baf8676be2 Reviewed-on: https://gerrit.libreoffice.org/69242 Tested-by: Jenkins Reviewed-by:
Matteo Casalin <matteo.casalin@yahoo.com>
-
Matteo Casalin yazdı
Change-Id: Ie6a69f8d7630fefd18404c7a93e2d38bd06e3d16 Reviewed-on: https://gerrit.libreoffice.org/69238 Tested-by: Jenkins Reviewed-by:
Matteo Casalin <matteo.casalin@yahoo.com>
-
Miklos Vajna yazdı
WW8Glossary::Load() does the same for the DOC autotext import. Old cost for a document with 2508 document parts: 843842 ms. New cost for the same document: 46572 ms (5% of baseline). Change-Id: If0ff183315cb7465dd2b32c1a4fc856b50611265 Reviewed-on: https://gerrit.libreoffice.org/69271Reviewed-by:
Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
-
Gabor Kelemen yazdı
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I78b0aa6cfc2523c897cf22efe25c2bc431b2b026 Reviewed-on: https://gerrit.libreoffice.org/68968 Tested-by: Jenkins Reviewed-by:
Miklos Vajna <vmiklos@collabora.com>
-
Zdeněk Crhonek yazdı
Change-Id: Ic68ef7b0ef8d67fbbdfa233fa60a9b6a0511895a Reviewed-on: https://gerrit.libreoffice.org/69277 Tested-by: Jenkins Reviewed-by:
Zdenek Crhonek <zcrhonek@gmail.com>
-
Matteo Casalin yazdı
This would lead to always false condition, since that text should be uppercase. Introduced in d210c6cc. Reduce parentheses while at it. Change-Id: Iec9cbbfd0a596ad1d4dcba50aa3a5c00a54ef425 Reviewed-on: https://gerrit.libreoffice.org/69234 Tested-by: Jenkins Reviewed-by:
Matteo Casalin <matteo.casalin@yahoo.com>
-
David Vogt yazdı
In old versions of LO/AOO, separator style was defaulting to a solid line. When you have an old document that doesn't have the style set explicitly, the line would disappear. Since newer versions explicitly set the style, we should set the default to what it was before. Change-Id: I8dacea75fcf2f95f9bc145442b22ab0d173e7c5a Reviewed-on: https://gerrit.libreoffice.org/69167 Tested-by: Jenkins Reviewed-by:
Miklos Vajna <vmiklos@collabora.com>
-
heiko tietze yazdı
Some changes to the ui file (GtkGrid, alignment, radio buttons), setChoiceRadiosControlOpt() instead of *list Labels adjusted accordingly Patch partially reverts I62bd9affc9e065d7afcc60296a72eae4612b0ddd Change-Id: Ia06b8f2513d98fbdb1971477cf7b7127595d338c Reviewed-on: https://gerrit.libreoffice.org/68846 Tested-by: Jenkins Reviewed-by:
Heiko Tietze <tietze.heiko@gmail.com>
-
Olivier Hallot yazdı
* Update helpcontent2 from branch 'master' - tdf#124066, tdf#114263 BASIC Replace function Help with kind help of Gerhard Weydt (tdf#124066) Change-Id: I856c8ff600774bec82daafdef63ea8cca15b5097 Reviewed-on: https://gerrit.libreoffice.org/69255 Tested-by: Jenkins Reviewed-by:
Olivier Hallot <olivier.hallot@libreoffice.org>
-
Tor Lillqvist yazdı
There are enough problems making the dialogs look and work sanely in the iOS app without the preview being placed completely wrongly and covering other controls. Note that I am not actually able to test this here in the master branch, as the iOS app does not work when built from the master branch of the online repo (and this master branch of core). The corresponding change to the cp-6.0 branch of core did work as expected (with the online bits of the app built from the collabora-online-4 branch). Change-Id: I383ae6b1fcacb41b20f97e17436aa26531e13c69
-
Tor Lillqvist yazdı
The bestmaxFrameSizeForScreenSize() function is full of magic numbers. (There originally, in OOo times, was a comment in there that said "fill in holy default values brought to us by product management" which says it all, really.) Those numbers have little or no relevance on iOS. Instead, make this function return the largest square that will fit on the display (square so that it will fit in either orientation, in case the device is rotated while a tunnelled dialog is displayed). And as a consequence the defaut font size on iOS can be bumped up a bit, to 10. Now the problematic dialogs look even better. Note that this is a cherry-pick from our vendor branch (cp-6.0). It hasn't actually been tested as the iOS app doesn't work at the moment if built from the master branches of online and core. Change-Id: I043d8f9947520adb04bd952ee49f9c7844a1fa8c
-
Tor Lillqvist yazdı
I suspected all the time that just one single-line change will be what is needed to make the dialogs look mostly sane. (Especially Format > Character... and Format > Paragraph...) No exotic hacks were needed after all, even though I experimented with more or less crazy ones for several days before I thought of changing this font size 14 to something smaller. The problem was apparently simply that with the larger default font, the dialog controls didn't fit properly in the space provided. Especially the four combo boxes on one line in the Font page were problematic. (It has three such lines of combo boxes.) Apparently the dialog machinery isn't especially good at reducing width of controls. The Size control shrunk to (almost?) zero width and was not visible, the Style control was too narrow to be usable, but the Language control was left as unnecessarily wide. Note that this is a cherry-pick from our vendor branch (cp-6.0). It hasn't actually been tested as the iOS app doesn't work at the moment if built from the master branches of online and core. (cherry picked from commit 96dce784) Change-Id: If5675856345be2ae502346e8c097ef04216e2986
-
Noel Grandin yazdı
Change-Id: I96de7fa324e3d2e3f0f133c93cf73776f4615ed3 Reviewed-on: https://gerrit.libreoffice.org/68134 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Grzegorz Araminowicz yazdı
before that there were imported two GroupShapes: - empty one with properties like id, name, InteropGrapBag - second one with actual shapes also fixed tests that relyed on that behaviour Change-Id: I2b94a53e21666b16725c4353448d75e916e4f9df Reviewed-on: https://gerrit.libreoffice.org/69252 Tested-by: Jenkins Reviewed-by:
Miklos Vajna <vmiklos@collabora.com>
-
Regina Henschel yazdı
The path coordinates were read as sal_Int16. But for a mso_sptArc shape the values are unsigned integer. I correct it for this shape type only, because I don't know, whether other places actually need sal_Int16. The change from 0xa504 to 0xa604 in the defaults means a change from 'ClockwiseArcTo' to 'ClockwiseArc' so that an implicit moveto is used, same as in VML command 'wr'. Change-Id: Ib9c594c15d5a97048595efd644a4a6e8774fcefd Reviewed-on: https://gerrit.libreoffice.org/68941 Tested-by: Jenkins Reviewed-by:
Regina Henschel <rb.henschel@t-online.de>
-
Jan-Marek Glogowski yazdı
If a task is still in the scheduler priority queue and its priority is changed, it won't be moved into the correct queue. We have to track the priority of the scheduled task, so we can warn the developer to fix the code and actually handle re-start correctly. Since we don't want to traverse the whole Scheduler queues on priority change (which sometimes get very long) to remove the wrong data item, we'll just invalidate it, if a priority change is detected. This also reverts commit d24b264c ("vcl opengl: avoid task priority warning on cursor blink"), which tried to avoid the warning, which was just half right and independent of the broken priority change handling. LO doesn't change priorities of scheduled tasks normally, so that bug didn't turn out to have much impact, I guess. Change-Id: I6e46b518a7c3532047c619c013bd8597f73ed7a6 Reviewed-on: https://gerrit.libreoffice.org/69249 Tested-by: Jenkins Reviewed-by:
Jan-Marek Glogowski <glogow@fbihome.de>
-
Caolán McNamara yazdı
Change-Id: I2d43c1fc65e8cfed1e252e1a16c37b907ec9f319 Reviewed-on: https://gerrit.libreoffice.org/69180 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com>
-
Mike Kaganski yazdı
.. after ed901c33 Change-Id: Icc38dcfbf59d3af8b1798064f241f9ce59f1732d Reviewed-on: https://gerrit.libreoffice.org/69256Reviewed-by:
Andras Timar <andras.timar@collabora.com> Tested-by:
Andras Timar <andras.timar@collabora.com>
-
Miklos Vajna yazdı
So that it's possible to do ad-hoc dumping from gdb with something like: print xMetaFile->dumpAsXml(0) Similar to how that already worked for SwDoc or SwFrame. Change-Id: I9cb884491f2a49afdb06179d8d54252101f37bb7 Reviewed-on: https://gerrit.libreoffice.org/69253Reviewed-by:
Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
-
Michael Meeks yazdı
A fairly pure re-factor, although adding disposed window checking to a number of sites with a warning. Moves the event emission helpers from VCL into SfxLokHelper: we're going to need more view / integration here next anyway. Removes lots of copy/paste horror. Change-Id: I279c11a1d8093b4feeeb6b7850f500806fff80dd Reviewed-on: https://gerrit.libreoffice.org/69218 Tested-by: Jenkins Reviewed-by:
Michael Meeks <michael.meeks@collabora.com>
-
Andrea Gelmini yazdı
Change-Id: I5bd2cc790c3bb81a3b5369ae25dc68664c030bf2 Reviewed-on: https://gerrit.libreoffice.org/69250 Tested-by: Jenkins Reviewed-by:
Julien Nabet <serval2412@yahoo.fr>
-
Caolán McNamara yazdı
Change-Id: I3c72b19f9c5343451164b5bd35dc79a3753e6a37 Reviewed-on: https://gerrit.libreoffice.org/69179 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
which is consistent with the calc format->cells->numbering page and solves the keyboard traversal problem here Change-Id: I90c0f4a380693af871bbd20912eafcf5ea259fc7 Reviewed-on: https://gerrit.libreoffice.org/69229Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com>
-
Miklos Vajna yazdı
All changes are about not assuming logical top is a lower y value than logical bottom, by going via the SwRectFnSet abstraction, which already does the right thing. Change-Id: I94a9881b018ad14b02e97425f60af01aa3fd9269 Reviewed-on: https://gerrit.libreoffice.org/69226 Tested-by: Jenkins Reviewed-by:
Miklos Vajna <vmiklos@collabora.com>
-