Kayıtlar (commit) · 64b4ed9de3852494416cdcb8c25d2e24fc4d0253 · LibreOffice / core

03 Tem, 2015 2 kayıt (commit)

tdf#92443 PushButton::ImplDrawPushButtonFrame: fix Invalidate() loop · 64b4ed9d

Miklos Vajna Tem 02, 2015 yazdı

Regression from commit 32a776c8
(Refactor Buttons to use RenderContext when painting, 2015-05-05), the
problem was that we started to call vcl::Window::SetSettings(), which
invokes Invalidate(), which should not happen, since we're in Paint().

Fix this by restoring the old behavior of calling
OutputDevice::SetSettings() directly again.

Change-Id: I57c8e7947764e8cdc2d144be2dd140d3c408255d
(cherry picked from commit b45040d1)

64b4ed9d

coverity#1309050 pLayout might be 0 here · 7fe52c31

Miklos Vajna Tem 02, 2015 yazdı

Change-Id: I5756c033e173faaba373c145b15a07e275453643
(cherry picked from commit ef46186b)

7fe52c31

02 Tem, 2015 10 kayıt (commit)

tdf#92262 - fixup shared_ptr -> VclPtr issue. · 50b93a18

Michael Meeks Tem 01, 2015 yazdı

Change-Id: Ia0b22e62001cff4a63ea197b77aebb1759f73122
Reviewed-on: https://gerrit.libreoffice.org/16664Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/16684Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

50b93a18

tdf#92434 - A series of hideous knock-on dbaccess crasher fixes. · 88b06253

Michael Meeks Tem 01, 2015 yazdı

Focus events during dispose, unfortunate incoming a11y events, etc.

Change-Id: Iee296b767839904f5f330786891bc2513ca06c0c
Reviewed-on: https://gerrit.libreoffice.org/16672Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/16686Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

88b06253

tdf#92434 - fix iteration, and remember to disposeAndClear. · f5721a9d

Michael Meeks Tem 01, 2015 yazdı

Change-Id: Id9c7b33689ea51a18394a96acbb9c08d67992942
Reviewed-on: https://gerrit.libreoffice.org/16671Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/16685Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

f5721a9d

tdf#92355 - use ScopedVclPtr as a replacement for in-line widgets. · a912d1f0

Michael Meeks Tem 01, 2015 yazdı

Change-Id: Iccabcf6df662c0c4814a4c4f20d690778799e049
Reviewed-on: https://gerrit.libreoffice.org/16683Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

a912d1f0

sw: avoid layout recursion when loading documents with charts... · d97f2ae3

Michael Stahl Haz 30, 2015 yazdı

... that have a Writer table as data source, such as ooo38798-1.sxw.

The problem is that during layouting, the SwWrtShell::CalcAndSetScale()
wants to call setVisualAreaSize() on the embedded chart object.

This switches the state of the object to RUNNING, which loads it from
the file, and during that the ODF filter calls into SwChartDataProvider
and that uses a UnoActionRemoveContext; unfortunately that ends all
pending Actions, so we get a recursive layout action.

Apparently the UnoActionRemoveContext is required to call
SwUnoTableCrsr::MakeBoxSels() for old-style tables, which need layout
frames for selection?!?

Try to avoid the problem by disabling UnoActionRemoveContext in case a
new-style table will be selected, which can be done without layout.

(cherry picked from commit b6cefd5e)

Conflicts:
	sw/source/core/unocore/unochart.cxx
	sw/source/core/unocore/unotbl.cxx

Change-Id: I097991ffb2e78ddf011db7575f7bb63ae8aa7005
Reviewed-on: https://gerrit.libreoffice.org/16617Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

d97f2ae3

fix a11y crash seen on moving chart wizard dialog · ea228fdf
Caolán McNamara Tem 02, 2015 yazdı
```
Change-Id: Ic3ba292e28fe12d7dcc2c2e67aeea48a4c8aaac2
(cherry picked from commit b161552b)
```
ea228fdf

Resolves: tdf#92467 crashes with empty history list on pressing down · a8ddd3b0

Caolán McNamara Tem 02, 2015 yazdı

regression from some 16->32 bit listbox limit changing

Change-Id: I045eeef935afed4154fe11bfd11916c2d6a722e9
(cherry picked from commit c51d5706)

a8ddd3b0

Assertions should tell the line number where the problem is · b0f8ade4

Tor Lillqvist Haz 18, 2015 yazdı

Let's not hide the assert() in a function whose sole purpose is to
call assert().

Change-Id: I7a8a04aad560b0f22398daabf12d00bbe58e89f1

b0f8ade4

SdrPaintWindow: no own buffer for rendercontext-enabled vcl::Windows · 08c6d3b1

Miklos Vajna Tem 01, 2015 yazdı

The buffered overlay manager paints using a timer, which is problematic
if the given vcl::Window already supports double-buffering itself, so
always use direct (to the rendercontext) painting in that case.

Change-Id: I93144c02814fd511f333224ab058374c7da369f0
(cherry picked from commit 25ade745)

08c6d3b1

vcl::Window::SupportsDoubleBuffering: respect VCL_DOUBLEBUFFERING_FORCE_ENABLE · be8bf4b6

Miklos Vajna Tem 01, 2015 yazdı

Double buffering default is false, then can be enabled on a per-widget
basis, finally this can be overriden at runtime by the
VCL_DOUBLEBUFFERING_FORCE_ENABLE environment variable (so that
everything is painted using double buffering).

Let SupportsDoubleBuffering() also respect this variable, so code
calling SupportsDoubleBuffering() can react to the runtime override,
too.

Change-Id: Ic9a1c00a801f6976069d7cfc47c3fa491ebc1ff0
(cherry picked from commit 7df3879d)

be8bf4b6

01 Tem, 2015 7 kayıt (commit)

gtk3: disable using notification that we are in the backdrop · 2b62e2ea
Caolán McNamara Tem 01, 2015 yazdı
```
Change-Id: I65a60acd956768f6a023c83053700803e5a8f1f2
(cherry picked from commit ff4b8d39)
```
2b62e2ea

Resolves: tdf#92461 fix font fallback in headless text renderer · 77552ecf

Caolán McNamara Tem 01, 2015 yazdı

This suggests that the GF_FONTSHIFT thing is very broken as
its level 0 for all the font renderers here, but follow
the working pattern for now

Change-Id: Ia180a40071157ead9a3b04c05658a6574dd5f864
(cherry picked from commit f4f84495)

77552ecf

tdf#92376 fix build of libetonyek on OS X · 045e3aa7

David Tardon Haz 28, 2015 yazdı

(cherry picked from commit a94acaba)

Change-Id: Ia4941184efb0cf6e84548f278e61e955a0b5b1f5
Reviewed-on: https://gerrit.libreoffice.org/16558Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

045e3aa7

tdf#92269 fix Windows Explorer crash caused by shellextension · 70c21ef0

Christian Lohmaier Tem 01, 2015 yazdı

wcscpy_s is buffer size, not string length, so size must also account
for a terminating NULL

Change-Id: Ie69692e47c142f3b733b093d0b87fa4bb03db7b4
(cherry picked from commit 2279f1f0)
Reviewed-on: https://gerrit.libreoffice.org/16653Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

70c21ef0

sw redercontext: fix missing draw of the overlay · 2fa23d10

Miklos Vajna Haz 30, 2015 yazdı

With this, if e.g. Ctrl-A is hit for a hello-world document, then
selection is properly visible.

Change-Id: If3fae1e73dc76c50e62f6e1f31d99873636f0e93
(cherry picked from commit a2c4bed5)

2fa23d10

sw rendercontext: update drawlayer in SwViewShell::Paint · f36eaa07

Miklos Vajna Haz 30, 2015 yazdı

Fixes warnings on startup like:

warn:legacy.osl:13026:1:svx/source/svdraw/svdpntv.cxx:813: SdrPaintView::UpdateDrawLayersRegion: No SdrPaintWindow (!)

when double buffering is enabled for SwEditWin.

Change-Id: I3dd8019a158b7d50c5e460abf504da31aabe72c3
(cherry picked from commit 82307b16)

f36eaa07

SwViewShell::DLPrePaint2: paint to mpOut if isOutputToWindow() · 6c59c767

Miklos Vajna Haz 30, 2015 yazdı

With this, most of the SwEditWin is painted to the virtual device in
case of double buffering, not directly to the screen (avoids
flickering).

Change-Id: If93aa082daaec6b0e2c417ebc7367e5ab601aa2c
(cherry picked from commit af9d02a2)

6c59c767

30 Haz, 2015 21 kayıt (commit)

gtk3: bizarro macosx default text area height calc infected gtk3 · 18d6d789

Caolán McNamara Haz 30, 2015 yazdı

mbNoFocusRects is also the case now for gtk3, but this unfortunate
heuristic makes the database and chart wizards and various other
things just way too tall. This is likely a desperate effort to
make pre layout dialogs size to something sensible

Change-Id: I501f04ad96063935dd1f162e009ffd5053a820c4
(cherry picked from commit 93b615d2)

18d6d789

only try gtk3 vclplug on >= 3.14 · 853cca09

Caolán McNamara Haz 30, 2015 yazdı

themeing has changed around quite a bit, and there's insufficient interest to
get older versions looking right

Change-Id: Ia2ee58d66c859e3bf00b54413fac1efb00d38dd3
(cherry picked from commit f82e6424)

853cca09

tdf#91641 adjust cursor when deleting preceding characters · 227e7f90

Justin Luth Haz 30, 2015 yazdı

IMDeleteSurrounding is used by input methods to take multiple
keystrokes and convert them into a special character.  Then the
composing keystrokes are removed.
Before this fix, the cursor placement was not adjusted,
so the special character was inserted in the wrong position
and if 3+ keystrokes were involved, the wrong characters were deleted.

Also fixes "editLine should have focus on accessibleText init."
The first time an accessibleEdit is created, it didnt recognize any
focused text when editing in the "Input Line".

Change-Id: I5be9b75f74d4df82fbd57da3817a626b5fcbeba1
Reviewed-on: https://gerrit.libreoffice.org/15961Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/16619

227e7f90

tdf#92426 explicitly set valid row/col for entire col/row references · 59487150

Eike Rathke Haz 30, 2015 yazdı

... for callers that individually check for them, like
ScRange::ParseAny()

Change-Id: I23fc2c178a9c89b59f99f2fb86223324b7e5d378
(cherry picked from commit 07cd14f1)

59487150

tdf#92386: Writer crashes in print preview if document in 2 windows · 41c328a9

Julien Nabet Haz 28, 2015 yazdı

2 changes for the 2 following bts
First bt: see https://bugs.documentfoundation.org/attachment.cgi?id=116883
Second bt: see https://bugs.documentfoundation.org/attachment.cgi?id=116888

Change-Id: I92ed3b7305bb5b714532f2dcffd615a8337db8b6
Reviewed-on: https://gerrit.libreoffice.org/16557Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit cb813b39)

41c328a9

Partially revert "svx, canvas, desktop: gb_OBJCXXFLAGS are not needed at all" · cb8e0034

Andras Timar Haz 29, 2015 yazdı

This reverts commit 601d7d38.

desktop and svx need these flags in case of OS X sandboxing

Change-Id: Ib811aa53bc2d71839961cdcea0dd4836ebdbc38c
(cherry picked from commit 57117cf5)
Reviewed-on: https://gerrit.libreoffice.org/16572Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

cb8e0034

Julien Nabet Haz 27, 2015 yazdı

0 0x00002aaaafaf3b0c in BrowseBox::DoShowCursor(char const*) (this=0x2f424e0) at /home/julien/compile-libreoffice/libreoffice/svtools/source/brwbox/brwbox1.cxx:182
1 0x00002aaaafafe392 in BrowseBox::GetFocus() (this=0x2f424e0) at /home/julien/compile-libreoffice/libreoffice/svtools/source/brwbox/brwbox1.cxx:2489
2 0x00002aaaafb27966 in svt::EditBrowseBox::GetFocus() (this=0x2f424e0) at /home/julien/compile-libreoffice/libreoffice/svtools/source/brwbox/editbrowsebox.cxx:237
3 0x00002aaab1b5706a in vcl::Window::CompatGetFocus() (this=0x2f424e0) at /home/julien/compile-libreoffice/libreoffice/vcl/source/window/window.cxx:3948
See https://bugs.documentfoundation.org/attachment.cgi?id=116859

Change-Id: I664884ee9333055707aecd7ad309c1a97596b71b
Reviewed-on: https://gerrit.libreoffice.org/16583Reviewed-by: Philippe Jung <phil.jung@free.fr>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

57eb9359

Julien Nabet Haz 25, 2015 yazdı

Missing "else" in front of the "if"
Regression from http://cgit.freedesktop.org/libreoffice/core/commit/?id=7b355da6853af6678c4ba22710d157cf8a6d43eb

Change-Id: I3c32e8f09acbea7094c4268384ec4b1c4e028fc5
Reviewed-on: https://gerrit.libreoffice.org/16497Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Deena Francis <deena.francis@gmail.com>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit 594ef250)
Reviewed-on: https://gerrit.libreoffice.org/16576Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

6a2c4efb

gtk3: re-enable when in backdrop and receive delete signal · 01bee1de
Caolán McNamara Haz 30, 2015 yazdı
```
Change-Id: I845a3eda41263a07e1e69eb6ff37ff5ab2576905
(cherry picked from commit 9ce8f735)
```
01bee1de
gtk3: detect if a new frame is just a tooltip · ff562991
Caolán McNamara Haz 30, 2015 yazdı
```
Change-Id: I906f53ca5428b51077b4ac28462c2e8827f2a31f
(cherry picked from commit f4305875)
```
ff562991
gtk3: draw disabled menubars entries with disabled text color · 88b336b8
Caolán McNamara Haz 30, 2015 yazdı
```
Change-Id: I9188c6071f62d13a688c1eb6b14b1ac3f7dc77d4
(cherry picked from commit 67d0aee9)
```
88b336b8
gtk3: listen to state-flags-changed and disable toplevels when in backdrop · 43f21855
Caolán McNamara Haz 30, 2015 yazdı
```
Change-Id: I173618b2e6a2ad69918da8b85ec0eef7099f1d3d
(cherry picked from commit 02b1e147)
```
43f21855

tdf#92427 entire column/row reference also if both sticky parts are relative · d2787cde

Eike Rathke Haz 30, 2015 yazdı

For example, convert A1:A1048576 to A:A but not A$1:A1048576 or
A1:A$1048576

Change-Id: I7845134f79a04f7c031896d515ea1cb8050bd454
(cherry picked from commit 0ccefa0c)

d2787cde

SwViewShell::ImplEndAction: avoid direct paint · cc12ac73

Miklos Vajna Haz 29, 2015 yazdı

Commit 56dd27d9 (sw: invalidate after
keypresses when we have a callback, 2015-01-13) only enabled
invalidate-then-paint for the tiled rendering case, because the main
loop had no priorities back then.

This limitation went away with 48c2815d
(tdf#91727 - Unwind non-dispatch of idle handlers., 2015-06-10), so it's
not a problem to always do this panting inside the Paint() call.

Change-Id: I98ddfcc0f20f1553974b74ec3c859dde315612e4
Reviewed-on: https://gerrit.libreoffice.org/16587Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit beb4aa21)

cc12ac73

SwViewShell::Paint: restore old render context at the end · b265e4e9

Miklos Vajna Haz 29, 2015 yazdı

The idea is that mpOut is only used for non-drawing purposes outside
Paint(), e.g. to do logic <-> pixel conversion.

Change-Id: Ia83cd32dd0a5152dcfc1644e92af08b4ddf4653c
Reviewed-on: https://gerrit.libreoffice.org/16584Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit 98d2d985)

b265e4e9

SwFrm::Calc: use vcl::RenderContext · 4a25cccd

Miklos Vajna Haz 29, 2015 yazdı

(cherry picked from commit 8527dfbd)

Conflicts:
	sw/source/core/layout/sectfrm.cxx
	sw/source/core/text/frmform.cxx
	sw/source/core/text/txtfrm.cxx

Change-Id: I98de3f5413756c494c677d592ea921155e4c08be

4a25cccd

coverity#1308430 pSh may be 0 here · 680514c0

Miklos Vajna Haz 29, 2015 yazdı

Change-Id: I2aaee946bdc5a22cf5a83e1e50714556260280f3
(cherry picked from commit 7192cb0f)

680514c0

SwFrm::PrepareMake: use vcl::RenderContext · dcc013ba
Miklos Vajna Haz 29, 2015 yazdı
```
Change-Id: I34306bb1622c79489eb647ed45f398ad2634c144
(cherry picked from commit ea1ea3b9)
```
dcc013ba

sw: outline SwFrm::Calc() · cd69dddc

Miklos Vajna Haz 29, 2015 yazdı

Change-Id: I9c59116828585c9645bc415ef5fffe65a24d09ee
(cherry picked from commit 533e9794)

cd69dddc

tdf#92438 fix regression in LibreLogo icon order · 620c0838

László Németh Haz 29, 2015 yazdı

Change-Id: I214f49ada17ddb350586426085d27290ad46ee61
Reviewed-on: https://gerrit.libreoffice.org/16603Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>

620c0838

more change in JNI func sigs between Java 6 and 7 workarounds · 25915907
Rene Engelhard Haz 29, 2015 yazdı
```
Change-Id: Ie9cbf1b6dfc79df3a74efd3b9bb31ce33e7be3a0
```
25915907