Change-Id: I4314ed8ecbfaf1435bc22688e9afb7b0b3bcbfd0

and

coverity#1424323 Uninitialized scalar field

Change-Id: I00855321a4099720b903553a46f45f6919f71880

Change-Id: Icce1317dc3ccfb598ce07ee61eddd873f1f98222
Reviewed-on: https://gerrit.libreoffice.org/45481Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ic06fb71c679e87069afda391e598d360b4b59cc2
Reviewed-on: https://gerrit.libreoffice.org/45516Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I90aed11ae0a29a0e9fc725b297e10a7ed30c9942
Reviewed-on: https://gerrit.libreoffice.org/45533Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: If85a78eb0d7f985872d95ae77a3d696a5f9d0f7a
Reviewed-on: https://gerrit.libreoffice.org/45545Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

... and SolarMutex: the problem is that rtl::StaticWithArg will
first lock the implicit mutex of the C++11 static variable, and
then the SolarMutex.

So if one thread creates the Desktop singleton with SolarMutex
locked and another thread without SolarMutex locked, this can
deadlock.

If we use rtl_Instance directly with SolarMutex, then there is
still a static variable, but the SolarMutex will always be locked
first, preventing this deadlock.

Change-Id: Ibd37fdfa96a4a2b57f661be3814dd597eb52d338
Reviewed-on: https://gerrit.libreoffice.org/45508Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>

...version "gcc (Ubuntu 6.3.0-12ubuntu2) 6.3.0 20170406" which reportedly
supports C++17 but doesn't know -Wregister

Change-Id: If8fd6f3c23ac26386fbc3ccd2df68d61d68ea793
Reviewed-on: https://gerrit.libreoffice.org/45509Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Iaddc79cee0c06f72f636a3d35959922fd78f4e20

...introduced with ba4a124b "Resolves:
tdf#114117 draw page shadow mangled"

Change-Id: I31573d55ae7e5ff015d4582de1d436cdc673acf1

It is expected that the commandline --convert-to switch gives mostly the
same result as save-as on the UI, but this was not the case for ODT, as
the convert-to case had no layout available.

As a result the explicit width of table columns or soft page-breaks were
missing from the export result in the convert-to case.

Given that Word formats already calculate the layout before export and
during crashtesting we already wait for the OnLayoutFinished even before
export, just enable calculating the layout before ODT export as well to
shrink the cmdline vs GUI differences.

[ No testcase: saving
writerperfect/qa/unit/data/writer/epubexport/table.fodt with the writer8
export filter would be a reproducer for this, but the test doesn't fail
without the fix even aftet not calling CalcLayot() via the
mustCalcLayoutOf() override, so I'm out of ideas right now how to test
this. ]

Change-Id: Ib05958e857f0a353b8740f2a87a6cf2f45f3c764
Reviewed-on: https://gerrit.libreoffice.org/45518Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I9188f4579900d7eec375754aa94d21ac4e8456e2
Reviewed-on: https://gerrit.libreoffice.org/45504Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Iebcd8688ec807aa61989b4622ea0d3eca5c4c671
Reviewed-on: https://gerrit.libreoffice.org/45478Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

...after 1fa761af "Ridiculously large delta for
SwarmSolverTest::testUnconstrained for now", to accommodate further Jenkins
lo_ubsan failures with actual values of 3.67055466470122
(<https://ci.libreoffice.org/job/lo_ubsan/741/console>) and 3.88389164367578
(<https://ci.libreoffice.org/job/lo_ubsan/743/console>).

Change-Id: Ibacb25ba82c2c279ef8dcd19c5ce7f6d5d8014d5
Reviewed-on: https://gerrit.libreoffice.org/45520Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

for some reason we're hitting more template AST nodes now? Anyhow,
updated singlevalfields and unusedenumconstants to cope.

For unusedfields, ignore field access inside Clone() methods, since it's
like a constructor.
Similarly for unusedmethods.

Change-Id: Icb2f76fb2f06ae5df21f9d75312e42a2800befb9
Reviewed-on: https://gerrit.libreoffice.org/45470Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: If2257d32fdd66703735466982e6913070ac1166d
Reviewed-on: https://gerrit.libreoffice.org/45402Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

...taking care not to warn about those cases that are used to silence Clang's
-Wunreachable-code

Change-Id: I3c1da907f51cc786f81c1322fe71d75832cd9191
Reviewed-on: https://gerrit.libreoffice.org/45521Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

If there are several separate conditional format elements that can be
represented as just one (with several ranges), try to do that.

A particular customer document used to take 3 minutes 20 seconds to
load, and it contained so many (tens of thousands) conditional formats
that the Format> Conditional Formatting> Manage... dialog was
practically impossible to use.

Now loading that document takes 15 seconds and there are just a
handful of separate conditional formats.

Also add a simple unit test to verify the deduplication.

Change-Id: I7c468af99956d4646ee5507390f1476caff52325
Reviewed-on: https://gerrit.libreoffice.org/45460Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Added sprms for Word 6 binary format; removed obsolete comments.

Change-Id: Iac88f8df9397f81586e39c1cf152c762be8f9aed
Reviewed-on: https://gerrit.libreoffice.org/45474Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I11177cd99a3d895c7ec94661fa677a0edfcdf9bf
Reviewed-on: https://gerrit.libreoffice.org/45536Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

not only Writer but also Calc, Impress, Draw and Math

Change-Id: I7f9fe86ffe5f9a812a5215617b9e673c73134202
Reviewed-on: https://gerrit.libreoffice.org/45472Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>

Tooltip and toolbar title renamed to 'Transformation'

Change-Id: I735d266c748fc41d4fd9913000c937a1011b787f
Reviewed-on: https://gerrit.libreoffice.org/45337Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: Id94586cc659a5e504c727c570dc9fc60c85c8820

Change-Id: I543818f6176b22226683be9cc6c459eda0e53183
Reviewed-on: https://gerrit.libreoffice.org/45501Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: Ied93745f924cbcbc674b5c9a78545aa1f79fc61e
Reviewed-on: https://gerrit.libreoffice.org/45513Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

when cairo had to stretch the 1 pixel dimension to fit the area.

When its this 1 pixel case set the same settings we use for the stipple effect
to get the expected interpolation

Change-Id: I42d87d6d01ebdb44083351a9632860f5f0a3bf63
Reviewed-on: https://gerrit.libreoffice.org/45511Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Project: help  ec6a05cc524a17ff090eaa7e506d7b5452ab227b

Fixed UX bugs

Clicking on tabs (Contents, Field, Index) now close the other ones
Set focus into seach field clicking in those tabs

Change-Id: I4b569aea86d4c5c441ce89dfa76f66844f0ebbc4
Reviewed-on: https://gerrit.libreoffice.org/44902Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Change-Id: Ie081f8144e50f576b9f8acb2ddd5b1c891533964
Reviewed-on: https://gerrit.libreoffice.org/45499Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

This runs fast enough that it can just be enabled.

Isn't allowed to break the build just yet due to the existing
GPG related problems.

Change-Id: I6f2ed3d7aeee9e7770940d96894ecdf4d0bf2d9b

In complex dialogs, they flood the lok client otherwise with duplicate
callbacks.

Change-Id: I6ab1ef12b90caed22dfc464e18068f5830cb9532

Change-Id: I1ceb806c6423964346c97d7b1ef6dcac46698902
Reviewed-on: https://gerrit.libreoffice.org/42882Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Sets the EPUBCoverImage filter data key at UNO level.

Change-Id: I46eb3c0df1e6c34af0be070c32f9f37666dc718e
Reviewed-on: https://gerrit.libreoffice.org/45485Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

If not set, fall back to the existing auto-find.

Change-Id: I5df7a535e4132a18a803c10fa0e06352d9b6b533

Change-Id: Ifeedad11c9a1c108e611160d089846cfc16b1e9e

Pick them up from <base directory>/<base name>.cover-image.<ext> as a
start.

Change-Id: Ie5ee7c02d6b3271e6e850ca9a2a10ed0bb4a598d
Reviewed-on: https://gerrit.libreoffice.org/45483Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

When it's only needed to be applied inside a dialog.

Change-Id: I7d61cfb49f80ab43511c9fc6cc6733a990dcae55
Reviewed-on: https://gerrit.libreoffice.org/45436Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: Ib7cd63351f4e5ed053e55fe9c5875ad92c81d762
Reviewed-on: https://gerrit.libreoffice.org/45490Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

fixes 3 CVEs

Change-Id: Idf5eee66fac399a2b338c2a9aaea2f56d2cb3a51
Reviewed-on: https://gerrit.libreoffice.org/45480Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

On the shadowtab page of a figure (eg. rectangle, ellipse) the widgets
that modify the shadow can now be selected using the tab button.
Removed an "invisible" alignment from the ui file that caused the problem.

Change-Id: Id833302d42b9c1f2df640135473f159c0a3af4f7
Reviewed-on: https://gerrit.libreoffice.org/45444Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Norbert points out that wait without arguments will wait for all
outstanding processes.

Change-Id: If850fd4a2e46a2c05d2917d38478ee2d3112bd78