- 17 Ara, 2018 23 kayıt (commit)
-
-
Michael Weghorn yazdı
This among others makes sure that the '-I'/'-isystem' compiler flags for the gtk3 includes end up in the 'INCLUDE' section in 'workdir/GbuildToJson/Library/libvclplug_gtk3lo.so' when that file is generated by 'gbuildtojson'. That file is used by 'gbuild-to-ide' to generate IDE-specific config files. Having the gtk3 headers in the 'INCLUDE' section makes sure that the includes are properly taken into account when generating the IDE-specific files, and the included files can thus actually be found. Also, there's no need to set '$$(INCLUDE)' via 'gb_Library_add_cxxflags', since the flags are already set via 'gb_Library_set_include', so drop the 'gb_Library_add_cxxflags' part altogether. Change-Id: Ibf198be9372ce2bec4c8a16d8530edf860733a57 Reviewed-on: https://gerrit.libreoffice.org/65207 Tested-by: Jenkins Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de>
-
andreas kainz yazdı
Change-Id: Ideebf1ed3dc0ed7db94873ffe28e6241f8b9e808 Reviewed-on: https://gerrit.libreoffice.org/65267 Tested-by: Jenkins Reviewed-by:
Heiko Tietze <tietze.heiko@gmail.com>
-
Vasily Melenchuk yazdı
Added support for content types for template and template with macros (.xltm, but no user interface for this yet). Fixed preferred extension for template: by default it is .xltx and not .xltm (macro-enabled), because MS Excel is very strict about matching of content-type and extension here. Fixed wrong namespace in FilterService for ExcelFilter. Change-Id: Ie717d31d72203601324860f069918d75082add4a Reviewed-on: https://gerrit.libreoffice.org/65111 Tested-by: Jenkins Reviewed-by:
Thorsten Behrens <Thorsten.Behrens@CIB.de>
-
Gabor Kelemen yazdı
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia155032426e02eb9ee64db3fb10946f5c9d445b7 Reviewed-on: https://gerrit.libreoffice.org/64832 Tested-by: Jenkins Reviewed-by:
Miklos Vajna <vmiklos@collabora.com>
-
László Németh yazdı
based on the OLE object size, instead of applying different scales for the bad (non-imported) VisibleArea settings. Change-Id: I3f246b779afd145fe260af83173c1944df21fb1a Reviewed-on: https://gerrit.libreoffice.org/65244 Tested-by: Jenkins Reviewed-by:
László Németh <nemeth@numbertext.org>
-
andreas kainz yazdı
Change-Id: I788e97ce1f6422ba95a478fb1618773c850764f5 Reviewed-on: https://gerrit.libreoffice.org/65262 Tested-by: Jenkins Reviewed-by:
andreas_kainz <kainz.a@gmail.com>
-
andreas kainz yazdı
and update some alignments Change-Id: I8d21e2764805e6b86fce776b7587d7bc0f76ae33 Reviewed-on: https://gerrit.libreoffice.org/65259 Tested-by: Jenkins Reviewed-by:
andreas_kainz <kainz.a@gmail.com>
-
Stephan Bergmann yazdı
...as flagged with -Werror=deprecated by trunk GCC in -std=c++2a mode. But C++17 forbids "this" in combination with a capture-default of "=", so in such cases list any entities explicitly that shall be captured by value. Change-Id: Ic228cd20682277a0f93e3e75798356d0fbbb80d4 Reviewed-on: https://gerrit.libreoffice.org/65241 Tested-by: Jenkins Reviewed-by:
Stephan Bergmann <sbergman@redhat.com>
-
Stephan Bergmann yazdı
Change-Id: I37112fdb971a60012a4cb4f1aebfbb79dda3f92e Reviewed-on: https://gerrit.libreoffice.org/65258 Tested-by: Jenkins Reviewed-by:
Stephan Bergmann <sbergman@redhat.com>
-
Samuel Mehrbrodt yazdı
Change-Id: Id6bb554c0e165c6d1f9c28c48fdbcd7156f42316 Reviewed-on: https://gerrit.libreoffice.org/65256Reviewed-by:
Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by:
Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
-
Justin Luth yazdı
cleanup of various nonsense that I ran across. Change-Id: Ib0a2f7bbe1096b36df88bf77de0eb90405c9f677 Reviewed-on: https://gerrit.libreoffice.org/65246 Tested-by: Jenkins Reviewed-by:
Justin Luth <justin_luth@sil.org>
-
Samuel Mehrbrodt yazdı
Change-Id: I25280099333a315dd6d6cae0d478287a96f45961 Reviewed-on: https://gerrit.libreoffice.org/65257Reviewed-by:
Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by:
Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
-
Mike Kaganski yazdı
Change-Id: I82d5e2ad7373fb9d39aa087426ea80ca4559b556 Reviewed-on: https://gerrit.libreoffice.org/65245 Tested-by: Jenkins Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com>
-
Olivier Hallot yazdı
* Update helpcontent2 from branch 'master' - Python: Remove wrong statement on modules. Change-Id: Ie8c8e9617807a27b2a152abaff0dbcafc03e9c2a Reviewed-on: https://gerrit.libreoffice.org/65255 Tested-by: Jenkins Reviewed-by:
Olivier Hallot <olivier.hallot@libreoffice.org>
-
sabri unal yazdı
* Update helpcontent2 from branch 'master' - Preview in fonts lists is corrected as Show preview of fonts Change-Id: Id2a2790a11ead2fc5bddb04536c0e7c2e6a11df8 Reviewed-on: https://gerrit.libreoffice.org/65235 Tested-by: Jenkins Reviewed-by:
Olivier Hallot <olivier.hallot@libreoffice.org>
-
Miklos Vajna yazdı
Change-Id: I000c534d1c9740dcb0dfbbe9fc71f18a503874f3 Reviewed-on: https://gerrit.libreoffice.org/65243Reviewed-by:
Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
-
Mike Kaganski yazdı
Change-Id: Ifb3cc0e62b88562fdf4050186b51a56316a15d07 Reviewed-on: https://gerrit.libreoffice.org/65240 Tested-by: Jenkins Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com>
-
Justin Luth yazdı
Paragraph justification can be specified either absolutely (in old versions or with eWW8:Jc80) or relatively (with eWW8:Jc). The last processed SPRM wins (I assume). The WW8 format seems to ALWAYS specify Jc80, and that is overwritten by an optional Jc SPRM. I haven't seen Jc be processed before a Jc80 SPRM, but if it does, then the justify would need to be treated as absolute. If for some reason neither of these exist, BiDi will adjust by default only if it is the newer WW8 format. Again, that is an assumption because I haven't seen such a document to test. Change-Id: I966077d743f1d148fe2fb9faba87fbdd8f3507f3 Reviewed-on: https://gerrit.libreoffice.org/63591 Tested-by: Jenkins Reviewed-by:
Justin Luth <justin_luth@sil.org> Reviewed-by:
Miklos Vajna <vmiklos@collabora.com>
-
Andrea Gelmini yazdı
Change-Id: I62306962317a4801b2f6a83a96fa3645e652e80f Reviewed-on: https://gerrit.libreoffice.org/65238Reviewed-by:
Julien Nabet <serval2412@yahoo.fr> Tested-by:
Julien Nabet <serval2412@yahoo.fr>
-
Andrea Gelmini yazdı
Change-Id: Ie0497c457d776304bbe972d75efea2da413fdaba Reviewed-on: https://gerrit.libreoffice.org/65236 Tested-by: Jenkins Reviewed-by:
Julien Nabet <serval2412@yahoo.fr>
-
andreas kainz yazdı
Change-Id: Ie0d85c41f4008ada7d90ea16d59c16fced0c22f9 Reviewed-on: https://gerrit.libreoffice.org/65233 Tested-by: Jenkins Reviewed-by:
andreas_kainz <kainz.a@gmail.com>
-
andreas kainz yazdı
Change-Id: I31908adeab72a16a5b82fbc3bc8ac3cce9ea4a4f Reviewed-on: https://gerrit.libreoffice.org/65218 Tested-by: Jenkins Reviewed-by:
andreas_kainz <kainz.a@gmail.com>
-
Mike Kaganski yazdı
On Windows 8.1, the one that is problematic to tell from Windows 10 (because the latter also exposes its version as 603 to the msiexec), the registry value doesn't exist at HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion but let's play safe and also check for "#6" value just in case. Reference: https://stackoverflow.com/questions/31072543/reliable-way-to-get-windows-version-from-registry Thanks to Mitchell <blazer64@gmail.com> for the idea! Change-Id: Ic907c4d992a7cb1d12e392686c19cd6fd6da3c7c Reviewed-on: https://gerrit.libreoffice.org/65231Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com> Tested-by:
Mike Kaganski <mike.kaganski@collabora.com>
-
- 16 Ara, 2018 15 kayıt (commit)
-
-
Caolán McNamara yazdı
e.g. MSVR-34956-mergedlo_utl_ConfigManager-PoC5.rtf Change-Id: I8bc7d7aa2a188b284750b22716009b835d27c669 Reviewed-on: https://gerrit.libreoffice.org/65229Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: I3b57bdd9a29ef41900bbb244daa27bf6d8c673c7 Error: comparison doesn't meet irreflexive requirements, assert(!(a < a)). Reviewed-on: https://gerrit.libreoffice.org/65228Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com>
-
Stephan Bergmann yazdı
...which had been removed completely with 6b847089 "graphite: update to 1.3.12". See <https://ci.libreoffice.org/job/lo_ubsan/1137/>: > /workdir/UnpackedTarball/graphite/src/gr_face.cpp:98:16: runtime error: downcast of address 0x60f00008c3b0 which does not point to an object of type 'gr_face' > 0x60f00008c3b0: note: object is of type 'graphite2::Face' > 2a 00 00 61 d0 17 e7 ff 99 2b 00 00 36 00 be be be be be be 88 d8 0e 00 d0 61 00 00 80 38 05 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'graphite2::Face' > #0 0x2b99fdaae105 in gr_make_face_with_ops /workdir/UnpackedTarball/graphite/src/gr_face.cpp:98:16 > #1 0x2b99fdaaeabe in gr_make_face /workdir/UnpackedTarball/graphite/src/gr_face.cpp:107:12 > #2 0x2b99fdfd6dc7 in _hb_graphite2_shaper_face_data_create /workdir/UnpackedTarball/harfbuzz/src/hb-graphite2.cc:114:18 > #3 0x2b99fdfd62f0 in hb_graphite2_shaper_face_data_ensure /workdir/UnpackedTarball/harfbuzz/src/hb-graphite2.cc:37:1 > #4 0x2b99fddb6a10 in hb_shape_plan_create_cached2 /workdir/UnpackedTarball/harfbuzz/src/./hb-shaper-list.hh:35:1 > #5 0x2b99fddb1478 in hb_shape_full /workdir/UnpackedTarball/harfbuzz/src/hb-shape.cc:133:33 > #6 0x2b99fc5867df in GenericSalLayout::LayoutText(ImplLayoutArgs&, SalLayoutGlyphs const*) /vcl/source/gdi/CommonSalLayout.cxx:440:23 > #7 0x2b99fb2345e4 in OutputDevice::ImplLayout(rtl::OUString const&, int, int, Point const&, long, long const*, SalLayoutFlags, vcl::TextLayoutCache const*, SalLayoutGlyphs const*) const /vcl/source/outdev/text.cxx:1310:36 > #8 0x2b99fb236220 in OutputDevice::GetTextArray(rtl::OUString const&, long*, int, int, vcl::TextLayoutCache const*, SalLayoutGlyphs const*) const /vcl/source/outdev/text.cxx:960:45 > #9 0x2b99fb235c56 in OutputDevice::GetTextWidth(rtl::OUString const&, int, int, vcl::TextLayoutCache const*, SalLayoutGlyphs const*) const /vcl/source/outdev/text.cxx:881:19 > #10 0x2b99fd105281 in ImplFontMetricData::ImplInitTextLineSize(OutputDevice const*) /vcl/source/font/fontmetric.cxx:325:30 > #11 0x2b99fb1c128c in OutputDevice::ImplNewFont() const /vcl/source/outdev/font.cxx:1062:38 > #12 0x2b99fb1bd46c in OutputDevice::GetFontFeatures(std::__debug::vector<vcl::font::Feature, std::allocator<vcl::font::Feature> >&) const /vcl/source/outdev/font.cxx:171:10 > #13 0x2b9a1a3c8607 in FontFeatureTest::testGetFontFeatures() /vcl/qa/cppunit/FontFeatureTest.cxx:58:5 > #14 0x2b9a1a401f2c in void std::__invoke_impl<void, void (FontFeatureTest::*&)(), FontFeatureTest*&>(std::__invoke_memfun_deref, void (FontFeatureTest::*&)(), FontFeatureTest*&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/invoke.h:73:14 > #15 0x2b9a1a401b0f in std::__invoke_result<void (FontFeatureTest::*&)(), FontFeatureTest*&>::type std::__invoke<void (FontFeatureTest::*&)(), FontFeatureTest*&>(void (FontFeatureTest::*&)(), FontFeatureTest*&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/invoke.h:95:14 > #16 0x2b9a1a40195c in void std::_Bind<void (FontFeatureTest::* (FontFeatureTest*))()>::__call<void, 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/functional:467:11 > #17 0x2b9a1a401533 in void std::_Bind<void (FontFeatureTest::* (FontFeatureTest*))()>::operator()<void>() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/functional:549:17 > #18 0x2b9a1a400340 in std::_Function_handler<void (), std::_Bind<void (FontFeatureTest::* (FontFeatureTest*))()> >::_M_invoke(std::_Any_data const&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/std_function.h:316:2 > #19 0x2b9a1a40259c in std::function<void ()>::operator()() const /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/std_function.h:706:14 > #20 0x2b9a1a3ff580 in CppUnit::TestCaller<FontFeatureTest>::runTest() /workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:175:7 > #21 0x2b99d930dab8 in CppUnit::TestCaseMethodFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5 > #22 0x2b99f39cf332 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /test/source/vclbootstrapprotector.cxx:49:14 > #23 0x2b99d92de5fa in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #24 0x2b99e850d672 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89:12 > #25 0x2b99d92de5fa in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #26 0x2b99e5130312 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63:16 > #27 0x2b99d92de5fa in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #28 0x2b99d9273d82 in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12 > #29 0x2b99d92de5fa in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #30 0x2b99d92d7f02 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86:18 > #31 0x2b99d93705e5 in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182:28 > #32 0x2b99d930c135 in CppUnit::TestCase::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:13 > #33 0x2b99d930ff12 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #34 0x2b99d930f0ed in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #35 0x2b99d930ff12 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #36 0x2b99d930f0ed in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #37 0x2b99d939eb32 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:27 > #38 0x2b99d936f075 in CppUnit::TestResult::runTest(CppUnit::Test*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149:9 > #39 0x2b99d939fa80 in CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:14 > #40 0x543813 in (anonymous namespace)::ProtectedFixtureFunctor::run() const /sal/cppunittester/cppunittester.cxx:316:20 > #41 0x54027d in sal_main() /sal/cppunittester/cppunittester.cxx:466:20 > #42 0x53f26e in main /sal/cppunittester/cppunittester.cxx:373:1 > #43 0x2b99daec8444 in __libc_start_main (/lib64/libc.so.6+0x22444) > #44 0x42f454 in _start (/workdir/LinkTarget/Executable/cppunittester+0x42f454) > > SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /workdir/UnpackedTarball/graphite/src/gr_face.cpp:98:16 in > > Error: a unit test failed, please do one of: > > make CppunitTest_vcl_fontfeature CPPUNITTRACE="gdb --args" > # for interactive debugging on Linux > make CppunitTest_vcl_fontfeature VALGRIND=memcheck > # for memory checking > make CppunitTest_vcl_fontfeature DEBUGCPPUNIT=TRUE > # for exception catching > > You can limit the execution to just one particular test by: > > make CPPUNIT_TEST_NAME="testXYZ" ...above mentioned params... > > /home/tdf/lode/jenkins/workspace/lo_ubsan/solenv/gbuild/CppunitTest.mk:113: recipe for target '/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/CppunitTest/vcl_fontfeature.test' failed Change-Id: Iccb72ec8a4c507478858ceb5af32b75f5ae53a45 Reviewed-on: https://gerrit.libreoffice.org/65226 Tested-by: Jenkins Reviewed-by:
Stephan Bergmann <sbergman@redhat.com>
-
Caolán McNamara yazdı
now that the double-decker monstrosity is in place Change-Id: I8bc8f98d0cfd2bf4506bbc61632c1e7b0f9cd3f1 Reviewed-on: https://gerrit.libreoffice.org/65181 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
Caolán McNamara <caolanm@redhat.com>
-
andreas kainz yazdı
Change-Id: Iac5a3144f9790457c2ccbe0fb916b66421443a6c Reviewed-on: https://gerrit.libreoffice.org/65216 Tested-by: Jenkins Reviewed-by:
andreas_kainz <kainz.a@gmail.com>
-
Julien Nabet yazdı
See bt from https://bugs.documentfoundation.org/attachment.cgi?id=147594 Change-Id: Ibf031b8024aa4952e2d3263a445cafdb3c031390 Reviewed-on: https://gerrit.libreoffice.org/65220 Tested-by: Jenkins Reviewed-by:
Julien Nabet <serval2412@yahoo.fr>
-
sabri unal yazdı
* Update dictionaries from branch 'master' - Related: tdf#121610 Do dictionary option titles Title Case Change-Id: I3ab12669bec1265ad06288a122661c5b77733e1b Reviewed-on: https://gerrit.libreoffice.org/64916Reviewed-by:
Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by:
Adolfo Jayme Barrientos <fitojb@ubuntu.com>
-
Stanislav Horacek yazdı
* Update helpcontent2 from branch 'master' - update description of customization dialogs Change-Id: I0d79cadf06f97e937c91908f5ffe7083c1a83291 Reviewed-on: https://gerrit.libreoffice.org/65205 Tested-by: Jenkins Reviewed-by:
Adolfo Jayme Barrientos <fitojb@ubuntu.com>
-
Sumit Chauhan yazdı
Bug solved , Changed the nTmp = 360+nTmp ,if nTmp <0. Change-Id: I855e634540c55ab91e8bbe5824014d304d87c8e9 Reviewed-on: https://gerrit.libreoffice.org/65211 Tested-by: Jenkins Reviewed-by:
Heiko Tietze <tietze.heiko@gmail.com>
-
Stephan Bergmann yazdı
(The unnecessary os.setstate(std::ios_base::failbit) was due to a misreading of C++17 [ostream.formatted.reqmts]/1.) Change-Id: I7d8285230cb316c7af45c76029e9629517d05d56 Reviewed-on: https://gerrit.libreoffice.org/65217 Tested-by: Jenkins Reviewed-by:
Stephan Bergmann <sbergman@redhat.com>
-
Roman Kuznetsov yazdı
Change-Id: I5d965f683520289c5f2466c5429c6fe8b574200a Reviewed-on: https://gerrit.libreoffice.org/65086 Tested-by: Jenkins Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com>
-
Mike Kaganski yazdı
This replaces commit 53058090. Now not only failure to start WU service, but also other errors during MSU installation won't break installation. E.g., running WU service as Guest does not prevent the service from starting; but installing updates fail, which makes previous solution incomplete. Instead, show a warning in those rare cases when an error happens, and continue. It will allow users to see the reason if they see "api-ms-win-*.dll missing" message later after installation. Of course, some small percentage of these warnings will be false, e.g. those on Windows 10. But those false messages must be really small minority, because only when (1) the installation fails (2) on a system with the component already present, such a message would be false. And it will not prevent the installation. This will not block unattended installations, since in those cases, MsiProcessMessage() will do nothing. Change-Id: I3a9e681e9d6701d092bd5c18bb4b68b4f77170f3 Reviewed-on: https://gerrit.libreoffice.org/64874 Tested-by: Jenkins Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com>
-
Zdeněk Crhonek yazdı
Change-Id: Id9dbd53f2902f484f9d1209953ff2ad58d77936c Reviewed-on: https://gerrit.libreoffice.org/65199 Tested-by: Jenkins Reviewed-by:
Zdenek Crhonek <zcrhonek@gmail.com>
-
Stanislav Horacek yazdı
* Update helpcontent2 from branch 'master' - fix small typo Change-Id: Ice019261f62cc4ade55ede48f492373877954d06 Reviewed-on: https://gerrit.libreoffice.org/65215 Tested-by: Jenkins Reviewed-by:
Julien Nabet <serval2412@yahoo.fr>
-
Michael Weghorn yazdı
Since 'XComponentContext' and 'DECL_STATIC_LINK' are used, add the corresponding includes. Otherwise a successful build depends on the header being included after other headers that make sure that compilation still works. An error could be provoked e.g. by moving the '#include <gtk/fpicker/SalGtkFilePicker.hxx>' in 'vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx' above all other existing includes. Change-Id: Ib23f8b714fb971238eab28a8d4d02414a0b13812 Reviewed-on: https://gerrit.libreoffice.org/65208 Tested-by: Jenkins Reviewed-by:
Michael Weghorn <m.weghorn@posteo.de>
-
- 15 Ara, 2018 2 kayıt (commit)
-
-
Andrea Gelmini yazdı
Change-Id: I846df107b450c966725bc1e516cec5989b8f4b08 Reviewed-on: https://gerrit.libreoffice.org/65193 Tested-by: Jenkins Reviewed-by:
Julien Nabet <serval2412@yahoo.fr>
-
Mike Kaganski yazdı
Previously, it used to use FindFirstFile on initial parts of UNC paths, and failed, failing the whole path. Change-Id: Ibc4442e28da17625676695070ed7ddba619f9082 Reviewed-on: https://gerrit.libreoffice.org/65191 Tested-by: Jenkins Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com>
-