1. 24 Şub, 2015 16 kayıt (commit)
    • Stephan Bergmann's avatar
      Avoid bad downcasts to VclBox · 6c7b85c2
      Stephan Bergmann yazdı
      At least in CppunitTest_smoektest there is a case where
      SystemWindow::setOptimalLayoutSize tries to downcast a VclGrid as a VclBox
      (stack top below), and that even appears to be unnecessary as the only place
      that requires the downcast is the Dialog::settingOptimalLayoutSize override.  So
      maybe it is guaranteed that GetWindow(WINDOW_FIRSTCHILD) is a VclBox if this is
      a Dialog, but need not be the case if this is not a Dialog?  Or the real bug is
      elsewhere...
      
      SystemWindow::setOptimalLayoutSize()
      SystemWindow::DoInitialLayout()
      FloatingWindow::StateChanged(StateChangedType)
      SfxFloatingWindow::StateChanged(StateChangedType)
      SmToolBoxWindow::StateChanged(StateChangedType)
      vcl::Window::ImplCallInitShow()
      vcl::Window::Show(bool, unsigned short)
      SfxChildWindow::Show(unsigned short)
      SfxWorkWindow::HidePopups_Impl(bool, bool, unsigned short)
      SfxDispatcher::DoActivate_Impl(bool, SfxViewFrame*)
      SfxViewFrame::DoActivate(bool, SfxViewFrame*)
      SfxApplication::SetViewFrame_Impl(SfxViewFrame*)
      SfxViewFrame::SetViewFrame(SfxViewFrame*)
      SfxViewFrame::MakeActive_Impl(bool)
      SfxBaseController::ConnectSfxFrame_Impl(SfxBaseController::ConnectSfxFrame)
      SfxBaseController::attachFrame(com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&)
      (anonymous namespace)::SfxFrameLoader_Impl::impl_createDocumentView(com::sun::star::uno::Reference<com::sun::star::frame::XModel2> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, comphelper::NamedValueCollection const&, rtl::OUString const&)
      (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&)
      framework::LoadEnv::impl_loadContent()
      framework::LoadEnv::startLoading()
      framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
      ...
      
      Change-Id: I786ad451fdf73eca22860695a614ee5b889a83cd
      6c7b85c2
    • Bjoern Michaelsen's avatar
      use by-ref iteration, omit pointless std::move() and add missing inline · 18a0d519
      Bjoern Michaelsen yazdı
      Change-Id: I45081f5f80c4a571af0abebd23a4fed6623498a0
      18a0d519
    • Stephan Bergmann's avatar
      Less casting · d05c7c62
      Stephan Bergmann yazdı
      Change-Id: I955d82d8dd7a6092feb1de03c7c6486125f30831
      d05c7c62
    • Tor Lillqvist's avatar
      tdf#84881: Bump MAX_SIGNATURE_CONTENT_LENGTH to 50000 for now · ca2d8786
      Tor Lillqvist yazdı
      Note that checks in the code against exceeding that limit apparently are
      broken, though. After the previous change I ended up with an invalid PDF where
      the signature hex string in the output PDF had brutally overrun its
      allocation.
      
      Now Adobe Reader says "The signature includes an embedded timestamp but it
      could not be verified". This is progress. Perhaps I just need to tell Adobe
      Reader to trust the certificate from the TSA I used.
      
      Change-Id: I1e8644ee641592a985e0190b52bf76839f99b3e7
      ca2d8786
    • Tor Lillqvist's avatar
      tdf#84881: Set TimeStampReq::certReq to true · 4702f6ae
      Tor Lillqvist yazdı
      I think Adobe Reader expects the timestamp info to include the TSA's
      certificate.
      
      Change-Id: Iedf1c4a9952b12ac61b4ba7f73bee339480e821d
      4702f6ae
    • Tor Lillqvist's avatar
      tdf#84881: Move some variables one block level out · 5ffeec96
      Tor Lillqvist yazdı
      It it scary to keep pointers to stack variables that have gone out of scope in
      a data structure that is in an outer block and used there later.
      
      Change-Id: Iced8b809d50089a4e6f9867be9b8501cce59d16f
      5ffeec96
    • Stephan Bergmann's avatar
      Fix MI RTTI (as needed by -fsanitize=vptr) · 03736d67
      Stephan Bergmann yazdı
      Change-Id: Idbde54c641531b34f397d07c5f929870c3a82371
      03736d67
    • Stephan Bergmann's avatar
      Remove long-unnecessary cruft · cdb214c3
      Stephan Bergmann yazdı
      Change-Id: Id770188f8c03cade5fd4f97295bb0933968dee71
      cdb214c3
    • Tor Lillqvist's avatar
      tdf#84881: NSSCMSAttribute::type can't be null. Must be same as typeTag.oid? · 167569bf
      Tor Lillqvist yazdı
      Why is a separate field then needed? Dunno, but probably because the type and
      values fields make up an encoded NSSCMSAttribute. (The comment in <nss/cmst.h>
      says so, but it took a while before I realized what it meant.) The typeTag and
      encoded fields are for NSS internal use or something.
      
      Now Adobe Reader says "The signature includes an embedded timestamp but it is
      invalid". Progress...
      
      Change-Id: I390947db8d414a7ceecc1f67aaeed5fa0f66fe6f
      167569bf
    • Stephan Bergmann's avatar
      Ensure listener is removed during ~SdModule · 6a23af75
      Stephan Bergmann yazdı
      Change-Id: I17fb441eac2593a0b43809f177250d46d6862a58
      6a23af75
    • Tor Lillqvist's avatar
      tdf#84881: Fix typo in OID string for id-aa-timeStampToken · c98f569d
      Tor Lillqvist yazdı
      Not that it seems to help. Adobe Reader still claims "signing time is from the
      clock on the signer's computer".
      
      (Why can't RFCs come with standard C header files (and Java and C# sources)
      defining macros/constants for the magic numbers, OIDs etc that the RFC
      defines?)
      
      Change-Id: I56e8cb4ef56e20345506a080e4d23764d2dfb956
      c98f569d
    • Stephan Bergmann's avatar
      Avoid unnecessary bad downcasts to ToolBox · 11292487
      Stephan Bergmann yazdı
      Change-Id: I239aee06ce543b6f7c213d845313ca51b3a5502d
      11292487
    • Stephan Bergmann's avatar
      Avoid unnecessary bad downcasts to Button · f02ee5b7
      Stephan Bergmann yazdı
      Change-Id: I36baaa1cd46385430474f8a841eafaaba07a18fc
      f02ee5b7
    • Noel Grandin's avatar
      fix marking of free slots in array · 9473ba24
      Noel Grandin yazdı
      Change-Id: I5170b9bbc4a3acab8307f7ad5ebc5e4ba9d58352
      9473ba24
    • Miklos Vajna's avatar
      Add SwPaM::dumpAsXml() · 44009b9a
      Miklos Vajna yazdı
      To avoid code duplication in SwRangeRedline::dumpAsXml() and
      SwFrm::dumpAsXml().
      
      Change-Id: Ic473cd77e960041b035b147dd31c16b141cc7cbe
      44009b9a
    • Yousuf Philips's avatar
      OXYGEN: Minor fixes to last commit · b09c594f
      Yousuf Philips yazdı
      Change-Id: Ibbc804ad2082c749160872a4460a45af8f985559
      Reviewed-on: https://gerrit.libreoffice.org/14598Tested-by: 's avatarYousuf Philips <philipz85@hotmail.com>
      Reviewed-by: 's avatarYousuf Philips <philipz85@hotmail.com>
      b09c594f
  2. 23 Şub, 2015 24 kayıt (commit)