Change-Id: I82882c8244ac553a8cce800fb93a000aa131a446
Reviewed-on: https://gerrit.libreoffice.org/20010Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I89159df36361f9ceff3401ef379c8230465617b7

When running CppunitTest_sc_macros_test in DrMemory, numerous
unaddressable accesses from SalTimerProc are reported.

During DeInitVCL(), ImplSalStopTimer() shuts down the TimerQueue, but
then the problem is that some disposing of some sidebar related UNO
service ends up calling Window::dispose() and Window::Hide() and
Window::ImplPostPaint(), which starts an Idle job maPaintIdle
that then re-starts the Win32 TimerQueue.

Change-Id: Ie1ab14330b6f1002c12d5302bb19f2b3f4c3811d

Not sure if there would be a performance penalty to re-loading these
icons every time, so move the static map from
ScIconSetFormat::getBitmap() to a member of ScDocument.

Change-Id: If560d70cea27e25396dd821d9e77a785e3b79820

Change-Id: I44d979180e53a7251547cebd60cf05c8322b2b83
Reviewed-on: https://gerrit.libreoffice.org/20028Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I721f53d79cd3e2c24542382d519a909a86a31111

Change-Id: I048aef08df43d07544aafc69b711d258dc40bc21

Change-Id: I597dbc3e4288acb5b71f7a344ae78ba568451614

Change-Id: Iee66687ce813ff801f29e4568329ed2a39f905ba

Change-Id: I9d8d0f6cc001de09d8d3f96d8ad7e243e07f426d

Change-Id: I961516d92abd693c19efe8a051e35ae5192ef7d2

Change-Id: I10f926af9ca19252878b9b6e20365c38c885ce83

Change-Id: I0f45b1a6ab198a8403073eea05497e76f758250c

...not a single sal_Unicode char (aParam.nUserIndex is of type sal_uInt16), just
the same as 2211ad69 "First cut on getting ODS
import/export of sheet-local anonymous ranges" did in a very similar place in
the same file.  (And Kohei, author of both places, assumes this is the right
thing to do, too.)

Change-Id: I12cd8abf1b4aaab7baa54f21d8c5a7ff2e171275

Change-Id: I3310813c971aa7abffccc0b7f462e05caa83482e

When tiled rendering, then only the render context (or failing that,
SwViewShell::GetOut()) has the correct zoom level, so use that when
doing pixel-to-logic conversion or scaling pixel values.

Change-Id: I265a642b8253c6eced42da2a0e06a2de25c36ca8

Otherwise many toolbar/menubar labels are missing when
starting any component from the start center.

Change-Id: I49d009431ae3d1003e5ff395265409b3a5641707

Change-Id: Id78cae55eb89520bd87713f9ea6c009c922f2870

Change-Id: I243dcb86cc1a99550b26962daf47c19eb62aa8df

Change-Id: If28713daab4bb5cbdb450879c2dc2a265c62a4f3

Change-Id: I25931d59fc1b4feb1fd1eaa036a64a28a269f409

...about

  static ImplImageTree instance;

in ImplImageTree::get (vcl/source/gdi/impimagetree.cxx) due to

  StyleIconSet ImplImageTree::maIconSet;

(of type std::unordered_map<OUString, IconSet, OUStringHash>) due to

  IconCache ImplImageTree::IconSet::maIconCache;

(of type std::unordered_map<OUString, std::pair<bool, BitmapEx>, OUStringHash>),
reported at least when building against Mac libc++.  This is a false positive,
as ImplImageTree::shutDown cleans this up.

Change-Id: Idb1a99aa33f71286e57b31b7adb833e3ee8b5f5a

...than fixing the avalanche of loplugin:staticmethods issues caused by
b5eaa0f9 "use unique_ptr for pImpl in sw/,"
given that SwMailMergeConfigItem_Impl has mutable state?

Change-Id: I342511d0f39086f33e2a8abd2c377341455d54a7

Change-Id: I46caceed3fdf0ad0aa51c8a8ede1177ca3d1855e

Change-Id: I809bac4b28e679c7dad8ed3ad28e36379bce4760

Change-Id: I220ae4732f221c7798f162653cad01717afb659f
Reviewed-on: https://gerrit.libreoffice.org/20011Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: Ia2f088a79b03ff866429e1cae73edccd36a01b4f

Change-Id: I2ae5a06f9ffe29de0b1cc5875615010da75f4ae9

...a Remark prints the whole stack of includes leading up to the source

Change-Id: I41e5bd2855b4a55b54e63432703f2e65b4c44249

Change-Id: I3266bb049be3a9b558b68b40d741efdcab2eb759

Change-Id: I882746f9c4a1c332c6657b93f104ecbf1c7be6f1

Change-Id: Iaf31a731c9151972ba2fe2ed50074ea59c147550

update the plugin with lessons learned from the mergeclasses plugin and
re-run it

Change-Id: I9d622eb3d05fceaf8fa764c533c8fa5dfb4c7711
Reviewed-on: https://gerrit.libreoffice.org/20015Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

found with the following script:
git ls-files *.hxx | xargs perl -0777 -ne 'if
(/include.*
.*
.*

"; close ARGV }'

Change-Id: I3afb0e81eb315c34bc0eb6bb4733dd1f0537d5c0

And move some to the include file where needed.

Change-Id: Ibbe2b7d531f41c1d58faf17f4795b4ce30355675

SwPostItMgr::GetSidebarWidth() can be called in two scenarios:

- inside PaintTile() the output device contains the zoom level and has
  the map mode enabled (and its scale factor is the zoom level)
- outisde PaintTile() the output device is SwEditWin and has the map
  mode disabled (and the zoom level is to be taken from the view
  options)

Change-Id: I6cf19f3241a2e972ae711e0efa7b0205aae1a3f2

Change-Id: I8508894d70e1ff16cfb9d7a9d716f11a923f453d

Change-Id: I7ac7eca32a67524f6c87696c16b16128e6d8518b

Change-Id: Ibf6a26940ec194f540255584776f8ebcefbb94ae

Change-Id: I8765ae89bcab8dc3c7360dace57a57094e5c5cc4