Kayıtlar (commit) · 7e91726f4d81f0ab27d79ee231abd666b4999758 · LibreOffice / core

25 Agu, 2015 35 kayıt (commit)

Treat an array of null string pointers as no strings for OpenCL · 7e91726f

Tor Lillqvist Agu 25, 2015 yazdı

For some reason, at least in the case of the "Test OpenCL" thing, we get here
an mpStringArray that is non-null but where all the elements (rtl_uString
pointers) in it are null. Treat that case as if the mpStringArray was null.

This makes the tests "Test OpenCL" actually use OpenCL. Maybe it has other
useful effects, too. (But for normal spreadsheet use, the mpStringArray that
gets handled here *is* null when all the cells used by a formula group are
numbers. At least it seemed so in a simple test.)

Also add more useful (?) SAL_INFO calls in the area.

Change-Id: I1388786a3a0765af6eb01a63da31e5b83c7a616d

7e91726f

upload libwps 0.4.1 · 737e2061
David Tardon Agu 25, 2015 yazdı
```
Change-Id: I53dc6d358952a046a4c1f03246441742dfa3d685
```
737e2061
typo · dea1d492
Stephan Bergmann Agu 25, 2015 yazdı
```
Change-Id: I555d4b79a61b371a39ad0f0b76c2d34c22414962
```
dea1d492
Remove redundant @since tag · 6d39088c
Stephan Bergmann Agu 25, 2015 yazdı
```
Change-Id: Icc3e913d4150e724c87e8293f7b641ee8ca19177
```
6d39088c

sidebar uno api corrections · c609b30b

Laurent Godard Agu 24, 2015 yazdı

Change-Id: I1bd1040cc80c0450a5e029c37f0737c0692c056a
Reviewed-on: https://gerrit.libreoffice.org/17952Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

c609b30b

Fix tdf#77881,tdf#80520,tdf#89525 bulllets lost issue. · 65a66d41

Mark Hung Tem 27, 2015 yazdı

Replace bullet char before write out font description
since it may be altered if bullet font has been changed
(i.e. StarSymbol to WingDings ).

Change-Id: I0461cc0a5e4628b36177602bba7ed7f74a0751eb
Reviewed-on: https://gerrit.libreoffice.org/17376Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>

65a66d41

Fix tdf#77514 CJK ruby text in RTL( vertical ) base line issue. · b14861e1

Mark Hung Agu 01, 2015 yazdı

Change-Id: Id670e83db01efe6bcd5fb6bb374ab9cb92898f88
Reviewed-on: https://gerrit.libreoffice.org/17460Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>

b14861e1

Fix tdf#80224 Custom text color changed to black on .PPTX export · 43679f94

Mark Hung Agu 02, 2015 yazdı

1) Indirect property values were ignored, now they are used.
2) Write endParaRPr so that PowerPoint display them.
3) Automatic colors are written as white or black based on
   whether background is dark.

Change-Id: I255c16f35149b738be2daf2800b1c90389f2c7cf
Reviewed-on: https://gerrit.libreoffice.org/17472Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>

43679f94

Updated core · 3ac03b3f

Christian Lohmaier Agu 25, 2015 yazdı

Project: help  67285d99b8c9373ba3fa992679353ee1a5bc4da9

typo "Navigator displays" → "The Navigator displays"

via pootle-feedback

Change-Id: I25578b8a780e607ce553e17289d96cdc7185577e

3ac03b3f

tdf#93468 add Arpitan (Switzerland) [frp-CH] · 76bc0e06
Eike Rathke Agu 25, 2015 yazdı
```
Change-Id: Icb96b45c936b974938c2dfae48960f727a1dc84d
```
76bc0e06

ensure editeng str len is in sync with attributes · cc596d8d

Caolán McNamara Agu 25, 2015 yazdı

for the duration of inserting attributes, and excess
dos newline chars can be removed safely afterwards

Change-Id: If70e34fec1c0819f827f483d3d7ac4f19b3caef8

cc596d8d

Some cleanup · 882604ad
Maxim Monastirsky Agu 25, 2015 yazdı
```
Change-Id: Ia22866225b2a726ed69c9f18d02d1ebffdafde8f
```
882604ad

Correct icon for number format in Calc's sidebar · c936d690

Yousuf Philips Agu 25, 2015 yazdı

Change-Id: Icc5958d77277c6938b8a03ef44dfd71b9350e288
Reviewed-on: https://gerrit.libreoffice.org/17978Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Tested-by: Maxim Monastirsky <momonasmon@gmail.com>

c936d690

Avoid overflow in PBMReader::ImplReadHeader · 662498ab

Stephan Bergmann Agu 25, 2015 yazdı

...as found by UBSan in CppunitTest_filter_ppm_test on
filter/qa/cppunit/data/pbm/fail/crash-1.pbm

Change-Id: Ib7c50ef1f07aba6b78f79c608be69c3dac38ddfe

662498ab

Handle non-aligned FFNs · 63738868

Stephan Bergmann Agu 24, 2015 yazdı

...as found by UBSan in CppunitTest_sw_filters_test (see below), and at the same
time limit reads within the pA array to its bounds.

> Testing file:///.../sw/qa/core/data/ww6/pass/crash-2.doc:
> sw/source/filter/ww8/ww8scan.cxx:6473:32: runtime error: upcast of misaligned address 0x6200000e70e7 for type 'WW8_FFN_Ver6', which requires 2 byte alignment
> 0x6200000e70e7: note: pointer points here
>  00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 0e 00 00 6a 00  00 00 00 0e 00 00 6a 00  00 00 6a
>              ^
>  WW8Fonts::WW8Fonts(SvStream&, WW8Fib&) sw/source/filter/ww8/ww8scan.cxx:6473:32
>  SwWW8ImplReader::CoreLoad(WW8Glossary*, SwPosition const&) sw/source/filter/ww8/ww8par.cxx:4961:20
>  SwWW8ImplReader::LoadThroughDecryption(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:5767:19
>  SwWW8ImplReader::LoadDoc(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:6039:19
>  WW8Reader::Read(SwDoc&, rtl::OUString const&, SwPaM&, rtl::OUString const&) sw/source/filter/ww8/ww8par.cxx:6157:20
>  SwReader::Read(Reader const&) sw/source/filter/basflt/shellio.cxx:175:18
>  SwDocShell::ConvertFrom(SfxMedium&) sw/source/uibase/app/docsh.cxx:258:22
>  SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:790:23
>  SwFiltersTest::filter(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) sw/qa/core/filters-test.cxx:112:20
>  SwFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) sw/qa/core/filters-test.cxx:71:12
>  test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:129:20
>  test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:154:5
>  SwFiltersTest::testCVEs() sw/qa/core/filters-test.cxx:154:5

Change-Id: I31ac8dc11d985745785c9dda1cec8a11a41098bb

63738868

parameter names are useless in DECL_LINK declarations · fab18ef3
Noel Grandin Agu 25, 2015 yazdı
```
Change-Id: I77f7b528ed97964bdc153f820f6f96977ddb9254
```
fab18ef3
misplaced brace · d6853956
Caolán McNamara Agu 25, 2015 yazdı
```
Change-Id: I6e43fd4a4b45f0217de8b6d93ef2403e46e39489
```
d6853956
vcl: disable randomly failing timer unit tests · 6bdd93e3
Thorsten Behrens Agu 25, 2015 yazdı
```
Change-Id: Iab26a2b55586fc824c5edbea519c4f68ba4a548f
```
6bdd93e3

Turn on glyph caching by default when using OpenGL · 9a68eb9c

Tor Lillqvist Agu 25, 2015 yazdı

Can now be turned off with a SAL_DISABLE_GLYPH_CACHING environment variable.

Change-Id: I7ac14d72dc0f85c0682d92492eb96bec1d207609

9a68eb9c

disable test case pending index assert fix · af9751a7
Caolán McNamara Agu 25, 2015 yazdı
```
Change-Id: Ic48e22169dff2ed06b75af519ca39addef7d07de
```
af9751a7
upload libmwaw 0.3.6 · 6b0585a5
David Tardon Agu 24, 2015 yazdı
```
Change-Id: I09249673d42d36bf72ee1ffbf8f3f37734bd8bae
```
6b0585a5
astyle · 51adbedb
David Tardon Agu 25, 2015 yazdı
```
Change-Id: I597c007e4636f6b05873f24ef3e89c0a7c2c3670
```
51adbedb
simplify some declarations · 2a0f9f08
Noel Grandin Agu 20, 2015 yazdı
```
Change-Id: I348e7f984e5e8b4b915d11de8182da07a6356f8d
```
2a0f9f08
SvResizeHelper::ValidateRect, simplify logic · b3705c21
Noel Grandin Agu 20, 2015 yazdı
```
Change-Id: Ie1c9891e8095172f53efc027eec9a68bde39ed1f
```
b3705c21
remove useless comment · 3b479413
Noel Grandin Agu 20, 2015 yazdı
```
Change-Id: Id253acad170e3d8f7a1278a10c731c6bd1927b92
```
3b479413

using RECT_EMPTY here is very dodgy · 6234e5e0

Noel Grandin Agu 20, 2015 yazdı

lets rather use something smaller, so as not too potentially bump
into the RECT_EMPTY checks in the Rectange code

Change-Id: Ief8200763cac29e3099a2717f20c6f10cbc7d579

6234e5e0

simplify, IsEmpty() checks both Right and Bottom already · 3f02a38c
Noel Grandin Agu 20, 2015 yazdı
```
Change-Id: I81fa9f80593bdea5098215f71c44b35e0087a6fc
```
3f02a38c
add some comments to Rectangle mutation methods · 25864323
Noel Grandin Agu 20, 2015 yazdı
```
Change-Id: I7e1d737fc1e7a431afd3cde74c2c974e0cbef9ef
```
25864323
there may be no storage available in older formats · 666fb214
Caolán McNamara Agu 25, 2015 yazdı
```
Change-Id: I23cbaf7fc1320168eb75ca33fd6d704125508785
```
666fb214
Nitpick: Follow our header guard naming convention · 4809c42c
Tor Lillqvist Agu 25, 2015 yazdı
```
Change-Id: I939d36dbb0a298f8181367f74001115ef89d5bc2
```
4809c42c
make pWindow private in SfxChildWindow · 219b50a2
Noel Grandin Agu 24, 2015 yazdı
```
Change-Id: I585d4e8f0a53f46b6fbcef9e4d26f88b57569684
```
219b50a2
make eChildAlignment private in SfxChildWindow · a9ea1295
Noel Grandin Agu 21, 2015 yazdı
```
Change-Id: I68a4c3324736e111a2c88e3edb9df506c33042b7
```
a9ea1295
clean up whitespace in childwin.hxx a little · 51ea8aec
Noel Grandin Agu 21, 2015 yazdı
```
Change-Id: Iefebe6b254f2c01b46b48ebaf7a6242e1bf80b62
```
51ea8aec
the implementation pointer of SfxChildWindow can be private · 64928744
Noel Grandin Agu 21, 2015 yazdı
```
Change-Id: I79366fe5abc98924e174dcbac83bbb8c053d59ce
```
64928744

sc: fix number format button highlighting in sidebar · fab0c5d1

Tomaž Vajngerl Agu 25, 2015 yazdı

When a number format for a cell (for example percent) is applied
it is highlighted in the toolbar but not the equal button in the
sidebar. This patch fixes this issue.

Change-Id: I7f33ab1e989f8a8e3c49468aae2042621d088798

fab0c5d1

24 Agu, 2015 5 kayıt (commit)

slideshow: replace for_each with range-based loop · ead5bc3c

Daniel Robertson Agu 22, 2015 yazdı

Replace ::std::for_each for a more readable range-based for loop in
cases in which the function object to be applied by for_each is more
readable as the body of a for loop.

Change-Id: Ib0b488b36ed58c65c56357e04391b85096d043aa
Reviewed-on: https://gerrit.libreoffice.org/17930Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

ead5bc3c

in reality we are limited to max sal_Int32 here · 0a76c1fd

Caolán McNamara Agu 24, 2015 yazdı

so accept that and test if the values were accepted or limited

Change-Id: Iaed5ebc2f12b52055506147c71117a2ad88d28ac

0a76c1fd

consider validity of m_nDrawCpO · 8329eb5e
Caolán McNamara Agu 24, 2015 yazdı
```
Change-Id: Ifbd131440bad6d840d369c99628cb8904697ad96
```
8329eb5e

Handle GetBaseCp overflow · d281b460

Stephan Bergmann Agu 24, 2015 yazdı

...as found by UBSan in CppunitTest_sw_filters_test (see below); note the TODOs
how best to report the errors up the call stack.

> Testing file:///.../sw/qa/core/data/ww6/pass/crash-3.doc:
> sw/source/filter/ww8/ww8scan.cxx:5240:63: runtime error: signed integer overflow: 1766665948 + 1768712052 cannot be represented in type 'int'
>  WW8Fib::GetBaseCp(ManTypes) const sw/source/filter/ww8/ww8scan.cxx:5240:63
>  SwWW8ImplReader::Read_GrafLayer(long) sw/source/filter/ww8/ww8graf.cxx:2393:18
>  SwWW8ImplReader::ReadChar(long, long) sw/source/filter/ww8/ww8par.cxx:3630:17
>  SwWW8ImplReader::ReadChars(int&, int, long, long) sw/source/filter/ww8/ww8par.cxx:3432:27
>  SwWW8ImplReader::ReadText(int, int, ManTypes) sw/source/filter/ww8/ww8par.cxx:3970:22
>  SwWW8ImplReader::CoreLoad(WW8Glossary*, SwPosition const&) sw/source/filter/ww8/ww8par.cxx:5169:9
>  SwWW8ImplReader::LoadThroughDecryption(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:5767:19
>  SwWW8ImplReader::LoadDoc(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:6039:19
>  WW8Reader::Read(SwDoc&, rtl::OUString const&, SwPaM&, rtl::OUString const&) sw/source/filter/ww8/ww8par.cxx:6157:20
>  SwReader::Read(Reader const&) sw/source/filter/basflt/shellio.cxx:175:18
>  SwDocShell::ConvertFrom(SfxMedium&) sw/source/uibase/app/docsh.cxx:258:22
>  SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:790:23
>  SwFiltersTest::filter(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) sw/qa/core/filters-test.cxx:112:20
>  SwFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) sw/qa/core/filters-test.cxx:71:12
>  test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:129:20
>  test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:154:5
>  SwFiltersTest::testCVEs() sw/qa/core/filters-test.cxx:154:5

Change-Id: I0b14f5c1e025565eb131e64590b7d5ff0135e767
Reviewed-on: https://gerrit.libreoffice.org/17965Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

d281b460

Handle zero nPLCF · 1a871f9d

Stephan Bergmann Agu 24, 2015 yazdı

...as found by ASan in CppunitTest_sw_filters_test:

> Testing file:///.../sw/qa/core/data/ww6/pass/crash-1.doc:
> ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6020009382b0 at pc 0x2b1dcb5eabac bp 0x7fffe8ccbdb0 sp 0x7fffe8ccbda8
> READ of size 4 at 0x6020009382b0 thread T0
>  WW8PLCF::SeekPos(int) sw/source/filter/ww8/ww8scan.cxx:2219:14
>  WW8PLCF::WW8PLCF(SvStream&, int, int, int, int, int, int) sw/source/filter/ww8/ww8scan.cxx:2080:9
>  WW8PLCFx_Fc_FKP::WW8PLCFx_Fc_FKP(SvStream*, SvStream*, SvStream*, WW8Fib const&, ePLCFT, int) sw/source/filter/ww8/ww8scan.cxx:2883:21
>  WW8PLCFx_Cp_FKP::WW8PLCFx_Cp_FKP(SvStream*, SvStream*, SvStream*, WW8ScannerBase const&, ePLCFT) sw/source/filter/ww8/ww8scan.cxx:3088:7
>  WW8ScannerBase::WW8ScannerBase(SvStream*, SvStream*, SvStream*, WW8Fib*) sw/source/filter/ww8/ww8scan.cxx:1588:20
>  SwWW8ImplReader::CoreLoad(WW8Glossary*, SwPosition const&) sw/source/filter/ww8/ww8par.cxx:5022:20
>  SwWW8ImplReader::LoadThroughDecryption(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:5767:19
>  SwWW8ImplReader::LoadDoc(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:6039:19
>  WW8Reader::Read(SwDoc&, rtl::OUString const&, SwPaM&, rtl::OUString const&) sw/source/filter/ww8/ww8par.cxx:6157:20
>  SwReader::Read(Reader const&) sw/source/filter/basflt/shellio.cxx:175:18
>  SwDocShell::ConvertFrom(SfxMedium&) sw/source/uibase/app/docsh.cxx:258:22
>  SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:790:23
>  SwFiltersTest::filter(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) sw/qa/core/filters-test.cxx:112:20
>  SwFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) sw/qa/core/filters-test.cxx:71:12
>  test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:129:20
>  test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:154:5
>  SwFiltersTest::testCVEs() sw/qa/core/filters-test.cxx:154:5
> 0x6020009382b1 is located 0 bytes to the right of 1-byte region [0x6020009382b0,0x6020009382b1)
> allocated by thread T0 here:
>  operator new[](unsigned long) /home/sbergman/clang/trunk/src/projects/compiler-rt/lib/asan/asan_new_delete.cc:64
>  WW8PLCF::ReadPLCF(SvStream&, int, unsigned int) sw/source/filter/ww8/ww8scan.cxx:2091:26
>  WW8PLCF::WW8PLCF(SvStream&, int, int, int, int, int, int) sw/source/filter/ww8/ww8scan.cxx:2075:9
>  WW8PLCFx_Fc_FKP::WW8PLCFx_Fc_FKP(SvStream*, SvStream*, SvStream*, WW8Fib const&, ePLCFT, int) sw/source/filter/ww8/ww8scan.cxx:2883:21
>  WW8PLCFx_Cp_FKP::WW8PLCFx_Cp_FKP(SvStream*, SvStream*, SvStream*, WW8ScannerBase const&, ePLCFT) sw/source/filter/ww8/ww8scan.cxx:3088:7
>  WW8ScannerBase::WW8ScannerBase(SvStream*, SvStream*, SvStream*, WW8Fib*) sw/source/filter/ww8/ww8scan.cxx:1588:20
>  SwWW8ImplReader::CoreLoad(WW8Glossary*, SwPosition const&) sw/source/filter/ww8/ww8par.cxx:5022:20
>  SwWW8ImplReader::LoadThroughDecryption(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:5767:19
>  SwWW8ImplReader::LoadDoc(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:6039:19
>  WW8Reader::Read(SwDoc&, rtl::OUString const&, SwPaM&, rtl::OUString const&) sw/source/filter/ww8/ww8par.cxx:6157:20
>  SwReader::Read(Reader const&) sw/source/filter/basflt/shellio.cxx:175:18
>  SwDocShell::ConvertFrom(SfxMedium&) sw/source/uibase/app/docsh.cxx:258:22
>  SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:790:23
>  SwFiltersTest::filter(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) sw/qa/core/filters-test.cxx:112:20
>  SwFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) sw/qa/core/filters-test.cxx:71:12
>  test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:129:20
>  test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:154:5
>  SwFiltersTest::testCVEs() sw/qa/core/filters-test.cxx:154:5

Change-Id: I97d995aad621b829b6fb6ee4622d386fec0bedea
Reviewed-on: https://gerrit.libreoffice.org/17963Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

1a871f9d