Change-Id: I7a034cbcbca892d80d01baf5b51da3647f45120c
Reviewed-on: https://gerrit.libreoffice.org/67979Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

It is possible to have connections from multiple data nodes to the same
presentation node with a presOf type. We use to order these based on as
they appear in the data XML, but we need to order them according to the
destOrd attribute.

Introduce an std::map for that, so get ordering automatically as we
iterate. Turn the std::pair into a struct to make the code a bit more
readable.

Change-Id: I3d2bb047ed3f171a194851f89151bd94071a8176
Reviewed-on: https://gerrit.libreoffice.org/68027Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: I2b01767b94a7c63fac725d2f6e943e589e232822
Reviewed-on: https://gerrit.libreoffice.org/68023
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

It was annoying that "Entry - Appear" animation was always added
despite user had selected another effect. Correct the design as:
- "Entry - Appear" is added for the first animation in the slide.
- Last selected effect is added.
- If the category is selected but the effect isn't, the first effect
  in the category is added.

Change-Id: I5e781feb0468bef4a5e46fd277554ddeadbcfbec
Reviewed-on: https://gerrit.libreoffice.org/67977
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>

Indefinite duration isn't necessary for indefinite repetition,
so simply check the number of iteration left and do not decrease
the number when the repetition is indefinite.

Note: a known issue is that the next effect starts before
"until click" or "until next slide" if the starting time of
the next slide is "after previous". A workaround is to set
the starting time of the next slide to "click".

Change-Id: Ie9c73b472dc400bc41501029ff19ecc3e3fab2df
Reviewed-on: https://gerrit.libreoffice.org/67896
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>

Please feel free to suggest a better name, if desired

Change-Id: Ic4bb7188d462cf204a847c4dd5afb6a14f4bf2bc
Reviewed-on: https://gerrit.libreoffice.org/66261
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Also add a unit test for that.

Change-Id: I86c195cebbe12b2bdf498954956db882f6f0d12b
Reviewed-on: https://gerrit.libreoffice.org/68005
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Please feel free to suggest a better name, if desired

Change-Id: I116b30f3734a96fe30a95a30514551983e0258ae
Reviewed-on: https://gerrit.libreoffice.org/66260
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: I3db38c6294aaaa4fe6c91fac83f1f1c087398b6a
Reviewed-on: https://gerrit.libreoffice.org/66954
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

... at invoking uno:ChooseDesign, instead of saving it into user's
working directory.

Change-Id: I899b259faca7fbc6ba2f5cc4ac8638f34e5febc6
Reviewed-on: https://gerrit.libreoffice.org/66672
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Convert shapes on the document to black & opaque
before sending it to the pdfexport filter.

Convert them back to gray & transparent after
the export operation.

Change-Id: Iffe66e371710f16ef1c04f0da196fc5a561af344
Reviewed-on: https://gerrit.libreoffice.org/67517
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

Change-Id: I47c469c0fcdff41d83729be9489c946e81ef3686
Reviewed-on: https://gerrit.libreoffice.org/68020
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I4c9fc9595a498609309ce7734c312fea09680c2f
Reviewed-on: https://gerrit.libreoffice.org/67586
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: I6e80e83fcdd596f641bce9b246aa634dd0cbae09
Reviewed-on: https://gerrit.libreoffice.org/67966
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Remove of invisible content has influence on page count and
therefore on fields for page count. So straight after removing
invisible content in the mail merge process, the layout has to
be updated before fields are converted to text.

Change-Id: If43f9921b6797c7ceb112860cda4baf4978c36bc
Reviewed-on: https://gerrit.libreoffice.org/67343
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

* Update helpcontent2 from branch 'master'
  - tdf#122787 Tip text on index of indexes
    
    Added a tip on including other indexes in TOC.
    
    Change-Id: Ia5877a09f9156ada440d6f2de3b612da659e08f7
    Reviewed-on: https://gerrit.libreoffice.org/68000
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

unlike GetInsertionPoint

Change-Id: I46bf5f5f395829c96dc715761bfbe10e7ab2c940
Reviewed-on: https://gerrit.libreoffice.org/68018
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ia9616f644a68ec6da22e646ba0d919a3489a9481
Reviewed-on: https://gerrit.libreoffice.org/67745
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

LibreOffice writes the ODF attributes 'display' and 'protected' of
the 'layer' element since version 6.2. It can read the ODF
attributes since version 6.2. But they are only evaluated if non of
the config items VisibleLayers, PrintableLayers and LockedLayers
exists. If the option is set to 'false' no config items are written
and so reading of ODF attributes is forced. Version 6.1 is the last
one which needs the config items. So until version 6.1 is end of
life the default value is 'true'.
The patch introduces this option and adapts the relevant unit
tests to consider the option.

Change-Id: I2f8fc61506b14820f6bee8bf153d89363690b9e8
Reviewed-on: https://gerrit.libreoffice.org/67784
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: I29fce67b32a5c632eb12210f707f13b995bd58d3
Reviewed-on: https://gerrit.libreoffice.org/68007
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...found with GCC 9, where the standard library iterator implementations are
apparently sufficiently different to older versions of GCC to find more cases
of !(... == ...) vs. ... != ...

Change-Id: Ibe7c5140049a69d2c5318b4b2371f2e66bd05028
Reviewed-on: https://gerrit.libreoffice.org/68012
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I135359d9cce4a3195a8e2099545ffafa5b767cdb
Reviewed-on: https://gerrit.libreoffice.org/68013
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

We should not call implts_resetInplaceMenuBar() unconditionally.
The problem which was fixed by that call can be solved by setting
m_bInplaceMenuSet to false, which is the proper solution. So after
the menu cleared up (inplace menu too), this indicator flag also
contains the right value.

Regression from:
dc3a2546

Change-Id: I85243417eb273629cc57b762b98fdd32dc9b1dd5
Reviewed-on: https://gerrit.libreoffice.org/68009
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Change-Id: I146e2cdf922b11dc36ade91d21c9b2208453adfc

FOURIER(Array, GroupedByColumns, Inverse, Polar)
is a matrix formula that computes discrete Fourier transform[DFT]
of input array(first argument) via a radix-2, decimation-in-time
fast Fourier transform algorithm.

Unit test for this is coming up in a new commit.

The data in input array(first argument) can be :-

1) grouped by columns (needs to be indicated by flag GroupedByColumns = TRUE)
   In this case the array can contain 1 or 2 columns, where the first column
   contains the real part of input series and second column if present contains
   the imaginary part of the input series. If there is only 1 column, the input
   series is treated as purely real. If the number of rows is not a power of 2,
   zeroes are appended to the input series internally to make the series length
   equal to the next nearest power of 2.

2) grouped by rows (needs to be indicated by flag GroupedByColumns = FALSE)
   In this case the array can contain 1 or 2 rows, where the first row
   contains the real part of input series and second row if present contains
   the imaginary part of the input series. If there is only 1 row, the input
   series is treated as purely real. If the number of columns is not a power of 2,
   zeroes are appended to the input series internally to make the series length
   equal to the next nearest power of 2.

The third argument "Inverse" is a boolean flag to indicate whether an inverse
DFT needs to be computed. This argument is optional and the default value is
FALSE.

The fourth argument Polar is a boolean flag to indicate whether the final output
needs to be in polar coordinates. This argument is optional and the default value
is FALSE.

The result of DFT consists of two columns - first column contains the real parts (or
the magnitudes if Polar=TRUE) and second column contains the imaginary parts (or
the phases if Polar=TRUE).

Implementation:

A fairly straighforward non-recursive implementation of radix-2 FFT algorithm is
written from scratch.

Reference:

Heckbert, P., 1995. Fourier transforms and the fast Fourier transform (FFT) algorithm.
Computer Graphics, 2, pp.15-463.

The normalization factor used in DFT / and inverse DFT in this implementation matches that
of fft() and ifft() functions of Matlab/Octave. It also matches the one used in Wikipedia
article on DFT: https://en.wikipedia.org/wiki/Discrete_Fourier_transform.

Change-Id: If4a40a6ef62bce1f03c589ae5357b2049f66fe64
Reviewed-on: https://gerrit.libreoffice.org/67938
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

Change-Id: I499e32ce86fabd18c52ac2f99713af0933572f7c

Change-Id: I5c10b3f1dbcdce9064397a76eb583d477628c4b4
Reviewed-on: https://gerrit.libreoffice.org/68001
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Using conjuction and disjuction distributivity and assuming
that for each range r: r.mnStart <= r.mnEnd.

Change-Id: Ifbd156426617ebf225b1b1139e17e4967a228cd6
Reviewed-on: https://gerrit.libreoffice.org/68003
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Have video fit to the media object size on the slide,
allow more complicated interactions.

Change-Id: Ice1fa4b521176ad7ed7f7d1d2b13e617e8282390
Reviewed-on: https://gerrit.libreoffice.org/67978
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

it is inefficient to allocate a tiny object like Color separately on the
heap

Change-Id: I2f03538f987ff032857f3316ed2d8c2c8d731549
Reviewed-on: https://gerrit.libreoffice.org/67968
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

it is inefficient to allocate a tiny object like Color separately on the
heap

Change-Id: Iac2cfc7c00c16240e7cf72e7d8814e97e9f65ac6
Reviewed-on: https://gerrit.libreoffice.org/67967
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Add exceptionToString() and getCaughtExceptionAsString() methods in
tools.

Use the new methods in DbgUnhandledException()

Add special-case case code for most of the exceptions that contain extra
fields, so all of the relevant data ends up in the log

Change-Id: I376f6549b4d7bd480202f8bff17a454657c75ece
Reviewed-on: https://gerrit.libreoffice.org/67857
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Regression from commit 8d2fe8d7
(SwView::SearchAndWrap: fix WrapAround search in fly frames,
2015-06-03).

The search implementation looks in the body text, then in case searching
in extra content was not enabled already, it attempts to search there.

The problem was that while the wrap-around implementation intended to do
the same, it failed to unset the "search in extra" flag in case nothing
was found, fix that now.

Change-Id: Idf078e464824cad69c9709309435f2db207503b8
Reviewed-on: https://gerrit.libreoffice.org/67986
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Change-Id: I83ed6787b15245d11223cc054608b83f68647d9a
Reviewed-on: https://gerrit.libreoffice.org/67993
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

This fixes the following build error on 32 bit archs as reported by
ricotz for LibreOffice 6.2.1.1 on #libreoffice-dev:

[build CXX] vcl/unx/kde5/KDE5SalGraphics.cxx
In file included from /<<PKGBUILDDIR>>/include/com/sun/star/uno/Any.h:29,
                 from /<<PKGBUILDDIR>>/workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/uno/XInterface.hdl:6,
                 from /<<PKGBUILDDIR>>/workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/lang/XTypeProvider.hdl:6,
                 from /<<PKGBUILDDIR>>/workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/lang/XTypeProvider.hpp:6,
                 from /<<PKGBUILDDIR>>/include/cppuhelper/compbase.hxx:25,
                 from /<<PKGBUILDDIR>>/vcl/unx/kde5/KDE5FilePicker.hxx:22,
                 from /<<PKGBUILDDIR>>/vcl/unx/kde5/KDE5FilePicker2.cxx:20:
/<<PKGBUILDDIR>>/include/cppu/unotype.hxx: In instantiation of ‘static const com::sun::star::uno::Type& cppu::UnoType< <template-parameter-1-1> >::get() [with T = int]’:
/<<PKGBUILDDIR>>/include/cppu/unotype.hxx:321:37:   required from ‘const com::sun::star::uno::Type& cppu::getTypeFavourUnsigned(const T*) [with T = int]’
/<<PKGBUILDDIR>>/include/com/sun/star/uno/Any.hxx:268:55:   required from ‘void com::sun::star::uno::operator<<=(com::sun::star::uno::Any&, const C&) [with C = int]’
/<<PKGBUILDDIR>>/vcl/unx/kde5/KDE5FilePicker2.cxx:664:22:   required from here
/<<PKGBUILDDIR>>/include/cppu/unotype.hxx:296:38: error: no matching function for call to ‘cppu_detail_getUnoType(T1*)’
         return cppu_detail_getUnoType(static_cast< T1 * >(0));
                ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~

Change-Id: I5b734160c4ce218a9a982ba4a595add13affa365
Reviewed-on: https://gerrit.libreoffice.org/67983Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Michael Weghorn <m.weghorn@posteo.de>

UINameSingular is used in the title of the animation effect.
It was missed in media objects, contorl objects, frames, tables,
etc., causing the title of the animation effect to become just a
number without prefixing object type before it.

Change-Id: I7446d59b1b80102c34b8326e20927f60ad24da25
Reviewed-on: https://gerrit.libreoffice.org/67934
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>

of the visible sheet of an embedded spreadsheet,
instead of exporting always the first column and row.

Change-Id: Iaf87bfc5b7658cd4d64cb9c83c50bbf66fd6e7f0
Reviewed-on: https://gerrit.libreoffice.org/67982
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

of the visible sheet of an embedded spreadsheet,
instead of showing always the first column and row.

Change-Id: I7b712d97f152da3cecf8371e21cf0a82ef21f199
Reviewed-on: https://gerrit.libreoffice.org/67867
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

* Update helpcontent2 from branch 'master'
  - HELP: Add new internal error codes for Calc
    
    Source - /core/include/formula/errorcodes.hxx
    
    Change-Id: I64fcef138cf9ec89d4501ea71aa4bab54d9d04fd
    Reviewed-on: https://gerrit.libreoffice.org/67620
    Tested-by: Jenkins
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

This way the 4 quadrant shapes in the center of the SmartArt form a
circle, as width is shrinking.

It's not height growing, as OOXML spec clearly says "ar" always just
shrinks one axis.

(>1 and <1 "ar" is to be handled when they are seen in action in an
actual document.)

Change-Id: I69f2390ee881253151cccc336ecbf1806a1216dc
Reviewed-on: https://gerrit.libreoffice.org/67980Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins