Change-Id: I28f4895814d9fc419274de5681efa535e815f822

This is a much better approach than my old one that tried to use the
correct XModel with the chart sidebar. Now everytime we leave the chart
edit mdoe we destroy the chart sidebar panels and recreate them when we
go back to chart edit mode.
As a result we no longer need to have worry that much about using the
correct ChartModel and about the lifecycle of the ChartModel.

Change-Id: Ie85ad82968e20a81f059d4bd930a83a70da35fc9

Change-Id: I6fc8a928374de48910395685b500ba95e8621d39

Change-Id: I6390f16a6c2346c4c903a34d702277b931bc0079

Change-Id: I02541a12c893038f090a8e2847b6882669a967df

Change-Id: Ib6ad2fff04dbbcdb3d5f527d0a23c771409dc6e3
Reviewed-on: https://gerrit.libreoffice.org/19285Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

- Use the existing createHexStringFromDigit()
    to export hex digits as strings

- The parameters offset and stream name
    are not required

Change-Id: If9aab7816efb81655c40a11743e8951ab0b26e1d

Change-Id: I891a2a0b3e2194892bd4629c22b823902d18adc2

Change-Id: I5ccdfc62a8fd3521b6c4ee0029e70b41aaf4542e

This reverts commit 934e4795.

Calculating with NaN cries for even more problems..

integralPhi is called with nan(0xfffff000001f6)
which recurses through rtl_math_erfc->rtl_math_erf->rtl_math_erfc
until we run out of stack

Change-Id: Iab8a22fb23686d22d151f2508dbeb44ab47a76b7

Change-Id: Ibd7f88734492c4336e8a92ebbf9c70afdb7b3b5c

ODF 1.2 part 3, 18.3.1 angle, says "An angle, as defined in §4.1 of
[SVG]" and "If no unit identifier is specified, the value is assumed to
be in degrees."

Unfortunately OOo could only read and write 10th of degree here.

See also https://issues.oasis-open.org/browse/OFFICE-3774

As the first step towards fixing that, implement the import for
draw:angle values with an angle unit identifier, but leave the import
as-is if the angle identifier is missing.

Change-Id: Ib88d417c03998ebcfc569b01492f0e1f851bbc85

That literal %s was irritating.

Change-Id: I2925b26b1f3d1c101106ca616d18b24b41210c72

so it happily passes the pre-cast string bounds check and blows
up in the post-cast string access

Change-Id: Ifd4d087b37e8a84d886e2f7833dfc773b8bf1343

Change-Id: Ic7c496259258bf36cd885ed68912b43117f348f0

Change-Id: Id9dc4c7e083da2a8d44c7295a8b605de81bca1ef
Reviewed-on: https://gerrit.libreoffice.org/19272Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Change-Id: I7dd21f30daa27e5de2848eb16aee9a610dd629d5
Reviewed-on: https://gerrit.libreoffice.org/19271Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Regression of:

commit 89d39bc1
Author: Oliver Specht <oliver.specht@cib.de>
Date:   Wed Sep 30 16:10:07 2015 +0200

        tdf#94559: 4th step to remove rtti.hxx

Change-Id: I94408dafde0f2dbea6c3a112963468c593adfc2d
Reviewed-on: https://gerrit.libreoffice.org/19276Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

Push/Pop-ing the cursor led to selection loss.
SelectHiddenRange() immediately returns false if the current cursor
hasMark(), so avoid all of the bugs and expensive push/pop routines
when there is a mark already.

Change-Id: I4624a3e0b2267942812d0429d527ad97962ec7fc
Reviewed-on: https://gerrit.libreoffice.org/19108Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I2658b8fc9d36fe92dd91e0f5adc27612ce1dc438
Reviewed-on: https://gerrit.libreoffice.org/19268Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I5ecf90a927b2ec4aeb2c0586a5da2f814c9062dd
Reviewed-on: https://gerrit.libreoffice.org/19275Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ice121a65e38d47b4a26f7ed81fc3037e031ae7c4

Change-Id: I54691786167fd17b115460f3329573f0c2f023ed

Change-Id: I97db1e22a42e25186be0d7304b9f2a5204fc1c83

Change-Id: I9329233a85df26dcfd83002e50604a6ea4fb50f9

Change-Id: Ic3464a466302b87fae70a63f2723d1355eccab6f

Change-Id: I11b99fca91b266bdf6c29dc142511bf01dbd4bed

Change-Id: Ib9eae95b8ace37d31e905bc098c67de97b7816e3

...to silence a clang-analyzer-deadcode.DeadStores on the last update of nLeft
and nRight, each.  Also, adding a gap of 3 to nRight in case no further buttons
will be layed out next to maDockRect resp. maHideRect is irrelevant, as nRight
will not be used for any further layout computations in those cases.

Change-Id: I251d4470099b1f98782ebdfd0c776d881bb7fae5

i.e. to reset to the initial post-startup state

performance still isn't great unfortunately, 0.7
cycles per second before this, 2.6 after this

Change-Id: Ib9d83b70f0cf052af36a49ed5bacef295fe9ed11
Reviewed-on: https://gerrit.libreoffice.org/19269Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I8a6ea395192d31391868f44152ab3b543a07aeaa

Change-Id: I9e2cf9b06fcf0b0a9dfd642fa788f203ade19fe3

...assuming the success of both steps 2 and 3 should be checked (though the of
this code is lost to history past 40d960cb
"divide pdfwriter_impl.cxx")

Change-Id: Icea5de98e5a0559dbc0f837650e842fb49bc41e0

Change-Id: Ie1d3afb0b9ca59232214d9ab6da9fa761a3fd449

...to silence a clang-analyzer-deadcode.DeadStores on the last update of nUsed

Change-Id: Ib470f09155bd181b05bc0342543a36e59b8dd937

nSxe, nSye were unused ever since WMFReader::GetPlaceableBound was introduced
(seemingly, involving some copy/paste) in
fa149f40 "#98505# if there is no WinExt we try
to calculate the extension instead of using (1/1) default which causes a crash
on unix and linux"

Change-Id: Ica6fb9ec1d25bd5314e73610eccef2a4df0c310f

Change-Id: Icef974fccdc487b8abef3b1200b0b34b7be703ec

Change-Id: I4924a3cecb1e12874659eeccde51126fab4d4e45

Change-Id: Ic76cf540896ba217f7df6045be31197b64298bf3