Regression from commit 8c48d69f

Change-Id: I302a210ab6c502e3938487ee02a08fc334cd3289
Reviewed-on: https://gerrit.libreoffice.org/59666
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Starting the SwDocIdle in StartIdeling() just reintroduces the
bug fixed in commit 401cba4c ("tdf#116370 cleanup Writer idle
job handing"), so trading one bug for the other.

For the real solution we have to handle two states:
1. The SwDocIdle being active
2. The SwDocIdle being blocked

For the first state we can just use the active state of the Idle
itself. Since it's not a AutoIdle, it will be turned of, if
invoked. Either some Idle handler will want to be run it again or
some other thread might start it again, if needed.
Since we're now tracking the wanted Idle state via the active task
flag, we can drop the explicit mbStartIdleTimer handling.

As a result of the first change, we can't stop the Idle anymore
when blocking it. But the Idle itself checks its ready state via
IsDocIdle() in its UpdateMinPeriod function, so we have to add
the blocking state to IsDocIdle().

Change-Id: I33017a8e07208a6a3bce761cc899ac3ca944cd61
Reviewed-on: https://gerrit.libreoffice.org/59586
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

"Next" button disabled with the last slide

Change-Id: Iebb7c46b9838f5372cb68c51daa41d114309d613
Reviewed-on: https://gerrit.libreoffice.org/59642
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

ECMA-376-1:2016 states that w:dir is functionally equivalent to LRE/RLE+PDF
pair around the enclosed runs. So this patch does just that.

Change-Id: Ibf9775338cc38a3bbc38a42a33fc64ae787b478f
Reviewed-on: https://gerrit.libreoffice.org/59643
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

The AdES validator at
<https://ec.europa.eu/cefdigital/DSS/webapp-demo/validation> recently
learned to deal with ODF files, this improves its output, so that
"Qualification Signature" section is no longer just a red "N/A" but an
orange "Indeterminate QESig".

Change-Id: I5f47b935f1dbfa4e2eee4654db31403479cb571d
Reviewed-on: https://gerrit.libreoffice.org/59633
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

MS formats only have support for Table and Cell fill.

Interestingly, MS Word doesn't let the cells inherit from
the Table fill setting,
so that value also needs to be written out into every cell.

Since Word apparently ignores the table color, I didn't
bother trying to search out how to export that in RTF
format.  (I did add it to DOCX since it was so easy to find.)

Change-Id: I7fe7723fb1603bc60608762aea79ff3b8122e073
Reviewed-on: https://gerrit.libreoffice.org/59282
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

So next time I write <data type="ST_Foo"> instead of <ref
name="ST_FOO">, I get an error quickly.

Change-Id: Ida91b8ebe68915e22c62addffafe418ab29b1158
Reviewed-on: https://gerrit.libreoffice.org/59661
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

* Update helpcontent2 from branch 'master'
  - Refactor help page on empty cells
    
    Change-Id: I8bff8e56804fae90a71fb35c0a67b015356c2138
    Reviewed-on: https://gerrit.libreoffice.org/59585
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Change-Id: Ic8bc7423765f8610d92ca3ced4c52d4838b7699a
Reviewed-on: https://gerrit.libreoffice.org/59653
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

* Update dictionaries from branch 'master'
  - Migrate the Turkish dictionary to hunspell-tr
    
    It had been permitted to be re-licensed under MPL v2.0,
    by the original author of the extension.
    
    It has fewer words, but a lot less false-positives,
    and false negatives.
    
    The original author offered to update the dictionary,
    if we provide him with a word list.
    
    Change-Id: Ideb27da220dcf10dabc924996362b549a5373352
    Reviewed-on: https://gerrit.libreoffice.org/59258Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
    

Change-Id: Ice56d317087dd24d2eef27f2ace5fdf9f4da946d
Reviewed-on: https://gerrit.libreoffice.org/59654
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

AppArmor denies writing to .ps files and dealing with temporaries needed
for "Print to file" functionality. Add .ps to the allowed extensions
list, also giving access to rm executable together with writing
printing-related temporary file.

Change-Id: I415e1401878bff6459f42162d4e8b517261b9cec
Reviewed-on: https://gerrit.libreoffice.org/59114
Tested-by: Jenkins
Reviewed-by: Rene Engelhard <rene@debian.org>

LibreOffice writes the properties visible, printable and locked of
layers into items in the subfile settings.xml and handles them as
properties of the view. ODF handles them as property of the layer.
To become more ODF conform as a first step these properties are now
read and written. They are used to initialize the view in case they
are missing in settings.xml, which is the case for foreign documents.
The ODF properties are written in addition to the items in
settings.xml, so that older versions will notice no difference with
such documents. SdModelTestBase is changed to handle odg as Draw
document.

Change-Id: I190ecc51fc6ee91ec4b96d06bb216ce517bdfcfe
Reviewed-on: https://gerrit.libreoffice.org/59269
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

* Update helpcontent2 from branch 'master'
  - Review date and time functions help pages
    
    fix some formatting issues
    Add note and warning on date parsing
    Mute l10n in some tables with constants
    
    Change-Id: I86b4e7651ac89e2d2c8e2e658a8bdfd8f185ab60
    Reviewed-on: https://gerrit.libreoffice.org/59582
    Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
    

Change-Id: I62c26622992447fd0dbc5fa857cb7231e9d00154
Reviewed-on: https://gerrit.libreoffice.org/59652
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

This allows using the logger on Windows with default settings
(not having TAGLOGGERTMP variable set).

Change-Id: Ic2be0ae90b2278b8c605aaa9f16f71fa16e7fcfe
Reviewed-on: https://gerrit.libreoffice.org/59657
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

SetTimer is a continuous timer, but we want to use it as a
one-shot, so make sure we actually kill it when not needed.

Change-Id: If6f5374346dc530eb664545ade2c2955885941b5
Reviewed-on: https://gerrit.libreoffice.org/59589
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Nobody else will handle our scheduler or WM_TIMER event, so
there is really no point to return any error value from the
handlers to some lower level function.

Change-Id: I33eac11076a30220cfa11cec8f352bd5c8b69209
Reviewed-on: https://gerrit.libreoffice.org/59588
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

The value 100000 already was in the year 2000 initial commit,
probably some memory and performance constraints back then. At
least one full column should be sortable, make it two so we don't
bail out that early for functions like MODE() that can take
multiple ranges. In fact maybe ScMatrix::IsSizeAllocatable()
should be taken into account, which is much larger though and
QuickSort() might not play well with it.

Change-Id: I061abfd0f061c8df62c31468df744eb5dc7152be
Reviewed-on: https://gerrit.libreoffice.org/59637Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Change-Id: Iee7b31f1b1a498b99f027cc9f5aeb60360213e51

Change-Id: Ifc28ac50a453eef8aa2f31d02ac513db0222eb4e

Change-Id: I32502b6b412afbe4c46a6efe0ca49dc50913673d
Reviewed-on: https://gerrit.libreoffice.org/59651
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Change-Id: I0a6a4c119cab8948b34fb6f32d8ec5066426e42e

If it's a first build, there are no Makefiles in the build dir.

Change-Id: Idec99145a5fb273921f58d92013a1c882cb8b026

Change-Id: Iefe1446e5f28471c6cafd256b29612c2457e42fc
Reviewed-on: https://gerrit.libreoffice.org/59640
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

Change-Id: Ic3536c1dd1e2aa9dd19af66db1b9a50fd8ef90e6
Reviewed-on: https://gerrit.libreoffice.org/59639
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

Change-Id: I3b03e3a75f5a6157479582e74be349c567fc1e8c

* Update helpcontent2 from branch 'master'
  - tdf#117592 Collateral file trigon.ods for NL
    
    Change-Id: Iec97f54113f398f97e751878422cfb0bc541fef5
Signed-off-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    Reviewed-on: https://gerrit.libreoffice.org/59609
    Tested-by: Jenkins
    

* Update helpcontent2 from branch 'master'
  - Mention ICU list of regular expressions
    
    ... because we use that engine under the hood.
    
    Change-Id: Icf72dfe7534ccad26cc4ee0aefd7d3f03817e65d
    Reviewed-on: https://gerrit.libreoffice.org/58969
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Change-Id: I1312371b1e95d93b6fa3e200851f5bfbf237d256
Reviewed-on: https://gerrit.libreoffice.org/59634
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I8a5f886306e028f06243768376b2a6c55df6063c
Reviewed-on: https://gerrit.libreoffice.org/59210
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

Change-Id: I3a1699efe5335c43f79a15c3487f8deb7d1be5c6
Reviewed-on: https://gerrit.libreoffice.org/59635
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Also a bit of fallout management overreaching into
include/

Change-Id: I99bd4527ecf34e5193602f0e9dcb33b504e8c9e1
Reviewed-on: https://gerrit.libreoffice.org/58808
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I7b768694ba5a82f7273fd7641fae5c3fc84233a6
Reviewed-on: https://gerrit.libreoffice.org/58340Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Jenkins

Change-Id: I001da359569d37afe482cdbb50e9c8b3ced24aff
Reviewed-on: https://gerrit.libreoffice.org/58134
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

into an existing document since....

commit deaa16bd
Author: Serge Krot <Serge.Krot@cib.de>
Date:   Mon Jan 29 12:17:06 2018 +0100

    tdf#72942 Do not overwrite styles from the inserted doc

    During inserting of the text from the external document
    we should not change original default styles in
    currently opened document.

because missing styles aren't created, so there's exceptons
thrown on their use.

I see that the m_bIsNewDoc flag is already checked for since...

commit 5ebe826c
Author: Miklos Vajna <vmiklos@collabora.co.uk>
Date:   Fri Oct 4 11:02:59 2013 +0200

    fdo#69384 fix impress -> writer copy&paste

    Regression from 2ade0712 (fdo#62044 RTF
    import: don't overwrite existing styles when pasting, 2013-06-04),
    during paste, if existing style was found, then the intention was to
    skip that style, but instead we tried to create one.

in the body of the following loop, which should mean that existing
styles are left alone and only missing styles created if we remove
this hunk of the tdf#72942 commit

Change-Id: Ia4aedb5e309c991490656061aa20d11ff24f4f9e
Reviewed-on: https://gerrit.libreoffice.org/59519
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

...in 26b40fcf "Moving mysqlc into connectivity
as a library", apparently without replacement

Change-Id: Ia1d32f98bd90efe2fcd4441dd84cd1862a4daa70

Change-Id: I8c71fe9a5ae0d228313b6b66752ee93aae72f539

Change-Id: I56db3db23361590b5d2c09bc8f6f23a02ccd7f60
Reviewed-on: https://gerrit.libreoffice.org/59570
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

since it has nothing to do with the headless command line option, so
use the name it has in the configure.ac file

Change-Id: Ibf0615ed02695d6e48a797f5632e4f417c010c70
Reviewed-on: https://gerrit.libreoffice.org/59611
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>