Change-Id: I55f4c0388b99cfebe647be1c35a9fd4bb2acf7ce

and

coverity#1351881 Resource leak

Change-Id: Ifdbff9d164f3b8b2ce5f59b6e18e6744202d0184

and

coverity#1351882 Useless call

sigh, silly me

regression from

commit 2ce227a7
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Thu Feb 4 09:17:42 2016 +0000

    coverity#1351755 Dereference null return value

Change-Id: I6d6841d04f9bba68ec2077d874dcd24edbf4ab6c

since

commit 2503a1e9
Author: Bryan Quigley <gquigs@gmail.com>
Date:   Wed Jan 27 12:19:28 2016 -0500

    tdf#96414 Remove showing navigator during slideshow

Change-Id: If3949c2527334107d1ca8af2bee50ec4b7b2947a

Change-Id: Ibd7183423cf9f6c984218e8b896a9593f9c04a2e

Change-Id: Ia2d8944227c6be8b5ae7b42f7d566ac150d522b9

Change-Id: I3e86b57b6384370666f023115ae7d4671f1eaca1

Change-Id: I85488439b06fddd73074757f1149dec5d988099d
Reviewed-on: https://gerrit.libreoffice.org/22161Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I794cb2f3f31e9ce48f3568bd5a4afc52abf0f934
Reviewed-on: https://gerrit.libreoffice.org/22160Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I55d5c2729a23bfdf079480f4d3adc41e9d8e03f2

Change-Id: Ifd5b544ad1374f13e3efc8c7a51601fadf1e14b6

Places that had utl::TextSearch::UpgradeToSearchOptions2() introduced
are worth an inspection if the new SearchAlgorithms2::WILDCARD search
should be supported or at least use SearchOptions2 instead of
SearchOptions to eliminate the small performance penalty that conversion
involves.

Change-Id: I565f73af2b551ae9ad0f488e672823dc6c5c1109

Change-Id: Ie6da8994451deca5577503e116281441c6358a6d

It's just the root element so far.

Change-Id: If32e9e5bf339f639a20fa88d85e826e14f65dac2

_rels/origin.sigs.rels of the _xmlsignatures temporary storage now
contains references to the individual signature streams.

Change-Id: I619bd81989e3b62fc4282e0e72fbfa780d1fb8bd

Change-Id: Ide7fe1388ffe6f85a1f459037316d03193470d8a

since maybe...

commit ead04f8f
Author: Philipp Lohmann [pl] <Philipp.Lohmann@Sun.COM>
Date:   Fri Dec 3 16:21:36 2010 +0100

    vcl118: #i115905# improved clip region interface on SAL layer (part 1, windows implementation)

Change-Id: Iaeb49b60f70a9f595b67c7eb307a2e90b58d7150

Change-Id: Ida1e27322bad5d2d36ae4217bb84187a022ebadf

Project: help  f0d7b49840e48ac130e57a7304a10b2a75b5fccd

tdf#70141 Add help page for font embedding

Add help page for font embedding in document file. The property
was introduced in release 4.1 by tdf#42195

Copyedit welcome.

Change-Id: I265ead91ffba632450169a424b122a21a17eb56c
Reviewed-on: https://gerrit.libreoffice.org/22025Reviewed-by: Olivier Hallot <ohallot@collabora.co.uk>
Tested-by: Olivier Hallot <ohallot@collabora.co.uk>

It's an empty file, with the only purpose to have relations, referencing
the individual signature streams. The only tricky part is that a temp
file needs closeOutput() to flush its contents, flush() is not enough.

Change-Id: I92ac61bce201c97a727ff02b1bb74599573a1807

Change-Id: Iee4b0a4e2582dff71aaaf1432adfc891cfb0a195
Reviewed-on: https://gerrit.libreoffice.org/21896Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>

... and drop some obviously unnecessary SolarMutexGuards.

Change-Id: Ie61198a264d52d1ebf7bd7c7de12a83845f4beb1

Change-Id: I51139c1c7658e6b71ebb704a8d02d1a8366a32d5

Now SolarMutex is locked only once in the destructor.

Change-Id: I945fcf2ac25ddc46fef521777109f4b4ac5e5232

Change-Id: If86bf825a714be00d678d50e80adddaced48c3e2

Change-Id: Id2002e535fa1a0c04aadd96e70ed2683bd5eb603

Happened when loading a report from the attachment of tdf#97033,
but that bug is apparently about a different crash.

Deploy the sw::UnoImplPtr, which is clearly the best way to avoid such
problems.  Also another silly weak pointer this, for tdf#72695.

Change-Id: Ice8db95ca3eecc638bd4a4ef7fa8967d180bd525

Change-Id: I4382949a35df3877fc6c93a83d6e84cd892756a8

regression from...

commit 2503a1e9
Date:   Wed Jan 27 12:19:28 2016 -0500

    tdf#96414 Remove showing navigator during slideshow

    This isn't very user-friendly and the presenter console
    does a much better job of this.

Change-Id: I10bec1bcd2305524446a20a34494c265330e4c10

.uno:CharBackgroundExt is supplementary to .uno:BackColor.

When .uno:BackColor is set, Writer turns into a 'watercan' mode, where the
user directly marks parts of the text with the wanted background color.

.uno:CharBackgroundExt then controls this watercan mode - dispatching it
toggles the watercan mode on/off, and also the StateChanged events reflect the
on/off mode accordingly.

Change-Id: I6472eb39129d1b1517fba14bad584cbd125e826a

jni_md.h not in $JAVA_HOME/include anymore in OpenJDK8 (it was in 7)

Change-Id: Id5c737182a8e476b609887753047fa7ed6b01193

The code that the comment is talking about was removed by the commit:
fb6edeb2
Let's remove the comment to spare our selfs from confusion

Change-Id: I7bdefb0ead5139be009bfb8dd7d9ad7c6821e3e8
Reviewed-on: https://gerrit.libreoffice.org/22120Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

A 'signatures relation' is kind of a pointer that says where is the list
of signatures. When adding the first signature, this has to be created,
in addition to the actual signature relation.

This is yet another difference to ODF signing, where the signature is
just another additional stream in the package, while OOXML signing first
modifies the package to add the signatures relation, and then signs the
streams, so the input storage of the OOXML signing can't be a read-only
storage.

Change-Id: I81a976c945b28ddf7f347c4a7bfd51f98a1fc225

... when height and width are different

SVG specifies embedded graphics to keep their aspect ratio (thanks to Regina for pointing out).
To implement this for Office SVG import, I had to correctly set the graphic data unit dimensions to make the existing SvgAspectRatio mapping work.
All together this now simplifies this method and packs all in clean linear transformations in the created stack of drwainglayer primitives.

Change-Id: Id80c2f74ffb148085085b2c9627bc31bc15bdee5
Reviewed-on: https://gerrit.libreoffice.org/21830Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
Tested-by: Armin Le Grand <Armin.Le.Grand@cib.de>

(5abe0ab1).
6884f53a "default B2DRange ctor doesn't do what
I thought it did" had reverted it, but the fix there is apparently not enough
yet, <http://ci.libreoffice.org/job/lo_ubsan/165/console> still fails with

> /vcl/headless/svpgdi.cxx:1274:28: runtime error: value 1.79769e+308 is outside the range of representable values of type 'int'
>  #0 0x2b826285b4d3 in SvpSalGraphics::releaseCairoContext(_cairo*, bool, basegfx::B2DRange const&) const /vcl/headless/svpgdi.cxx:1274:28
>  #1 0x2b8262868c3b in SvpSalGraphics::drawPolyPolygon(basegfx::B2DPolyPolygon const&) /vcl/headless/svpgdi.cxx:899:5
>  #2 0x2b826286c6f6 in SvpSalGraphics::drawPolygon(unsigned int, SalPoint const*) /vcl/headless/svpgdi.cxx:551:5
>  #3 0x2b826179915c in SalGraphics::DrawPolygon(unsigned int, SalPoint const*, OutputDevice const*) /vcl/source/gdi/salgdilayout.cxx:419:9
>  #4 0x2b82604d6f5a in OutputDevice::DrawEllipse(Rectangle const&) /vcl/source/outdev/curvedshapes.cxx:67:13
>  #5 0x2b8261f02c4d in CircType::Draw(OutputDevice&) /vcl/source/filter/sgvmain.cxx:596:13
>  #6 0x2b8261f0ddc6 in DrawObjkList(SvStream&, OutputDevice&) /vcl/source/filter/sgvmain.cxx:698:100
>  #7 0x2b8261f1462a in SgfFilterSDrw(SvStream&, SgfHeader&, SgfEntry&, GDIMetaFile&) /vcl/source/filter/sgvmain.cxx:820:26
>  #8 0x2b8261f16726 in SgfSDrwFilter(SvStream&, GDIMetaFile&, INetURLObject const&) /vcl/source/filter/sgvmain.cxx:858:22
>  #9 0x2b8261e48f33 in GraphicFilter::ImportGraphic(Graphic&, rtl::OUString const&, SvStream&, unsigned short, unsigned short*, GraphicFilterImportFlags, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>*, WMF_EXTERNALHEADER*) /vcl/source/filter/graphicfilter.cxx:1670:30
>  #10 0x2b8261e3c85a in GraphicFilter::ImportGraphic(Graphic&, rtl::OUString const&, SvStream&, unsigned short, unsigned short*, GraphicFilterImportFlags, WMF_EXTERNALHEADER*) /vcl/source/filter/graphicfilter.cxx:1314:12
>  #11 0x2b827bb9fee3 in VclFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) /vcl/qa/cppunit/graphicfilter/filters-test.cxx:60:12
[...]

Change-Id: Icb8f52414f57f08334fc501842b3f75c1d3642eb

Change-Id: I959279c11f0ae5f372936ee3db605716cab37c21

Change-Id: Ic78ae8ce5bf396f55fdc847d6b70476c9dab4ee9

Change-Id: I706e65777c3f7ec1af255d93ffa31925e75fb2b7
Reviewed-on: https://gerrit.libreoffice.org/22123Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ide7446e1aebe698277b13cc7eeb39efe16af3ec2

Change-Id: I9660690b29da411dcdf148007242ffa944957f78