Kayıtlar (commit) · 975ab665df3158799cbde1146e124d8c08b4d9df · LibreOffice / core

02 Eyl, 2015 3 kayıt (commit)

tdf#93750 allow for EMF+ record padding up to 11 bytes · 975ab665

Mike Kaganski Agu 28, 2015 yazdı

When an array of EMF+ has extra bytes in the end, that are less than 12,
they should not be  treated as another EMF+ record, but simply ignored.

Change-Id: I34701c00916812c8a6a4b69730f602da81719b35
Reviewed-on: https://gerrit.libreoffice.org/18110Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit daecb93a)
Reviewed-on: https://gerrit.libreoffice.org/18200Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

975ab665

tdf#93532 - Switching to 64-bit checksum · f85ed94f

Marco Cecchetti Agu 26, 2015 yazdı

Added a C++ and a GLSL implementation of a 64-bit CRC algorithm.

Changed hardcoded checksum value in ooxmlimport unit test (testN777345).

Change-Id: I16bb985a14866775efda49e21fe033ff64645896
Reviewed-on: https://gerrit.libreoffice.org/18254Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

f85ed94f

windows opengl: When the 2nd param is NULL, the 1st is ignored anyway. · 7017ab35

Jan Holesovsky Eyl 01, 2015 yazdı

Change-Id: I840e8bb2d2ccae869c330bb32dba484b4a835a51
Reviewed-on: https://gerrit.libreoffice.org/18248Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

7017ab35

01 Eyl, 2015 31 kayıt (commit)

tdf#93600: Avoid crash on entering '=' as a cell value · f2a367ff

Katarina Behrens Agu 29, 2015 yazdı

To match formulas, 'formula is' condition should be used instead

Change-Id: I37a9a2680c49bffcb8b25a11faedc1421cfa2d00
Reviewed-on: https://gerrit.libreoffice.org/18126Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-on: https://gerrit.libreoffice.org/18159Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

f2a367ff

check for ridiculous lengths and check stream status · 315cd789

Caolán McNamara Agu 31, 2015 yazdı

Change-Id: Iefe943794e005f03b2a6ea5fc642b8c3d21b3334
(cherry picked from commit 858257d4)
Reviewed-on: https://gerrit.libreoffice.org/18173Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

315cd789

check stream status · 03d15f27

Caolán McNamara Agu 31, 2015 yazdı

Change-Id: I27bb289288d319a93201e9c3d703114924ca258c
(cherry picked from commit daf1578d)
Reviewed-on: https://gerrit.libreoffice.org/18177Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

03d15f27

sd: Don't crash when the sidebar is hidden · 2575e441

Maxim Monastirsky Agu 30, 2015 yazdı

Change-Id: I09a5019a98b529ba11f07392906a3e0fb7bc1bac
(cherry picked from commit c511b279)
Reviewed-on: https://gerrit.libreoffice.org/18243Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

2575e441

tdf#93838 windows opengl: fix vertical text position in UniscribeLayout · 7abc8172

Miklos Vajna Eyl 01, 2015 yazdı

For one, aPos.Y() is meant to be the baseline position of the text.
Based on the MSDN documentation and
<https://www-user.tu-chemnitz.de/~ygu/petzold/ch05c.htm>, that means if
we want to get top position, we have to only extract tmAscent and not
tmInternalLeading.

For another, ImplWinFontEntry::AddChunkOfGlyphs() adds a border of 2
pixels both horizontally and vertically, which means that then we need
to undo that when counting the vertical position, too.

Change-Id: I4ac8e881ea5910662674c2a1b53ece943487ccd9
(cherry picked from commit b1a918ae)
Reviewed-on: https://gerrit.libreoffice.org/18244Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

7abc8172

tdf#93839 - Encourage vdevs to pick up new GL Contexts when they go invalid. · eb9e5a86

Michael Meeks Eyl 01, 2015 yazdı

Change-Id: I21726d0dd052fdc87e8dd36ff7122518325f6313
Reviewed-on: https://gerrit.libreoffice.org/18242Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

eb9e5a86

sids unsorted · dae95dbb

Caolán McNamara Eyl 01, 2015 yazdı

since

commit 74ef8a41
Author: Maxim Monastirsky <momonasmon@gmail.com>
Date:   Sun Dec 7 01:18:06 2014 +0200

    Introduce ParaspaceIncrease/Decrease commands in Writer and Calc

Change-Id: I53dab158160ed9840404e60917fbb8725517bcd3
(cherry picked from commit 34ebb26d)
Reviewed-on: https://gerrit.libreoffice.org/18241Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

dae95dbb

Caolán McNamara Eyl 01, 2015 yazdı

Change-Id: Ice9a860ca839d37308b5c2f2eb639852fefe1d15
(cherry picked from commit dcb0738b)
Reviewed-on: https://gerrit.libreoffice.org/18240Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

305aaf3b

tdf#93772 - handle framebuffer unbinding on GL context switch. · 77d7cab8

Michael Meeks Agu 29, 2015 yazdı

Also start gl tests in vcldemo:
    $ SAL_FORCEGL=1 vcldemo --gltests

Change-Id: I8f0022770d57cd60c830659e3f7fcc0721320a10
Reviewed-on: https://gerrit.libreoffice.org/18135Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

77d7cab8

tdf#93351: Edit style button in Schema & Numbering should point to List styles · fba2fee2

Julien Nabet Agu 22, 2015 yazdı

Related to http://cgit.freedesktop.org/libreoffice/core/commit/?id=e38f63d861715fb56f41af82b897c2128ea20b38

Change-Id: I4ede777207fe42dede6e82c7399189354f182f6a
Reviewed-on: https://gerrit.libreoffice.org/17924Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
(cherry picked from commit ad8e2baf)
Reviewed-on: https://gerrit.libreoffice.org/17991Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

fba2fee2

Extended GL painting debug tracing. · 06c595d7

Michael Meeks Agu 29, 2015 yazdı

Change-Id: I52158729d240ca3cb9e7977bc6d1f5acb14437ad
Reviewed-on: https://gerrit.libreoffice.org/18134Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

06c595d7

SIFR: Fix insert row and column icons and correct arrowsquare icon · bb274290

Yousuf Philips Agu 30, 2015 yazdı

Change-Id: I49352d85378fa45a07c8ccd402f17e3178e6dabc
Reviewed-on: https://gerrit.libreoffice.org/18139Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
(cherry picked from commit 30211d1e)
Reviewed-on: https://gerrit.libreoffice.org/18234Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

bb274290

windows opengl: Call InitGLEWDebugging() after we have the context. · e52845ef

Jan Holesovsky Eyl 01, 2015 yazdı

Change-Id: I1582443cf6799dd73a3909660d524eaacbc2d909
Reviewed-on: https://gerrit.libreoffice.org/18237Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

e52845ef

windows opengl: Don't paint cached widgets upside down. · 9d747c42

Jan Holesovsky Eyl 01, 2015 yazdı

Change-Id: Idf1e4bd06c2c6d2371c634e68baf4fd0a7763cb1
Reviewed-on: https://gerrit.libreoffice.org/18233Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>

9d747c42

Resolves: tdf#91060 don't crash on loading certain pptx · 414230d6

Caolán McNamara Eyl 01, 2015 yazdı

Change-Id: Ibf32ef644222a59c5fe6a9736ff64739ab24b74f
(cherry picked from commit c874bf3f)
Reviewed-on: https://gerrit.libreoffice.org/18225Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

414230d6

Turn on glyph caching by default when using OpenGL · 4c942942

Tor Lillqvist Agu 25, 2015 yazdı

Can now be turned off with a SAL_DISABLE_GLYPH_CACHING environment variable.

Change-Id: I7ac14d72dc0f85c0682d92492eb96bec1d207609
(cherry picked from commit 9a68eb9c)
Reviewed-on: https://gerrit.libreoffice.org/18230Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

4c942942

check stream status · 508125f9

Caolán McNamara Agu 31, 2015 yazdı

Change-Id: I65ed5979d35d8739367294a71620782b832cfd71
(cherry picked from commit a8fe085f)
Reviewed-on: https://gerrit.libreoffice.org/18160Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

508125f9

check stream status · 2ab9d3ea

Caolán McNamara Agu 29, 2015 yazdı

Change-Id: I6b9537cf94ac1c5d996ba64ddf878745dadde254
(cherry picked from commit 452cd9e7)
Reviewed-on: https://gerrit.libreoffice.org/18128Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

2ab9d3ea

Updated core · 713725c1

Christian Lohmaier Eyl 01, 2015 yazdı

Project: dictionaries  71f54e95a0b443c673f924c71e23d04b540cc441

tdf#93514 remove Czech thesaurus

Change-Id: I40ebd1ca223fe7950ed3280c43a51a3dfbd0070e
(cherry picked from commit 03a4a7b13f28c2c8df08cf6d5049fde97d6b4244)

713725c1

tdf#93713 Add 'Unprotect Cells' to Table menu · 9e1f0209

Yousuf Philips Eyl 01, 2015 yazdı

Change-Id: Iad667e78c812d794f91d0a22323977e2b79408d9
Reviewed-on: https://gerrit.libreoffice.org/18222Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

9e1f0209

tdf#73071 Fix minor spacing issue in style section · 6681627f

Yousuf Philips Eyl 01, 2015 yazdı

Change-Id: Ied562af293a4e970b9963f566d85a79375737954
Reviewed-on: https://gerrit.libreoffice.org/18221Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

6681627f

Revert "windows opengl: Set PFD_DOUBLEBUFFER even for single buffer rendering" · 9a267b26

Miklos Vajna Eyl 01, 2015 yazdı

This reverts commit 6fd71992. Kendy says the
original problem can't be reproduced anymore, and most unexpected flickering
goes away with this for my nvidia card.

Also, it's a good idea in general to keep PFD_DOUBLEBUFFER and
WGL_DOUBLE_BUFFER_ARB in sync, which is now the case.

Change-Id: I7a809d1c85be4206c01720d5de9b0a5617a59c87
(cherry picked from commit dbf5882a)
Reviewed-on: https://gerrit.libreoffice.org/18223Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

9a267b26

tdf#91022: Incorrect Dates in Report created with legacy report wizard · f46d8fd4

Julien Nabet Eyl 01, 2015 yazdı

Regression from http://cgit.freedesktop.org/libreoffice/core/commit/?id=5d8ecad569fd7a254902da154ed8057ec61f3a83
Thank you Matthew Francis for having found the root cause!

Change-Id: I4128368a5f5df6a9fc5f7668fb1f8f330b5795b9
Reviewed-on: https://gerrit.libreoffice.org/18210Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
(cherry picked from commit ed33646c)
Reviewed-on: https://gerrit.libreoffice.org/18224Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

f46d8fd4

Compensate for the extra two pixels in ImplWinFontEntry::AddChunkOfGlyphs() · 8b4268dc

Tor Lillqvist Agu 31, 2015 yazdı

Should do similarly for vertical text, too.

Change-Id: I51f5ee3ba1686f151b04f98c43388e0bdfac97fb
(cherry picked from commit 860d6948)
Reviewed-on: https://gerrit.libreoffice.org/18181Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

8b4268dc

tdf#93751 - ensure textures are unbound from framebuffers post destroy. · 0a3cfc66

Michael Meeks Agu 31, 2015 yazdı

Change-Id: I81aec0e6f8db57905826c54c3442528be6068700
Reviewed-on: https://gerrit.libreoffice.org/18184Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

0a3cfc66

Fix the OpenCL VLOOKUP to work properly and add it to the trusted subset · 3253cc2b

Tor Lillqvist Agu 25, 2015 yazdı

Treat an array of null string pointers as no strings for OpenCL. For
some reason, at least in the case of the "Test OpenCL" thing, we got
an mpStringArray that is non-null but where all the elements
(rtl_uString pointers) in it are null. Treat that case as if the
mpStringArray was null.

This makes the tests "Test OpenCL" actually use OpenCL. Maybe it has other
useful effects, too. (But for normal spreadsheet use, the mpStringArray that
gets handled here *is* null when all the cells used by a formula group are
numbers. At least it seemed so in a simple test.)

Add a few more useful (?) SAL_INFO calls.

Some cosmetic changes to make the code look saner.

Return correct value from the OpenCL VLOOKUP implementation. Also,
when the lookup fails, produce the expected N/A error code instead of
a bare NaN.

Don't claim we support strings arguments in the OpenCL VLOOKUP.  The
string support certainly isn't complete or correct anyway. Partially
revert c3383aaf.

Add VLOOKUP to the set of opcodes that we trust the OpenCL
implementation for.

(cherry picked from commit 7e91726f)
(cherry picked from commit d4310b6c)
(cherry picked from commit 32b35d9d)
(cherry picked from commit 41a60940)
(cherry picked from commit 16226445)
(cherry picked from commit 7bb7539c)

Change-Id: I5402732c9ddcac1efcc25960a5c46175d7a90b4d
Reviewed-on: https://gerrit.libreoffice.org/18022Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

3253cc2b

tdf#93530 - glClear our depth, stencil and buffer contents on init. · bcef0483

Michael Meeks Agu 27, 2015 yazdı

Change-Id: I117fd5f5fd12fd6534b9d10532a39807ad82ce71
Reviewed-on: https://gerrit.libreoffice.org/18069Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-on: https://gerrit.libreoffice.org/18220Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

bcef0483

vcl opengl: fix setting up debug context on Windows · 20c92dc6

Miklos Vajna Agu 14, 2015 yazdı

At least with my AMD card, in case of SAL_FORCEGL=1 the startup crashes
quite early. DrMemory says:

~~Dr.M~~ Error #1: UNADDRESSABLE ACCESS: writing 0x00001414-0x00001415 1 byte(s)
~~Dr.M~~ # 0 atioglxx.dll!DrvPresentBuffers                          +0xd6ea6  (0x09a248f6 <atioglxx.dll+0x1248f6>)
~~Dr.M~~ # 1 atioglxx.dll!DrvPresentBuffers                          +0x3c069c (0x09d0e0ed <atioglxx.dll+0x40e0ed>)
~~Dr.M~~ # 2 vcllo.dll!OpenGLContext::InitGLEW                        [c:\lo\master\vcl\source\opengl\openglcontext.cxx:949]
~~Dr.M~~ # 3 vcllo.dll!OpenGLContext::ImplInit                        [c:\lo\master\vcl\source\opengl\openglcontext.cxx:866]
~~Dr.M~~ # 4 vcllo.dll!OpenGLContext::init                            [c:\lo\master\vcl\source\opengl\openglcontext.cxx:786]
~~Dr.M~~ # 5 vcllo.dll!WinOpenGLSalGraphicsImpl::CreateWinContext     [c:\lo\master\vcl\opengl\win\gdiimpl.cxx:36]

Turns out that in order to enable the GL_DEBUG_OUTPUT_SYNCHRONOUS_ARB
extension, the GL context must be created with WGL_CONTEXT_DEBUG_BIT_ARB
set. It seems that other drivers did not enforce this so far, but in
this case the driver just crashes without this.

Fix the problem by splitting out the debug setup part of InitGLEW() into
a new InitGLEWDebugging(), and at least on Windows call it only after
wglCreateContextAttribsARB() and wglMakeCurrent(). Additionally make
sure that in the debug case the necessary flag is passed to
wglCreateContextAttribsARB().

Conflicts:
	vcl/source/opengl/OpenGLContext.cxx

Change-Id: I6b77e0c06fd85fdae0386a0801f1de1838524586
Reviewed-on: https://gerrit.libreoffice.org/17750Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-on: https://gerrit.libreoffice.org/18219Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

20c92dc6

get rid of a few thousand unnecessary OpenGL calls · 8cb5adc2

Markus Mohrhard Haz 12, 2015 yazdı

For each iteration of the (gtk) main loop we are dropping the yield
mutext which results in calling OpenGLContext::clearCurrent. That method
calls OpenGLContext::ReleaseFramebuffers which would call in the end
glBindFramebuffer for each framebuffer related to that context.

This would easily grow into the thousand OpenGL calls without doing any
work.

Change-Id: I209cc534fe58a5e11ef7df7f850a787916b8bd43
Reviewed-on: https://gerrit.libreoffice.org/16241Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-on: https://gerrit.libreoffice.org/18218Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

8cb5adc2

tdf#93736 opengl: use "old" SubdivideBezier when drawing PolyLines · d12f8f49

Tomaž Vajngerl Eyl 01, 2015 yazdı

SubdivideBezier creates polygons which are more exact for drawing
in opengl when drawing hairline PolyLines - so let's use that with
AA line drawing.

(cherry picked from commit b3de73f3)

Change-Id: I490fd0f19361b5fc9e1f4e03851c1ae1a1f75f71
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>

d12f8f49

tdf#93822 - disable horror legacy menu background saving for OpenGL. · bce18e96

Michael Meeks Agu 31, 2015 yazdı

Change-Id: Icaa5fb197f3fa234da4538a2a7b21131cab89277
Reviewed-on: https://gerrit.libreoffice.org/18203Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

bce18e96

31 Agu, 2015 6 kayıt (commit)

update emoji autocorrect entries from po-files · 2ca27755
Christian Lohmaier Agu 31, 2015 yazdı
```
Change-Id: If0dc78a2d6e3c9fccf37504902abab07bfea8200
```
2ca27755

Updated core · acb7fef8

Christian Lohmaier Agu 31, 2015 yazdı

Project: translations  4fa65dd50ea6f91747c7ea50d70eb64c3624ba3e

update translations for 5-0

and force-fix errors using pocheck

Change-Id: I6c11b6e05f8c2a2c6df3d9cf7b7773da7849c8f1

acb7fef8

vcl: Improve management of mnRef0Count. · 44377b91

Jan Holesovsky Agu 31, 2015 yazdı

Follow-up to 34700400; this fixes sw_ww8export
unit test on Windows.

Change-Id: Ic0c3228efb59a182e1562b73117418cd8b5e6017
Reviewed-on: https://gerrit.libreoffice.org/18175Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

44377b91

Add missing helpful GL trace messages outside of the impl. itself. · 64895577

Michael Meeks Agu 28, 2015 yazdı

Change-Id: I5b71e3c9edc3e1e89e52c2e17b5fe0a025ac66ea
Reviewed-on: https://gerrit.libreoffice.org/18109Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

64895577

Avoid bogus warnings with VCL_GL_INFO, by making the optimizer work. · 3583320a

Michael Meeks Agu 28, 2015 yazdı

Change-Id: Ia4afcd58b4ce0b4d6d9708a4cede0857b7633b9e
Reviewed-on: https://gerrit.libreoffice.org/18171Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

3583320a

tdf#93798 - avoid apitrace provoked infinite loop dumping errors. · 11fc36a4

Michael Meeks Agu 31, 2015 yazdı

Change-Id: I6c42e6a9ead90ed6fad2f289cd686a72cffa0c2d
Reviewed-on: https://gerrit.libreoffice.org/18165Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

11fc36a4