Change-Id: Idc0ca78da8ebbdfe8489eee92a1167eb1bd9722f
Reviewed-on: https://gerrit.libreoffice.org/16794Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Iaaeb6e6f928c6e40112b6c852a6868e1f4abdc47
Reviewed-on: https://gerrit.libreoffice.org/16793Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I3965966f0d3fe65389e8834d67452ac56f9df2d6

Change-Id: I2908fc052d44a8bddf8ebb628f67ce346ac519c7

Change-Id: Ia1e22ff95457a958ef26974091aa2092b32505bd

Change-Id: Ia7a75c4686734aa811006858343666d2edfde8a1

Change-Id: Ie1ccffe5461475a0425891861f825aeea149e876

Change-Id: I3932afa803ceb6429d4e5cf63af59131307d5c6e

Change-Id: I71b7fba7bb77c9df2befde6dc9629d3cb1586f62

To test:

Scenario 1:
* go to Writer -> Format -> Page
* select page format and orientation, if possible a different one than the default
  in your env.
* File -> Print -> Properties should now show those values (and not the default
  values from the printer)

Scenario 2 (aka Scenario 2 from tdf#61186)
* now go to File -> Printer settings
* change page format and orientation, if possible to yet a different one than the
  printer default and a page one
* File -> Print -> Properties should now show what was selected in Printer settings
  and not the format of the page

Change-Id: Ibc84540f428b79dbec2587c50eefe526a62751b3
Reviewed-on: https://gerrit.libreoffice.org/16716Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

and an on-the-fly comment translation

Change-Id: I7e2d24928c3b508db39053ea768c25048bfb5d87

The code in ScSum is mostly identical with that in IterateParameters.
Worse, functions like SUBTOTAL and AGGREGATE use IterateParameters for
the SUM function.
Now we have one set of code for all SUM-functions and averted the danger of
diverting pieces of code which are supposed to do the same thing.

Removed old-style bNull-method too.

Change-Id: Ia4f22c21c4b3c3a244ea1cd10c30d8cfcaa8ef6c
Reviewed-on: https://gerrit.libreoffice.org/15362Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Change-Id: Icb7f7cb20f5e2b200442bbc2d2bd4eb540170045
Reviewed-on: https://gerrit.libreoffice.org/16761Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>

Change-Id: Ia2bb2897bc3fdb04c89f3328718f32fecd30eb64
Reviewed-on: https://gerrit.libreoffice.org/16760Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I0a35a010d3edc8caea30e16813c937f1fa4d3ac8
Reviewed-on: https://gerrit.libreoffice.org/16797Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

0  0x00002aaab1f6a803 in VirtualDevice::InnerImplSetOutputSizePixel(Size const&, bool, boost::shared_array<unsigned char> const&, bool) (this=0x0, rNewSize=Size = {...}, bErase=true, pBuffer=..., bTopDown=false) at /home/julien/compile-libreoffice/libreoffice/vcl/source/gdi/virdev.cxx:293
1  0x00002aaab1f6ae54 in VirtualDevice::ImplSetOutputSizePixel(Size const&, bool, boost::shared_array<unsigned char> const&, bool) (this=0x0, rNewSize=Size = {...}, bErase=true, pBuffer=..., bTopDown=false) at /home/julien/compile-libreoffice/libreoffice/vcl/source/gdi/virdev.cxx:396
2  0x00002aaab1f6b1af in VirtualDevice::SetOutputSizePixel(Size const&, bool) (this=0x0, rNewSize=Size = {...}, bErase=true)
    at /home/julien/compile-libreoffice/libreoffice/vcl/source/gdi/virdev.cxx:444
3  0x00002aaae650e30f in vclcanvas::SpriteCanvasHelper::updateScreen(bool, bool&) (this=0x69daf50, bUpdateAll=true, io_bSurfaceDirty=@0x69dafe0: true)
    at /home/julien/compile-libreoffice/libreoffice/canvas/source/vcl/spritecanvashelper.cxx:316

So initialize maVDev

Change-Id: I4a79ba6e8f13c4a2bed3127742a9a9c928e133cd
Reviewed-on: https://gerrit.libreoffice.org/16770Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

That's not what XSubToolbarController was originally designed for,
probably, but it has more in common than otherwise. A split button
offers a dropdown with some functions, and the main part of that
button updates with the last selection, to easily re-apply it.

This is based on the change made in commit
dd69bde3, so that updateImage
method is called once an icon refreshing is requested.

Change-Id: I6bd15638665f917ed7060886cd7835cdcd1a34f9

Change-Id: I6a0b8bbeec94fe19b609542550f9cce783daef20

Change-Id: Ieabb075b1e324792726a6c67949fbf3e7127615d
Reviewed-on: https://gerrit.libreoffice.org/15375Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

Regression from commit beb4aa21
(SwViewShell::ImplEndAction: avoid direct paint, 2015-06-29), the
problem was that the lcl_PaintTransparentFormControls() call performs
direct paint, so it should be called only in case we don't do an async
paint via invalidate.

As expected, this call is no longer needed for the original i#107365
bug document in case SwViewShell::Paint() will be called by the main
loop shortly.

Change-Id: Ia27c551ed838d610f972f20abbb4ae9f0e1241b6

Change-Id: I55dd98b1613376c8e1c83af8ffdc66a58e022cb1

So that the sub-toolbar controller will pick the
right image size.

Change-Id: I70b642ac84377b461a001ef11f551a5e1448c0f1

Change-Id: I71d0ded04b35472f14e4764a47212c73ac500814

The doc for XSubToolbarController::updateImage says:

"gets called to notify a controller that it should set an image
which represents the current selected function.

Only the controller instance is able to set the correct image
for the current function. A toolbar implementation will ask
sub-toolbar controllers to update their image whenever it has
to update the images of all its buttons." However, it didn't
work that way until now.

Steps to reproduce:

1. Open one of the custom shapes dropdowns, and choose a shape
   other than the default. Note that the button is now updated
   with the last selection.

2. Change the icon theme. Note that the button shows now the
   default shape, despite the fact that a future activation
   of that button, will still draw the last used shape.

Change-Id: I9345c9faa17dc82a5f590b242b60751ce5d8e648
Reviewed-on: https://gerrit.libreoffice.org/16781Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

Change-Id: Ib7ea6624ac6b112779b0e64b08805538b8d6afff
Reviewed-on: https://gerrit.libreoffice.org/16796Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>

Change-Id: I2846824d402d029cde8d214f8112047243c79c54

Thanks to Stephan Bergmann.

Change-Id: I22aa3bb827db28bce3eabebb9b8c514663fad860

...but C2514 is still there

Change-Id: I818fed066b0ddaf5c30e6057285151d8a575c373

Change-Id: Ic136cce6abef44291b7236a6d709f0eee391f311
Reviewed-on: https://gerrit.libreoffice.org/16784Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ied85d93019d0f6c01c14045758b405f2ac316676
Reviewed-on: https://gerrit.libreoffice.org/16783Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I14e8bb3e4e38ade1044ce1c50c9676a65152724c
Reviewed-on: https://gerrit.libreoffice.org/16733Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ief207205b3f05dd0ed92a2d1d30e265cbdb914e3

... following commit cc96b273

Change-Id: I152875b6f72ff972d004f6df11325ce89f43ad9d

Change-Id: Ieb73b50471263212285b9c3883c082477c1ad656
Reviewed-on: https://gerrit.libreoffice.org/16729Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Regression from commit 1d9e8376 (Use
GetBoundRect() instead of Frm() in layout., 2011-04-29), this causes
problems for double-buffered rendering and also seems to be pointless,
as just above we already added the rectangle to the repaint area.

Change-Id: I3dc67143e8332ab941a683414ee318dbef13de88

One one hand, a problem since commit
330b8602 (fdo#68787 DOCX import: handle
when w:separator is missing for footnotes, 2013-09-04) was that the type
attribute from <w:footnote w:type="separator"> resulted in two
ooxml:CT_FtnEdn_type tokens, ignoring too many paragraph ends for
footnotes, which resulted in missing paragraph style on footnotes.

On the other hand, fixing the first problem showed that it wasn't
correct that commit 9389cf78 (cp#1000018
RTF import: empty para at the end of footnote text got lost, 2013-11-15)
unconditionally removed the RemoveLastParagraph() call in
DomainMapper_Impl::PopFootOrEndnote(). It turns out that RTF and DOCX
have different semantics here, the footnote is always within a <p></p>
pair in DOCX, while in RTF a \par at the end of a
footnote means an empty paragraph. Fix that by conditionally restoring
the removed RemoveLastParagraph() call.

Change-Id: I33020ac761c94addfec8164a17863565e4453b07

is e.g. an SwDrawFrameFormat instead of an SwFlyFrameFormat during
CppunitTest_sw_uiwriter

Change-Id: I97511cf516f76b12e04da61ce6fd51f61ef83241

This reverts commit 7df3879d. It's not
necessary since commit f16d82ea (make it
possible to force enable double buffering for all widgets, 2015-06-03).

Change-Id: I9e89fea4e94a91edbbe355780c2a12d6e6cb6e4a
Reviewed-on: https://gerrit.libreoffice.org/16728Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ic4d922bd27b7f119a7f8b95bbb4d4ed9e89fe51d