- 20 Agu, 2015 40 kayıt (commit)
-
-
Caolán McNamara yazdı
i.e. the sal_Int32 nDXLen = std::min<sal_Int32>(nLen, aOldDX.size()); line and its usage Change-Id: Ib0100d2de210a45b340c3a7de6c6dcf2a07443d0 (cherry picked from commit 6d4f97b0) Reviewed-on: https://gerrit.libreoffice.org/17751Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Norbert Thiebaud <nthiebaud@gmail.com>
-
Eike Rathke yazdı
Bloody workaround hack for the fact that Chart does not handle category/x-axis times internally and is not able to pass its own axis numberformat to its own databrowser editor. Change-Id: I016695ad0104366c0bb636b449a2014ade31aca3 (cherry picked from commit 711b34d5) Reviewed-on: https://gerrit.libreoffice.org/17627Tested-by:
-
Giuseppe Castagno yazdı
Added two Windows API missing errors. The errors added: ERROR_FILE_CHECKED_OUT returned when trying to access a file that is locked by another user. ERROR_INVALID_NAME returned when trying to access a local file with the wrong chars in the path or file name. Mapped to existent osl_File_E_.... for compatibility. Change-Id: I0bea1ff2727729c569b0a2cb6befd0d38289b8a2 Reviewed-on: https://gerrit.libreoffice.org/17412Tested-by:
Samuel Mehrbrodt <s.mehrbrodt@gmail.com> (cherry picked from commit b7ae1465) Reviewed-on: https://gerrit.libreoffice.org/17650Reviewed-by:
Giuseppe Castagno <giuseppe.castagno@acca-esse.eu> Reviewed-by:
Thorsten Behrens <Thorsten.Behrens@CIB.de>
-
Stephan Bergmann yazdı
6b4c596b "Fix memory leak for BASIC sub (as well as void function)," from just looking at the few lines of code in isolation, and their revision history, looked like a plausible and effective approach to fix the leaks reported by CppunitTest_basci_vba when run under lsan. However, tdf#92446 indicates that that innocent-looking change had rather dire consequences. So revert it and leave a fix for the memory leak to somebody who actually understands all this code. Change-Id: Ic81b1c14a1cfb07c6ec4415cc26b2f826adbc8ca (cherry picked from commit 9d094b9f)
-
Jan Holesovsky yazdı
The behavior was confusing from the user point of view - the "Default" meant the handout layout (that by default is 6 slides per page), not any kind of default. And it looked like the orientation does not work. Let's provide better wording instead of "Default" at least. The ideal would be also to disable the "Order" when "According to layout" is chosen. Unfortunately it is not easily possible, as the enabling/disabling is controlled by the UIControlOptions's mnDependsOnEntry, and that allows only one value; and we'd need "everything but the 0" there. Change-Id: Ife98c421bf8f52506a7dc32caea6af6c24ef17c6 Reviewed-on: https://gerrit.libreoffice.org/17696Tested-by:
Jan Holesovsky <kendy@collabora.com> Tested-by:
-
Maxim Monastirsky yazdı
Change-Id: I89f8aa5e087e95c96d63695be0ec4e9b4fbe0a0c (cherry picked from commit 4622823a) Reviewed-on: https://gerrit.libreoffice.org/17706Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
Maxim Monastirsky yazdı
Reproduced with the gen vclplug Change-Id: Ia8a5c73908f5af47ef55b4431b6e1e5a21609e7d (cherry picked from commit b556f14f) Reviewed-on: https://gerrit.libreoffice.org/17705Reviewed-by:
-
Stephan Bergmann yazdı
...after 54f10a96 "tdf#93404: Forgot to launch WakeUpThread," when the WakeUpThread blocks on locking StatusIndicatorFactory::m_mutex in StatusIndicatorFactory::update() while the joining thread blocks on StatusIndicatorFactory::impl_stopWakeUpThread() -> WakeUpThread::stop() -> Thread::join(). Change-Id: I3480014b1f522901064ea9b71ffa2ebf5d74fef5 (cherry picked from commit ded58e06) Reviewed-on: https://gerrit.libreoffice.org/17709Reviewed-by:
-
Caolán McNamara yazdı
thanks to ccsheller for noticing Change-Id: Idb0f39c48173445b750e0b85ac20b3f6b43691a7 (cherry picked from commit 348cc2ce) Reviewed-on: https://gerrit.libreoffice.org/17692Reviewed-by:
David Tardon <dtardon@redhat.com> Tested-by:
-
Caolán McNamara yazdı
Change-Id: I5186f6a65bb9d5ed8a0d1ab1d71f7e2c13865411 (cherry picked from commit ea700888) Reviewed-on: https://gerrit.libreoffice.org/17693Tested-by:
-
Maxim Monastirsky yazdı
Don't let long strings (in some languages) make it request so much space. Change-Id: I5b2af9d7cc54d1ba772ae75971cfff27bee31a05 (cherry picked from commit d2f218f5) Reviewed-on: https://gerrit.libreoffice.org/17699Reviewed-by:
-
Stephan Bergmann yazdı
...in 017f2507 "Ensure WakeUpThread is joined before exit" Change-Id: Iaa5a5772f099b11229bd40c3cc10d863ef0ad5b3 (cherry picked from commit 54f10a96) Reviewed-on: https://gerrit.libreoffice.org/17697Reviewed-by:
-
Eike Rathke yazdı
This cures only a symptom, the underlying cause is that the broadcasters still are listed in maBulkGroupAreas. Change-Id: I9625483016a51eb6f6a7e3d58ed42c7dad3a57b3 (cherry picked from commit 2d4edd7d) Reviewed-on: https://gerrit.libreoffice.org/17684Tested-by:
-
Jan Holesovsky yazdı
There is a follow-up commit in master that improves the UX, but it unfortunately changes the string, and we are past the UI freeze, so cherry-picking only the revert. This reverts commit a6a04658. Change-Id: If2732ca1c847cd1502e07a6416134fe3669de35e Reviewed-on: https://gerrit.libreoffice.org/17681Reviewed-by:
-
Miklos Vajna yazdı
E.g. in Writer create a new comment, type a word that is not in the dictionary, then a space to trigger the spelling, and that painted the spelling error indicator outside Paint(). (cherry picked from commits 71aed918 and 89bd30cf) Change-Id: I8f72486189e04a5596729fb52b6af39772f8e002 Reviewed-on: https://gerrit.libreoffice.org/17690Tested-by:
-
Noel Grandin yazdı
caused by commit 4b668293 "convert BOX_LINE and BOXINFO_LINE to enum class" (cherry picked from commit 78446df2) Conflicts: sw/source/filter/ww8/wrtww8gr.cxx Change-Id: I23eb359a40035dd40bdb60703de567b1c328e793 Reviewed-on: https://gerrit.libreoffice.org/17691Tested-by:
-
Julien Nabet yazdı
Change-Id: I59cc13cebf9a15e873cd0b7f8fccffa37a6a8f39 Reviewed-on: https://gerrit.libreoffice.org/17688Tested-by:
Noel Grandin <noelgrandin@gmail.com>
-
Caolán McNamara yazdı
Change-Id: Ie4068fdc1e54e0ad3e55354938a4c5e1459e7fe0 (cherry picked from commit 7ffe6aeb) Reviewed-on: https://gerrit.libreoffice.org/17682Tested-by:
-
Caolán McNamara yazdı
this effectively reverts commit c43ee00e Author: Herbert Duerr <hdu@openoffice.org> Date: Wed Aug 15 13:20:51 2001 +0000 #91025# reduce flicker in charmap dialog in favour of the new double buffering Paint is calling RecalculateFont which calls SelectIndex which calls Update which calls Paint, boom Change-Id: I69e9f53b7db09837ff08a2ce9fc6f81a52b5c794 (cherry picked from commit 79395c93) Reviewed-on: https://gerrit.libreoffice.org/17674Reviewed-by:
Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by:
-
Maxim Monastirsky yazdı
The sidebar has width limit, so a panel shouldn't attempt to resize more than that. Otherwise we'll get an endless loop. (based on e98cf0c6) Change-Id: Ia36535637e3585595c673c7fc46a1a7b162b74ba Reviewed-on: https://gerrit.libreoffice.org/17667Reviewed-by:
-
Jan Holesovsky yazdı
Unfortunately the original commit caused a regression. The fix of tdf#90150 is also problematic from the UX point of view - with that, the user is never sure what page he/she is looking at. Should we do any changes there, then it should show the range of visible pages, like "Pages 2-3 of 5." or "Pages 1-4 of 8." etc. This reverts commit 1622b67e. Change-Id: I371bb326da14b621a5116295ed1dc0de208f309d Reviewed-on: https://gerrit.libreoffice.org/17662Tested-by:
-
Maxim Monastirsky yazdı
Change-Id: I1ef697008dcd5e993c1d509fce055c5454d80f40 (cherry picked from commit 7d3fa6ba) Reviewed-on: https://gerrit.libreoffice.org/17668Tested-by:
-
Miklos Vajna yazdı
Regression from commit 0761f816 (123792: complete annotations on text ranges feature, 2013-12-19), the problem was that in case a comment had a reply, then both comments produced its range overlay, and this repeated semi-transparent overlay resulted in dark color. Go back to the old behavior of just painting the overlay for the non-reply comment; for real, partly overlapping comments showing the exact boundaries of the overlapping overlays still makes sense. (cherry picked from commit 780dd8c1) Conflicts: sw/qa/extras/uiwriter/uiwriter.cxx Change-Id: Ic2673a1a41146ff547262ba681b34a63f41aa8ff Reviewed-on: https://gerrit.libreoffice.org/17669Reviewed-by:
-
Stephan Bergmann yazdı
Change-Id: Ieecad5f244703c4d2436e22a3ab50f719843eef4 (cherry picked from commit 68c6408b) Reviewed-on: https://gerrit.libreoffice.org/17672Reviewed-by:
-
Miklos Vajna yazdı
Usually the topmost window of a paint hierarchy has a paint rectangle that covers the paint rectangle of all its children, but this is not necessarly true in every case. One example is the cursor travelling described in the bug report, where the topmost DockingAreaWindow only paints a few buttons on the toolbar, and then even if children are painted correctly to the frame-level persistent buffer, only the DockingAreaWindow part of the buffer is copied to the screen. Fix this by building an union rectangle that covers all areas in a buffered paint run, and then paint that rectangle from the buffer, not just the paint rectangle of the topmost parent. Change-Id: Ib0b30413d83c4b3fdec27fa7ddad16c21fd094b6 (cherry picked from commit 7305941b) Reviewed-on: https://gerrit.libreoffice.org/17664Tested-by:
Tor Lillqvist <tml@collabora.com> Tested-by:
-
Caolán McNamara yazdı
(cherry picked from commit 0592da19) Change-Id: If16e90c5ba1a43ceb9702e752835928da7b3ef32 Reviewed-on: https://gerrit.libreoffice.org/17657Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I4dc93242be76dc2d7f7504457967c8d390afe9c8 (cherry picked from commit 9b0cd919) Reviewed-on: https://gerrit.libreoffice.org/17647Tested-by:
-
Miklos Vajna yazdı
This fixes the vertical rendering artifacts visible on the bug screenshot with the oxygen-gtk Gtk theme, and also is a lot simpler than what we did here before. Change-Id: I21a167452f14ae52bd0d899b3ed467ce40540dec Reviewed-on: https://gerrit.libreoffice.org/17631Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk> Tested-by:
-
Miklos Vajna yazdı
(cherry picked from commits 131d5b01 and cd064472) Change-Id: I34fb235a2e44eb510a630fb8dbcc2ec68cf96b79 Reviewed-on: https://gerrit.libreoffice.org/17642Reviewed-by:
-
Miklos Vajna yazdı
Regression from commit 0761f816 (123792: complete annotations on text ranges feature, 2013-12-19), the problem was that while sw wanted CH_TXTATR_INWORD as a placeholder character for anchor positions that do not count as a word boundary, the commit changed GetCharOfTextAttr() so that annotations have CH_TXTATR_BREAKWORD as the placeholder. Fix the problem by reverting the last hunk of sw/source/core/txtnode/thints.cxx changes in that commit. (cherry picked from commit 89d61536) Conflicts: sw/qa/extras/uiwriter/uiwriter.cxx Change-Id: Ia8c97efda9c1e90ae3c27ddb8247e3f3203a63fb Reviewed-on: https://gerrit.libreoffice.org/17621Tested-by:
-
Eike Rathke yazdı
Regression of 087a79db Change-Id: I903e05234882c79e6da6499cb17e16fd7226f91c (cherry picked from commit 2a06a052) Reviewed-on: https://gerrit.libreoffice.org/17636Tested-by:
-
Julien Nabet yazdı
0x00002aaaaf4bd163 in SfxItemSet::GetItemState (this=0x0, nWhich=26182, bSrchInParent=true, ppItem=0x7fffffff1730) at /home/julien/compile-libreoffice/libreoffice/svl/source/items/itemset.cxx:422 422 SfxItemArray ppFnd = pAktSet->m_pItems; (gdb) bt 0 0x00002aaaaf4bd163 in SfxItemSet::GetItemState(unsigned short, bool, SfxPoolItem const**) const (this=0x0, nWhich=26182, bSrchInParent=true, ppItem=0x7fffffff1730) at /home/julien/compile-libreoffice/libreoffice/svl/source/items/itemset.cxx:422 1 0x00002aaaaf4bd306 in SfxItemSet::HasItem(unsigned short, SfxPoolItem const**) const (this=0x0, nWhich=26182, ppItem=0x7fffffff1730) at /home/julien/compile-libreoffice/libreoffice/svl/source/items/itemset.cxx:463 2 0x00002aaacd9902c9 in ScCellShell::ExecuteEdit(SfxRequest&) (this=0x312fe10, rReq=...) at /home/julien/compile-libreoffice/libreoffice/sc/source/ui/view/cellsh1.cxx:1032 See https://gerrit.libreoffice.org/#/c/17603/ for details Thank you Maxim! Change-Id: Ie4cf31e3764c02f335830c59674a94acd6c209df Reviewed-on: https://gerrit.libreoffice.org/17603Reviewed-by:Maxim Monastirsky <momonasmon@gmail.com> Tested-by:
Eike Rathke <erack@redhat.com> Tested-by:
-
Łukasz Hryniuk yazdı
SumSquare returns IterateResult, which, because of rounding errors, store first value in mfFirst and rest in mfRest. They should be added to get the full sum of square of matrices difference. Change-Id: I9bc435801d94206960b0b4fe4a9149ef1abeb3be Reviewed-on: https://gerrit.libreoffice.org/17592Reviewed-by:
-
Michael Stahl yazdı
Problem is that the TextBox SwFrmFmt of a draw object gets a FLY_AS_CHAR anchor set, which is then not updated later before nodes are deleted. (regression from c7307c77) (cherry picked from commit 9dbb88fc) Change-Id: I906ee47b5c30944a08fd8a0d7d6ea8b8c9e6a6a8 Reviewed-on: https://gerrit.libreoffice.org/17580Tested-by:
-
Christian Lohmaier yazdı
Change-Id: Ibdc0596181711e748e4b1f59ffc27629c5423e66
-
Miklos Vajna yazdı
Regression from commit 0761f816 (123792: complete annotations on text ranges feature, 2013-12-19), the problem was that the added additional IDocumentMarkAccess::GetType() check in lcl_FindDdeBookmark(), which means that the function no longer finds bookmarks with the matching name, only real DDE marks. This is a problem, as SwTrnsfrDdeLink::WriteData() depends on the fact that sw::mark::Bookmark inherits from sw::mark::DdeBookmark. As a result, the fast IDocumentMarkAccess::GetType() (that intentionally doesn't handle inheritance for performance reasons) can't be used here. (cherry picked from commit e06e2cb1) Conflicts: sw/qa/extras/uiwriter/uiwriter.cxx Change-Id: I2b7a07c18b641ac991f3227812a609dedc960e08 Reviewed-on: https://gerrit.libreoffice.org/17447Tested-by:
Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
-
Justin Luth yazdı
The marker used in Word to identify table cell division was being included in the track-changes deletion from the following cell if the deletion was the first node in the cell. This would cause the two table cells to merge into one when changes were accepted by Word. (Problem not seen in LibreOffice itself.) Change-Id: Ia98017cbba7d3a43b67764ae0fa6447b7e90ca86 Reviewed-on: https://gerrit.libreoffice.org/15340Tested-by:
-
Lionel Elie Mamane yazdı
Else, on any action done directly (not through the FormControllerHelper) on the controller and raising an SQL error, this would silently swallow the error message, and the operation would fail without any message to the user. E.g. when validating an insertion or modification in a grid control by moving the cursor to a different line (as opposed to clicking the "Save Record" button). Change-Id: Ie569d9c826609f803f7b312c0469907155558ef2 Reviewed-on: https://gerrit.libreoffice.org/17268Tested-by:
-
Lionel Elie Mamane yazdı
This avoids arbitrarily switching to the first form in the document, which would do a (premature!) save to the database of the modifications pending in the active form. This may lead to a database error, when the data is not in a shape to be written to the database, e.g. when on an insertion row and not all mandatory fields have been filled in. This then pops up an error message to the user. Change-Id: I30bb533598ca707b892bb7155e54ce05d4ddf275 Reviewed-on: https://gerrit.libreoffice.org/17269Tested-by:
-
Lionel Elie Mamane yazdı
This disable will be done, in a better way, by the call to BrowseBox::MouseButtonDown below, *after* the destination of the mouse click has grabbed the focus, by a call to DeactivateCell(). If this is done here, while the "source" controller still has the focus, then the window's Disable() method will try to pass the focus the the "next control". However, the "next" control may belong to another form, and this will do a (premature!) save to the database of the modifications. This may lead to a database error, when the data is not in a shape to be written to the database, e.g. when on an insertion row and not all mandatory fields have been filled in. This then pops up an error message to the user. Change-Id: I38b1850319691b34232e51f131f8d099dc4a9114 Reviewed-on: https://gerrit.libreoffice.org/17270Tested-by:
-
