Change-Id: I8a2d4f3cce3e286432a100f82b5d22f588fb95b8
Reviewed-on: https://gerrit.libreoffice.org/30773Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

...introduced with 789055bc "clang-tidy
performance-unnecessary-copy-initialization" (so partially revert it).  Whatever
clang-tidy erroneously reported there, cur and next are lvalue references into
vec, so this attempted copy now actually overwrote one with the other.  The
result was that if multiple JREs are detected on the system, "Options -
LibreOffice - Advanced" would list a single one multiple times.

Change-Id: I7ef454c0f37669722812383848602dc2bacf7cd1

Change-Id: Iace2281ec4b5cfaa6e1de44b58a6705ca3a18c58

This is not an experimental feature and it should be possible to enable it
without enabling other features.

Change-Id: Idbdce23d0db2983a4eb1c8e1d02d15c43733f042
Reviewed-on: https://gerrit.libreoffice.org/30848Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

thanks Benjamin

Change-Id: I7ea0f6c8a8b8b35f864036844f1dc786e1f6bda8
Reviewed-on: https://gerrit.libreoffice.org/30910Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Has ever been like that since
    commit 54bd83fe
    Date:   Thu Oct 31 15:24:42 2002 +0000

Change-Id: Ifa52dc10458a91054675900a55c1eee14899d80d

Change-Id: Ib84e703d4c1528d022435c7695c97a3fc284563a

Change-Id: I9887d7ca83ffc012fec1a78ef9ef537d2188a7e3

Change-Id: Ia828755baa2c244cb23dc92202c1f9ed2448fe31

So also "empty" result cells with a number format applied are displayed empty,
instead of 1899-12-30 for example.

Change-Id: I5280d0213b8a809a04c5cb152ded58028706493a

This sprang from an IRC conversation with uniscript about allowing .xcd in
extensions, so that an extension with (localization) data for many packages
would not need one .xcu file per package, but rather only a single file.  That
is possible with a single .xcu file using the <item> syntax, as shown here.  (I
had thought that originally only registrymodifications.xcu supported the <item>
syntax, but can't find any traces of that; so looks like an extension with an
.xcu file using <item> syntax should be supported by OOo and derivates "since
ages".)

Change-Id: I1101793e6b14ba9c1e7647edab76927d4d31a81c

With this, the value of signing-certificate conforms to the RFC.

Change-Id: I27595068be46651efcbf0bd63fc51f79c6e18b4f
Reviewed-on: https://gerrit.libreoffice.org/30907Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

And rename it to AdES, as the PDF PAdES generation will be affected by
this checkbox in the near future.

Change-Id: I06121e4eb9debac7a55a737a71780c2fa5c4d084
Reviewed-on: https://gerrit.libreoffice.org/30908Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Tor Lillqvist <tml@collabora.com>

Change-Id: Ic7aa466c62eb8850d3c6b50c0e10b0575bd9b82e

Towards writing the complete signing-certificate value.

Change-Id: I0c7f3ddf863f944cc9e763beaf7d92e631dbcd4b

Change-Id: I94036432e23b2d73b6e2006ed49f9890ae11aa05

because under Ambiance there are dark primary toolbars and light panels and
currently we can only render the same icons in the same colors on each.

Breeze was explicitly selected as the default icon set to use under unity
in

commit c0da1080
Author: Bjoern Michaelsen <bjoern.michaelsen@canonical.com>
Date:   Sat Feb 27 14:30:01 2016 +0100

    lp#1506544 tdf#92458: default to breeze theme on unity desktops

    Change-Id: I1e0e10d1561e32c5904e0e7352e914bb62b85363

and the downstream workaround of lp#1580537 for this problem is to turn
libreoffice toolbars light.

glade has toolbar and a panel, both of them are light, so best solution
I can see is to remove the primary class from our toolbars.

Change-Id: I2f94ff52d56af1806e2b80b97e4ae2c4c82ae57e

Valgrind reveals that in Writer doing "Table - Insert Table... - Insert" (so the
table-related toolbar appears at the bottom of the document window), then "File
- Exit LibreOffice - Don't Save" causes

> Invalid read of size 8
>    at 0xE87CA6C: std::__cxx1998::vector<ImplStatusItem*, std::allocator<ImplStatusItem*> >::size() const (/usr/lib/gcc/x86_64-redhat-linux/6.2.1/../../../../include/c++/6.2.1/bits/stl_vector.h:656)
>    by 0xE87B09F: StatusBar::GetItemCount() const (/vcl/source/window/status.cxx:1019)
>    by 0x75248D91: VCLXAccessibleStatusBar::VCLXAccessibleStatusBar(VCLXWindow*) (/accessibility/source/standard/vclxaccessiblestatusbar.cxx:43)
>    by 0x75201C37: (anonymous namespace)::AccessibleFactory::createAccessibleContext(VCLXWindow*) (/accessibility/source/helper/acc_factory.cxx:312)
>    by 0xD27B191: VCLXWindow::CreateAccessibleContext() (/toolkit/source/awt/vclxwindow.cxx:862)
>    by 0xD2862AC: VCLXWindow::getAccessibleContext() (/toolkit/source/awt/vclxwindow.cxx:2375)
>    by 0xD2864AF: non-virtual thunk to VCLXWindow::getAccessibleContext() (/toolkit/source/awt/vclxwindow.cxx:0)
>    by 0x2A5CF0CD: AtkListener::handleChildRemoved(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleContext> const&, com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible> const&) (/vcl/unx/gtk3/a11y/../../gtk/a11y/atklistener.cxx:200)
>    by 0x2A5CF646: AtkListener::notifyEvent(com::sun::star::accessibility::AccessibleEventObject const&) (/vcl/unx/gtk3/a11y/../../gtk/a11y/atklistener.cxx:301)
>    by 0x77D6DB7: comphelper::AccessibleEventNotifier::addEvent(unsigned int, com::sun::star::accessibility::AccessibleEventObject const&) (/comphelper/source/misc/accessibleeventnotifier.cxx:277)
>    by 0x77D4219: comphelper::OAccessibleContextHelper::NotifyAccessibleEvent(short, com::sun::star::uno::Any const&, com::sun::star::uno::Any const&) (/comphelper/source/misc/accessiblecontexthelper.cxx:186)
>    by 0xD1FB887: VCLXAccessibleComponent::ProcessWindowEvent(VclWindowEvent const&) (/toolkit/source/awt/vclxaccessiblecomponent.cxx:210)
>    by 0xD1FAEC0: VCLXAccessibleComponent::WindowEventListener(VclWindowEvent&) (/toolkit/source/awt/vclxaccessiblecomponent.cxx:125)
>    by 0xD1F9C87: VCLXAccessibleComponent::LinkStubWindowEventListener(void*, VclWindowEvent&) (/toolkit/source/awt/vclxaccessiblecomponent.cxx:114)
>    by 0xE797CD7: Link<VclWindowEvent&, void>::Call(VclWindowEvent&) const (/include/tools/link.hxx:84)
>    by 0xE794189: vcl::Window::CallEventListeners(unsigned long, void*) (/vcl/source/window/event.cxx:240)
>    by 0xE8EDC9F: vcl::Window::dispose() (/vcl/source/window/window.cxx:172)
>    by 0xE875B9B: StatusBar::dispose() (/vcl/source/window/status.cxx:170)
>    by 0xEAD71EE: VclReferenceBase::disposeOnce() (/vcl/source/outdev/vclreferencebase.cxx:42)
>    by 0x3AA25A76: VclPtr<StatusBar>::disposeAndClear() (/include/vcl/vclptr.hxx:231)
>    by 0x3AC1CF0D: framework::StatusBarManager::dispose() (/framework/source/uielement/statusbarmanager.cxx:202)
>    by 0x3AC2936D: framework::StatusBarWrapper::dispose() (/framework/source/uielement/statusbarwrapper.cxx:75)
>    by 0x3AA4F246: framework::LayoutManager::implts_destroyStatusBar() (/framework/source/layoutmanager/layoutmanager.cxx:840)
>    by 0x3AA4EF68: framework::LayoutManager::implts_destroyElements() (/framework/source/layoutmanager/layoutmanager.cxx:443)
>    by 0x3AA4ED7E: framework::LayoutManager::implts_reset(bool) (/framework/source/layoutmanager/layoutmanager.cxx:412)
>    by 0x3AA5E683: framework::LayoutManager::frameAction(com::sun::star::frame::FrameActionEvent const&) (/framework/source/layoutmanager/layoutmanager.cxx:2814)
>    by 0x3AB0A30C: (anonymous namespace)::Frame::implts_sendFrameActionEvent(com::sun::star::frame::FrameAction const&) (/framework/source/services/frame.cxx:3110)
>    by 0x3AB0299D: (anonymous namespace)::Frame::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) (/framework/source/services/frame.cxx:1557)
>    by 0x3AB055AB: (anonymous namespace)::Frame::close(unsigned char) (/framework/source/services/frame.cxx:1801)
>    by 0x3AAF1DC4: framework::Desktop::impl_closeFrames(bool) (/framework/source/services/desktop.cxx:1698)
>    by 0x3AAF132A: framework::Desktop::terminate() (/framework/source/services/desktop.cxx:230)
>    by 0x3A9D71CA: framework::CloseDispatcher::implts_terminateApplication() (/framework/source/dispatch/closedispatcher.cxx:562)
>    by 0x3A9D632C: framework::CloseDispatcher::impl_asyncCallback(LinkParamNone*) (/framework/source/dispatch/closedispatcher.cxx:410)
>    by 0x3A9D49D7: framework::CloseDispatcher::LinkStubimpl_asyncCallback(void*, LinkParamNone*) (/framework/source/dispatch/closedispatcher.cxx:254)
>    by 0xE9B4BE7: Link<LinkParamNone*, void>::Call(LinkParamNone*) const (/include/tools/link.hxx:84)
>    by 0xEE027A7: vcl::EventPoster::DoEvent_Impl(void*) (/vcl/source/helper/evntpost.cxx:52)
>    by 0xEE02767: vcl::EventPoster::LinkStubDoEvent_Impl(void*, void*) (/vcl/source/helper/evntpost.cxx:48)
>    by 0xE91FC17: Link<void*, void>::Call(void*) const (/include/tools/link.hxx:84)
>    by 0xE91CE8B: ImplHandleUserEvent(ImplSVEvent*) (/vcl/source/window/winproc.cxx:1957)
>    by 0xE91A33F: ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) (/vcl/source/window/winproc.cxx:2507)
>    by 0xEFEA88D: SalFrame::CallCallback(SalEvent, void const*) const (/vcl/inc/salframe.hxx:276)
>    by 0xEFFF457: SalGenericDisplay::DispatchInternalEvent() (/vcl/unx/generic/app/gendisp.cxx:86)
>  Address 0x6ccc64b0 is 32 bytes inside a block of size 56 free'd
>    at 0x4C2D22A: operator delete(void*) (/builddir/build/BUILD/valgrind-3.11.0/coregrind/m_replacemalloc/vg_replace_malloc.c:576)
>    by 0xE875B47: StatusBar::dispose() (/vcl/source/window/status.cxx:165)

It looks rather pointless that StatusBar::dispose causes instantiation of a
VCLXAccessibleStatusBar, but not sure what would be the right level to fix this.
So work around it by making the pointlessly pointer mpItemList non-pointer, and
clearing it in StatusBar::dispose, so that a latter call to
StatusBar::GetItemCount returns 0 (which appears to be OK for the needs of that
zombie VCLXAccessibleStatusBar).

Change-Id: I1e982a335cb78e87a6c16633174bca76b59c6049

This also reduces some cycles in SmElementsControl::MouseMove().

Change-Id: I1dd5f9cd37e4a78010ebb719b4726f9b061d8ff2
Reviewed-on: https://gerrit.libreoffice.org/30897Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
Tested-by: Takeshi Abe <tabe@fixedpoint.jp>

Change-Id: I9137cc2b925f67af6b6dc7106327de76c28c74ac
Reviewed-on: https://gerrit.libreoffice.org/30904Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

to prevent it from growing too large and thus distorting the dialog

Change-Id: Iaa27d3085ec314246565cae79ab7d627a94a3bff
Reviewed-on: https://gerrit.libreoffice.org/30898Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I82140569a3e09225065d721e4aeac5c5fe93bc45

which isn't news, but...

with focus follows mouse enabled, activate filter menu of a calc autofilter.
Move the mouse around and enter the menu, menu pops down because there are
configure and mouse events which indicate that the position of the main
application window has "moved"

when LibreOffice detects the window has moved, it closes the windows
popups, so the menu disappears.

Change-Id: I2d1aa4a51153002c925e2dde4402da2d84e52de5

Deactivating the assert in fillSortedColumnArray() was necessary for the bug's
Paste Special and Sort scenario, but actually the assert could had been hit
also earlier if some cell values were not pasted / skipped and Sort was invoked
after that.

Change-Id: I7b08bfb4104f4c7eb30815944bc87eec79a87334

Change-Id: I074e464996070ac3f20d27a66a5f0246ede45c79

Change-Id: I63e038173338055b5b4003e1a6040b8680b8bbd6
Reviewed-on: https://gerrit.libreoffice.org/30901Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I004ebe3bd214a7c35a286f10bb13aef6900f0f87
Reviewed-on: https://gerrit.libreoffice.org/30896Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

under wayland, the value selected by gdk_drag_status is not immediately
available via gdk_drag_context_get_selected_action, so use the value
we set on it, not the value it claims to have

pull common code together as getPreferredDragAction

Change-Id: I4d95c4b8183505f2203ad1a8f6947df983ce8d21

...other options to avoid such irrelevant warnings can be to move code to an
include file and/or to define a dummy main() accessing otherwise unreferenced
entities.

Change-Id: Ifd44e376b35ef68496f3aba6a3c046d684824000

Change-Id: I245000b48775955dcf72f362829df7594e8b637b
Reviewed-on: https://gerrit.libreoffice.org/30880Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I955facfe3e901fcb76798dab342f96a67d5ac63f
Reviewed-on: https://gerrit.libreoffice.org/30894Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

look for final classes, and make sure they don't have protected members

Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4
Reviewed-on: https://gerrit.libreoffice.org/30895Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I02e933da66241e99e3b81d90d679f1502bab3fef
Reviewed-on: https://gerrit.libreoffice.org/30866Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Reference class added to
desktop/source/lib/lokandroid.cxx
for Java_org_libreoffice_kit_Document_getTextSelection()

Change-Id: I211d5709df39fd9fafdab9232af760613f6b86c0
Reviewed-on: https://gerrit.libreoffice.org/29804Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>

Change-Id: I196c9c2b24f94ac66bb200fea561bdc5ccc679e5

When the context itself is being disposed.  While this solves the
issue of addAccessibleEventListener() being called twice despite
removeAccessibleEventListener() being called only once, it won't
solve the problem of leaky atk focus events.

Change-Id: I984107ed2d30e6dba8067d11f400ff64d665d157

It turns out we actually need the horizontal shift, so re-enable it.

Change-Id: If9d16276f0f56b518c6bedc2fcbbd3d8746d8d5d

Negative descender means the glyph is above the baseline and no shift
should happen.

Change-Id: I0ee3575051e47f16c64db4e85c0b8a390029567f

This is called only if a cell has the table:formula attribute and that *is* a
formula cell and nothing else. In fact in ODFF the initial leading '=' is not
mandatory, so attempting to set a different cell type if it is not present is
wrong.

Commit 62ec7f9e introduced that, which at that
time may have been necessary, but doubtful..

Additionally, ScFormulaCell::CompileXML() that tries to group formulas had to
be adpated to not rely on the presence of a leading '='. Luckily there was an
assert..

These changes enable loading of "error cell" formulas that were stored without
a leading '=' if they originated from a paste special with only values, which
maintains an error result as error formula.

Change-Id: I43394de108066a24b792eec958b19f51f990403b

Error results weren't handled at all and sorted same as numeric 0, which
due to "stable sort" resulted in arbitrary looking sort order if 0
values or results where included.

Change-Id: Ib7c516b57ea92bc5b813f448d9c2bb5491e43940