Reviewed-on: https://gerrit.libreoffice.org/18792Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 5ba0f79e)

Backported to 5-0 replacing the interim forward compatibility of
4a334351

Change-Id: Ic053342fde436a7053c15e32683e09b9e91f5308
Signed-off-by: Eike Rathke <erack@redhat.com>
(cherry picked from commit 656667ae)

Change-Id: I411a7e26f536a1e4924f566a2ecba097fc134db2
(cherry picked from commit 24271e34)
(cherry picked from commit 10b190ee)

it looks like draw:name values are supposed to be unique in ODF, even
if it's not spelled out explicitly, since it exists so the frame can be
referenced, which sort of implies that it has to be unique, so a
document where the values aren't unique can be considered invalid

    19.197.10 <draw:frame>
    The draw:name attribute specifies a name by which a <draw:frame>
element can be referenced.

So reject duplicate frames but limit this to document generated with
4.4.X which we believe is the version that created these bogus docs

(cherry picked from commit de0432a9)

Change-Id: I83f6d72fd969f667f0a8c2c85d2ffeeed672387a
Reviewed-on: https://gerrit.libreoffice.org/20054Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit df58e602)

XAccessibleEventBroadcaster::addAccessibleEventListener test calls the
fireEvent() and the problem is that the event is triggered not on the
print preview itself, but some toolbar button.  This then causes an
accessible event to be broadcast from the print preview too, but only
after doAccessibleAction() returns, some time later from VCL main-loop.

If the test checks the flag in the listener before the main thread sends
the event, the test fails; try to fix that with
XToolkit::processEventsToIdle().

(cherry picked from commit 1d87c245)

qadevOOo: sadly XToolkit::processEventsToIdle doesn't fix...

... the ScAccessiblePreviewTable test, somehow the event still doesn't
fire in time, let's add an arbitrary sleep too.

(cherry picked from commit c94cf0cf)

Change-Id: Ia52bdf99cdc349ffb0a03536fba271b792caae0f
Reviewed-on: https://gerrit.libreoffice.org/20018Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit e3ee6df3)

Modify styles.xml to not use japanese language specification in style
for date

Change-Id: I0e418c06d5c8d6b04eeaa3e6f6c33c194ee2ef3f
Reviewed-on: https://gerrit.libreoffice.org/20063Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
(cherry picked from commit ec544c4b)
Reviewed-on: https://gerrit.libreoffice.org/20071Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit 7ff72979)

Regression of b5cd11b4

It was always wrong to propagate ForceArray already if a function had a
ForceArray parameter *somewhere*, we need to do this per parameter
instead.

(cherry picked from commit 49257e1d)

Conflicts:
	formula/source/core/api/FormulaCompiler.cxx

prevent ForceArray propagation on the same token, tdf#95670 follow-up

This may happen if the last RPN token is put and the function has a
ForceArray parameter but now again would be wrong if not all parameters
are ForceArray.

(cherry picked from commit b31b17e5)

890fb6b5b88337033cfcf2e8189371ee39461205

-Werror,-Winconsistent-missing-override

(cherry picked from commit 6edc492e)
Backported to SAL_OVERRIDE

3bb2764b625d44f6e0cecbdde3363440faef63b5

Change-Id: If188d45366279d9a7bf641edc7e4dd7095d6d035
Reviewed-on: https://gerrit.libreoffice.org/19993Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit 29adff38)

Change-Id: I2ae5a06f9ffe29de0b1cc5875615010da75f4ae9
(cherry picked from commit d1225d60)
Reviewed-on: https://gerrit.libreoffice.org/20020Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
(cherry picked from commit d9b6f836)

Change-Id: I1d962ad637f19b02855616edebcedbad719689c5
(cherry picked from commit ee655627)
Reviewed-on: https://gerrit.libreoffice.org/20053Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 22f51321)

... file format by default if the requested filter does not exist.

Much better to write an error message and do nothing.

Change-Id: Ie5404772e7aae5751126bd4c2784b58177804448
(cherry picked from commit c994ce8a)
Reviewed-on: https://gerrit.libreoffice.org/20007Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit de7a50d6)

This fixes a buffer overflow writing over the end of pCaretXArray,
which can happen e.g. when drawing mnemonics in the password dialog.
Based on a similar calculation of nCurrIdx found in
GenericSalLayout::GetCaretPositions().

Change-Id: I7d723cf8cfaeb66f340c7d9ea5b3bc728c6d6209
Reviewed-on: https://gerrit.libreoffice.org/19385Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit f630b6d5)
Reviewed-on: https://gerrit.libreoffice.org/20031Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit e401cb5c)

Change-Id: I7c732d94346be8f37fba1a32655ba224c74e0235
Reviewed-on: https://gerrit.libreoffice.org/20017Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
(cherry picked from commit aaf3bc89)

substreams require a Model and a DrawPage

Change-Id: I701cf6e2283f84f18b9a0c06a4ce0aa8be934bf3
Reviewed-on: https://gerrit.libreoffice.org/19951Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>
(cherry picked from commit f47bd056)
Reviewed-on: https://gerrit.libreoffice.org/19954Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit aac3a50a)

so LibreOffice thinks its window is smaller than what gtk3 has allocated
for it.

For gtk3 (like firefox does) split size and position handling, leave
position/move handling to the configureEvent, but listen to sizeAllocate
and use that for the size handling.

Leave gtk2 as it always was

(cherry picked from commit 6adfbe62)

Change-Id: Ic52d6971595741ed658247b651e9e16c2ef9ed0b
Reviewed-on: https://gerrit.libreoffice.org/19924Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 717c4a8c)

Change-Id: I59a9401c0bdc2d641ea54498af0eb1e589ab12f3
(cherry picked from commit a3223557)
(cherry picked from commit 38e24f1d)
Reviewed-on: https://gerrit.libreoffice.org/19942Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit 1bdffdee)

The following scenario is how it breaks:
1. user has ExcelA1 as her formula syntax setting, CONV_UNSPECIFIED
(that means "same as formula syntax") as her string ref syntax setting
2. she saves the document, it will now contain CONV_UNSPECIFIED value
3. someone else with CalcA1 formula syntax setting opens the document
... since it contains CONV_UNSPECIFIED "same as formula syntax" value,
it will use his CalcA1 formula syntax value to evaluate INDIRECT func
=> #REF!

Avoid this by reading formula syntax/grammar value, mapping it to
matching string ref syntax and saving that instead of CONV_UNSPECIFIED

Change-Id: Ide62d81e6b70c2e9f2ff79648935788107475778
Reviewed-on: https://gerrit.libreoffice.org/19610Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/19983Tested-by: Jenkins <ci@libreoffice.org>
(cherry picked from commit c3293e0e)

Change-Id: I32f0de20864cae267ebd32516f20baf8e38f910b

Zoom level of SwEditWin is kept in sync with the client, so that the
pixel-based comment widgets can be positioned correctly. But that does
not mean in general the SwEditWin map mode should not be disabled: so
that we don't have to tweak the map mode for each and every
postMouseEvent() call and still be able to send them using logic
coordinates.

Change-Id: I6f686b93d2509d52fdd34e84a502cf04e1ce6e59
(cherry picked from commit de2a6897)

Without this, vcl::Window::ImplTrackTimerHdl() will be called on a
deleted vcl::Window.

Can be reproduced with a comment having a scrollbar in a LOK client,
then clicking on the down button of the scrollbar a number of times ->
crash on exit.

Change-Id: I5d67f96e8baa199f65ec5cf39cb5d39c8162ff33
(cherry picked from commit 7c654ee9)

With this, if a comment has a vertical scrollbar, then not only the
buttons of the scrollbar can be clicked on, but also the slider of the
scrollbar can be dragged.

(cherry picked from commit d562df03)

Conflicts:
	sw/source/uibase/docvw/SidebarWin.cxx

Change-Id: I2e39e18bf60c42a878bb8bfd808f1d47be27eecb

This is similar to the mouse button down handling. When the map mode is
disabled and the map mode is in twips, then in general it's possible to
send mouse coordinates in twips. The scrollbar is usually in pixels, so
add extra code to still make this possible.

Change-Id: I0c7e404ecd7ac839e000266e396683bb7d15c505
(cherry picked from commit d7acb44b)

If a comment had a scrollbar, and the user clicked on the down arrow of
it, then the button remained in the "pushed" state, as the scrollbar
invalidations were not routed to the LOK client.

With this, the button gets back to its non-pushed state after the mouse
button is released.

(cherry picked from commit 55040ea1)

Change-Id: Ie4ba5d0ec07229b0cfc08532e8e91ae25f7a4c9e

(cherry picked from commit 527190f0)

Conflicts:
	sw/source/uibase/docvw/SidebarWin.cxx

Change-Id: Ib1c334825a6629224fe0c8fba564656d53e67410

(cherry picked from commit 43976548)

Conflicts:
	vcl/source/control/scrbar.cxx

Change-Id: Ieaedaa525d613f8ba55f336c613da163a09f7a33

With this, if a comment has enough content that it gets a vertical
scrollbar, then tiled rendering output looks OK, even with non-100%
zoom.

Change-Id: I699aadc11b6c34fb0791e70705719fd61169d972
(cherry picked from commit 30b511ae)

This one is special, as normally its map mode is in pixels, but we need
all sub-widgets to work in twips when tiled rendering.

With this, the scrollbar widget (both the buttons and the
button/background area of the scrollbar itself) is painted at the
correct location when Writer comments have enough content so the
scrollbar is visible.

Change-Id: I4ee9ef8618974b965339078d2262364ec19732ef
(cherry picked from commit f411ef1b)

These member functions take logic units, and the only case when omitting
PixelToLogic() all the time works is when both the widget itself and
render context has a pixel map unit.

Add missing PixelToLogic() calls where the input is in pixels, so in
case the render context has some logic units, the output is still
painted at the correct location.

This is needed for e.g. tiled rendering of the scrollbar of Writer
comment widgets.

Change-Id: Ideb75625b1f6349c5f18342e6f438fd5d7c31dcd
(cherry picked from commit f2081039)

Checking for a bool is certainly cheaper than a chain of member function
calls.

Change-Id: I9520194e58e75264f3fcbb413a618e3995f59a4e
(cherry picked from commit 5eb7759d)

Instead of invalidating the whole area, invalidate the sub-widget when
the whole area of the sub-widget would be invalidated.

With this, a test comment with enough comment to have a scrollbar
results in 3 paintTile() calls instead of 11 ones (70% save).

(cherry picked from commit 9ece5c87)

Conflicts:
	sw/source/uibase/docvw/SidebarTxtControl.cxx

Change-Id: I2fe317549eefac9a63aaf50f5a9a242e15c4dc86

E.g. when a Witer comment has long enough contents to get scrolled, the
desktop case repaints its contents by vcl::Window::Scroll(), followed by
a vcl::Window::Update(), i.e. vcl::Window::Invalidate() is not called.

The result of this in case of tiled rendering is that no tile is
repainted, so call vcl::Window::Invalidate() after scrolling manually.

A generic VCL-level invalidate-after-scroll is not wanted, as the
scrolling of the document contents and the main document window is not
in sync when tiled rendering.

(cherry picked from commit 162ae47a)

Conflicts:
	editeng/source/editeng/impedit.cxx

Change-Id: I74296a0f0e52c92cf3db6aefa73f28bb2b202871

Change-Id: Ia513821b43729951c7b097fea498f0e22b9d10ea
(cherry picked from commit 8a1b9ac5)

So that clients can know if they get old-style RGBA or new-style ARGB
output in paintTile().

Change-Id: Icfde4b3259444b3524e64478ccd976664a3fe0ed
(cherry picked from commit fc06f801)

Change-Id: I8fdde4b46e3e315a5b6a35cabc4495ebf69db057
(cherry picked from commit 6f5589d5)

Change-Id: Id7157ea5fadd684dceec52f69ec9279c4107b5f1
(cherry picked from commit 9feffdbe)

Change-Id: I46caceed3fdf0ad0aa51c8a8ede1177ca3d1855e
(cherry picked from commit 506432f5)

Change-Id: I19efc6050c78162e0889437d4c8285d1a6714e82
(cherry picked from commit be28ab9a)

(cherry picked from commit 479325de)

Conflicts:
	sc/inc/docuno.hxx
	sd/source/ui/inc/unomodel.hxx
	sw/inc/unotxdoc.hxx

Change-Id: I9a6a75457078dc6383673f4c1a2012b69b5cefdd

(cherry picked from commit 4bddfc00)

Conflicts:
	libreofficekit/source/gtk/lokdocview.cxx

Change-Id: I8aaf19a50f25f495cb87fba7ff6a4b0f56ed7d80

Change-Id: I9e48407f6f5eb5cc4c36439b72648bb8d43deb79

...re 2c346d66 "tdf#39080 Hide Whitespace UI
option added to the View menu."

Change-Id: Ib2f364dba7a50854a11f004b42c7ee22ee10e48b
(cherry picked from commit 6efbd4bb)

Regression from commit 54a2c8c0
(tdf#39080 Interactive hide-whitespace mode, 2015-08-30), the problem
was that SwPageFrm::IsOverHeaderFooterArea() checked if the header is
active before accepting that the user clicked in that area.

Don't require an active header at least in non-hide-whitespace mode, as
the member function is used in the "could there be a header here" sense
in SwEditWin::MouseButtonDown() to show the controls that allows
actually adding a header.

Change-Id: I6f905920113aed1512e333e718a8f26d88a3245d
(cherry picked from commit a23f85f1)