Skip to content

C
core
Dal (branch)/etiket değiştir
  1. 16 Kas, 2014 18 kayıt (commit)
    • Matteo Casalin's avatar
      Clarify flow by avoiding assignment in if condition · bed58e39
      Matteo Casalin yazdı 
      Change-Id: Ifed65f41ab2375d702bf0c4299c65d1e3d78a7f0
      bed58e39
    • Matteo Casalin's avatar
      nNum is never read: remove it · 240ca5fe
      Matteo Casalin yazdı 
      Change-Id: I615ee0ec9aca3c30018fb45f91240471b88e96eb
      240ca5fe
    • Caolán McNamara's avatar
      callcatcher: update unused code · 2ab73c38
      Caolán McNamara yazdı 
      pleasing cleanup of whacky ScRawToken::sbyteOffset, etc.

Change-Id: I5ad97f8dab7c5dc9d5f0286bf606b619126c22c9
      2ab73c38
    • Mark Hung's avatar
      Improve rtf import filter to handle Chinese suffixes of numbered lists. · 93b9a238
      Mark Hung yazdı 
      Currently rtftok doesn't handle multibyte string as destination
text very well. For example, RTF files created by MSO 2010 Traditional
Chinese version use CP950 (aka BIG5) for unicode to ansi conversion.
When a Chinsese numbered list was picked, the Chinese dot ( unicode
0x3001, big5 0xa142 ), was used by default as a list number suffix.
However when it is imported , only a single B (0x42) were left.
The theory of the patch is to collect both hex string and normal
character with m_aHexBuffer, and convert it into OUString as late
as possible. It allows prefixes and suffixes to be imported from
RTF files created by MSO 2010 TC correctly.

Reviewed on:
	https://gerrit.libreoffice.org/12435

Conflicts:
	sw/qa/extras/rtfimport/rtfimport.cxx

Change-Id: I63062da39bf36ea27ec11e5d0eb1d1abf5018d96
      93b9a238
    • Michael Meeks's avatar
      emfplus: re-work and cleanup unit test · 19866932
      Michael Meeks yazdı 
      Change-Id: I484331c4dd5feedf8587530912bb65556c1689c0
      19866932
    • Miklos Vajna's avatar
      vcl: let the ModalDialog ctor take an OUString · 133c295b
      Miklos Vajna yazdı 
      Change-Id: I839435338f4acf80c40896b6c86f7ef122f5449d
      133c295b
    • Miklos Vajna's avatar
      writerfilter: this is expected to be UTF-8 · b04759db
      Miklos Vajna yazdı 
      Change-Id: I7408be90f1ff552f4bb33e8a89d4b9075634e3e5
      b04759db
    • Miklos Vajna's avatar
      fdo#83204 RTF import: handle \pard<para props> after \bkmkstart · 8a30ba57
      Miklos Vajna yazdı 
      Change-Id: I4f5f0f653f2ce7782ec1d1fc5ef550a21a9c1d35
      8a30ba57
    • Miklos Vajna's avatar
      vcl: let the ModelessDialog ctor take an OUString · 7ae56e48
      Miklos Vajna yazdı 
      Change-Id: Iae88a9889c674337fb999a23a799d8730d2793d5
      7ae56e48
    • Miklos Vajna's avatar
      writerfilter: these are expected to be UTF-8 · 6a499c90
      Miklos Vajna yazdı 
      Change-Id: I8cd2ce341996a219ee885969de3482be422730b3
      6a499c90
    • Michael Meeks's avatar
      vcldemo: create multiple windows sharing the same renderer. · 7cf996cf
      Michael Meeks yazdı 
      Change-Id: Iac813b78c476b69dc6aa78d48c025f5fda76db1a
      7cf996cf
    • Takeshi Abe's avatar
      Mark as noncopyable · 1bbda773
      Takeshi Abe yazdı 
      Change-Id: Ibbec7a5d9b6726865da14c9bdfad8b8118f85e5b
      1bbda773
    • Chris Sherlock's avatar
      vcl: fdo#86307 removed Solaris workaround from #i64273# · 29dd2977
      Chris Sherlock yazdı 
      Basically, they were working around issues with XmbTextListToTextProperty
returning garbage characters, which showed on window titles.

The comment in the code is far more informative than the bug report:

 /* #i64273# there are some weird cases when using IIIMP on Solaris
    where for unknown reasons XmbTextListToTextProperty results in
    garbage. Test one string once to ensure safety.

    FIXME: This must be a bug in xiiimp.so.2 somewhere. However
    it was not possible to recreate this in a small sample program.
    This reeks of memory corruption somehow.
 */

Now I did a bit of research (aka "Google search") and discovered #i6759#
which was logged in 2002. This shows that the codebase was using __XOpenIM
in xiimp.so.2, which probably caused this issue. From the bug:

    I've tried to look into this problem and have found out, that
    apparently the
    use of the '__XOpenIM' subroutine from the
    /usr/openwin/lib/locale/common/xiiimp.so.2
    shared library causes this problem.  When running on Solaris, OO tries to
    dlopen() the above mentioned shared library, looks up the  '__XOpenIM'
    symbol in it and calls this function ( function XvaOpenIM() in file
    vcl/unx/source/app/i18n_wrp.cxx ).

    There's alternate code in OO that just calls the X11 documented function
    'XOpenIM()' instead.  This is enabled by running OO 1.0.x with the
    environment variable USE_XOPENIM defined to some value.  When running
    OO with

      env USE_XOPENIM=1 ~/OpenOffice.org1.0.1/soffice

    the problem does *not* occur any more and xprop for the same two windows
    mentioned in the initial bug report shows:

    % xprop |egrep '_NAME|_LOCALE'
    WM_LOCALE_NAME(STRING) = "de_DE..ISO8859-15"
    WM_ICON_NAME(STRING) = "unbenannt1 - OpenOffice.org 1.0.1 "
    WM_NAME(STRING) = "unbenannt1 - OpenOffice.org 1.0.1 "

    % xprop | egrep '_NAME|_LOCALE'
    WM_LOCALE_NAME(STRING) = "de_DE..ISO8859-15"
    WM_ICON_NAME(STRING) = "Umbruch einfÿ77777774gen"
    WM_NAME(STRING) = "Umbruch einfÿ77777774gen"

    As far as I can tell, the use of '__XOpenIM' frees some memory inside the
    Solaris X11 shared library that is still in use by the X11 character set
    conversion routines. Or in other words: the X11 character set conversion
    routines operate on freed memory, after __XOpenIM was called.

    These character set conversion routines are used by
    XmbTextListToTextProperty
    ( in WMAdaptor::setWMName() in file vcl/unx/source/app/wmadaptor.cxx ) and
    it seems they still access memory that was freed by the use of
    '__XOpenIM'.

Now later on, Caolan removed XvaOpenIM() in commit
4d6dab2c and then later committed a patch that
removed the ability to use the environment variable USE_XOPENIM as it wasn't
necessary anymore (commit: 8b028754). I'd say
that this was probably fixed in one of these changes.

Change-Id: I20effd77e0cdcde26d1be756cc6231f30f35118e
      29dd2977
    • Chris Sherlock's avatar
      vcl: SalGraphics::mirror() - always use GetGraphicsWidth() · 28effca6
      Chris Sherlock yazdı 
      There's never a case where we need to get the width from VirtualDevice,
we really should only get it from the SalGraphics instance. This vastly
simplifies matters.

Change-Id: I8bae9c163fcb0ce5d064d802c2783437124ebcb2
Reviewed-on: https://gerrit.libreoffice.org/12473Reviewed-by: 's avatarChris Sherlock <chris.sherlock79@gmail.com>
Tested-by: 's avatarChris Sherlock <chris.sherlock79@gmail.com>
      28effca6
    • Brij Mohan Lal Srivastava's avatar
      fdo#85432 : Add locale details to help->about · c5092a8d
      Brij Mohan Lal Srivastava yazdı 
      Added locale text to About dialog

Change-Id: Ic26219e8fe845b4c5027b65d5f5edba9279b1b11
Reviewed-on: https://gerrit.libreoffice.org/12464Reviewed-by: 's avatarAdolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: 's avatarMichael Meeks <michael.meeks@collabora.com>
Tested-by: 's avatarMichael Meeks <michael.meeks@collabora.com>
      c5092a8d
    • Tor Lillqvist's avatar
      Avoid error: redefinition of 'GetImpl' for iOS · 1defd9ae
      Tor Lillqvist yazdı 
      Whether this stuff actually works at all for iOS any more I have no
idea, and can't be bothered to check in my own time. Why do I bother
fixing compilation errors then? Good question.

Change-Id: If0ec4fbde42536d3d90e8c5337948815b5f47cef
      1defd9ae
    • Kohei Yoshida's avatar
      Remove unused header include. · 2f342c61
      Kohei Yoshida yazdı 
      Change-Id: I57cfac2993301e438124c224655fdcac0ed0fd32
      2f342c61
    • Kohei Yoshida's avatar
      Remove brdcst.hxx from document.hxx. · 30123b95
      Kohei Yoshida yazdı 
      Change-Id: Ie44a743a6814cdf1bc15f850547ae71afd595836
      30123b95
  3. 15 Kas, 2014 22 kayıt (commit)