Change-Id: Idd06aaa1a01a1f3ca17e23ae703549105f2d9669

Change-Id: I2f6adcff92aedb54c91fe57c1f7511160d9868ce

(it = aUsedSeqNo.insert(pParent).first) != aUsedSeqNo.end()) has
undefined behavior due to undefined evaluation order of insert and end.

Change-Id: I8e6f6912cb96c95b60c4fc964dc0f64feaf69265

Change-Id: Ia2a213708baf910429be9fd397e0112c80e8cd2d

Change-Id: I43f344fb06e45cc883c8c6cd9bbfbe29ef9c01f7

Change-Id: I4ba4164343f252ac451433ba3b07e2cd214e13f8

GCC 4.7 has a completely mysterious complaint that can be avoided with a
typedef:
inc/o3tl/sorted_vector.hxx:48:16: error: ‘vector’ is not a template

Change-Id: I58111df62c74f7d3a07e1e6e4fa1a400ff7d887c

I can't add a regular erase(iterator) method because we only hand
out const_iterator's

Change-Id: Ia3bdecb0f909d0712138c7ee48da268951e2733b

Implement suggestionss from David Tardon, mostly around prohibiting
access that could result in the vector becoming unsorted.
Add front() and back() accessors.
Add lower_bound() method.
Add optimised insert() method.

Change-Id: Icbb3597277f3e5963573b57d4f6d3cb740e896e6

Change-Id: Ife861e0b34becf5a4f9a61c3e34be75b5acd00d7

a) remove special handling of 0x0002 in our custom icu rules.
   Which brings us a step closer to getting rid of at least
   some of them in favour of the defaults
b) expand the 0x02 in SwTxtNode::BuildConversionMap like we
   do for fields so

Good side effect is our word count and character count now take into account
the actual footnote indicator text, as does our cursor travelling. Both of
which are more word-alike.

Change-Id: I3b0024ac4b10934bee7a9e83b0fce08a18556c7b

so that on version bumps and/or added/removed patches that we
rebuild them from scratch, which hopefully will make incremental
builds post external module bump pain-free

Change-Id: If268401a2794989d49861c08f7a69ef926cf5809

Change-Id: I9762e198825fbc697f4049a7da5755d72c14e481

Change-Id: Ib8db74de1f18342794713952470e26ba87bc75fe

Change-Id: Ie3319870ae26e9e2cac32641a33be62e4e020c02

Change-Id: I3e47892002a0cf0d22d86e9da925c76ac2781579

Change-Id: I70df41a8ed5ed7e6c614749125f19b80c5e03291

Change-Id: I54d0e708f00ecbd95f34a62b54768f15d263ec69

The only thing that sysui exports that is used by another package are
application icons, used in desktop (windows build only). But since
gbuildification of desktop they are included directly from
$(SRCDIR)/sysui/desktop/icons instead of $(OUTDIR)/inc/icons, so the
dependency is no longer necessary.

Change-Id: I6fa3153d3793e785c1ed602c3e67c86cead2bae2

This allows us to drop dependency on setup_native everywhere.

Change-Id: Ib033f8d5953682379c6c2ab53d5cf221e9d8cfec

   retain presence of MPL licensed nssrenam.h symbol renamer.

Change-Id: I48bad55cc982fba6fb48a921746801de9993bff1

Change-Id: I9e4e2cfc3ce61f6ac24e96a2a92fdabc4a72321e

Change-Id: I03d9130ffcce7ec92fc768e8c4ee63e425e76c21

Change-Id: I1e1ec7e91d513bc34737c7659d1178a02e80c53e

These were not deleted earlier, leaving a gray field after comment
deletion.

Change-Id: I66d5e04f075a54eb0638a63b8cd7bd8c1920603e

Change-Id: I0e2988e99f4a333cf147e41c069913180e94ec93

This avoids fetching data that will not be requested when the "cursor" is only moved and no data requested. That is typically what RowSetCache does when its own cursor is moved within its window.

This basically makes the whole {next,previous,absolute,...}_checked story obsolete, by basically always being as fast as the i_bFetchRow==false case, but in a safer way.

Change-Id: I89eaf277069736b3077bde8b45325929db290f2d

...when building --without-system-zlib on Linux.

Change-Id: I9bcb355ec75291609b28397c16068acf293ba6eb

Change-Id: I100a95d5f84ab61cb26ac39d436cb9f2cb7246e5

ppenum is already tested for NULL at the beginning of the function.
What is intended here is to know if the memory allocation succeeded.

Found by cppcheck.

Change-Id: I31a3bed93b5dfe1a4d384478267f7c8cc0421181

Change-Id: Ifbfd8e4b7a549d0225229a60a12b1b346fc02828

Change-Id: Idc8e8445b870805b99d2b9434cf1f752c63cc6a0

Change-Id: I8f71f0b20f3f1f41acde05d59a9b94d1ce942a7b

Change-Id: I59dd2a5b2f7760ca610d64289cb11d5aedcd5965

Change-Id: Ifb70bf8277659b942ef05f55f483e1407814958f

Change-Id: I5ef42a2a9cae39628442d99c4bc691bd947a92d5

Change-Id: I4c36c13d1bd519217b8e6335d31c3450e8c8d4bc