Change-Id: I6e5bef8840730f61ca976c72a808b9ffd21fe8dc
Reviewed-on: https://gerrit.libreoffice.org/57883Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins

Change-Id: I07cf04cd2acc5b50d64224edb9f2c2de2c61e356
Reviewed-on: https://gerrit.libreoffice.org/57884Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins

Change-Id: I2f9f532890bedf4aa3d86bf2aa4b6961846a915a
Reviewed-on: https://gerrit.libreoffice.org/57886Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins

Change-Id: I8758872f6a5270de3f9b9dea750b9d40c7a446db
Reviewed-on: https://gerrit.libreoffice.org/57800Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins

MS Word's UI is a bit confusing for RTL because the only place you
can set it (at least in Word 2003) is on the Normal paragraph
style - everywhere else the control is grayed out.

Add a test that very specifically tests the impact of Normal style.
The document does not use the "default" style at all, because
the style used is based on -none-. Normal is set to RTL - does
that mean that the whole document should be RTL or that
Left/Right should swap?

No. Parentless style provides LTR in MSWord, and thus the LO code
that ExchangeLeftRight() based on DefaultStyle's bidi setting was
wrong. Yes, it is determined by style/DocDefault settings, but
not by DefaultStyle in particular.

Change-Id: I000953e51d3d919f73aa1e97df63f266d15447b2
Reviewed-on: https://gerrit.libreoffice.org/57859
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

Styles without parents still have inheritance - from the DocDefaults.
So, make sure to check those properties too in
GetPropertyFromStyleSheet() (and therefore also in GetAnyProperty).

Currently, this should only impact when InStyleSheetImport(),
but if the docDefaults ever find a way to naturally migrate
into LO as doc defaults and not into the style itself, then
this will also be useful to check for paragraph properties etc.

Change-Id: Ic02cd10c104c0330684308f1380a77009206a664
Reviewed-on: https://gerrit.libreoffice.org/57805Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Justin Luth <justin_luth@sil.org>

Change-Id: If6e6df9ac592c77f19e381e50b7eb26fbf429f61
Reviewed-on: https://gerrit.libreoffice.org/57831Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins

Change-Id: I22c02c9d4e121d3cb3b68be9a5c845e9e45cc123
Reviewed-on: https://gerrit.libreoffice.org/57603Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins

Change-Id: Ia11646ac8f2f57225a1cf37725c5e0742a8489d9
Reviewed-on: https://gerrit.libreoffice.org/57605Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins

Change-Id: I1cc2b1f63326d1d0e1f6e452b93af11e59a2d674
Reviewed-on: https://gerrit.libreoffice.org/57799Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins

Change-Id: If0d8f4033d9bc20f521d33d732fb349f0df5eeef
Reviewed-on: https://gerrit.libreoffice.org/57822Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins

Change-Id: Idef368c44454ae144b091132cd0d6103f92a6dde
Reviewed-on: https://gerrit.libreoffice.org/57854
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ida903be094861991fe36792caa9a6b75738e4f15
Reviewed-on: https://gerrit.libreoffice.org/57847
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

* Update helpcontent2 from branch 'master'
  - Fix a typo found by Andrea Gelmini
    
    -reformatting part
    
    Change-Id: If12a0361a9b47878b7df0f562154931437e59fc6
    Reviewed-on: https://gerrit.libreoffice.org/57827
    Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
    

Change-Id: I4c50618d0f570978873c13c9e503d5c3d32f9f9d
Reviewed-on: https://gerrit.libreoffice.org/57830
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>

Change-Id: Ie3427dfbbdf6ecf96b4fc36c534022dc881b3957

Change-Id: I1a926f45510e18cf399aa2eb7e1bf0ad8f4f0226
Reviewed-on: https://gerrit.libreoffice.org/57836
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Fixed also alignment and accelerator issues

Change-Id: I3182b98a793ebc3d2e9d11975842bf7aac010d7c
Reviewed-on: https://gerrit.libreoffice.org/57848
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

Just like the other backends, just release the SolarMutex when
processing Qt events and keep it for user events.

Change-Id: I0c4a7149f1541607b546a99e51e790836bc9b2f9
Reviewed-on: https://gerrit.libreoffice.org/57844
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: I9671ad7c9e75b9e10abf46bc6b53fcd760acecbf
Reviewed-on: https://gerrit.libreoffice.org/57599
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

regression from
    commit f14b9d30
    convert (a>b?a:b) to std::max(a,b)

In this code
   int a;
   std::max<sal_uInt16>(a,0)
std::max will first convert a and b to sal_uInt16, therefore potentially
converting a negative number to a positive number due to the conversion
rules. Then it will take the larger number.

While this code
    int a;
    static_cast<sal_uInt16>(a > 0 ? a : 0)
will compare first, and then convert the larger number to sal_uInt16,
which might result in making a "a" that is larger than 2^16 into a
smaller value, but which will never convert a negative "a" value into a
positive value.

Change-Id: Id4f6df0089b1a74ea4ac1c5d05655e7c1d8f0c7f
Reviewed-on: https://gerrit.libreoffice.org/57846
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Thanks to Noel Grandin and Juline Nabet

Change-Id: Ie12c7bd7e2b6c6a1f2c3e7173f11a84f19137568
Reviewed-on: https://gerrit.libreoffice.org/57851Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

fallout from
    commit 65e41592
    pass SvStream around by std::unique_ptr

The backtrace where it was was freeing the SvStream we need is below,
the code seems dodgy because it is re-creating the underlying SvStream. Before
65e41592, it just leaked the SvStream.

0  SvStream::~SvStream()
    at tools/source/stream/stream.cxx:369
1  SvFileStream::~SvFileStream()
    at tools/source/stream/strmunx.cxx:300
2  SvFileStream::~SvFileStream()
    at tools/source/stream/strmunx.cxx:298
3  std::default_delete<SvStream>::operator()(SvStream*) const
4  std::unique_ptr<SvStream, std::default_delete<SvStream> >::reset(SvStream*)
5  std::unique_ptr<SvStream, std::default_delete<SvStream> >::operator=(std::unique_ptr<SvStream, std::default_delete<SvStream> >&&)
6  SfxMedium::GetMedium_Impl()
     at sfx2/source/doc/docfile.cxx:2603
7  SfxMedium::GetInputStream()
    at sfx2/source/doc/docfile.cxx:3329
8  ImportExcel8::ReadBasic()
    at sc/source/filter/excel/excimp8.cxx:391
9  ImportExcel8::PostDocLoad()
    at sc/source/filter/excel/excimp8.cxx:425
10 ImportExcel8::Read() (this=0x4727a10)
    at sc/source/filter/excel/read.cxx:1298
11 ScFormatFilterPluginImpl::ScImportExcel(SfxMedium&, ScDocument*, EXCIMPFORMAT)
    at sc/source/filter/excel/excel.cxx:142

Change-Id: I4fb769a7da71ef9a27ddef1581448efb3d303bde
Reviewed-on: https://gerrit.libreoffice.org/57843
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

There are also other "force to array" context modes in which a
range reference does not result in an implicit intersection.

Change-Id: I3f4d85f73ecde5bbf9f011deeac2936d5f43949b

Change-Id: I4bb060a6a65ca27bba8d16c268660bedef8b0ed5
Reviewed-on: https://gerrit.libreoffice.org/57821Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins

Change-Id: Ia44131f2ebee0c162b05c8019cf3600181aea5e0
Reviewed-on: https://gerrit.libreoffice.org/57842
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ie28001cf1eb5259f479caecdfb50355f98b80b7f

e.g. progress bar updates. Release and re-acquire SolarMutex

Change-Id: Ie4e12fed7b2b8ee9bcb163334d82e466025cb7fa
Reviewed-on: https://gerrit.libreoffice.org/57780
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

Change-Id: Id7d0de124c4b9006db8c28e5cebb3ba38b0143ee
Reviewed-on: https://gerrit.libreoffice.org/57602
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Iebc31a53404da41f35eed7338662365d7efbd7a2
Reviewed-on: https://gerrit.libreoffice.org/57810
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I011f4cbb10324c4a7d4e1be3ab1355291f79730b
Reviewed-on: https://gerrit.libreoffice.org/57838
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

can_focus property needs to be true for tab navigation to stop here

Change-Id: If9ed0cefc652369243d623a311ba92e2941bd43f
Reviewed-on: https://gerrit.libreoffice.org/57834
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I09d5df8d7f07eb4b6c4341d9cd281131fc2df23b
Reviewed-on: https://gerrit.libreoffice.org/57535
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

I add a function to get the data from the submenu

Change-Id: If8aedc72abfc7ca967377f0e588167f9f62fe137
Reviewed-on: https://gerrit.libreoffice.org/57269
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: I1827262ad95942cacff589929f9436f8383cf142
Reviewed-on: https://gerrit.libreoffice.org/57642
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

as it is added only at its end.

Change-Id: I46731565ddf833b055ddd5dc9175638daef1e298
Reviewed-on: https://gerrit.libreoffice.org/57837
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I271b1d69d5231ab76cb49fb0101c09d7c0ef6b79
Reviewed-on: https://gerrit.libreoffice.org/57779
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

The default style is only relevant if no style is defined
for the paragraph, so it should not be hard-coded into
any general operation.

The intention of that code was to look for an inherited value,
which can properly be found with GetPropertyFromStyleSheet().

Change-Id: Ie2805d2516b43b45e702ee860deabe89d50ec031
Reviewed-on: https://gerrit.libreoffice.org/57804
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

Change-Id: If68a45523242a30d5bc8122818b36f0babc70dcd
Reviewed-on: https://gerrit.libreoffice.org/57828
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>

Change-Id: I2715bcbaf642fd24d61f61dbf4e978e06afbf102
Reviewed-on: https://gerrit.libreoffice.org/57824
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>