Fixed:
- TCP port got lost/reset when editing a server;
- in Gtk widget disabled comma;
- secure protocol checkbox always unchecked when editing a
  server.

Change-Id: I358fc7375552b29e4840a3616e4e47b95b88ed2c
Reviewed-on: https://gerrit.libreoffice.org/21039Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Tested-by: Jan-Marek Glogowski <glogow@fbihome.de>

Slight misinterpretation of the
{Sunday, Monday, Monday, Tuesday, ..., Sunday}
sequence defined in ODFF.

Change-Id: I09ac711adf8a52db1c9efbb1c67dc908b8e06618

The filters map between a common subset of Word smart tags and Writer
RDF annotations, and when doing so, they need to know what path to use
for a smart tag namespace and also the other way around: what RDF types
are interesting for smart tag purposes.

It turns out there is BAILS specification at
<http://www.tscp.org/wp-content/uploads/2013/08/TSCP_BAILSv1.pdf> that
describes how to refer to BAF objects, so use that instead of our custom
RDF statement / document metadata key names.

Change-Id: Iac569608b05aa61547f664f2a5df7d46fe46da76

Change-Id: I342e9b5355c3ea09eede6c47b0f209f538ee82cb

Change-Id: Ic586d44d2ff0f913f655b8a7539326a6dea78477

Change-Id: I9db63e6c6b4df33387b9b4d59450494e8bd856f1

... which now has exactly 1 parameter; removed the now non-matching
required flag of a not existing second parameter. Luckily the resource
manager treats this as a separate record block and this 0 didn't harm
the subsequent 0, accidentally..

Change-Id: I0994ed75643245c1bdebc9a92ade77abdd1c61d8

Change-Id: I64b22f91bf56497b9f705e4773e24c5ba88a14ae

Change-Id: Id56e219782d7f858cdeb26232c7aabd4f643c9d9
Reviewed-on: https://gerrit.libreoffice.org/21020Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

...that had inadvertently been removed as part of a larger code removal in
6948c546 "tdf#75637: Resolve help images via a
vnd.libreoffice.image UCP"

Change-Id: Ic2d5e1a5fa5a10b240bb9e511e6dcb8097e58081

Change-Id: Ibc51fb4cc72163fb643a85ad3f0b6061b7d77ccc

Change-Id: Ib6676f6f940ce497ac6fe28189e1c3a4ed4ec0bf
Reviewed-on: https://gerrit.libreoffice.org/21032Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

Change-Id: I77f49f09ce9fe5897f78044c0522210978c904d1

...that happen to be requested concurrently from multiple threads

Change-Id: Icecfb0b8d88c9123064689643eddf90a99d3b1b8

...instead of dereferencing null pointers

Change-Id: I9d1709468a5b601b9f3d86dadea7a8e817f449d8

...except when checking for infinity

Change-Id: If6e3b8965169cc615fa5d76422e1925866714936

Change-Id: I5ecd63d79e8be77879d3789c45079929696abe03

Change-Id: Ib45af8a56ac3adc428c530908cf1bbd95e9cc64c
Reviewed-on: https://gerrit.libreoffice.org/21065Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>

Avoid hundreds of presumably pointless warning messages in some unit
tests at least. The code explicitly checks and handles the asserted
condition not being true right after the DBG_ASSERTs.

Change-Id: I5482c56aeeadb8f85dfdd03e12960abd7e769c56

Change-Id: Ie24194fe04dafbc447cf8a8a015316e9ba6e9ac9
Reviewed-on: https://gerrit.libreoffice.org/21071Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I37948ff77d060dc18a583389966b52c06a95bdaf

"yeah, makes sense to remove it", says Stephan.

Change-Id: Ife7baa5814a856dca7f0f02ac3cb2521e2980851

Project: dictionaries  ce7755c7d3179d682dfaccace9e64b6a008c77d2

tdf#96782 updated German dictionaries

Change-Id: Ifa7aed93eaa0448ba530cc029ee55480060e1be5

Change-Id: Id3b155abec7b7a2ff43d0a35e98709f5ee51c6b9
Reviewed-on: https://gerrit.libreoffice.org/21069Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

The Test currently tries to test the OpenCL and the SW interpreter and
assumes that it will show different results. However if we succeed in
generating an OpenCL interpreter we will never generate a SW interpreter.

There are a number of problems with the approach taken in this test.

1.) Assuming that we are able to execute OpenCL is an invalid
assumption.

2.) Changing the configuration inside of a test needs to be exeption
save as we are otherwise left with a strange config for the remaining
test cases.

3.) Changing the configuration does not change the formula group
interpreter. This needs to be done explicitly.

Change-Id: I679985ee7551b21aaa52038e107324980e7e1bb6

Change-Id: Ie0b3efdbe23a163aab1e8d128217ee1f1c7fd287

Change-Id: I2ef26c34a424e653d85597c85baa736c19004313

Change-Id: Id8b2db3b824ea40345aba99a5f24f2579c0ad630

Change-Id: I4e2345cdf9fd8d088f3522d563263b65abedb7c9

Change-Id: I588a9c0205e03f701b617fd1775e7f9b9b88c6b0

Change-Id: I544eac439cb7277e47a23a90c6fbc45496161c3b

Change-Id: I60ee2ccc6090c305ade4ba16d3d298866cf89c4e

This may sound crazy, but literally vcl::FontInfo serves no purpose
that I can see. The inheritance chain is like this:

        ┌────────────────────────┐
        │                        │
        │        vcl::Font       │
        │                        │
        └────────────────────────┘
                     ^
                    ╱ ╲
                     │
                     │
        ┌────────────────────────┐
        │                        │
        │      vcl::FontInfo     │
        │                        │
        └────────────────────────┘
                     ^
                    ╱ ╲
                     │
                     │

        ┌────────────────────────┐
        │                        │
        │       FontMetric       │
        │                        │
        └────────────────────────┘

vcl::FontInfo (which, incidentally, needs to be put into the vcl
namespace due to collisions with poppler!) literally does nothing
and is acting as a bridge between FontMetric and vcl::Font. Unlike
a bridge though, this bridge doesn't actually *do* anything.

So I'm removing it, which means one less class to deal with in the
vcl fonts world.

Change-Id: I32725669c9bca7fbb0846b6a062135464046e4f6
Reviewed-on: https://gerrit.libreoffice.org/21058Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I0a49bab5f410901d40c5b3b62a5a3f9d9946b8a0
Reviewed-on: https://gerrit.libreoffice.org/21057Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I74cde57e328047ac149593c5bb065d7a6066941d
Reviewed-on: https://gerrit.libreoffice.org/21056Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: I15f64797340ae366e02c2b503767cd3d22a66eeb

Change-Id: Ib0a3d82af858304bf63a20bcb30b8de741491935
Reviewed-on: https://gerrit.libreoffice.org/21054Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Change-Id: Ia2fe20559745e705667f23cdd73cbe50c6371aaa
Reviewed-on: https://gerrit.libreoffice.org/21053Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Changed private variables to use accessor functions in ImplFontMetric.
It turns out there are some variables that are redundant as they are
already in ImplFontAttributes. These are:

- meFamilyType
- mbDevice

I also needed to change ImplFontMetric::GetSlant() to GetSlantType()
as the names conflicted.

Change-Id: Ic06a374fb929e3b2ffb18a6c66577c526c3b31a7
Reviewed-on: https://gerrit.libreoffice.org/21050Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

Project: help  864de3b4e95b4550d7cfdb99ff2188e63f140cd0

Fix typo in AGGREGATE function help page

Change-Id: I0701328d135968735bec3b30adeba64fc6138f04
Reviewed-on: https://gerrit.libreoffice.org/21051Reviewed-by: Olivier Hallot <ohallot@collabora.co.uk>
Tested-by: Olivier Hallot <ohallot@collabora.co.uk>