- 29 Mar, 2018 40 kayıt (commit)
-
-
Caolán McNamara yazdı
Change-Id: Ibdbc047029c31d2b06d2349d68e1cbd9b15fd514 Reviewed-on: https://gerrit.libreoffice.org/52135Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
andreas kainz yazdı
Change-Id: I88807f2119747f0dab0d40c91cb62583b203cbf5 Reviewed-on: https://gerrit.libreoffice.org/52130Tested-by:
andreas_kainz <kainz.a@gmail.com>
-
andreas kainz yazdı
Change-Id: I498128cea0c22ed21323f398d1d866c332785e3f Reviewed-on: https://gerrit.libreoffice.org/52124Tested-by:
-
Winfried Donkers yazdı
Also, improve efficiency of function. Change-Id: Id01542bdd997e0cacfdfd16683d1ac832d22fa35 Reviewed-on: https://gerrit.libreoffice.org/51708Tested-by:
Eike Rathke <erack@redhat.com>
-
Cor Nouws yazdı
Change-Id: I9a08fe3d2d5efc14c8845993d3b18a230df51052 Reviewed-on: https://gerrit.libreoffice.org/52098Tested-by:
Miklos Vajna <vmiklos@collabora.co.uk>
-
heiko tietze yazdı
Change-Id: I3b48e9d8d2acfb33f003a6505737b0c25f5a2637 Reviewed-on: https://gerrit.libreoffice.org/52123Tested-by:
Heiko Tietze <tietze.heiko@gmail.com>
-
Julien Nabet yazdı
Change-Id: I9b8a7e873eef56c704fa6c09d37d51a0ea913a92 Reviewed-on: https://gerrit.libreoffice.org/52075Tested-by:
Julien Nabet <serval2412@yahoo.fr>
-
Stephan Bergmann yazdı
Change-Id: Iea48bb3304e2688b440c5c396ed340ffffa11568 Reviewed-on: https://gerrit.libreoffice.org/52121Tested-by:
Stephan Bergmann <sbergman@redhat.com>
-
Stephan Bergmann yazdı
I happened to come across a SEGV caused by a null ToolBox::mpData once, as below. Interestingly, some ToolBox member functions like GetItemPos and GetItemCount do take a potential null mpData (after a call to dispose) into account. > #0 0x00007fffebc1b93c in std::__cxx1998::vector<ImplToolItem, std::allocator<ImplToolItem> >::size() const (this=0x20) at /usr/include/c++/7/bits/stl_vector.h:671 > #1 0x00007fffebc172ce in ToolBox::SetItemBits(unsigned short, ToolBoxItemBits) (this=0x7ffec6449230, nItemId=16, nBits=ToolBoxItemBits::DROPDOWN) at /data/sbergman/lo-ro/source/vcl/source/window/toolbox2.cxx:889 > #2 0x00007ffff07ccc42 in SvxClipBoardControl::StateChanged(unsigned short, SfxItemState, SfxPoolItem const*) (this=0x7ffec6420390, nSID=5312, eState=SfxItemState::DEFAULT, pState=0xad4cf60) at /data/sbergman/lo-ro/source/svx/source/mnuctrls/clipboardctl.cxx:116 > #3 0x00007ffff1d69c4f in SfxToolBoxControl::statusChanged(com::sun::star::frame::FeatureStateEvent const&) (this=0x7ffec6420390, rEvent=...) at /data/sbergman/lo-ro/source/sfx2/source/toolbox/tbxitem.cxx:521 > #4 0x00007ffff193e163 in SfxDispatchController_Impl::addStatusListener(com::sun::star::uno::Reference<com::sun::star::frame::XStatusListener> const&, com::sun::star::util::URL const&) (this=0xaa3da80, aListener=uno::Reference to (SvxClipBoardControl *) 0x7ffec64203b8, aURL=...) at /data/sbergman/lo-ro/source/sfx2/source/control/unoctitm.cxx:865 > #5 0x00007ffff193ddfc in SfxOfficeDispatch::addStatusListener(com::sun::star::uno::Reference<com::sun::star::frame::XStatusListener> const&, com::sun::star::util::URL const&) (this=0xaffa990, aListener=uno::Reference to (SvxClipBoardControl *) 0x7ffec64203b8, aURL=...) at /data/sbergman/lo-ro/source/sfx2/source/control/unoctitm.cxx:250 > #6 0x00007fffee75c7e4 in svt::ToolboxController::bindListener() (this=0x7ffec6420390) at /data/sbergman/lo-ro/source/svtools/source/uno/toolboxcontroller.cxx:529 > #7 0x00007fffee75c056 in svt::ToolboxController::update() (this=0x7ffec6420390) at /data/sbergman/lo-ro/source/svtools/source/uno/toolboxcontroller.cxx:227 > #8 0x00007fffc11ddef6 in framework::ToolBarManager::UpdateControllers() (this=0x7ffec6142930) at /data/sbergman/lo-ro/source/framework/source/uielement/toolbarmanager.cxx:364 > #9 0x00007fffc11e995e in framework::ToolBarManager::AsyncUpdateControllersHdl(Timer*) (this=0x7ffec6142930) at /data/sbergman/lo-ro/source/framework/source/uielement/toolbarmanager.cxx:1852 > #10 0x00007fffc11dc748 in framework::ToolBarManager::LinkStubAsyncUpdateControllersHdl(void*, Timer*) (instance=0x7ffec6142930, data=0x7ffec6142b00) at /data/sbergman/lo-ro/source/framework/source/uielement/toolbarmanager.cxx:1839 > #11 0x00007fffec264928 in Link<Timer*, void>::Call(Timer*) const (this=0x7ffec6142b20, data=0x7ffec6142b00) at /data/sbergman/lo-ro/source/include/tools/link.hxx:84 > #12 0x00007fffec264787 in Timer::Invoke() (this=0x7ffec6142b00) at /data/sbergman/lo-ro/source/vcl/source/app/timer.cxx:76 > #13 0x00007fffec21cdd2 in Scheduler::ProcessTaskScheduling() () at /data/sbergman/lo-ro/source/vcl/source/app/scheduler.cxx:448 > #14 0x00007fffec21bfed in Scheduler::CallbackTaskScheduling() () at /data/sbergman/lo-ro/source/vcl/source/app/scheduler.cxx:270 > #15 0x00007fffcdfaa036 in SalTimer::CallCallback() (this=0x199ae40) at /data/sbergman/lo-ro/source/vcl/inc/saltimer.hxx:55 > #16 0x00007fffcdfa920d in sal_gtk_timeout_dispatch(_GSource*, int (*)(void*), void*) (pSource=0x7e1abe0) at /data/sbergman/lo-ro/source/vcl/unx/gtk3/gtk3gtkdata.cxx:692 > #17 0x00007ffff5aa7b77 in g_main_dispatch (context=0x63d8d0) at /usr/src/debug/glib2-2.54.3-2.fc27.x86_64/glib/gmain.c:3142 > #18 0x00007ffff5aa7b77 in g_main_context_dispatch (context=context@entry=0x63d8d0) at /usr/src/debug/glib2-2.54.3-2.fc27.x86_64/glib/gmain.c:3795 > #19 0x00007ffff5aa7f20 in g_main_context_iterate (context=context@entry=0x63d8d0, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at /usr/src/debug/glib2-2.54.3-2.fc27.x86_64/glib/gmain.c:3868 > #20 0x00007ffff5aa7fac in g_main_context_iteration (context=0x63d8d0, may_block=1) at /usr/src/debug/glib2-2.54.3-2.fc27.x86_64/glib/gmain.c:3929 > #21 0x00007fffcdfa78f4 in GtkSalData::Yield(bool, bool) (this=0x63ae70, bWait=true, bHandleAllCurrentEvents=false) at /data/sbergman/lo-ro/source/vcl/unx/gtk3/gtk3gtkdata.cxx:459 > #22 0x00007fffcdfabf07 in GtkInstance::DoYield(bool, bool) (this=0x6e6a90, bWait=true, bHandleAllCurrentEvents=false) at /data/sbergman/lo-ro/source/vcl/unx/gtk/gtkinst.cxx:412 > #23 0x00007fffec2515ca in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at /data/sbergman/lo-ro/source/vcl/source/app/svapp.cxx:472 > #24 0x00007fffec24c2c4 in Application::Yield() () at /data/sbergman/lo-ro/source/vcl/source/app/svapp.cxx:537 > #25 0x00007fffec24c24e in Application::Execute() () at /data/sbergman/lo-ro/source/vcl/source/app/svapp.cxx:452 > #26 0x00007ffff774d617 in desktop::Desktop::Main() (this=0x7fffffff2950) at /data/sbergman/lo-ro/source/desktop/source/app/app.cxx:1623 > #27 0x00007fffec260825 in ImplSVMain() () at /data/sbergman/lo-ro/source/vcl/source/app/svmain.cxx:198 > #28 0x00007fffec262498 in SVMain() () at /data/sbergman/lo-ro/source/vcl/source/app/svmain.cxx:236 > #29 0x00007ffff77bba98 in soffice_main() () at /data/sbergman/lo-ro/source/desktop/source/app/sofficemain.cxx:166 > #30 0x000000000040086d in sal_main () at /data/sbergman/lo-ro/source/desktop/source/app/main.c:48 > #31 0x0000000000400847 in main (argc=4, argv=0x7fffffff2c98) at /data/sbergman/lo-ro/source/desktop/source/app/main.c:47 Change-Id: I622b4128de0a6be294b59caf2bb2d6f7b529c349 Reviewed-on: https://gerrit.libreoffice.org/52086Tested-by:
-
Miklos Vajna yazdı
Reported problem is that nothing happens for paste. Direct cause is that BITMAP is selected as the format, and Excel advertises BITMAP, but when we try to import that, it fails. There are 3 interesting commits in the recent history for this topic: - commit c47db038 (fdo#52547 SOT: Prefer embedding image data to embedding linked image., 2014-02-07) was a bugfix due to newer firefox - commit 538c13f3 (fdo#78801 fdo#52547 Paste preference is image, then html, then text., 2014-05-28) was a regression fix from the previous fix - commit a96a7ce5 (fdo#81835 Don't prefer GDI Metafiles to RTF/HTML, 2014-08-05), was a regression fix from the previous fixes Going back to the original state shows that the Excel -> Writer use-case used to be RTF. Restore the old Excel -> Writer (RTF) behavior by: - going back to the original state, ignoring the enum class conversions - re-fix fdo#52547: prefer bitmap over html, but leave everything else unchanged - fdo#78801 needs no fix in this case - fdo#81835 needs no fix in this case - tdf#115574 selects RTF -> table shows up After all these complications, the actual fix is surprisingly simple. Change-Id: I2d728afa7d1dd7888fa43525366c197d806eea6c Reviewed-on: https://gerrit.libreoffice.org/52120Reviewed-by:
-
Stephan Bergmann yazdı
...that had been added with f0215dcc "unotools: assert if TempFile::GetURL() fails due to missing file UCP". But when SRCDIR is a read-only tree, JunitTest_sc_unoapi_2 fails with that assert firing when TempFile::GetURL is called from SfxMedium::CreateTempFile (sfx2/source/doc/docfile.cxx), which in turn is prepared to handle an empty return value from GetURL, and the test succeeds after removing the assert. So it looks like that assert was not precise enough to only fire in the scenarios where it was intended to fire. Change-Id: I333e9026ee14e9d1140b1b475793a5b15ededd70 Reviewed-on: https://gerrit.libreoffice.org/52085Tested-by:
-
Julien Nabet yazdı
Change-Id: I85ab503b52e9d5fa20fcc20b136c92ce5cb7b6cf Reviewed-on: https://gerrit.libreoffice.org/52078Tested-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Julien Nabet yazdı
Change-Id: I29c4af5a59f72c478090f1b8625a0507d461374a Reviewed-on: https://gerrit.libreoffice.org/52077Tested-by:
-
Noel Grandin yazdı
Change-Id: Ic044a6e4568e707022d87bc5712205fbdf084ba2 Reviewed-on: https://gerrit.libreoffice.org/52067Tested-by:
-
Mike Kaganski yazdı
Change-Id: I257f2799c507a6669ad7048db72fbe374f40de11 Reviewed-on: https://gerrit.libreoffice.org/52076Tested-by:
Mike Kaganski <mike.kaganski@collabora.com>
-
Szymon Kłos yazdı
Change-Id: I862246d9c69e754bdd883787fe42c7d61a1a53d3 Reviewed-on: https://gerrit.libreoffice.org/51790Tested-by:
Szymon Kłos <szymon.klos@collabora.com>
-
László Németh yazdı
Apply the following extra requirements of Hungarian orthography for sorting words and sentences: – expand simplified double consonants; – ignore spaces and hyphens; – prefer lower case homonyms. Note: automatic sorting is better this way, but it's still not error-free. Important advantage, that now it's *possible* to fix all errors in a semi-automatic way, using soft hyphens. Inserting them in bad or ambiguous character positions will fix all automatic sortings later. Example with consonant "gy", simplified form of long "gygy" is the ambiguous "ggy" (it can be "g" and "gy", too, as in "meggyőz"): = Bad = = Now = = Good (corrected, "|" signs soft hyphen) = megbíz megbíz megbíz meggyíz megzavar meg|győz meggyőz megye megzavar megzavar meggyíz megye megye meggyőz meggyíz megyünk megyünk megyünk Change-Id: Ia84f264ad9ea4cdebe5f3ea22212a9594b4fe44d Reviewed-on: https://gerrit.libreoffice.org/51973Tested-by:
László Németh <nemeth@numbertext.org>
-
Mike Kaganski yazdı
The intent of the test is to trigger PDF export. On Windows, GDI printing is used, so no use to run it (and it would provide a sane PDF with 2 white paths). Change-Id: I808807ce0d339cccbb3d097f486d2562e7b2819f Reviewed-on: https://gerrit.libreoffice.org/52072Reviewed-by:
-
Caolán McNamara yazdı
Change-Id: I11a60e5c6f7728fd47dbb461004622a99f055b16 Reviewed-on: https://gerrit.libreoffice.org/52060Tested-by:
-
Christian Lohmaier yazdı
Change-Id: I8973bbbfd0b51106b528c1def872e1018a9c2159
-
Noel Grandin yazdı
Change-Id: I7805ac9bc6f8c0aa5ba4804777e7d7c2c29a78f3 Reviewed-on: https://gerrit.libreoffice.org/52066Tested-by:
-
Justin Luth yazdı
Inserting the 0x02 placeholder as the first entry in the line interferes with the aesthetic tab code. lcl_text has code to ignore that placeholder, but lcl_utext doesn't. Ignoring at lcl_utext has the same affect as not processing it at all. Only .docx adds 0x02, so it should be fairly safe to avoid the 0x02 completely. Nothing was detected missing by skipping the placeholder. All of the code was inherited from OOo. Change-Id: Ie8840e5946fec89f270fef5523c88ee5051ca8ef Reviewed-on: https://gerrit.libreoffice.org/51912Tested-by:
Justin Luth <justin_luth@sil.org> Reviewed-by:
-
Jim Raykowski yazdı
Change-Id: Ic3d198488de6d0420dbdb8fb7dbfb0335556e108 Reviewed-on: https://gerrit.libreoffice.org/52047Reviewed-by:
Katarina Behrens <Katarina.Behrens@cib.de> Tested-by:
-
Stephan Bergmann yazdı
Change-Id: If8d0b89810c7c9a0cf8664e5f34be154e35e40ed Reviewed-on: https://gerrit.libreoffice.org/52071Tested-by:
-
Caolán McNamara yazdı
Change-Id: I05c91dc21ddcef0f64f712f4fe9a5736b0cee0f9 Reviewed-on: https://gerrit.libreoffice.org/52059Tested-by:
-
Caolán McNamara yazdı
Change-Id: I14cfde619e1280c21d8481fc58c5ba69855c1b5d Reviewed-on: https://gerrit.libreoffice.org/52064Tested-by:
-
David Tardon yazdı
Change-Id: Ib44570ff53d754d1d568378ef0dac4d4789f2042 Reviewed-on: https://gerrit.libreoffice.org/52051Tested-by:
David Tardon <dtardon@redhat.com>
-
Caolán McNamara yazdı
Change-Id: Ie3a352551a82656939c7d25b7f922a03b80d232b Reviewed-on: https://gerrit.libreoffice.org/52061Tested-by:
-
Caolán McNamara yazdı
Change-Id: Ie098ea6fd2b36e8bc6173f3ca69f2ffc5e312533 Reviewed-on: https://gerrit.libreoffice.org/52062Tested-by:
-
Caolán McNamara yazdı
Change-Id: I699fb3e07d21dc1852c0d50d4a7d478bcf1d1a96 Reviewed-on: https://gerrit.libreoffice.org/52063Tested-by:
-
Caolán McNamara yazdı
Change-Id: Ic384dfd66f834ee360c60e497b8b7b688c913f02 Reviewed-on: https://gerrit.libreoffice.org/52057Tested-by:
-
Caolán McNamara yazdı
Change-Id: I18506b74ac999893eab1d652b46ee2226f5a3dea Reviewed-on: https://gerrit.libreoffice.org/52058Tested-by:
-
Armin Le Grand yazdı
The part to detect a hit on a TableObjectText in Draw/Impress for a non-selected Table was setting the HitType to SdrHitKind::TextEditObj. This prevents the latter happeing check for URL (see below). Not directly setting to TextEditObj is okay, this is determined and set later. I checked various possible changes to keep the behaviour as for 'normal' SdrObjects, so please be careful when doing changes in the HitTest code Change-Id: I326a73b88fc56fd902b5052cc3a2ddecf3c3ba61 Reviewed-on: https://gerrit.libreoffice.org/52016Tested-by:
Armin Le Grand <Armin.Le.Grand@cib.de>
-
Noel Grandin yazdı
Change-Id: If0d729ee84263a5afb2c7acb2d62b08602aa59f4 Reviewed-on: https://gerrit.libreoffice.org/52046Tested-by:
-
Mike Kaganski yazdı
Change-Id: I8b6ab688ec13cee7c5a6b49d6691efdcea2a3d74 Reviewed-on: https://gerrit.libreoffice.org/52049Reviewed-by:
-
Stephan Bergmann yazdı
...as the SwTextBlocks ctor internally calls SwDOCXReader::MakeEntries -> BeginPutDoc which wants to open the document read-write. That would fail if SRCDIR is a read-only tree. Change-Id: I433b80bcec53c8ca4282d1f45c941153a4064eb9 Reviewed-on: https://gerrit.libreoffice.org/52053Tested-by:
-
Tamas Bunth yazdı
Also fix bugs shown by the unit test Use boost date/time instead of std, because std::tm cannot handle dates before 1970. Change-Id: I7f5dbb3d828a591a4b51c7204dc3bd39fefc42ff Reviewed-on: https://gerrit.libreoffice.org/51804Tested-by:
Tamás Bunth <btomi96@gmail.com>
-
Caolán McNamara yazdı
rather than a question form when it was used in a query dialog Change-Id: Ife5caba5bf307a2786e7581fce44bc1fc9a8368d Reviewed-on: https://gerrit.libreoffice.org/52004Tested-by:
-
andreas kainz yazdı
Change-Id: Ie0971fae1ef3d02ab0c9ca8cce1cd1fd3d7b6166 Reviewed-on: https://gerrit.libreoffice.org/52050Tested-by:
-
andreas kainz yazdı
Change-Id: I17ac726e498546676fb6de3328356d2e155e734a Reviewed-on: https://gerrit.libreoffice.org/52048Tested-by:
-
