Lets assume that that was an oversight, and change all those user-provided
copy assignment ops into implicitly-defined ones (that will now also copy
Bundle::mnColor).  Avoids -Wdeprecated-copy with GCC trunk towards GCC 9, as the
copy ctors were already left implicitly-defined (and so already copied
Bundle::mnColor).

Change-Id: I43e323b55d059c7afecaddab0d777b6df47182c8
Reviewed-on: https://gerrit.libreoffice.org/56539
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

See https://bugs.documentfoundation.org/show_bug.cgi?id=96099#c44

Change-Id: Ib2d828a66bc14faa4f341eec9210e1effdebd7c1
Reviewed-on: https://gerrit.libreoffice.org/56541
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

The assertion fails when one reproduces tdf#69460 but removing the
assert() does not cause any problems.

Change-Id: Idaa5d41a0cf76073e406d7152fc3b4e9ebd3e876
Reviewed-on: https://gerrit.libreoffice.org/56538Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>

Change-Id: I50b842afc505ce603225fb2d25281cc8e9240200
Reviewed-on: https://gerrit.libreoffice.org/56537Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

...as that member is only used in m_aIdToStyle, and it was confusing how the
user-provided HashedStyle copy ctor initializes it to zero while the implicitly
defined copy assignment op copies it.  (And existence of only one of those
copy functions also triggered -Wdeprecated-copy with GCC trunk towards GCC 9.)

Change-Id: I176ef95af8780fefe21e53f61fd66f5e2d9156ab
Reviewed-on: https://gerrit.libreoffice.org/56528
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Which is used in e.g. the Calc cell border dialog. The approach is
similar to commit 60790935 (tdf#96657 -
vcl opengl: implement invert: Track Frame., 2016-01-09) but that one was
for rectangles, this one is for polygons.

Change-Id: Ib1feebab2d14f4450fee0afe96afcea906965fdb
Reviewed-on: https://gerrit.libreoffice.org/56534Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

Change-Id: I017c100f83faac64ad3a8430010c226b438e6a07
Reviewed-on: https://gerrit.libreoffice.org/56529
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

add to NB grouped (full and compact) in Edit group
cause Format is only Format selected text but not Format page.
Edit group is most generic group that fit's for page selection

Change-Id: I49af8ff5b560655d43c55818da391a768d26ef04
Reviewed-on: https://gerrit.libreoffice.org/56430
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

If the fon supports Graphite features we can get the feature
descriptions from the font, but this descriptions are mostly
limited (available in a limited number of languages), so it is
better to only use this descriptions only if the feature does not
have an OpenType description available.

Change-Id: Ic0b81cb8cc22e1e73f30e6a960167cfa982fbfc7
Reviewed-on: https://gerrit.libreoffice.org/56318
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I85243dff96b9090de0fd55564b44abb6142d9ac2
Reviewed-on: https://gerrit.libreoffice.org/56524
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Change-Id: Ic38eab88f68952549af3417c3e85020877c95446
Reviewed-on: https://gerrit.libreoffice.org/56498
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

pasting content from another cell

In tiled rendering case (headless) each window has its own clipboard,
otherwise exists a unique clipboard (UNO service).

Change-Id: I7d5d0b085faeaffa3fc0a80914fbe9349f4aa402
Reviewed-on: https://gerrit.libreoffice.org/56508
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

When embedding fonts to ODF documents we can get into a situation
where the same font is embedded multiple times and this wastes
space. To prevent this we calculate the checksum of the font first
and track the fonts that are embedded. When the font has the same
checksum, the path to already embedded font is returned.

Change-Id: I087c42d9a63b1697b9b4ea985dbce2fda760a996
Reviewed-on: https://gerrit.libreoffice.org/56507
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I5c775b8bc5cef3e14404f119e1ffb06334022003
Reviewed-on: https://gerrit.libreoffice.org/56506
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I0f9392d95ec2887ee62d1486f63600693a8b4dca
Reviewed-on: https://gerrit.libreoffice.org/56497
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and spelling out using the new NatNum12 modifier
to support common "in", "on", "from", "to", etc. date
suffix variants, "dash-free" spell out format of years
of the new Hungarian orthographical reform, and months
with articles.

For example, "in 2018" is "2018-ban", "in 2019" is "2019-ben"
in Hungarian because of "vowel harmony", the word stem
dependent fluctuation of the suffix variants, a frequent
linguistic feature of other agglutinative languages, too,
including Estonian, Finnish and Turkish.

Note: some of the new date formats will work correctly only
with the upcoming update of the external libnumbertext.

Note 2: add also alternative (real) abbreviated month names,
because the default abbreviated month names are Roman
numbers.

Change-Id: Ibb33ff6a627b8e27fd02388653e3b33ebd446a10
Reviewed-on: https://gerrit.libreoffice.org/55637
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Change-Id: I4bd0a9dd7be5b6ad7c1307f73c89ab0ee915ce9f
Reviewed-on: https://gerrit.libreoffice.org/56495
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Appears to be a regression introduced with
b6b1ded0 "sc: replace ScCaptionPtr with
std::shared_ptr, tdf#117997, tdf#117228".  Reported e.g. as
<https://ci.libreoffice.org//job/lo_ubsan/954/console> during
CppunitTest_sc_subsequent_export_test and CppunitTest_sc_ucalc:

> /sc/source/core/data/document.cxx:2574:28: runtime error: member call on null pointer of type 'ScDocShell'
>     #0 0x2b9971542d76 in ScDocument::IsClipboardSource() const /sc/source/core/data/document.cxx:2574:28
>     #1 0x2b99722b7762 in ScFormulaCell::ScFormulaCell(ScFormulaCell const&, ScDocument&, ScAddress const&, ScCloneFlags) /sc/source/core/data/formulacell.cxx:844:14
>     #2 0x2b996fee35b0 in ScCellValue::assign(ScCellValue const&, ScDocument&, ScCloneFlags) /sc/source/core/data/cellvalue.cxx:395:29
>     #3 0x2b997312db22 in ScChangeTrack::Clone(ScDocument*) const /sc/source/core/tool/chgtrack.cxx:4565:25
>     #4 0x2b99cd1728be in XclExpChangeTrack::CreateTempChangeTrack() /sc/source/filter/xcl97/XclExpChangeTrack.cxx:1561:12
>     #5 0x2b99cd169a74 in XclExpChangeTrack::XclExpChangeTrack(XclExpRoot const&) /sc/source/filter/xcl97/XclExpChangeTrack.cxx:1418:39
>     #6 0x2b99cab087c0 in ExcDocument::ReadDoc() /sc/source/filter/excel/excdoc.cxx:788:41
>     #7 0x2b99cadddc2e in ExportBiff5::Write() /sc/source/filter/excel/expop2.cxx:112:5
>     #8 0x2b99cab8ee83 in lcl_ExportExcelBiff(SfxMedium&, ScDocument*, SvStream*, bool, unsigned short) /sc/source/filter/excel/excel.cxx:181:16
>     #9 0x2b99cab8d342 in ScFormatFilterPluginImpl::ScExportExcel5(SfxMedium&, ScDocument*, ExportFormatExcel, unsigned short) /sc/source/filter/excel/excel.cxx:219:16
>     #10 0x2b99768df9d2 in ScDocShell::ConvertTo(SfxMedium&) /sc/source/ui/docshell/docsh.cxx:2419:30
>     #11 0x2b998a7e2550 in SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) /sfx2/source/doc/objstor.cxx:1513:19
>     #12 0x2b998a7fe5e2 in SfxObjectShell::DoSaveAs(SfxMedium&) /sfx2/source/doc/objstor.cxx:1900:17
>     #13 0x2b9985a31bb6 in ScBootstrapFixture::saveAndReload(ScDocShell*, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags) /sc/qa/unit/helper/qahelper.cxx:664:5
>     #14 0x2b9985a34593 in ScBootstrapFixture::saveAndReload(ScDocShell*, int) /sc/qa/unit/helper/qahelper.cxx:686:28
>     #15 0x2b9956fca835 in ScExportTest::testTrackChangesSimpleXLSX() /sc/qa/unit/subsequent_export-test.cxx:2618:29
>     #16 0x2b9957203058 in void std::_Mem_fn_base<void (ScExportTest::*)(), true>::operator()<, void>(ScExportTest*) const /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:600:11
>     #17 0x2b9957202d63 in void std::_Bind<std::_Mem_fn<void (ScExportTest::*)()> (ScExportTest*)>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1073:11
>     #18 0x2b9957202771 in void std::_Bind<std::_Mem_fn<void (ScExportTest::*)()> (ScExportTest*)>::operator()<, void>() /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1131:11
>     #19 0x2b9957201149 in std::_Function_handler<void (), std::_Bind<std::_Mem_fn<void (ScExportTest::*)()> (ScExportTest*)> >::_M_invoke(std::_Any_data const&) /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1871:2
>     #20 0x2b9957203ad0 in std::function<void ()>::operator()() const /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:2271:14
>     #21 0x2b99571ff885 in CppUnit::TestCaller<ScExportTest>::runTest() /workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:175:7
>     #22 0x2b990c338e7d in CppUnit::TestCaseMethodFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5
>     #23 0x2b99294cb4d6 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /test/source/vclbootstrapprotector.cxx:48:14
>     #24 0x2b990c2f7947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
>     #25 0x2b991bcad7a6 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89:12
>     #26 0x2b990c2f7947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
>     #27 0x2b9917d39e13 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63:16
>     #28 0x2b990c2f7947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
>     #29 0x2b990c2732df in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12
>     #30 0x2b990c2f7947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
>     #31 0x2b990c2edb70 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86:18
>     #32 0x2b990c3c2ccb in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::string const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182:10
>     #33 0x2b990c335efd in CppUnit::TestCase::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:5
>     #34 0x2b990c33c0b3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:5
>     #35 0x2b990c33b01d in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
>     #36 0x2b990c33c0b3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:5
>     #37 0x2b990c33b01d in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
>     #38 0x2b990c402686 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:5
>     #39 0x2b990c3c0e19 in CppUnit::TestResult::runTest(CppUnit::Test*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149:3
>     #40 0x2b990c403b27 in CppUnit::TestRunner::run(CppUnit::TestResult&, std::string const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:3
>     #41 0x515d6d in (anonymous namespace)::ProtectedFixtureFunctor::run() const /sal/cppunittester/cppunittester.cxx:315:13
>     #42 0x51071f in sal_main() /sal/cppunittester/cppunittester.cxx:465:14
>     #43 0x50e832 in main /sal/cppunittester/cppunittester.cxx:372:1
>     #44 0x2b990e038444 in __libc_start_main (/lib64/libc.so.6+0x22444)
>     #45 0x433494 in _start (/workdir/LinkTarget/Executable/cppunittester+0x433494)

Change-Id: Id6cbc92844c89d48daecf8fad0b8899fcd087eaa
Reviewed-on: https://gerrit.libreoffice.org/56513
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

If that (implicitly defined) ctor had ever been used, it would have failed to
increment m_nRef, so could have caused m_pInstance to be deleted too early.  So
better mark it as deleted.  (LO itself apparently didn't call it.  If 3rd party
code would want to call it after all, it could be changed from deleted to
properly user-provided, incrementing m_nRef, in the future.)

The implicitly defined copy assignment op happens to already do the right thing,
and /is/ used, e.g., during

>         m_aNode = _rhs.m_aNode;

in DriversConfig::operator= (connectivity/source/commontools/DriversConfig.cxx).
Mark it as defaulted to avoid -Wdeprecated-copy with GCC trunk towards GCC 9.

Change-Id: I527123d9de837c311d30a270feb09dc173d9f411
Reviewed-on: https://gerrit.libreoffice.org/56512
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

fixes 6.0 commit  9ae1e094
> PPTX export: correct position of rotated groups

However, there was nothing excluding the re-positioning
to only group items.

Change-Id: I62e36b46c0d2ac3e41f8d7d4ed82df11e6eb1ee5
Reviewed-on: https://gerrit.libreoffice.org/56386
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

Change-Id: I8f91e5d00e716bbd0e6aa25697e0b30908ffb8bb

Otherwise calc's threading asserts with fdo#37765-1.

Change-Id: Ic2500f2218bf62c4d05f1c5284e62a53c0598b53
Reviewed-on: https://gerrit.libreoffice.org/56484
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Otherwise fdo#74583-1 asserts with calc's threading.

Change-Id: I2ba46a15d1d5216b279ae21d92ae52353e470df6
Reviewed-on: https://gerrit.libreoffice.org/56479
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

The Mapping struct is small, so there's no need to reuse it.
Without this, sc/qa/.../sumif_wildcards.fods sometimes fails with calc
threading.

Change-Id: If1f370bebe8e1afa14f8645d843a056b6f0dbdea
Reviewed-on: https://gerrit.libreoffice.org/56449
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Change-Id: If4725a7c170a4f10b1ffd0cfc769fcdca70e2eaf
Reviewed-on: https://gerrit.libreoffice.org/56493
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Reorder footer-left/footer-first so that they are valid wrt. ODF 1.3
draft schema.  The schema was changed to add footer-first after
footer-left, but the filter wrote footer-first before footer-left.

Change-Id: I48b7ed932729ec2c94e17e6f3d4797926c9811ee
Reviewed-on: https://gerrit.libreoffice.org/56482
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I101c8a39344ab007640aec9ddad6f82d4fe64296
Reviewed-on: https://gerrit.libreoffice.org/56504
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

We want to avoid the phenomenon where right after typing the first
character into a Writer documnent in a LibreOffice instance, spell and
grammar checking stuff is initialised which can take a quite long
time, especially the LightProof one.

Even after my recent change that made the Lightproof initialisation
clearly faster (by avoiding the import of the large
lightproof_impl_pt_BR.py module before actually doing Brazilian
Portuguese proofreading), there still was a 0.3 second delay on my
relatively fast machine.

This change moves that delay into Writer start instead, before any
document window is ready to accept input. At least then the user is
not entering text and wondering why it doesn't show up right away.

Change-Id: Ie578c310dc9cb9bfc964e2986eec177fb1d4e666
Reviewed-on: https://gerrit.libreoffice.org/56473
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

Change-Id: Id7a50d5379f8d2f8ecd39a75a520b1501600adcb
Reviewed-on: https://gerrit.libreoffice.org/56501
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I34411e00d67ab29eb0796207d17f77a4f767c0b0
Reviewed-on: https://gerrit.libreoffice.org/56500
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I0f26159f8af09a68c819c400abd09454a6d827b2
Reviewed-on: https://gerrit.libreoffice.org/56499
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ic895c7b79a25a0766cc6d352c5ed75873004fddb
Reviewed-on: https://gerrit.libreoffice.org/56496
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I79fcbaa12def04aa36bdf1928638b70ad490448c
Reviewed-on: https://gerrit.libreoffice.org/56494
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I7dce11ddf85fc92d6ac69ea307c4c1c181521460
Reviewed-on: https://gerrit.libreoffice.org/56492
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Idc99dfd6e5ee7bc999088f4657d77613d0029b97
Reviewed-on: https://gerrit.libreoffice.org/56489
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

So that the graphic reflects the new "signed" state

Change-Id: Ic943581c4dfff53fbf9fbd5f1398c98842497a25
Reviewed-on: https://gerrit.libreoffice.org/56477
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Instead just copy the "unsigned" graphic

Change-Id: I5183b0b33be0469dceaace142d73aa403cc32ef2
Reviewed-on: https://gerrit.libreoffice.org/56472
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

See bt:
https://bugs.documentfoundation.org/attachment.cgi?id=143105

Regression from:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=a9ef943769b06e6bdffe7326f288b27e08a95698

Change-Id: I285f00cb6ede3d952a794b60ff64586fe2224e5f
Reviewed-on: https://gerrit.libreoffice.org/56490Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

The MS formats apparently require absolute sheet references in
named ranges. So, it can't directly use LO's GLOBAL relative ranges.
Instead, attempt to emulate that by duplicating the GLOBAL name
directly into every sheet. If the name already exists, then
(in theory) it would have overridden the global one anyway,
so just drop it in that case.

Change-Id: I32ab6f957a60fde7ec8a1912cfb0974a55db3886
Reviewed-on: https://gerrit.libreoffice.org/54743Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Change-Id: I3072630c769224be730e6ec16b1a02fa4f1b10e6
Reviewed-on: https://gerrit.libreoffice.org/56485Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>