Skip to content

C
core
Dal (branch)/etiket değiştir
  1. 07 Eyl, 2018 6 kayıt (commit)
    • Stephan Bergmann's avatar
      DeInitVCL in PythonTest · e7a3329f
      Stephan Bergmann yazdı 
      After b9757f5c "loplugin:useuniqueptr in
vcl/svdata" ASan/UBSan builds started to fail (like
<https://ci.libreoffice.org//job/lo_ubsan/1025/>) at the end of
PythonTest_dbaccess_python (and probably other PythonTests), when during exit
the static utl::ConfigManager instance already happens to be destroyed by the
time the static ImplSVData's mpSettingsConfigItem is destroyed (which would
normally be cleared during DeInitVCL, if PythonTests would call that, and which
in the past had thus simply been leaked in PythonTests when that
mpSettingsConfigItem was a plain pointer instead of std::unique_ptr).

So ensure that PythonTests that initialize VCL also call DeInitVCL, via a new
private_deinitTestEnvironment, complementing the existing
private_initTestEnvironment.

However, while private_initTestEnvironment is called once (typically via
UnoInProcess.setUp, which internally makes sure to only call it once) as soon as
the first executed test needs it, private_deinitTestEnvironment must be called
once after the lasts test needing it has executed.  The only way that I found to
do that is to override unittest.TextTestResult's stopTestRun method, which is
called once after all tests have been executed.  Hence a new test runner setup
in unotest/source/python/org/libreoffice/unittest.py that is now called from
solenv/gbuild/PythonTest.mk.

That revealed a few places in PythonTests that didn't yet close/delete documents
that they had opened, which has now been added.

One remaining problem then is that classes like SwXTextDocument and friends call
Application::GetSolarMutex from their dtors, via sw::UnoImplPtrDeleter (a "Smart
pointer class ensuring that the pointed object is deleted with a locked
SolarMutex", sw/inc/unobaseclass.hxx).  That means that any PyUNO proxies to
such C++ objects that remain alive after private_deinitTestEnvironment will
cause issues at exit, when Python does a final garbage collection of those
objects.  The ultimate fix will be to remove that unhelpful UnoImplPtrDeleter
and its locking of SolarMutex from the dtors of UNO objects; until then, the
Python code is now sprinkled with some HACKs to make sure all those PyUNO
proxies are released in a timely fashion (see the comment in
unotest/source/python/org/libreoffice/unittest.py for details).  (Also, it would
probably help if UnoInProcess didn't keep a local self.xDoc around referencing
(just) the last result of calling one of its open* methods, confusingly making
it the responsibility of UnoInProcess to close that one document while making it
the responsibility of the test code making the other UnoInProcess.open* calls to
close any other documents.)

Change-Id: Ief27c81e2b763e9be20cbf3234b68924315f13be
Reviewed-on: https://gerrit.libreoffice.org/60100
Tested-by: Jenkins
Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      e7a3329f
    • Julien Nabet's avatar
      tdf#75341: fix condition to approve row (form) · dbb444e4
      Julien Nabet yazdı 
      Considering rColInfo.nNullable != ColumnValue::NO_NULLS is ok to approve row
isn't sufficient in the case the field is "Input required" in form.

Change-Id: I27c57fe8ce5afac97eb0650f93703333c85f1421
Reviewed-on: https://gerrit.libreoffice.org/60109
Tested-by: Jenkins
Reviewed-by: 's avatarLionel Elie Mamane <lionel@mamane.lu>
      dbb444e4
    • Kohei Yoshida's avatar
      tdf#116453: Add a test case for this. · e55a8522
      Kohei Yoshida yazdı 
      Change-Id: I280f070bf974ac2f4a889f4c98a80a87092c013a
Reviewed-on: https://gerrit.libreoffice.org/60118
Tested-by: Jenkins
Reviewed-by: 's avatarKohei Yoshida <libreoffice@kohei.us>
      e55a8522
    • Mike Kaganski's avatar
      Update git submodules · be5e7fed
      Mike Kaganski yazdı 
      * Update helpcontent2 from branch 'master'
  - Mark XML Source as experimental feature
    
    ... since commit 65722772
    
    Change-Id: I80d97004a9cd4dc9e6600e6bab64a43c5be91633
    Reviewed-on: https://gerrit.libreoffice.org/59706
    Tested-by: Jenkins
Reviewed-by: 's avatarAdolfo Jayme Barrientos <fitojb@ubuntu.com>
      be5e7fed
    • Mike Kaganski's avatar
      Update git submodules · 719d5d72
      Mike Kaganski yazdı 
      * Update helpcontent2 from branch 'master'
  - Mention custom format codes for Calc's TEXT() function
    
    Change-Id: I29271e2f555cbc231b616e75b43b37775143feae
    Reviewed-on: https://gerrit.libreoffice.org/59984Reviewed-by: 's avatarAdolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: 's avatarAdolfo Jayme Barrientos <fitojb@ubuntu.com>
      719d5d72
    • Andrea Gelmini's avatar
      Fix typo · 6732bebb
      Andrea Gelmini yazdı 
      Change-Id: Ib2c183f5edb94e68f43f92edd83cb8d3ae5b40e1
Reviewed-on: https://gerrit.libreoffice.org/60103
Tested-by: Jenkins
Reviewed-by: 's avatarJens Carl <j.carl43@gmx.de>
      6732bebb
  3. 06 Eyl, 2018 34 kayıt (commit)