• Stephan Bergmann's avatar
    DeInitVCL in PythonTest · e7a3329f
    Stephan Bergmann yazdı
    After b9757f5c "loplugin:useuniqueptr in
    vcl/svdata" ASan/UBSan builds started to fail (like
    <https://ci.libreoffice.org//job/lo_ubsan/1025/>) at the end of
    PythonTest_dbaccess_python (and probably other PythonTests), when during exit
    the static utl::ConfigManager instance already happens to be destroyed by the
    time the static ImplSVData's mpSettingsConfigItem is destroyed (which would
    normally be cleared during DeInitVCL, if PythonTests would call that, and which
    in the past had thus simply been leaked in PythonTests when that
    mpSettingsConfigItem was a plain pointer instead of std::unique_ptr).
    
    So ensure that PythonTests that initialize VCL also call DeInitVCL, via a new
    private_deinitTestEnvironment, complementing the existing
    private_initTestEnvironment.
    
    However, while private_initTestEnvironment is called once (typically via
    UnoInProcess.setUp, which internally makes sure to only call it once) as soon as
    the first executed test needs it, private_deinitTestEnvironment must be called
    once after the lasts test needing it has executed.  The only way that I found to
    do that is to override unittest.TextTestResult's stopTestRun method, which is
    called once after all tests have been executed.  Hence a new test runner setup
    in unotest/source/python/org/libreoffice/unittest.py that is now called from
    solenv/gbuild/PythonTest.mk.
    
    That revealed a few places in PythonTests that didn't yet close/delete documents
    that they had opened, which has now been added.
    
    One remaining problem then is that classes like SwXTextDocument and friends call
    Application::GetSolarMutex from their dtors, via sw::UnoImplPtrDeleter (a "Smart
    pointer class ensuring that the pointed object is deleted with a locked
    SolarMutex", sw/inc/unobaseclass.hxx).  That means that any PyUNO proxies to
    such C++ objects that remain alive after private_deinitTestEnvironment will
    cause issues at exit, when Python does a final garbage collection of those
    objects.  The ultimate fix will be to remove that unhelpful UnoImplPtrDeleter
    and its locking of SolarMutex from the dtors of UNO objects; until then, the
    Python code is now sprinkled with some HACKs to make sure all those PyUNO
    proxies are released in a timely fashion (see the comment in
    unotest/source/python/org/libreoffice/unittest.py for details).  (Also, it would
    probably help if UnoInProcess didn't keep a local self.xDoc around referencing
    (just) the last result of calling one of its open* methods, confusingly making
    it the responsibility of UnoInProcess to close that one document while making it
    the responsibility of the test code making the other UnoInProcess.open* calls to
    close any other documents.)
    
    Change-Id: Ief27c81e2b763e9be20cbf3234b68924315f13be
    Reviewed-on: https://gerrit.libreoffice.org/60100
    Tested-by: Jenkins
    Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
    e7a3329f
Adı
Son kayıt (commit)
Son güncelleme
.git-hooks Loading commit data...
UnoControls Loading commit data...
accessibility Loading commit data...
android Loading commit data...
animations Loading commit data...
apple_remote Loading commit data...
avmedia Loading commit data...
basctl Loading commit data...
basegfx Loading commit data...
basic Loading commit data...
bean Loading commit data...
bin Loading commit data...
binaryurp Loading commit data...
bridges Loading commit data...
canvas Loading commit data...
chart2 Loading commit data...
cli_ure Loading commit data...
codemaker Loading commit data...
comphelper Loading commit data...
compilerplugins Loading commit data...
config_host Loading commit data...
configmgr Loading commit data...
connectivity Loading commit data...
cppcanvas Loading commit data...
cppu Loading commit data...
cppuhelper Loading commit data...
cpputools Loading commit data...
cui Loading commit data...
dbaccess Loading commit data...
desktop Loading commit data...
dictionaries @ 5b81821a
distro-configs Loading commit data...
drawinglayer Loading commit data...
dtrans Loading commit data...
editeng Loading commit data...
embeddedobj Loading commit data...
embedserv Loading commit data...
emfio Loading commit data...
eventattacher Loading commit data...
extensions Loading commit data...
external Loading commit data...
extras Loading commit data...
filter Loading commit data...
forms Loading commit data...
formula Loading commit data...
fpicker Loading commit data...
framework Loading commit data...
helpcompiler Loading commit data...
helpcontent2 @ 104f6c7f
hwpfilter Loading commit data...
i18nlangtag Loading commit data...
i18npool Loading commit data...
i18nutil Loading commit data...
icon-themes Loading commit data...
idl Loading commit data...
idlc Loading commit data...
include Loading commit data...
instsetoo_native Loading commit data...
io Loading commit data...
ios Loading commit data...
javaunohelper Loading commit data...
jurt Loading commit data...
jvmaccess Loading commit data...
jvmfwk Loading commit data...
l10ntools Loading commit data...
librelogo Loading commit data...
libreofficekit Loading commit data...
lingucomponent Loading commit data...
linguistic Loading commit data...
lotuswordpro Loading commit data...
m4 Loading commit data...
nlpsolver Loading commit data...
o3tl Loading commit data...
odk Loading commit data...
offapi Loading commit data...
officecfg Loading commit data...
onlineupdate Loading commit data...
oovbaapi Loading commit data...
oox Loading commit data...
opencl Loading commit data...
osx Loading commit data...
package Loading commit data...
postprocess Loading commit data...
pyuno Loading commit data...
qadevOOo Loading commit data...
readlicense_oo Loading commit data...
registry Loading commit data...
remotebridges Loading commit data...
reportbuilder Loading commit data...
reportdesign Loading commit data...
ridljar Loading commit data...
sal Loading commit data...
salhelper Loading commit data...
sax Loading commit data...
sc Loading commit data...
scaddins Loading commit data...
sccomp Loading commit data...
schema Loading commit data...
scp2 Loading commit data...
scripting Loading commit data...
sd Loading commit data...
sdext Loading commit data...
setup_native Loading commit data...
sfx2 Loading commit data...
shell Loading commit data...
slideshow Loading commit data...
smoketest Loading commit data...
solenv Loading commit data...
soltools Loading commit data...
sot Loading commit data...
starmath Loading commit data...
stoc Loading commit data...
store Loading commit data...
svgio Loading commit data...
svl Loading commit data...
svtools Loading commit data...
svx Loading commit data...
sw Loading commit data...
swext Loading commit data...
sysui Loading commit data...
test Loading commit data...
testtools Loading commit data...
toolkit Loading commit data...
tools Loading commit data...
translations @ 54cc0de6
ucb Loading commit data...
ucbhelper Loading commit data...
udkapi Loading commit data...
uitest Loading commit data...
unodevtools Loading commit data...
unoidl Loading commit data...
unoil Loading commit data...
unotest Loading commit data...
unotools Loading commit data...
unoxml Loading commit data...
ure Loading commit data...
uui Loading commit data...
vbahelper Loading commit data...
vcl Loading commit data...
winaccessibility Loading commit data...
wizards Loading commit data...
writerfilter Loading commit data...
writerperfect Loading commit data...
xmerge Loading commit data...
xmlhelp Loading commit data...
xmloff Loading commit data...
xmlreader Loading commit data...
xmlscript Loading commit data...
xmlsecurity Loading commit data...
.buckconfig Loading commit data...
.buckversion Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitmodules Loading commit data...
.gitreview Loading commit data...
BUCK Loading commit data...
COPYING Loading commit data...
COPYING.LGPL Loading commit data...
COPYING.MPL Loading commit data...
Library_merged.mk Loading commit data...
Makefile.fetch Loading commit data...
Makefile.gbuild Loading commit data...
Makefile.in Loading commit data...
README.Solaris Loading commit data...
README.cross Loading commit data...
README.md Loading commit data...
Repository.mk Loading commit data...
RepositoryExternal.mk Loading commit data...
RepositoryFixes.mk Loading commit data...
RepositoryModule_build.mk Loading commit data...
RepositoryModule_host.mk Loading commit data...
TEMPLATE.SOURCECODE.HEADER Loading commit data...
autogen.sh Loading commit data...
config.guess Loading commit data...
config.sub Loading commit data...
config_host.mk.in Loading commit data...
config_host_lang.mk.in Loading commit data...
configure.ac Loading commit data...
download.lst Loading commit data...
g Loading commit data...
install-sh Loading commit data...
leak-suppress.txt Loading commit data...
lo.xcent.in Loading commit data...
logerrit Loading commit data...
sanitize-ubsan-blacklist Loading commit data...