Kayıtlar (commit) · fab18ef350058081967c66e1eea50dde44d08c41 · LibreOffice / core

25 Agu, 2015 20 kayıt (commit)
- parameter names are useless in DECL_LINK declarations · fab18ef3
  Noel Grandin Agu 25, 2015 yazdı
```
Change-Id: I77f7b528ed97964bdc153f820f6f96977ddb9254
```
  fab18ef3
- misplaced brace · d6853956
  Caolán McNamara Agu 25, 2015 yazdı
```
Change-Id: I6e43fd4a4b45f0217de8b6d93ef2403e46e39489
```
  d6853956
- vcl: disable randomly failing timer unit tests · 6bdd93e3
  Thorsten Behrens Agu 25, 2015 yazdı
```
Change-Id: Iab26a2b55586fc824c5edbea519c4f68ba4a548f
```
  6bdd93e3
- Turn on glyph caching by default when using OpenGL · 9a68eb9c
  Tor Lillqvist Agu 25, 2015 yazdı
```
Can now be turned off with a SAL_DISABLE_GLYPH_CACHING environment variable.

Change-Id: I7ac14d72dc0f85c0682d92492eb96bec1d207609
```
  9a68eb9c
- disable test case pending index assert fix · af9751a7
  Caolán McNamara Agu 25, 2015 yazdı
```
Change-Id: Ic48e22169dff2ed06b75af519ca39addef7d07de
```
  af9751a7
- upload libmwaw 0.3.6 · 6b0585a5
  David Tardon Agu 24, 2015 yazdı
```
Change-Id: I09249673d42d36bf72ee1ffbf8f3f37734bd8bae
```
  6b0585a5
- astyle · 51adbedb
  David Tardon Agu 25, 2015 yazdı
```
Change-Id: I597c007e4636f6b05873f24ef3e89c0a7c2c3670
```
  51adbedb
- simplify some declarations · 2a0f9f08
  Noel Grandin Agu 20, 2015 yazdı
```
Change-Id: I348e7f984e5e8b4b915d11de8182da07a6356f8d
```
  2a0f9f08
- SvResizeHelper::ValidateRect, simplify logic · b3705c21
  Noel Grandin Agu 20, 2015 yazdı
```
Change-Id: Ie1c9891e8095172f53efc027eec9a68bde39ed1f
```
  b3705c21
- remove useless comment · 3b479413
  Noel Grandin Agu 20, 2015 yazdı
```
Change-Id: Id253acad170e3d8f7a1278a10c731c6bd1927b92
```
  3b479413
- using RECT_EMPTY here is very dodgy · 6234e5e0
  Noel Grandin Agu 20, 2015 yazdı
```
lets rather use something smaller, so as not too potentially bump
into the RECT_EMPTY checks in the Rectange code

Change-Id: Ief8200763cac29e3099a2717f20c6f10cbc7d579
```
  6234e5e0
- simplify, IsEmpty() checks both Right and Bottom already · 3f02a38c
  Noel Grandin Agu 20, 2015 yazdı
```
Change-Id: I81fa9f80593bdea5098215f71c44b35e0087a6fc
```
  3f02a38c
- add some comments to Rectangle mutation methods · 25864323
  Noel Grandin Agu 20, 2015 yazdı
```
Change-Id: I7e1d737fc1e7a431afd3cde74c2c974e0cbef9ef
```
  25864323
- there may be no storage available in older formats · 666fb214
  Caolán McNamara Agu 25, 2015 yazdı
```
Change-Id: I23cbaf7fc1320168eb75ca33fd6d704125508785
```
  666fb214
- Nitpick: Follow our header guard naming convention · 4809c42c
  Tor Lillqvist Agu 25, 2015 yazdı
```
Change-Id: I939d36dbb0a298f8181367f74001115ef89d5bc2
```
  4809c42c
- make pWindow private in SfxChildWindow · 219b50a2
  Noel Grandin Agu 24, 2015 yazdı
```
Change-Id: I585d4e8f0a53f46b6fbcef9e4d26f88b57569684
```
  219b50a2
- make eChildAlignment private in SfxChildWindow · a9ea1295
  Noel Grandin Agu 21, 2015 yazdı
```
Change-Id: I68a4c3324736e111a2c88e3edb9df506c33042b7
```
  a9ea1295
- clean up whitespace in childwin.hxx a little · 51ea8aec
  Noel Grandin Agu 21, 2015 yazdı
```
Change-Id: Iefebe6b254f2c01b46b48ebaf7a6242e1bf80b62
```
  51ea8aec
- the implementation pointer of SfxChildWindow can be private · 64928744
  Noel Grandin Agu 21, 2015 yazdı
```
Change-Id: I79366fe5abc98924e174dcbac83bbb8c053d59ce
```
  64928744
- sc: fix number format button highlighting in sidebar · fab0c5d1
  Tomaž Vajngerl Agu 25, 2015 yazdı
```
When a number format for a cell (for example percent) is applied
it is highlighted in the toolbar but not the equal button in the
sidebar. This patch fixes this issue.

Change-Id: I7f33ab1e989f8a8e3c49468aae2042621d088798
```
  fab0c5d1
24 Agu, 2015 20 kayıt (commit)

slideshow: replace for_each with range-based loop · ead5bc3c

Daniel Robertson Agu 22, 2015 yazdı

Replace ::std::for_each for a more readable range-based for loop in
cases in which the function object to be applied by for_each is more
readable as the body of a for loop.

Change-Id: Ib0b488b36ed58c65c56357e04391b85096d043aa
Reviewed-on: https://gerrit.libreoffice.org/17930Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>

ead5bc3c

in reality we are limited to max sal_Int32 here · 0a76c1fd

Caolán McNamara Agu 24, 2015 yazdı

so accept that and test if the values were accepted or limited

Change-Id: Iaed5ebc2f12b52055506147c71117a2ad88d28ac

0a76c1fd

consider validity of m_nDrawCpO · 8329eb5e
Caolán McNamara Agu 24, 2015 yazdı
```
Change-Id: Ifbd131440bad6d840d369c99628cb8904697ad96
```
8329eb5e

Handle GetBaseCp overflow · d281b460

Stephan Bergmann Agu 24, 2015 yazdı

...as found by UBSan in CppunitTest_sw_filters_test (see below); note the TODOs
how best to report the errors up the call stack.

> Testing file:///.../sw/qa/core/data/ww6/pass/crash-3.doc:
> sw/source/filter/ww8/ww8scan.cxx:5240:63: runtime error: signed integer overflow: 1766665948 + 1768712052 cannot be represented in type 'int'
>  WW8Fib::GetBaseCp(ManTypes) const sw/source/filter/ww8/ww8scan.cxx:5240:63
>  SwWW8ImplReader::Read_GrafLayer(long) sw/source/filter/ww8/ww8graf.cxx:2393:18
>  SwWW8ImplReader::ReadChar(long, long) sw/source/filter/ww8/ww8par.cxx:3630:17
>  SwWW8ImplReader::ReadChars(int&, int, long, long) sw/source/filter/ww8/ww8par.cxx:3432:27
>  SwWW8ImplReader::ReadText(int, int, ManTypes) sw/source/filter/ww8/ww8par.cxx:3970:22
>  SwWW8ImplReader::CoreLoad(WW8Glossary*, SwPosition const&) sw/source/filter/ww8/ww8par.cxx:5169:9
>  SwWW8ImplReader::LoadThroughDecryption(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:5767:19
>  SwWW8ImplReader::LoadDoc(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:6039:19
>  WW8Reader::Read(SwDoc&, rtl::OUString const&, SwPaM&, rtl::OUString const&) sw/source/filter/ww8/ww8par.cxx:6157:20
>  SwReader::Read(Reader const&) sw/source/filter/basflt/shellio.cxx:175:18
>  SwDocShell::ConvertFrom(SfxMedium&) sw/source/uibase/app/docsh.cxx:258:22
>  SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:790:23
>  SwFiltersTest::filter(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) sw/qa/core/filters-test.cxx:112:20
>  SwFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) sw/qa/core/filters-test.cxx:71:12
>  test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:129:20
>  test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:154:5
>  SwFiltersTest::testCVEs() sw/qa/core/filters-test.cxx:154:5

Change-Id: I0b14f5c1e025565eb131e64590b7d5ff0135e767
Reviewed-on: https://gerrit.libreoffice.org/17965Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

d281b460

Handle zero nPLCF · 1a871f9d

Stephan Bergmann Agu 24, 2015 yazdı

...as found by ASan in CppunitTest_sw_filters_test:

> Testing file:///.../sw/qa/core/data/ww6/pass/crash-1.doc:
> ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6020009382b0 at pc 0x2b1dcb5eabac bp 0x7fffe8ccbdb0 sp 0x7fffe8ccbda8
> READ of size 4 at 0x6020009382b0 thread T0
>  WW8PLCF::SeekPos(int) sw/source/filter/ww8/ww8scan.cxx:2219:14
>  WW8PLCF::WW8PLCF(SvStream&, int, int, int, int, int, int) sw/source/filter/ww8/ww8scan.cxx:2080:9
>  WW8PLCFx_Fc_FKP::WW8PLCFx_Fc_FKP(SvStream*, SvStream*, SvStream*, WW8Fib const&, ePLCFT, int) sw/source/filter/ww8/ww8scan.cxx:2883:21
>  WW8PLCFx_Cp_FKP::WW8PLCFx_Cp_FKP(SvStream*, SvStream*, SvStream*, WW8ScannerBase const&, ePLCFT) sw/source/filter/ww8/ww8scan.cxx:3088:7
>  WW8ScannerBase::WW8ScannerBase(SvStream*, SvStream*, SvStream*, WW8Fib*) sw/source/filter/ww8/ww8scan.cxx:1588:20
>  SwWW8ImplReader::CoreLoad(WW8Glossary*, SwPosition const&) sw/source/filter/ww8/ww8par.cxx:5022:20
>  SwWW8ImplReader::LoadThroughDecryption(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:5767:19
>  SwWW8ImplReader::LoadDoc(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:6039:19
>  WW8Reader::Read(SwDoc&, rtl::OUString const&, SwPaM&, rtl::OUString const&) sw/source/filter/ww8/ww8par.cxx:6157:20
>  SwReader::Read(Reader const&) sw/source/filter/basflt/shellio.cxx:175:18
>  SwDocShell::ConvertFrom(SfxMedium&) sw/source/uibase/app/docsh.cxx:258:22
>  SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:790:23
>  SwFiltersTest::filter(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) sw/qa/core/filters-test.cxx:112:20
>  SwFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) sw/qa/core/filters-test.cxx:71:12
>  test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:129:20
>  test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:154:5
>  SwFiltersTest::testCVEs() sw/qa/core/filters-test.cxx:154:5
> 0x6020009382b1 is located 0 bytes to the right of 1-byte region [0x6020009382b0,0x6020009382b1)
> allocated by thread T0 here:
>  operator new[](unsigned long) /home/sbergman/clang/trunk/src/projects/compiler-rt/lib/asan/asan_new_delete.cc:64
>  WW8PLCF::ReadPLCF(SvStream&, int, unsigned int) sw/source/filter/ww8/ww8scan.cxx:2091:26
>  WW8PLCF::WW8PLCF(SvStream&, int, int, int, int, int, int) sw/source/filter/ww8/ww8scan.cxx:2075:9
>  WW8PLCFx_Fc_FKP::WW8PLCFx_Fc_FKP(SvStream*, SvStream*, SvStream*, WW8Fib const&, ePLCFT, int) sw/source/filter/ww8/ww8scan.cxx:2883:21
>  WW8PLCFx_Cp_FKP::WW8PLCFx_Cp_FKP(SvStream*, SvStream*, SvStream*, WW8ScannerBase const&, ePLCFT) sw/source/filter/ww8/ww8scan.cxx:3088:7
>  WW8ScannerBase::WW8ScannerBase(SvStream*, SvStream*, SvStream*, WW8Fib*) sw/source/filter/ww8/ww8scan.cxx:1588:20
>  SwWW8ImplReader::CoreLoad(WW8Glossary*, SwPosition const&) sw/source/filter/ww8/ww8par.cxx:5022:20
>  SwWW8ImplReader::LoadThroughDecryption(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:5767:19
>  SwWW8ImplReader::LoadDoc(SwPaM&, WW8Glossary*) sw/source/filter/ww8/ww8par.cxx:6039:19
>  WW8Reader::Read(SwDoc&, rtl::OUString const&, SwPaM&, rtl::OUString const&) sw/source/filter/ww8/ww8par.cxx:6157:20
>  SwReader::Read(Reader const&) sw/source/filter/basflt/shellio.cxx:175:18
>  SwDocShell::ConvertFrom(SfxMedium&) sw/source/uibase/app/docsh.cxx:258:22
>  SfxObjectShell::DoLoad(SfxMedium*) sfx2/source/doc/objstor.cxx:790:23
>  SwFiltersTest::filter(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) sw/qa/core/filters-test.cxx:112:20
>  SwFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) sw/qa/core/filters-test.cxx:71:12
>  test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:129:20
>  test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) unotest/source/cpp/filters-test.cxx:154:5
>  SwFiltersTest::testCVEs() sw/qa/core/filters-test.cxx:154:5

Change-Id: I97d995aad621b829b6fb6ee4622d386fec0bedea
Reviewed-on: https://gerrit.libreoffice.org/17963Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

1a871f9d

Don't attempt to cache glyphs that are vertical but the text direction isn't · 32069752
Tor Lillqvist Agu 24, 2015 yazdı
```
That is a too complex and rare case to bother with, I think.

Change-Id: Ica6ef7fa05314d2367dcff32627c1aec6ba8f8df
```
32069752
Clean up output · a4ef3f4e
Stephan Bergmann Agu 24, 2015 yazdı
```
Change-Id: I4fbcd03e4af82ba8e3697651ddce92ba0ba450a6
```
a4ef3f4e
Make test order deterministic · 82fb80ec
Stephan Bergmann Agu 24, 2015 yazdı
```
Change-Id: I9980034f0cb948acd6bb20aaf0fc27928ac68913
```
82fb80ec

loop over successfully read bookmarks · 02e9b490

Caolán McNamara Agu 24, 2015 yazdı

not over the amount that should be there

Change-Id: Ia2c353f9d7e274a5bebf405e1743ef1d1872b4de

02e9b490

detect and reject loop in tif · 6b82437d
Caolán McNamara Agu 24, 2015 yazdı
```
Change-Id: I77d315fa432a3eb1a65539489a2ba6da8508b283
```
6b82437d
-Werror,-Wpessimizing-move ("moving a temporary object prevents copy elision") · 7e415c83
Stephan Bergmann Agu 24, 2015 yazdı
```
Change-Id: I9e5b74e5ff0348f0880972a82726178354ab7d0f
```
7e415c83
allow avoiding config for CustomToolBarImportHelper · 48a047f2
Caolán McNamara Agu 24, 2015 yazdı
```
Change-Id: Iff0dd632f8c6b187d3515f542cc9fe2ca59088e5
```
48a047f2
limit seeks to valid area · c0c90751
Caolán McNamara Agu 24, 2015 yazdı
```
Change-Id: I401d93491999a3fc3db4f597eea9c4fe5b9bc926
```
c0c90751
coverity#1317300 Untrusted array index read · 479862c7
Caolán McNamara Agu 24, 2015 yazdı
```
Change-Id: Ia9fe42974ffe24f6a679396b5d7ca672c0459f4b
```
479862c7

tdf#93437: release reference held by ScFormulaReferenceHelper · e931b059

Katarina Behrens Agu 24, 2015 yazdı

This does two things: reverts a revert of
087f7fe5 -- turns out it was innocent.

Plus, it actually releases the reference that prevents destructor from 
being called. It was actually ScFormulaDlg's own m_aHelper member variable 
holding reference to 'this' (extra-wicked, through SetWindow(this)),
never releasing it.

Change-Id: I258a280e09674d1a2f1ddebea19ea1b42dcdc777
Reviewed-on: https://gerrit.libreoffice.org/17949Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

e931b059

tdf#89381 Revert "vcl: SalGraphics::mirror() - always use GetGraphicsWidth()" · d2c09305

Maxim Monastirsky Agu 23, 2015 yazdı

This reverts commit 28effca6.

Change-Id: Ie21ae1ef969b2cfdce81a152c195a69ad3c27f65
Reviewed-on: https://gerrit.libreoffice.org/17937Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

d2c09305

guard against hangs with bogus unsorted plcfs · 74c0f744
Caolán McNamara Agu 24, 2015 yazdı
```
This reverts commit 6d21cbd1.

Change-Id: I309302ab5357b8404ee4c75bd0bfcb4f816e0588
```
74c0f744
Revert "guard against hangs with bogus unsorted plcfs" · 6d21cbd1
Caolán McNamara Agu 24, 2015 yazdı
```
This reverts commit f3db01f3.

<= maybe, need to double check
```
6d21cbd1
include vector · 1e8e3a8c
Caolán McNamara Agu 24, 2015 yazdı
```
Change-Id: I84f571c0564b33a5b647a270c567959b415b3747
```
1e8e3a8c
guard against hangs with bogus unsorted plcfs · f3db01f3
Caolán McNamara Agu 24, 2015 yazdı
```
Change-Id: I91caff583617435add76503498ca4ed361eb5d2e
```
f3db01f3